Re: [PATCH wayland 1/5] display-test: move a misplaced comment

On Mon, May 16, 2016 at 11:44:40AM +0300, Pekka Paalanen wrote: > On Fri, 13 May 2016 15:01:18 +0200 > Marek Chalupa wrote: > > > we split a function while refactoring in c643781 and now > > the comment makes no sense > > > > Signed-off-by: Marek Chalupa

Re: [PATCH weston] desktop-shell: Don’t reconfigure an already fullscreen surface

with a mod+tab. > > > > Signed-off-by: Emmanuel Gil Peyrot <linkma...@linkmauve.fr> > > Makes sense, and I can't immediately think of a use case where this wouldn't > make sense. So fwiw, > Reviewed-by: Yong Bakos <yba...@humanoriented.com> LGTM too. Revi

Re: [PATCH weston] zunitc: use platform-independent macros for integer formatting

anuel Gil Peyrot <linkma...@linkmauve.fr> I like that this removes warnings, although it makes the print statements slightly clunkier but I guess clear enough what's going on. Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Pushed: 8a12069..1764d22 master -> master

Re: [PATCH 4/6] compositor: use generated constant instead of hardcoded value

On Tue, Apr 26, 2016 at 11:34:06PM +0200, David Fort wrote: > Use SINCE macros instead of the hardcoded version value. > > Signed-off-by: David Fort <cont...@hardening-consulting.com> LGTM, Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Pushed: 2d4aa83..8a12

Re: [PATCH 3/6] rdp: Fix the ContextNew callback with recent FreeRDP versions

-by: David Fort <cont...@hardening-consulting.com> LGTM, it returns BOOL for newer versions, ref. https://github.com/FreeRDP/FreeRDP/blob/master/include/freerdp/peer.h and FREERDP_CB_RET_TYPE is abstracting the change so it supports new and old versions, so: Reviewed-by: Bryce Harrington &

Re: [PATCH 2/6] rdp: don't release the seat until it is safe

On Tue, Apr 26, 2016 at 11:34:04PM +0200, David Fort wrote: > Releasing a seat is not safe, so let's just announce it without keyboard > and mouse until this is fixed. Without this patch we just can't reconnect on > the RDP compositor as it crashes. > > Signed-off-by: David Fort

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

On Mon, May 16, 2016 at 11:50:14AM +0200, Quentin Glidic wrote: > On 01/05/2016 23:32, David Fort wrote: > >FreeRDP 2.0 is about to be released, this allows to compile against this > >version. > >The detection is adjusted to prefer FreeRDP 2 against version 1.x. > > > >Signed-off-by: David Fort

Re: [PATCH wayland] tests: Check for client/server-core.h inclusion

d-*-protocol.h should include. > > Add an include check in the headers-protocol-core-test, to be sure that > a wayland-*-protocol.h generated with the --include-core-only option > properly includes wayland-*-core.h. > > Signed-off-by: Yong Bakos <yba...@humanorient

[ANNOUNCE] weston 1.10.92

config arg of weston_wayland_backend_config_add_new_output main: let load_wayland_backend() clean up on error Bryce Harrington (3): releasing: Correct documentation for script name data: Some client icons configure.ac: bump to version 1.10.92 for the beta release Daniel Stone (1): libinput: Rem

[ANNOUNCE] wayland 1.10.92

nd-scanner Bryce Harrington (1): configure.ac: bump to version 1.10.92 for the beta release Yong Bakos (4): protocol: Remove double line break doc: Formalize file comment in wayland-client.h, wayland-server.h connection: Move wl_interface_equal to util private: Remove u

Re: [PATCH] weston: catch missing commandline values

On Thu, May 12, 2016 at 02:47:15PM -0700, Florian Hänel wrote: > took me long enough that --tty 2 is wrong snce it does not give an error. > I did not use weston_log since not everyone using the parser has that. > > Maybe we should also check for EINVAL from strtol. > > --Florian > >From

Re: [ANNOUNCE] wayland 1.10.91

On Wed, May 11, 2016 at 05:32:37PM -0500, Yong Bakos wrote: > On May 11, 2016, at 2:32 PM, Yong Bakos <j...@humanoriented.com> wrote: > > > > On May 11, 2016, at 2:11 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > >> > >> On Fri, May 06, 2

Re: [ANNOUNCE] wayland 1.10.91

On Thu, May 12, 2016 at 11:20:46AM +0300, Pekka Paalanen wrote: > On Thu, 12 May 2016 10:38:56 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote: > > > On Fri, May 06, 2016 at 02:17:23

Re: [ANNOUNCE] wayland 1.10.91

On Thu, May 12, 2016 at 10:38:56AM +0800, Jonas Ådahl wrote: > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote: > > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote: > > > On Wed, 4 May 2016 11:46:23 -0700 > > > Bryce Harrington &l

Re: [weston] xdg-shell: define further the behavior of input devices around xdg_popup

On Tue, Jun 09, 2015 at 07:32:32PM +0200, Carlos Garnacho wrote: > This consolidates the behavior that compositors must implement when > xdg_popups cause input to be redirected into the popup surface. > > Signed-off-by: Carlos Garnacho Hi Carlos, If this is still relevant

[PATCH weston v2] data: Some client icons

This adds an alternate weston terminal icon and icons for the flower and editor clients. The original Inkscape SVG file is included. Example screenshot: http://www.bryceharrington.org/Files/weston-icons.png Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- v2: License under b

Re: [PATCH weston] data: Some client icons

On Wed, May 04, 2016 at 10:08:12AM +0100, Daniel Stone wrote: > Hi Bryce, > > On 25 March 2016 at 00:57, Bryce Harrington <br...@osg.samsung.com> wrote: > > This adds an alternate weston terminal icon and icons for the flower and > > editor clients. The original In

[PATCH weston] build: Define wayland prereq version

Establishes a single variable for defining the libwayland version requirements. Enforces the same version dependency between libwayland-client and libwayland-server, as recommended by pq in the 1.11 release discussions. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- config

Re: [PATCH weston 0/5] gl-renderer: Renaming of things and minor improvements

On Wed, May 11, 2016 at 02:48:13PM +0200, Miguel A. Vico wrote: > Hi, > > Feedback for the first revision has been addressed. Here is a new series that > basically splits the orginal patch into several little pieces. > > Additionally, gl_renderer_create() has been renamed to >

Re: [PATCH wayland] private: Remove unnecessary forward declarations

wl_map_for_each(struct wl_map *map, wl_iterator_func_t func, void *data); > > > > -struct wl_connection; > > -struct wl_closure; > > -struct wl_proxy; > > Trying to think of a place in C where a forward struct declaration is > actually required. > > Thi

Re: [PATCH wayland 1/1] connection: Move wl_interface_equal to util

On Tue, May 10, 2016 at 06:08:15PM -0700, Bryce Harrington wrote: > On Mon, May 09, 2016 at 03:41:14PM +0300, Pekka Paalanen wrote: > > On Sun, 8 May 2016 08:44:08 -0500 > > Yong Bakos <j...@humanoriented.com> wrote: > > > > > From: Yong Bakos <yba.

Re: [PATCH wayland 1/1] doc: Formalize file comment in wayland-client.h, wayland-server.h

On Tue, May 10, 2016 at 06:05:44PM -0700, Bryce Harrington wrote: > On Sun, May 08, 2016 at 02:42:28PM -0500, Yong Bakos wrote: > > From: Yong Bakos <yba...@humanoriented.com> > > > > Publican was generating a subtle error during a build: > > Error: no ID for c

Re: Does anyone use Weston on the Raspberry Pi?

On Wed, May 11, 2016 at 07:53:03AM -0500, Derek Foreman wrote: > On 11/05/16 03:28 AM, Pekka Paalanen wrote: > > Hi, > > > > it has been a very long time since anything has happened with Weston's > > rpi-backend. This is the (only) Weston backend using a proprietary API, > > for Raspberry Pi it

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

On Tue, May 10, 2016 at 03:33:59PM +0300, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 15:40:35 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > The drm backend was copying most everything out of the config object > > already, but now also copy the

Re: [PATCH wayland 1/1] connection: Move wl_interface_equal to util

st struct wl_interface *a, const struct wl_interface > > *b) > > +{ > > + /* In most cases the pointer equality test is sufficient. > > + * However, in some cases, depending on how things are split > > +* across shared objects, we can end up with multiple &g

Re: [PATCH wayland 1/1] doc: Formalize file comment in wayland-client.h, wayland-server.h

r in the generated html documentation. > > References: d74a9c079b1aeb44f69b4132dc2c38362e21f281 > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> LGTM, Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > src/wayland-client.h | 7 +-- >

Re: [PATCH wayland v2] scanner: Add version argument to wayland-scanner

it a comment with wayland library > > version to every file it generates. > > > > v2: separate variable definitions into their own lines and remove > > old style "version" argument > > > > Reviewed-by: Bryce Harrington <br...@osg.samsung.com>

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > > > Hi, > > > > here is the v3 of the stabilization series, whi

Re: [PATCH weston v3 14/17] compositor: check viewport source rect validity

On Tue, Apr 26, 2016 at 03:51:06PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > wp_viewporter spec requires protocol errors when the viewport is outside > the buffer area. > > The viewport is checked in wl_surface.commit handler as the error needs > to

Re: [PATCH weston v3 13/17] compositor: fix wp_viewport use after free

ct weston_surface *surface = > wl_resource_get_user_data(resource); > > - assert(surface->viewport_resource != NULL); > + if (!surface) { > + wl_resource_post_error(resource, > + WP_VIEWPORT_ERROR_NO_SURFACE, > + &quo

Re: [PATCH weston v3 07/17] compositor: refactor into convert_size_by_transform_scale()

le and transforms never happen in practice anyway, so assert may be the better choice. Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Weston patches 6 and 7 would be fine to land now pre-beta; they don't depend on the protocol changes and are straightforward refactors. B

Re: [PATCH weston v3 06/17] compositor: constify weston_surface_build_buffer_matrix()

.uk> Sure, LGTM: Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > src/compositor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index 5500197..491b333 100644 > --- a/src/com

[ANNOUNCE] wayland 1.10.91

enum attributes Bill Spitzak (1): doc: Use enum argument type to make links in protocol documentation Bryce Harrington (3): configure.ac: bump to version 1.10.90 for open development doc: Note strong recommendation to use S-o-b in contributions configure.ac: bump

Re: [GSoC] Some questions about wayland clients with no outputs present

On Mon, May 02, 2016 at 04:42:52PM +0300, Pekka Paalanen wrote: > On Mon, 2 May 2016 12:49:04 +0200 > Armin Krezović wrote: > > > So, the backends should indicate to the compositor (and thence to the > > > enabled shell) that the output change has occurred, and then the

Re: [PATCH weston v7 1/3] x11: port the x11 backend to the new init api

base to master. > > > > Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> > > Tested-by: Benoit Gschwind <gschw...@gnu-log.net> I've gone ahead and pushed this one, with the whitespace fix, to get it off the list. Bryce > > Le 30/04/2016 00:40, Bryce

Re: [PATCH wayland v4 1/1] protocol: Add summaries to event parameters

On Sat, Apr 30, 2016 at 10:50:37PM +0800, Jonas Ådahl wrote: > On Sat, Apr 30, 2016 at 07:35:50AM -0500, Yong Bakos wrote: > > From: Yong Bakos > > > > All event arg elements now have an appropriate summary attribute. > > This was conducted mostly in response to the

Re: [PATCH wayland 1/5] client: fix typo

On Mon, May 02, 2016 at 12:29:57PM +0200, Armin Krezović wrote: > On 02.05.2016 10:49, Eric Engestrom wrote: > > Since all of the fixes are trivial, patches 1-5: > > Reviewed-by: Armin Krezović Thanks, pushed: 4db7602..ee4e21c master -> master Bryce > >

Re: [GSoC] Some questions about wayland clients with no outputs present

On Mon, May 02, 2016 at 12:49:04PM +0200, Armin Krezović wrote: > On 30.04.2016 22:14, Bryce Harrington wrote: > > On Sat, Apr 30, 2016 at 05:20:09PM +0200, Armin Krezović wrote: > > But virtual outputs is not a bad idea, it could be useful for testing or > > perhaps to e

Re: [PATCH wayland] Add version argument to wayland-scanner

zović <krezovic.ar...@gmail.com> One formatting nit below, but otherwise LGTM so with that thing fixed: Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > src/scanner.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff

Re: [GSoC] Some questions about wayland clients with no outputs present

On Sat, Apr 30, 2016 at 05:20:09PM +0200, Armin Krezović wrote: > Hi all, > > Now that I've analyzed the weston codebase a bit, I'm ready to > bombard you people with some questions :). > > For those that aren't yet aware, I'll be working on making weston > able to run with no outputs and

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

On Sat, Apr 30, 2016 at 11:54:15AM +0300, Giulio Camuffo wrote: > 2016-04-30 0:38 GMT+03:00 Bryce Harrington <br...@osg.samsung.com>: > > On Sun, Apr 17, 2016 at 05:31:32PM +0300, Giulio Camuffo wrote: > >> Sorry, i keep seeing things after i hit send... > >> >

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

com> Is this just to handle when an old and a new version are installed, or does weston fail to build entirely against the newer library? I'm having trouble visualizing what the failure is that this fixes. But technically it looks ok, at least to the limits of my mediocre autoconfu, so: Reviewed

Re: [PATCH wayland 09/10] doc: Hyphenate compound adjectives window-local, surface-local

On Thu, Apr 28, 2016 at 12:01:33PM -0500, Yong Bakos wrote: > From: Yong Bakos > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Patches 9 and 10 for wayland R-b'd and

Re: [PATCH wayland-protocols 07/10] pointer-constraints: Use 'surface-local' in simplified parameter summary

On Thu, Apr 28, 2016 at 12:00:45PM -0500, Yong Bakos wrote: > From: Yong Bakos > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Pushed for wayland-protocols:

Re: [PATCH weston 02/10] desktop-shell: Use 'surface-local' to correct grammar

On Thu, Apr 28, 2016 at 11:59:06AM -0500, Yong Bakos wrote: > From: Yong Bakos > > Correct the pluralization by simplifying with 'surface-local'. > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos

Re: [PATCH wayland-web 01/10] architecture: Hyphenate compound adjective window-local

On Thu, Apr 28, 2016 at 11:57:52AM -0500, Yong Bakos wrote: > From: Yong Bakos <yba...@humanoriented.com> > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Rev

Re: [PATCH weston v1] headless-backend: fix leak of transfrom configuration

On Fri, Apr 29, 2016 at 03:36:49PM +0200, Quentin Glidic wrote: > On 29/04/2016 15:21, Benoit Gschwind wrote: > >Signed-off-by: Benoit Gschwind > >--- > >v1: > > - fix warning for freeing a const > > - fix typo > > > > src/main.c | 10 +++--- > > 1 file changed, 7

[PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

of the config object and the backend's, don't allow the backend to hang onto the config object outside the initialization scope. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- v6: - Drop use of drm_config confi

[PATCH weston v7 1/3] x11: port the x11 backend to the new init api

rsioning implies that there we expect potential future descrepancy between main's definition of the config object and the backend's, don't allow the backend to hang onto the config object outside the initialization scope. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Giul

[PATCH weston v7 2/3] drm: port the drm backend to the new init api

From: Giulio Camuffo <giuliocamu...@gmail.com> Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Tested-by: Benoit Gschwind <gschw...@gnu-log

[PATCH weston v7 0/3] drm and x11 backend configuration

Yet another stab at the drm and x11 backend config stuff... Benoit Gschwind (1): x11: port the x11 backend to the new init api Bryce Harrington (1): drm: Don't hang onto the backend config object post-backend_init Giulio Camuffo (1): drm: port the drm backend to the new init api

Re: [PATCH weston v6 12/12] x11: Initialize all outputs at start

On Sun, Apr 17, 2016 at 05:35:07PM +0300, Giulio Camuffo wrote: > 2016-04-16 6:28 GMT+03:00 Bryce Harrington <br...@osg.samsung.com>: > > We know ahead of time the maximum number of outputs we'll be > > configuring, so just alloc that memory from the get-go, instead of > &g

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

On Sun, Apr 17, 2016 at 05:10:24PM +0300, Giulio Camuffo wrote: > 2016-04-16 6:28 GMT+03:00 Bryce Harrington <br...@osg.samsung.com>: > > From: Benoit Gschwind <gschw...@gnu-log.net> > > > > Use a "well" defined structure to configure x11-backend and move

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

On Sun, Apr 17, 2016 at 05:31:32PM +0300, Giulio Camuffo wrote: > Sorry, i keep seeing things after i hit send... > > 2016-04-17 17:10 GMT+03:00 Giulio Camuffo <giuliocamu...@gmail.com>: > > 2016-04-16 6:28 GMT+03:00 Bryce Harrington <br...@osg.samsun

Re: [PATCH] headless-backend: fix leak of transfrom configuration

ston_log("Invalid transform \"%s\"\n", transform); > > + config.transform = WL_OUTPUT_TRANSFORM_NORMAL; > > + if(transform) { > > if ( > > Also note the minor misspelling in the commit message, for v2. Ditto here. The rest looks correct though, so with

Re: [PATCH wayland v2 01/01] protocol: Add summaries to event parameters

ed during 'make check'. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> I'd reviewed this in detail earlier, and looks like the v2 improvements are good, so: Reviewed-by: Bryce Harrington <br...@osg.samsung.com> While this is just documentation and doesn't change protocol tec

Re: [PATCH wayland-web] building: Remove deprecated mesa autogen option

On Wed, Apr 27, 2016 at 08:44:24AM -0500, Yong Bakos wrote: > From: Yong Bakos > > Using --disable-gallium-egl generates a warning when running autogen.sh, > because the option has been deprecated. See: > > https://bugzilla.redhat.com/show_bug.cgi?id=1128372 > >

Re: [PATCH wayland-web] building: Remove deprecated mesa autogen option

/show_bug.cgi?id=1128372 > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Confirmed: ... config.status: executing libtool commands configure: WARNING: unrecognized options: --disable-gallium-egl prefix: /home/bryce/build/Wayland/install ... Reviewed-by: Bry

Wayland 1.11 release cycle kickoff

inhibition (by Bryce Harrington) == Works in Progress == These I haven't looked much into but might be candidates for inclusion. Some just need review, others are ongoing development that maybe can be finished up? 1. Various APIs for client info (by Giulio Camuffo) 2. Pointer locking

Re: [PATCH wayland] protocol: Correct grammar and spelling

On Tue, Apr 05, 2016 at 10:15:53PM -0500, Yong Bakos wrote: > > On Apr 5, 2016, at 8:03 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > On Tue, Apr 05, 2016 at 06:24:01PM -0500, Yong Bakos wrote: > >> From: Yong Bakos <yba...@humanoriented.com>

Re: [PATCH weston] weston-info: look for the right wp_presentation

bal_info(info, id, interface, version); Yep clients/weston-info.c:else if (!strcmp(interface, "presentation")) clients/presentation-shm.c: } else if (strcmp(interface, wp_presentation_interface.name) == 0) { tests/presentation-test.c: if (strc

Re: standardizing "surface-local coordinates"

On Thu, Apr 21, 2016 at 09:17:32AM -0500, Yong Bakos wrote: > > On Apr 19, 2016, at 12:26 PM, Daniel Stone wrote: > > > > On 19 April 2016 at 17:55, Yong Bakos wrote: > >> There was a little discussion recently about standardizing occurrences of >

Re: [PATCH weston] man: Clarify weston.ini scale option

On Thu, Apr 21, 2016 at 02:21:38PM -0500, Yong Bakos wrote: > On Apr 21, 2016, at 2:15 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > On Thu, Apr 21, 2016 at 12:49:29PM -0500, Yong Bakos wrote: > >> From: Yong Bakos <yba...@humanoriented.com> &g

Re: [PATCH weston] man: Clarify weston.ini scale option

s <yba...@humanoriented.com> Looks good, Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Btw in changelogs when referring to bug tickets, a standard syntax is: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94824 if the patch is intended to close the bug report as fixe

Re: [PATCH weston] build: add check for clock_gettime() in librt

t that will set CLOCK_GETTIME_LIBS > appropiately and replaced all instances of -lrt with it. > Built-tested against old and new glibc. > > Signed-off-by: Gustavo Zacarias <gust...@zacarias.com.ar> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > Makefile.

Re: [PATCH weston] tests: check for NULL surface in keyboard and pointer handlers

ULL. > > Handle NULL surface gracefully in keyboard and pointer enter/leave > handlers. Touch-down handler is already NULL-safe. > > This fixes a SEGV in a test I am writing for wp_viewport. > > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> LGTM, Revi

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

f button/ring/strip > configurations. > > Signed-off-by: Carlos Garnacho <carl...@gnome.org> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks pretty good. A few grammar suggestions below. With those fixed, Reviewed-by: Bryce Harrington <br...@osg.samsung

Re: [PATCH weston v6 09/12] drm: Move drm's output configuration into the drm backend

ormat as its enum type rather than as string. > 2016-04-16 6:28 GMT+03:00 Bryce Harrington <br...@osg.samsung.com>: > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > > --- > > src/compositor-drm.c | 93 > >

Re: [PATCH weston v5 00/11] drm: port the drm backend to the new init api

09/11 > > This patch look to address some concern I raised in the patch 03/11, but > seems to need more discussion. > > PATCH 10/11 > > The patch look to address issue of PATCH 07/11 that Pekka raised about > freeing config variable. > > PATCH 11/11 > > Look fine.

Re: [PATCH weston v5 00/11] drm: port the drm backend to the new init api

On Wed, Apr 13, 2016 at 05:21:39PM +0300, Pekka Paalanen wrote: > On Wed, 13 Apr 2016 03:25:04 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > In following up on my earlier update of Giulio's drm backend config > > patch, I've taken the liberty to try

[PATCH weston v6 01/12] drm: Spelling fix in comment

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/compositor-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 119b6c5..a47b453 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1551,7 +

[PATCH weston v6 09/12] drm: Move drm's output configuration into the drm backend

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/compositor-drm.c | 93 src/compositor-drm.h | 41 --- src/main.c | 43 3 files changed, 80 insertions(+), 97 del

[PATCH weston v6 05/12] drm: port the drm backend to the new init api

From: Giulio Camuffo <giuliocamu...@gmail.com> Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net> Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Tested-by: Benoit Gschwind <gschw...@gnu-log.ne

[PATCH weston v6 08/12] drm: Don't hang onto the backend config object post-backend_init

it helps make the drm backend config initialization more consistent with the other backends. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> v6: - Drop use of drm_config config wrapper Signed-off-by: Bryce Ha

[PATCH weston v6 03/12] compositor: Drop unneeded create_output callback

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/compositor.h | 8 1 file changed, 8 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index 0ba00be..5ca497c 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -691,14 +691,6 @@ struct weston_backend_

[PATCH weston v6 00/12] Port three backends to the new init api

to account for code changes by 91880f1e to make vt switching configurable. Benoit Gschwind (2): x11: port the x11 backend to the new init api headless: port the headless backend to the new init api Bryce Harrington (9): drm: Spelling fix in comment Revert 'main: Remove unused

[PATCH weston v6 10/12] drm: Pass gbm_format as enum rather than string in output config

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/compositor-drm.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index d129adc..a896785 100644 --- a/src/compositor-drm.c +++ b/src/comp

[PATCH weston v6 11/12] Enforce destruction of all backend config objects after initialization

Since the backend config struct versioning implies that there we expect potential future descrepancy between main's definition of the config object and the backend's, don't allow the backend to hang onto the config object outside the initialization scope. Signed-off-by: Bryce Harrington <

[PATCH weston v6 12/12] x11: Initialize all outputs at start

We know ahead of time the maximum number of outputs we'll be configuring, so just alloc that memory from the get-go, instead of realloc'ing for each new output. Suggested-by: Pekka Paalanen <ppaala...@gmail.com> Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src

[PATCH weston v6 06/12] x11: port the x11 backend to the new init api

From: Benoit Gschwind <gschw...@gnu-log.net> Use a "well" defined structure to configure x11-backend and move configuration file parsing inside the weston compositor code. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> v6: - Define version number in the header

[PATCH weston v6 07/12] headless: port the headless backend to the new init api

From: Benoit Gschwind <gschw...@gnu-log.net> refactor configuration API of headless-backend Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> v6: - Define version number in the header - Don't use l

[PATCH weston v6 04/12] compositor: Version the backend configuration structures

assumptions. So long as the backend's struct is equal or larger than what was passed in and the major versions are equal, we're good; but if it is larger, then this is a fatal error. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.c

Re: [PATCH weston v5 03/11] drm: port the drm backend to the new init api

On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote: > > + /** The seat to be used by the output. Set to NULL to use the > > +* default seat. */ > > + char *seat; > > + /** The modeline to be used by the output. Refer to the documentation > > +* of

Re: [PATCH 2/5] drm: port the drm backend to the new init api

On Fri, Apr 15, 2016 at 12:01:01PM +0300, Pekka Paalanen wrote: > On Thu, 14 Apr 2016 19:09:34 +0300 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > > > 2016-04-13 14:30 GMT+03:00 Pekka Paalanen <ppaala...@gmail.com>: > > > On Tue, 12 Apr 2016 21:34

Re: [PATCH 2/5] drm: port the drm backend to the new init api

On Fri, Apr 15, 2016 at 12:01:01PM +0300, Pekka Paalanen wrote: > On Thu, 14 Apr 2016 19:09:34 +0300 > Giulio Camuffo <giuliocamu...@gmail.com> wrote: > > > 2016-04-13 14:30 GMT+03:00 Pekka Paalanen <ppaala...@gmail.com>: > > > On Tue, 12 Apr 2016 21:34

Re: [PATCH weston v5 00/11] drm: port the drm backend to the new init api

ddress issue of PATCH 07/11 that Pekka raised about > freeing config variable. > > PATCH 11/11 > > Look fine. > > Reviewed-by: Benoit Gschwind <gschw...@gnu-log.net> > > > > [1] git node: 94cb06a208130b0ee16553a2cd513e5e7d67f368 > > > > Le 13/04/2016 12:25, Bryce Harrin

Re: [PATCH weston v5 03/11] drm: port the drm backend to the new init api

On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote: > Hello Bryce and Giulio, > > Thanks for your contribution :), here is my comments. > > Le 13/04/2016 12:25, Bryce Harrington a écrit : > > From: Giulio Camuffo <giuliocamu...@gmail.com> > > > &

Re: [PATCH] option-parser: Handle short double-arg options

On Fri, Apr 15, 2016 at 11:55:57AM +0300, Pekka Paalanen wrote: > On Thu, 14 Apr 2016 11:10:57 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > On Thu, Apr 14, 2016 at 03:16:07PM +0300, Pekka Paalanen wrote: > > > On Sat, 13 Feb 2016 23:56:38 +0100 >

Re: [PATCH wayland-build-tools] wl_install_deps: Add missing dependencies

On Thu, Apr 14, 2016 at 05:48:12PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Building on Ubuntu 15.10 x64 fails due to missing packages: > libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgcrypt20-dev, > x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. >

Re: [PATCH weston v5 07/11] headless: port the headless backend to the new init api

On Thu, Apr 14, 2016 at 04:53:39PM +0300, Pekka Paalanen wrote: > On Wed, 13 Apr 2016 03:25:11 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > refactor configuration API of headless-backend > > > > Signed-off-by: Bryce Harrington <br...@osg.sams

Re: [PATCH] option-parser: Handle short double-arg options

acement lib or improve our existing solution, although I have some other matters that would be higher priority in the near term. Bryce > Thanks, > pq > > > Le 12/02/2016 00:25, Bryce Harrington a écrit : > > > weston allows both short and long style options to take argume

Re: [PATCH weston] Makefile: fix systemd-notify plugin CFLAGS

my install $prefix. > > Cc: Egor Starkov <egor.star...@ge.com> > Cc: Eugen Friedrich <efriedr...@de.adit-jv.com> > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Went ahead and pushed it, too:

Re: [PATCH wayland-build-tools] wl_install_deps: Add missing dependencies, remove INCLUDE_XWAYLAND logic

On Wed, Apr 13, 2016 at 05:29:31PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Building on Ubuntu 15.10 x64 fails due to missing packages: > libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgudev-1.0-dev, > libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev,

Re: [PATCH wayland-build-tools] readme: Add instructions

lt;yba...@humanoriented.com> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Thanks, pushed: bcc2863..452f1d9 master -> master > --- > README | 54 +- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff -

Re: [PATCH wayland-protocols 1/4] stable/presentation-time: swap two paragraphs in 'presented'

gt; Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> For all four patches: Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > stable/presentation-time/presentation-time.xml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH wayland-protocols 00/19] Correct writing errors

On Mon, Apr 11, 2016 at 05:22:47PM -0500, Yong Bakos wrote: > From: Yong Bakos > > This v1 patchset consists of spelling, grammar and minor formatting > changes to all protocol xml files. The approach here is to be > minimally invasive and to not impart stylistic

Re: [PATCH 4/5] compositor: Version the backend configuration structures

On Wed, Apr 13, 2016 at 02:47:06PM +0300, Pekka Paalanen wrote: > On Tue, 12 Apr 2016 21:44:10 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > > > On Mon, 21 Mar 2016 23:11:29 +0100 >

Re: [PATCH weston v5 09/11] drm: Don't hang onto the backend config object post-backend_init

On Wed, Apr 13, 2016 at 04:54:04PM +0300, Pekka Paalanen wrote: > On Wed, 13 Apr 2016 03:25:13 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > The drm backend was copying most everything out of the config object > > already, but now also copy the

[PATCH weston v5 07/11] headless: port the headless backend to the new init api

refactor configuration API of headless-backend Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- v5: - update to current trunk - fixed typo 'struct weston_wayland_backend_config' - dropped unused variables - dropped weston_headless_backend_config_create() in

[PATCH weston v5 00/11] drm: port the drm backend to the new init api

: port the x11 backend to the new init api Bryce Harrington (9): Revert "main: Remove unused function load_backend_new()" compositor: Version the backend configuration structures drm: Fix gcc warning about missing braces. compositor: Document refs for alternatives/assumptions f

<    1   2   3   4   5   6   7   8   9   10   >