[PATCH] cliptest: Avoid use of uninitialized memory when regions don't intersect

2014-08-18 Thread Derek Foreman
Prevent attempting to draw the intersection polygon when it contains no vertices. Signed-off-by: Derek Foreman der...@osg.samsung.com --- clients/cliptest.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/clients/cliptest.c b/clients/cliptest.c index a1928f4

[PATCH] tests: allow running make check without make install

2014-08-21 Thread Derek Foreman
This is my first attempt at a patch to allow running weston-keyboard, desktop-shell and screenshooter out of the build directory so make check doesn't do funny things... From a97352451bff6398edace74defca67e18c92bb98 Mon Sep 17 00:00:00 2001 From: Derek Foreman der...@osg.samsung.com Date: Thu, 21

Re: [PATCH] tests: allow running make check without make install

2014-08-21 Thread Derek Foreman
And here's a second round with free()s for the asprintf()s. On 21/08/14 11:46 AM, Derek Foreman wrote: This is my first attempt at a patch to allow running weston-keyboard, desktop-shell and screenshooter out of the build directory so make check doesn't do funny things

[PATCH] desktop-shell: No longer segfault on cleanup

2014-08-22 Thread Derek Foreman
the destroy handler. Signed-off-by: Derek Foreman der...@osg.samsung.com --- desktop-shell/shell.c | 16 desktop-shell/shell.h | 1 - 2 files changed, 17 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 99f3343..07700cf 100644 --- a/desktop-shell/shell.c

Re: [PATCH] desktop-shell: No longer segfault on cleanup

2014-08-22 Thread Derek Foreman
resulting in a segfault. On 22/08/14 05:47 PM, Eoff, Ullysses A wrote: Does this fix https://bugs.freedesktop.org/show_bug.cgi?id=82957 ? U. Artie -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Derek Foreman Sent: Friday

Re: [PATCH weston 1/3] compositor: add weston_client_start()

2014-08-27 Thread Derek Foreman
in client disconnects. Cc: Boyan Ding stu_...@126.com Cc: Derek Foreman der...@osg.samsung.com Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk --- src/compositor.c | 60 src/compositor.h | 3 +++ 2 files changed, 63

[PATCH] pixman-backend: add support for zooming

2014-08-29 Thread Derek Foreman
Currently if you try to zoom with mod+scrollwheel the pixman backend will stop rendering anything at all and will continuously log pixman renderer does not support zoom, giving the impression that the server is hung. Instead, this patch adds the missing zoom functionality. This should close BUG

[PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-08-29 Thread Derek Foreman
If a full screen program is fading out and a touch start happens, it will result in a NULL pointer dereference when weston_touch_set_focus tries to derefernce view-surface-resource. Instead, this patch sets the focus to NULL, which should be the same as if the program was destroyed during the

Re: [PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-08-29 Thread Derek Foreman
I should mention I don't have a touch capable screen and am only doing partial testing with a modified version of libinput. More testing would be nice. :) On 29/08/14 01:12 PM, Derek Foreman wrote: If a full screen program is fading out and a touch start happens, it will result in a NULL

Re: [PATCH] pixman-backend: add support for zooming

2014-09-01 Thread Derek Foreman
On 01/09/14 04:52 AM, Jason Ekstrand wrote: On Mon, Sep 1, 2014 at 2:37 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 29 Aug 2014 23:35:37 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: On Aug 29, 2014 6:25 PM, Derek Foreman der...@osg.samsung.com wrote: On 29/08/14 06:42 PM

[PATCH] pixman-renderer: fail to zoom more gracefully

2014-09-01 Thread Derek Foreman
When zoom is activated in the pixman rendered the log is filled with warnings and all rendering stops. With this patch the warning is generated once and rendering continues without zooming. Closes bug 80258 --- src/pixman-renderer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-09-04 Thread Derek Foreman
On 04/09/14 06:49 AM, Pekka Paalanen wrote: On Fri, 29 Aug 2014 13:18:54 -0500 Derek Foreman der...@osg.samsung.com wrote: I should mention I don't have a touch capable screen and am only doing partial testing with a modified version of libinput. More testing would be nice. :) On 29/08

[PATCH] matrix-test: fix units in report

2014-09-04 Thread Derek Foreman
The matrix-test speed tests are calculated in ns but some printed the units as us --- tests/matrix-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/matrix-test.c b/tests/matrix-test.c index 7b414c9..6bf4ba3 100644 --- a/tests/matrix-test.c +++

[PATCH] shm: fix error in comment

2014-09-10 Thread Derek Foreman
--- src/wayland-shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 3fce678..04ba4f2 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -372,7 +372,7 @@ wl_shm_buffer_get_stride(struct wl_shm_buffer *buffer) * Returns a

[PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-10 Thread Derek Foreman
weston_surface_update_transform() no longer exists, except in comments. Fix that. --- desktop-shell/shell.c | 2 +- src/compositor-drm.c | 3 +-- src/compositor.c | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Derek Foreman
On 11/09/14 08:22 AM, Pekka Paalanen wrote: On Thu, 11 Sep 2014 08:10:25 -0500 Derek Foreman der...@osg.samsung.com wrote: On 11/09/14 04:00 AM, Pekka Paalanen wrote: On Wed, 10 Sep 2014 15:37:33 -0500 Derek Foreman der...@osg.samsung.com wrote: weston_surface_update_transform() no longer

[PATCH 2/2] cosmetic: Move WL_EXPORT out of header files

2014-09-18 Thread Derek Foreman
Most of the code only puts WL_EXPORT in .c files. Remove the few instances in header files. If it's missing form the associated .c, put it there instead. --- src/compositor.h | 6 +++--- src/filter.c | 4 ++-- src/filter.h | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff

[PATCH 1/2] cosmetic: Remove prototype for nonexistent function

2014-09-18 Thread Derek Foreman
--- src/filter.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/filter.h b/src/filter.h index dad538b..34d0f81 100644 --- a/src/filter.h +++ b/src/filter.h @@ -52,9 +52,6 @@ struct weston_motion_filter { struct weston_motion_filter_interface *interface; }; -WL_EXPORT struct

[PATCH libinput] cosmetic: Remove prototype for nonexistent create_linear_acceleration_filter()

2014-09-18 Thread Derek Foreman
--- src/filter.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/filter.h b/src/filter.h index 31ac7eb..8553495 100644 --- a/src/filter.h +++ b/src/filter.h @@ -52,9 +52,6 @@ struct motion_filter { struct motion_filter_interface *interface; }; -struct motion_filter *

[PATCH] shell: fix weston_output_mode_switch() usage

2014-09-19 Thread Derek Foreman
Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE will result in the mode being set back to the passed in mode - so the passed mode should be the native mode. Additionally, weston_output_mode_switch() should be called when output-original_mode is non-NULL (which indicates

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-22 Thread Derek Foreman
On 22/09/14 06:41 AM, Pekka Paalanen wrote: On Fri, 19 Sep 2014 14:43:23 -0500 Derek Foreman der...@osg.samsung.com wrote: Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE will result in the mode being set back to the passed in mode - so the passed mode should

[PATCH] compositor: Refactor weston_output_mode_switch()

2014-09-22 Thread Derek Foreman
This breaks weston_output_mode_switch() into 3 functions: weston_output_mode_set_native() weston_output_mode_switch_to_temporary() weston_output_mode_switch_to_native() Differences from previous behaviour: SET_NATIVE didn't set current_scale (now it does) SET_TEMPORARY could set mode and scale

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Derek Foreman
On 23/09/14 08:34 AM, Hardening wrote: Le 23/09/2014 09:37, Pekka Paalanen a écrit : On Mon, 22 Sep 2014 11:01:10 -0500 Derek Foreman der...@osg.samsung.com wrote: On 22/09/14 06:41 AM, Pekka Paalanen wrote: On Fri, 19 Sep 2014 14:43:23 -0500 Derek Foreman der...@osg.samsung.com wrote

[RFC weston 00/16] Replace existing transformation code with matrix operations

2014-09-26 Thread Derek Foreman
zooming. Derek Foreman (10): compositor: Move weston_matrix_transform_region to compositor.c and export it compositor: add weston_matrix_transform_rect() and use it for where appropriate compositor: use matrix transforms for surface_to_buffer functions compositor: use

[RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-09-26 Thread Derek Foreman
If a transformation matrix causes a scale or a rotation not a multiple of 90 degrees then textures rendered with it would benefit from bilinear filtering. weston_matrix_needs_filtering() checks for this. --- src/compositor.c | 23 +++ src/compositor.h | 3 +++ 2 files

[RFC weston 06/16] pixman-renderer: Use output-matrix for region transformations and enable output zoom

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net --- src/pixman-renderer.c | 70 +++ 1 file changed, 60 insertions(+), 10 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 18b6476..d3650d1 100644 --- a/src/pixman-renderer.c

[RFC weston 10/16] compositor: use weston_matrix_transform_region for overlay setup

2014-09-26 Thread Derek Foreman
--- src/compositor-drm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index e4496e7..cd999e9 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -906,17 +906,13 @@

[RFC weston 03/16] Use pixel coordinates for weston_output.matrix

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net Previously, weston_output.matrix was in GL coordinates and therefore only really useful for the GL backend. --- src/compositor.c | 106 -- src/gl-renderer.c | 14 +++- 2 files changed, 52

[RFC weston 07/16] compositor: Move weston_matrix_transform_region to compositor.c and export it

2014-09-26 Thread Derek Foreman
We're going to use this to replace much of the other transform code so it's no longer just relevant to pixman-renderer.c --- src/compositor.c | 51 +++ src/compositor.h | 4 src/pixman-renderer.c | 51

[RFC weston 09/16] compositor: use matrix transforms for surface_to_buffer functions

2014-09-26 Thread Derek Foreman
Now that we have weston_matrix_transform and appropriate matrices we can use that instead of weston_transformed_coord + scaler_surface_to_buffer. scaler_surface_to_buffer no longer has users, so remove it. --- src/compositor.c | 41 - 1 file changed, 4

[RFC weston 02/16] gl-renderer: Call glViewport after the context is made current

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net --- src/gl-renderer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index f7f29b3..8684180 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -870,15 +870,15 @@

[RFC weston 12/16] matrix: Add functions to decompose a transformation matrix into basic operations

2014-09-26 Thread Derek Foreman
Adds an internal weston_matrix_decompose() which takes a matrix and decomposes translation, rotation, shear and scale parameters to re-create it. This information is cached the first time any helper functions are used to extract these values and dirtied whenever a matrix multiplication takes

[RFC weston 14/16] renderers: use weston_matrix_needs_filtering to choose filter parameters in gl and pixman renderers

2014-09-26 Thread Derek Foreman
Note: This causes a performance drop when zoomed under pixman. --- src/gl-renderer.c | 6 +++--- src/pixman-renderer.c | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index f3aeff2..d42108d 100644 --- a/src/gl-renderer.c +++

[RFC weston 05/16] pixman-renderer: Add a weston_matrix_to_pixman_transform function and simplify the buffer-to-output matrix computation

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net Now that we have a buffer-to-surface matrix and the global-to-output matrix is in pixels, we can remove a large chunk of confusing code from the pixman renderer. Hopefully, having this stuff in weston core will keep the pixman renderer from gettin broken

[RFC weston 01/16] weston_surface: Add surface-to-buffer and buffer-to-surface matrices

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net --- src/compositor.c | 84 src/compositor.h | 6 2 files changed, 90 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index a219766..136cc83 100644 --- a/src/compositor.c +++

[RFC weston 11/16] compositor: Remove weston_transformed_region

2014-09-26 Thread Derek Foreman
Replace all uses of weston_transform_region with weston_matrix_transform_region, then remove the function completely. --- src/compositor-wayland.c | 8 ++--- src/compositor-x11.c | 8 + src/compositor.c | 92 src/compositor.h

[RFC weston 04/16] zoom: Use pixels instead of GL coordinates

2014-09-26 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net Previously, the zoom functions used GL coordinates natively which doesn't work with the new output matrix calculations. This changes zoom to work in pixel coordinates to match the new output matrix format. This also cleans up the math in the zoom code

[RFC weston 16/16] compositor: Remove weston_transformed_rect() and weston_transformed_coord()

2014-09-26 Thread Derek Foreman
The last caller of weston_transformed_rect() has been replaced so we can remove weston_transformed_rect() - since it was the last caller of weston_transformed_coord() we can get rid of that too. --- src/compositor.c | 80 src/compositor.h |

[RFC weston 08/16] compositor: add weston_matrix_transform_rect() and use it for where appropriate

2014-09-26 Thread Derek Foreman
New function that transforms a pixman_box32_t rectangle by a matrix. Since pixman rectangles are represented by 2 corners, non-90 degree rotations can't be properly represented. This function gives the axis aligned rectangle that encloses the rotated rectangle. We use this for

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-09-30 Thread Derek Foreman
on that short circuit there... Though bilinear vs nearest doesn't have anywhere near the same performance impact there. Are you suggesting pixman always be set to use bilinear, and it'll just pick nearest automatically when the image transform doesn't require it? On 09/26/2014 02:10 PM, Derek Foreman

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-02 Thread Derek Foreman
haven't had a chance to really look over things carefully. I have been reading this thread, just haven't had a chance to respond. On Wed, Oct 1, 2014 at 12:41 AM, Pekka Paalanen ppaala...@gmail.com mailto:ppaala...@gmail.com wrote: On Tue, 30 Sep 2014 14:35:24 -0500 Derek Foreman der

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-02 Thread Derek Foreman
On 02/10/14 02:15 PM, Bill Spitzak wrote: On 10/02/2014 12:37 AM, Pekka Paalanen wrote: On Wed, 1 Oct 2014 18:09:32 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: (do we use bool in weston? Maybe just return int). We may need both x and y scales and it may be useful to get those as

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-03 Thread Derek Foreman
On 02/10/14 07:09 PM, Jason Ekstrand wrote: On Thu, Oct 2, 2014 at 3:21 PM, Derek Foreman der...@osg.samsung.com mailto:der...@osg.samsung.com wrote: On 02/10/14 02:37 PM, Jason Ekstrand wrote: On Oct 2, 2014 12:37 AM, Pekka Paalanen ppaala...@gmail.com mailto:ppaala

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-03 Thread Derek Foreman
On 03/10/14 02:04 AM, Pekka Paalanen wrote: On Thu, 02 Oct 2014 17:21:04 -0500 Derek Foreman der...@osg.samsung.com wrote: On 02/10/14 02:37 PM, Jason Ekstrand wrote: On Oct 2, 2014 12:37 AM, Pekka Paalanen ppaala...@gmail.com mailto:ppaala...@gmail.com wrote: On Wed, 1 Oct 2014 18:09:32

[PATCH weston] cosmetic: replace boolean function return values with bool

2014-10-03 Thread Derek Foreman
For functions that test if something is true/valid and return a 1 or 0, it makes sense to switch to bool. --- src/cms-colord.c| 10 +- src/compositor.c| 20 ++-- src/compositor.h| 5 +++-- src/input.c | 8 src/weston-launch.c | 11 ++-

Re: [RFC weston 13/16] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-03 Thread Derek Foreman
On 03/10/14 02:04 AM, Pekka Paalanen wrote: On Thu, 02 Oct 2014 17:21:04 -0500 Derek Foreman der...@osg.samsung.com wrote: On 02/10/14 02:37 PM, Jason Ekstrand wrote: On Oct 2, 2014 12:37 AM, Pekka Paalanen ppaala...@gmail.com mailto:ppaala...@gmail.com wrote: On Wed, 1 Oct 2014 18:09:32

[PATCH wayland] cosmetic: convert some function returns from int to bool

2014-10-03 Thread Derek Foreman
--- src/scanner.c | 5 +++-- src/wayland-shm.c | 9 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 809130b..dc113f5 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -21,6 +21,7 @@ * OF THIS SOFTWARE. */ +#include stdbool.h

[PATCH libinput] cosmetic: convert evdev_need_touch_frame from int to bool

2014-10-03 Thread Derek Foreman
We use stdbool elsewhere, so use it here too for consistency. --- src/evdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d8e3e5a..1b4ce10 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -577,11 +577,11 @@

[PATCH weston] gl-renderer: don't move memory in output_rotate_damage

2014-10-09 Thread Derek Foreman
output_rotate_damage shifted an array of pixman regions with a loop. Now it uses an index into that array. This currently only saves 1 pixman_region32_copy, but we can now raise BUFFER_DAMAGE_COUNT without a performance impact if we run into a configuration where this is useful. ---

[PATCH weston] compositor: make keep_buffer a bool

2014-10-10 Thread Derek Foreman
The comments already call it bool, so let's just make it one --- src/compositor-drm.c | 4 ++-- src/compositor.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 07b83a7..bee41ef 100644 --- a/src/compositor-drm.c +++

[PATCH weston v2 02/20] gl-renderer: Call glViewport after the context is made current

2014-10-16 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net --- src/gl-renderer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 076c242..d54928b 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -867,15 +867,15 @@

[PATCH weston v2 00/20] Replace existing transformation code with matrix operations

2014-10-16 Thread Derek Foreman
- changes to how compositor-drm checks for plane viability - addition of weston_view_to_output_matrix() to create the end to end matrix Derek Foreman (14): compositor: Move weston_matrix_transform_region to compositor.c and export it compositor: add weston_matrix_transform_rect() and use

[PATCH weston v2 17/20] compositor: Add weston_matrix_to_transform function

2014-10-16 Thread Derek Foreman
This function examines a matrix to see if it can be built with simple scale + translate + wl_output_transform enum. --- src/compositor.c | 57 src/compositor.h | 5 + 2 files changed, 62 insertions(+) diff --git a/src/compositor.c

[PATCH weston v2 03/20] Use pixel coordinates for weston_output.matrix

2014-10-16 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net Previously, weston_output.matrix was in GL coordinates and therefore only really useful for the GL backend. --- src/compositor.c | 106 -- src/gl-renderer.c | 14 +++- 2 files changed, 52

[PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

2014-10-16 Thread Derek Foreman
New function that transforms a pixman_box32_t rectangle by a matrix. Since pixman rectangles are represented by 2 corners, non-90 degree rotations can't be properly represented. This function gives the axis aligned rectangle that encloses the rotated rectangle. We use this for

[PATCH weston v2 12/20] compositor: Add a function to test if images transformed by a matrix should be bilinearly filtered

2014-10-16 Thread Derek Foreman
If a transformation matrix causes a scale, a rotation not a multiple of 90 degrees or a non-integer translation then textures rendered with it would benefit from bilinear filtering. This test is done in a lazy fashion by examining elements of the matrix to check for a simple pattern that

[PATCH weston v2 18/20] compositor: add weston_view_to_output_matrix()

2014-10-16 Thread Derek Foreman
New function that creates a matrix that can transform buffer co-ordinates to output co-ordinates (or the inverse of that matrix). --- src/compositor.c | 19 +++ src/compositor.h | 6 +- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/compositor.c

[PATCH weston v2 14/20] compositor-drm: use weston_surface_to_buffer_rect instead of weston_transformed_rect

2014-10-16 Thread Derek Foreman
The weston_transformed_rect() call should have the same result as weston_surface_to_buffer_rect(). Also, this mix of fixed, float, and int is difficult to follow and I don't trust it, so just convert to fixed for the plane API at the end of the calculation. --- src/compositor-drm.c | 34

[PATCH weston v2 15/20] compositor: Remove weston_transformed_rect() and weston_transformed_coord()

2014-10-16 Thread Derek Foreman
The last caller of weston_transformed_rect() has been replaced so we can remove weston_transformed_rect() - since it was the last caller of weston_transformed_coord() we can get rid of that too. --- src/compositor.c | 80 src/compositor.h |

[PATCH weston v2 05/20] pixman-renderer: Add a weston_matrix_to_pixman_transform function and simplify the buffer-to-output matrix computation

2014-10-16 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net Now that we have a buffer-to-surface matrix and the global-to-output matrix is in pixels, we can remove a large chunk of confusing code from the pixman renderer. Hopefully, having this stuff in weston core will keep the pixman renderer from gettin broken

[PATCH weston v2 09/20] compositor: use matrix transforms for surface_to_buffer functions

2014-10-16 Thread Derek Foreman
Now that we have weston_matrix_transform and appropriate matrices we can use that instead of weston_transformed_coord + scaler_surface_to_buffer. scaler_surface_to_buffer no longer has users, so remove it. --- src/compositor.c | 41 - 1 file changed, 4

[PATCH weston v2 11/20] compositor: Remove weston_transformed_region

2014-10-16 Thread Derek Foreman
Replace all uses of weston_transform_region with weston_matrix_transform_region, then remove the function completely. --- src/compositor-wayland.c | 8 ++--- src/compositor-x11.c | 8 + src/compositor.c | 92 src/compositor.h

[PATCH weston v2 13/20] renderers: use weston_matrix_needs_filtering to choose filter parameters in gl and pixman renderers

2014-10-16 Thread Derek Foreman
Note: This causes a performance drop when zoomed under pixman. Also, pixman has clever optimization algorithms to switch from BILINEAR to NEAREST automatically when it detects they'll have the same result - we still do our own test here because the pixman check misses a few opportunities when the

[PATCH weston v2 07/20] compositor: Move weston_matrix_transform_region to compositor.c and export it

2014-10-16 Thread Derek Foreman
We're going to use this to replace much of the other transform code so it's no longer just relevant to pixman-renderer.c --- src/compositor.c | 51 +++ src/compositor.h | 4 src/pixman-renderer.c | 51

[PATCH weston v2 19/20] renderers: use weston_view_to_output_matrix() in renderers

2014-10-16 Thread Derek Foreman
We now use this function in the gl renderer to determine if linear filtering is required, and in the pixman renderer to set up the image transformation. --- src/gl-renderer.c | 9 ++--- src/pixman-renderer.c | 14 +- 2 files changed, 3 insertions(+), 20 deletions(-) diff

[PATCH weston v2 06/20] pixman-renderer: Use output-matrix for region transformations and enable output zoom

2014-10-16 Thread Derek Foreman
From: Jason Ekstrand ja...@jlekstrand.net --- src/pixman-renderer.c | 70 +++ 1 file changed, 60 insertions(+), 10 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 18b6476..d3650d1 100644 --- a/src/pixman-renderer.c

[PATCH weston v2 20/20] compositor-drm: use weston_view_to_output_matrix() to test plane viability

2014-10-16 Thread Derek Foreman
Instead of comparing buffer transforms to output transforms we now use weston_view_to_output_matrix() and weston_matrix_to_transform() to test if we can use a drm plane. We no longer test scaling, since the drm plane api supports scaling. Unfortunately the drmSetPlane() call is far from the

[PATCH weston v2 10/20] compositor: use weston_matrix_transform_region for overlay setup

2014-10-16 Thread Derek Foreman
--- src/compositor-drm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 07b83a7..c997c26 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -919,17 +919,13 @@

[PATCH weston v2 16/20] compositor: use weston_matrix_transform for weston_output_transform_coordinate

2014-10-16 Thread Derek Foreman
We can greatly simplify weston_output_transform_coordinate now by simply multiplying by the output matrix and converting the result to fixed point. --- src/compositor.c | 62 1 file changed, 4 insertions(+), 58 deletions(-) diff --git

Re: [PATCH weston v5 2/3] Implement data_device interface destructor

2014-10-16 Thread Derek Foreman
I apologize in advance for only commenting on the whitespace :) On 13/10/14 12:05 AM, kabeer khan wrote: window : compare version and call appropriate destructor Signed-off-by: kabeer khan kabeer.k...@samsung.com --- clients/window.c | 15 ++- 1 file changed, 10 insertions(+),

Re: [PATCH weston v5 3/3 1/2] Implement data_device interface destructor

2014-10-16 Thread Derek Foreman
On 13/10/14 12:06 AM, kabeer khan wrote: data_device : change version while initializing data_device_manager interface and data_device interface Signed-off-by: kabeer khan kabeer.k...@samsung.com --- src/data-device.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

[PATCH weston] gl-renderer: compress pixman bands to simplify geometry

2014-10-16 Thread Derek Foreman
Pixman uses y-x banded rectangles to represent regions. We use these y-x banded rectangles to generate triangle fans, resulting in more geometry than strictly necessary to draw the screen. This patch combines the bands to reduce geometry for complex scenes. --- src/gl-renderer.c | 67

Re: [PATCH Weston 1/1] desktop-shell: implement autolaunch

2014-10-22 Thread Derek Foreman
printf's %m until today - do we want to depend on a gnuism? I've seen at least some activity towards a freebsd port - I don't believe %m is supported there? That said, it runs nicely here and does what it says on the tin... Reviewed-by: Derek Foreman der...@osg.samsung.com On 22/10/14 08:53 AM, Pekka

[PATCH weston] backends: don't run off the end of strings

2014-10-23 Thread Derek Foreman
Strings from the config parser can be of length 0, so we should check that before checking the string's bytes. The x11 backend's usage is technically safe since the null terminator is present, but I've changed it too in case someone's looking at it as a reference for new code. ---

[PATCH weston] backends: refactor transform string parsing

2014-10-23 Thread Derek Foreman
Most of the backends do their own parsing of transform strings, so let's put that all in the same place (compositor.c/h) --- src/compositor-drm.c | 30 -- src/compositor-rpi.c | 43 --- src/compositor-wayland.c | 25

Re: [PATCH weston] backends: don't run off the end of strings

2014-10-23 Thread Derek Foreman
. On 10/23/2014 10:21 AM, Derek Foreman wrote: Strings from the config parser can be of length 0, so we should check that before checking the string's bytes. The x11 backend's usage is technically safe since the null terminator is present, but I've changed it too in case someone's looking

Re: [WESTON PATCH 1/1] Weston: Fix some weston.ini.man typesetting macros

2014-10-24 Thread Derek Foreman
An obvious improvement. Reviewed-by: Derek Foreman der...@osg.samsung.com On 23/10/14 09:40 PM, Frederic Plourde wrote: This patch fixes a couple of misuses around .TP 7 macros that wrongly limited right margins and relative identation. --- man/weston.ini.man | 3 +-- 1 file changed, 1

Re: [PATCH 3/3] compositor: Fix typos in help text

2014-10-24 Thread Derek Foreman
The whole series looks correct to me... Reviewed-by: Derek Foreman der...@osg.samsung.com On 23/10/14 04:44 PM, Bryce Harrington wrote: Signed-off-by: Bryce Harrington br...@osg.samsung.com --- src/compositor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src

Re: [PATCH 2/2] compositor: List only available backends in help text

2014-10-24 Thread Derek Foreman
I think this series is all obviously correct too. Though, I suppose this one will look funny if someone manages to build weston without any back-ends. :) Reviewed-by: Derek Foreman der...@osg.samsung.com On 23/10/14 05:25 PM, Bryce Harrington wrote: Signed-off-by: Bryce Harrington br

[PATCH libinput] evdev: Pass along device overflow information

2014-10-24 Thread Derek Foreman
Currently libinput users just see choppy input if the kernel event queue overflows. This patch passes along an event so the caller can at least log it. --- src/evdev.c| 1 + src/libinput-private.h | 3 +++ src/libinput.c | 18 ++ src/libinput.h | 5

Re: [PATCH libinput] evdev: Pass along device overflow information

2014-10-27 Thread Derek Foreman
On 26/10/14 11:11 PM, Peter Hutterer wrote: On Fri, Oct 24, 2014 at 01:18:06PM -0500, Derek Foreman wrote: Currently libinput users just see choppy input if the kernel event queue overflows. This patch passes along an event so the caller can at least log it. any reason you didn't just log

[PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Derek Foreman
Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 1b4ce10..c786537

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-27 Thread Derek Foreman
silly bug reports...) Thanks On 27/10/14 09:26 AM, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10 ++ 1 file changed, 10

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 27/10/14 07:11 PM, Peter Hutterer wrote: On Mon, Oct 27, 2014 at 09:33:45AM -0500, Derek Foreman wrote: A couple of questions on this one: Is it ok to limit logging to 10 messages like this? IMO yes. Should I be doing that on a per device basis instead of globally? you are doing

Re: [PATCH libinput] evdev: Log evdev event queue overflows

2014-10-28 Thread Derek Foreman
On 28/10/14 03:20 AM, Ran Benita wrote: On Mon, Oct 27, 2014 at 09:26:39AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 10

[PATCH libinput v2] evdev: Log evdev event queue overflows

2014-10-29 Thread Derek Foreman
Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. --- src/evdev.c | 11 +++ src/evdev.h | 4 2 files changed, 15 insertions(+) diff --git a/src/evdev.c b/src/evdev.c

[PATCH libinput 3/4] evdev: add DPI to evdev calculations

2014-10-30 Thread Derek Foreman
Assume normal mice are 400DPI, and that all calculations should be normalized to this before being fed into the filter. There isn't yet a way to configure a device's DPI. --- src/evdev.c | 6 -- src/evdev.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/evdev.c

[PATCH libinput 4/4] config: Allow setting non-default device DPI

2014-10-30 Thread Derek Foreman
This allows changing a device's DPI from the default 400 --- src/evdev.c| 7 +++ src/evdev.h| 3 +++ src/libinput.c | 7 +++ src/libinput.h | 22 ++ 4 files changed, 39 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 8efa21a..e267320 100644 ---

[PATCH libinput 1/4] filter: Fix typo

2014-10-30 Thread Derek Foreman
accelator - accelerator --- src/evdev.c | 2 +- src/filter.c | 2 +- src/filter.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index dd2228b..341f7d8 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -981,7 +981,7 @@ int

[PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-10-30 Thread Derek Foreman
just set it to 400 (which may actually not be that prevalent any more but there doesn't seem to be such thing as a standard DPI mouse). Derek Foreman (4): filter: Fix typo filter: perform speed computations with doubles evdev: add DPI to evdev calculations config: Allow setting non-default

Re: [PATCH libinput v2] evdev: Log evdev event queue overflows

2014-10-30 Thread Derek Foreman
On 30/10/14 07:14 PM, Peter Hutterer wrote: On Wed, Oct 29, 2014 at 09:56:27AM -0500, Derek Foreman wrote: Log a message when the kernel event queue overflows and events are dropped. After 10 messages logging stops to avoid flooding the logs if the condition is persistent. merged locally

Re: [PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-11-04 Thread Derek Foreman
On 03/11/14 09:51 PM, Peter Hutterer wrote: On Mon, Nov 03, 2014 at 11:56:59AM +0100, David Herrmann wrote: Hi On Fri, Oct 31, 2014 at 5:33 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Oct 30, 2014 at 04:34:12PM -0500, Derek Foreman wrote: The acceleration filter currently

Re: [PATCH weston] compositor: Fix weston_subsurface_is_synchronized() return value.

2014-11-04 Thread Derek Foreman
On 04/11/14 07:38 AM, Carlos Olmedo Escobar wrote: Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the return value of weston_subsurface_is_synchronized(). Ouch! Nice catch. :( Reviewed-by: Derek Foreman der...@osg.samsung.com Signed-off-by: Carlos Olmedo Escobar

[PATCH weston v2] compositor: Refactor weston_output_mode_switch()

2014-11-04 Thread Derek Foreman
independently - now it can't. Signed-off-by: Derek Foreman der...@osg.samsung.com --- In previous version weston_output_mode_switch_to_temporary didn't call weston_mode_switch_finish() correctly desktop-shell/shell.c | 12 +-- fullscreen-shell/fullscreen-shell.c | 13 +-- src

[PATCH weston] compositor: check version before calling wl_output_send_scale()

2014-11-05 Thread Derek Foreman
Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/compositor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 1f6700d..9dcabe3 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -105,6 +105,7 @@ static void

[PATCH weston] compositor: stop sending spurious events on mode switch

2014-11-10 Thread Derek Foreman
commit 6ae7bc982fa accidentally made weston_output_mode_switch_temporary send done events when it shouldn't. Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 9dcabe3..6a81cc7

Re: [PATCH weston v0 05/11] tests: add screenshot recording to weston-test

2014-11-10 Thread Derek Foreman
a region look a little more intuitive than it would otherwise. On 11/09/2014 01:41 PM, Bryce Harrington wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG

[PATCH weston] input: Use slightly less obscure logic in evdev_notify_keyboard_focus()

2014-11-17 Thread Derek Foreman
-by: Derek Foreman der...@osg.samsung.com --- src/input.c | 1 + src/libinput-device.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/input.c b/src/input.c index 5f19875..6784ead 100644 --- a/src/input.c +++ b/src/input.c @@ -2209,6 +2209,7

[PATCH weston] dnd: reset the mouse cursor after adding a new item

2014-11-18 Thread Derek Foreman
one of the issues in bug 56298 https://bugs.freedesktop.org/show_bug.cgi?id=56298 Signed-off-by: Derek Foreman der...@osg.samsung.com --- clients/dnd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/clients/dnd.c b/clients/dnd.c index 956c306..332d137 100644 --- a/clients

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

2014-11-19 Thread Derek Foreman
On 19/11/14 08:33 AM, Pekka Paalanen wrote: On Thu, 16 Oct 2014 16:37:02 -0500 Derek Foreman der...@osg.samsung.com wrote: Pixman uses y-x banded rectangles to represent regions. We use these y-x banded rectangles to generate triangle fans, resulting in more geometry than strictly

  1   2   3   4   5   6   7   8   9   10   >