[PATCH weston] configure.ac: drop spurious bracket

Otherwise configure output looks like checking for library containing pam_open_session... -lpam ./configure: line 18064: ]: command not found checking for COLORD... yes Signed-off-by: Guido Günther <a...@sigxcpu.org> --- configure.ac | 2 +- 1 file changed, 1 insertion

[PATCH weston v2 0/1] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12

simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 This makes things testable on non freedreno as well. E.g. intel supports it. Changes from v1: * don't forget to set modifier in dmabuf_modifiers * give an idea how the image should look like Guido Günther (1): simple-dmabuf-drm: support

Re: [PATCH weston v2 1/1] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well

Hi, On Tue, May 29, 2018 at 11:44:36AM +0300, Pekka Paalanen wrote: > On Mon, 28 May 2018 17:41:57 +0200 > Guido Günther wrote: > > > This makes --import-format=NV12 testable on e.g. intel > > > > We only set nv12_format_found to true if we found that format and

Re: [PATCH weston 3/3] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well

Hi, On Mon, May 28, 2018 at 04:31:14PM +0300, Pekka Paalanen wrote: > On Tue, 20 Mar 2018 11:36:38 +0100 > Guido Günther <a...@sigxcpu.org> wrote: > > > This makes --import-format=NV12 testable on e.g. intel > > > > We only set nv12_format_found to true if we f

[PATCH weston v2 1/1] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well

image should be green in the upper left corner and white in the lower right. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 55 + 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/clients/simple-dmabuf-d

[PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

Some modeline generators put out e.g. +HSync instead of +hsync. Accept that too since it's not ambigous. Signed-off-by: Guido Günther --- libweston/compositor-drm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

Hi, On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: > On 26 June 2018 at 19:40, Guido Günther wrote: > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > > Hmm which generator is that? The cvt

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

Hi, On Tue, Jul 03, 2018 at 12:04:37PM +0300, Pekka Paalanen wrote: > On Tue, 26 Jun 2018 20:40:08 +0200 > Guido Günther wrote: > > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > >

Re: [PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

Hi, On Thu, Jul 19, 2018 at 04:45:02PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. > > Signed-off-by: Emilio Pozuelo Monfort > --- > Some improvements from Daniel (thanks!). I

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

Hi, On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote: > Hi, > On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > > No need to write libdrm driver specific code for each supported > > driver, we can just let GBM call the right one for us now. &g

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

Hi, On Fri, Jul 20, 2018 at 11:10:29PM +0200, Guido Günther wrote: > Hi, > On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote: > > Hi, > > On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > > > No need to write libdrm driver speci

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

Hi, On Tue, Jul 10, 2018 at 05:53:15PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. > > Signed-off-by: Emilio Pozuelo Monfort > --- > > Hi, > > This simplifies the code a lot,

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

Hi, On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. This one breaks NV12 on intel when using rootston as compositor for me. $

[weston PATCH] simple-dmabuf-drm: support etnaviv drm as well

Since freedreno and etnaviv can live in parallel allow to build in different DRM backends. --- Makefile.am | 6 ++- clients/simple-dmabuf-drm.c | 122 +++- configure.ac| 29 +++ 3 files changed, 121 insertions(+),

[PATCH weston v2 0/4] simple-dmabuf-drm: multiple backends and etnaviv support

Changes from v1: - Split up changes - autoconf: - don't define unused have_ variables. Use true instead to prevent abort of PKG_CHECK_MODULES - use && instead of -a in test - properly check variables - use vfunc for drm_device_destroy Guido Gü

[PATCH weston v2 4/4] simple-dmabuf-drm: support etnaviv drm as well

--- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 73 + configure.ac| 5 +++- 3 files changed, 78 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index c2d448e7..19319fa2 100644 --- a/Makefile.am

[PATCH weston v2 1/4] simple-dmabuf-drm: allow multiple backends

This allows to enable freedreno and intel backends at the same time building the prerequisites for adding further ones. --- Makefile.am | 5 - clients/simple-dmabuf-drm.c | 53 + configure.ac| 24 +++-

[PATCH weston v2 1/1] Allow simple-dmabuf-drm to pass y_inverted flag

This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is interpreted correctly by the compositor. --- clients/simple-dmabuf-drm.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/clients/simple-dmabuf-drm.c

[PATCH weston v2 0/1] Allow simple-dmabuf-drm to pass y_inverted flag

Changes from v1 - introduce opts as a bitmask of features that can be used to manipulate the displayed image Guido Günther (1): Allow simple-dmabuf-drm to pass y_inverted flag clients/simple-dmabuf-drm.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions

[PATCH weston v2 2/4] simpla-dmabuf-drm: Use more weston like coding style

--- clients/simple-dmabuf-drm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 51ad51f8..b576ad3a 100644 --- a/clients/simple-dmabuf-drm.c +++ b/clients/simple-dmabuf-drm.c @@ -203,8 +203,8

[PATCH weston v2 3/4] simple-dmabuf-drm: use vfunc for drm_device_destroy

Remove ifdef clutter and makes sure it's only called for the active backend. --- clients/simple-dmabuf-drm.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index b576ad3a..492c9667 100644 ---

[weston PATCH] Allow simple-dmabuf-drm to pass y_inverted flag

This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is interpreted correctly by the compositor. --- clients/simple-dmabuf-drm.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c

Re: [PATCH weston v5 0/3] simple-dmabuf-drm: Support etnaviv and freedreno cleanups

On Tue, Mar 20, 2018 at 09:41:57AM +0100, Guido Günther wrote: > Former patches 1-2 where already applied thanks Derek. > > Changes from v4 > - configure: use true if etnaviv drm was not found as with > other drm backends (avoids an unused variable assignment) >

Re: [PATCH weston v2 1/1] Allow simple-dmabuf-drm to pass y_inverted flag

On Fri, Mar 16, 2018 at 01:55:41PM +0200, Pekka Paalanen wrote: > On Thu, 15 Mar 2018 17:34:55 +0100 > Guido Günther <a...@sigxcpu.org> wrote: > > > This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is > > interpreted correctly by the compositor. > &g

[PATCH weston] .gitignore weston-simple-dmabuf-drm

Got renamed in f9dec67990a54afe14d4d2db694bf696ae418bcd Signed-off-by: Guido Günther <a...@sigxcpu.org> --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index ac76fd9f..661f4882 100644 --- a/.gitignore +++ b/.gitignore @@ -67,7

[PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

Changes from v2 - Explain OPT_* usage - Switch is_immediate to OPT_* - use getopt_long Changes from v1 - introduce opts as a bitmask of features that can be used to manipulate the displayed image Guido Günther (3): Allow simple-dmabuf-drm to pass y_inverted flag simple-dmabuf-drm

[PATCH weston v3 1/3] Allow simple-dmabuf-drm to pass y_inverted flag

This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is interpreted correctly by the compositor. We introduce an OPT_* bitmask to hold this flag and possible future command line flags. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.

[PATCH weston v3 2/3] simple-dmabuf-drm: use opt bitmask instead of is_immediate

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1789db73..427597ab 100644 --- a/clients/simple-dmabuf-drm.c

[PATCH weston v3 3/3] simple-dmabuf-drm: use getopt_long

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 51 - 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 427597ab..4f26e4a9

[PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

Changes from v2 - Explain OPT_* usage - Switch is_immediate to OPT_* - use getopt_long Changes from v1 - introduce opts as a bitmask of features that can be used to manipulate the displayed image Guido Günther (3): Allow simple-dmabuf-drm to pass y_inverted flag simple-dmabuf-drm

Re: [PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

On Mon, Mar 19, 2018 at 12:12:36PM +0200, Pekka Paalanen wrote: > On Fri, 16 Mar 2018 18:56:47 +0100 > Guido Günther <a...@sigxcpu.org> wrote: > > > Changes from v2 > > > > - Explain OPT_* usage > > - Switch is_immediate to OPT_* > >

[PATCH weston v3 1/3] simple-dmabuf-drm: support etnaviv drm as well

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 74 + configure.ac| 5 ++- 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makef

[PATCH weston v3 0/3] simple-dmabuf-drm: Support etnaviv (and other cleanups)

unused have_ variables. Use true instead to prevent abort of PKG_CHECK_MODULES - use && instead of -a in test - properly check variables - use vfunc for drm_device_destroy Guido Günther (3): simple-dmabuf-drm: support etnaviv drm as well simple-dmabuf-drm: u

[PATCH weston v3 3/3] simple-dmabuf-drm: name ALIGN FD_ALIGN

Other backends might have different alignment requirements and since we can have several backends we want a less generic name. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/

[PATCH weston v3 2/3] simple-dmabuf-drm: use large enough buffer for freedreno

Use stride instead of width fur buffer calculation. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 174d0f85..08e794c8

[PATCH weston 3/3] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well

This makes --import-format=NV12 testable on e.g. intel We only set nv12_format_found to true if we found that format and at least one understood modifier. Store modifier verbatim instead of using a boolean flag. Last advertised and supported modifier currently wins. Signed-off-by: Guido Günther

[PATCH weston 1/3] simple-dmabuf-drm: drop superfluous declaration

variable is defined in simple-dmabuf-drm.h Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 2975f3a5..1c062fad 100644 --- a/clients/simple-

[PATCH weston 2/3] simple-dmabuf-drm: don't exit from create_display

Only exit from main so control flow is in one place. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1c062fad..b9

[PATCH weston v5 2/3] simple-dmabuf-drm: simplify fd_map_bo

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 19e8dbb1..cb04622f 100644 --- a/clients/simple-dmabuf-drm.c +++ b/clients/

[PATCH weston v5 1/3] simple-dmabuf-drm: 0 is a valid fd (freedreno)

Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 2975f3a5..19e

[PATCH weston v5 0/3] simple-dmabuf-drm: Support etnaviv and freedreno cleanups

ariables - use vfunc for drm_device_destroy Guido Günther (3): simple-dmabuf-drm: 0 is a valid fd (freedreno) simple-dmabuf-drm: simplify fd_map_bo simple-dmabuf-drm: support etnaviv drm as well Makefile.am | 1 + clients/simple-dmabuf-dr

[PATCH weston v5 3/3] simple-dmabuf-drm: support etnaviv drm as well

Reviewed-by: Derek Foreman <der...@osg.samsung.com> Signed-off-by: Guido Günther <a...@sigxcpu.org> --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 68 + configure.ac| 5 +++- 3 files changed, 73 inse

[PATCH weston 0/3] simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12

This makes NV12 testable on non freedreno as well. E.g. intel supports it. Guido Günther (3): simple-dmabuf-drm: drop superfluous declaration simple-dmabuf-drm: don't exit from create_display simple-dmabuf-drm: support DRM_FORMAT_LINEAR for NV12 as well clients/simple-dmabuf-drm.c | 63

[PATCH weston v4 3/4] simple-dmabuf-drm: 0 is a valid fd (freedreno)

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index a184d7e7..22891639 100644 --- a/clients/simple-dmabuf-drm.c +++ b/c

[PATCH weston v4 1/4] simple-dmabuf-drm: Always define ALIGN

Other backends might want to use it. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 4f26e4a9..efe3b7f5 100644 --- a/clients/

[PATCH weston v4 4/4] simple-dmabuf-drm: support etnaviv drm as well

Signed-off-by: Guido Günther <a...@sigxcpu.org> --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 77 + configure.ac| 5 ++- 3 files changed, 82 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makef

[PATCH weston v4 0/4] simple-dmabuf-drm: Support etnaviv and freedreno cleanups

_destroy Guido Günther (4): simple-dmabuf-drm: Always define ALIGN simple-dmabuf-drm: use large enough buffer (freedreno) simple-dmabuf-drm: 0 is a valid fd (freedreno) simple-dmabuf-drm: support etnaviv drm as well Makefile.am | 1 + clients/simple-dmabuf-dr

[PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

Use stride instead of width for buffer calculation. Signed-off-by: Guido Günther <a...@sigxcpu.org> --- clients/simple-dmabuf-drm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index efe3b7f5..a184d7e7

Re: [RFC PATCH wayland-protocols] presentation: New protocol for presenting surfaces to the user

Hi Carlos, On Fri, Oct 18, 2019 at 01:08:36AM +0200, Carlos Garnacho wrote: > Hi Pekka, > > Thank you for your comments! > > On Wed, Oct 16, 2019 at 11:31 AM Pekka Paalanen wrote: > > > On Wed, 16 Oct 2019 10:54:08 +0200 > > Olivier Fourdan wrote: > > > > > Hey Carlos, > > > > > > On Wed, Oct