[PATCH libinput 04/20] touchpad: don't allow tapping while any button is down

From: Peter Hutterer peter.hutte...@who-t.net Immediately set the state to DEAD, waiting for the tap release to go back to idle. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 2 +- 1 file changed, 1

[PATCH libinput 11/20] touchpad: Rework is_pointer handling

de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 9df4a78..b671211

[PATCH libinput 07/20] touchpad: save the active clickfinger button

From: Peter Hutterer peter.hutte...@who-t.net To avoid having a button left press and a button right release if the number of fingers changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-buttons.c | 22

[PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 34 ++ src/evdev-mt-touchpad.c | 4

[PATCH libinput 05/20] touchpad: move button-related code into a separate file

de Goede hdego...@redhat.com --- src/Makefile.am | 1 + src/evdev-mt-touchpad-buttons.c | 146 src/evdev-mt-touchpad.c | 102 ++-- src/evdev-mt-touchpad.h | 11 +++ 4 files changed, 162 insertions

[PATCH libinput 06/20] doc: add state machine SVG to EXTRA_DIST

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- doc/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 31b673b

[PATCH libinput 17/20] touchpad: Ignore fingers in button area for 2 finger scroll

Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 910bd2a..7333ec9 100644

[PATCH libinput 19/20] touchpad: handle_timeouts: Remove unused return value

Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index 3b8b07b..c40b05c

[PATCH libinput 00/20] clickpad-improvements v2

Hi All, Here is my improved version of Peter's clickpad-improvements patch-set. Changes in v2: * after a click, lock the finger to its current position Pin all fingers until they move more then the threshold in * touchpad: add clickpad-style software buttons Simplify the state machine used

[PATCH libinput 12/20] Add a log_bug macro

For logging when things happen which should not happen. We may want to do something more fancy in the future but for now this suffices. Modelled after log_bug in libevdev. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput

[PATCH libinput 01/20] touchpad: set ntouches for single-touch pads depending on key bits

-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index bbbd8f3..8021db2 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev

[PATCH libinput 09/20] touchpad: add clickpad-style software buttons

support for a top button area such as can be found one the Thinkpad [2-5]40 series. -Init area.top_edge to INT_MAX in the non soft button case to make the entire state machine a nop in that case Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com

Re: [PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

Hi, On 04/15/2014 03:44 PM, Daniel Stone wrote: Hi, On 15 April 2014 13:28, Hans de Goede hdego...@redhat.com wrote: Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click

Re: [PATCH libinput 0/9] Improvements for clickpad touchpads

Hi Peter, So as you requested I've been looking at your wip/clickpad-improvements branch. I've been mostly reading the code / patches and here is a long list of comments : 1) I like the state-machine concept, and having a diagram. I think this is a good way to deal with this, otherwise we will

Re: [PATCH v2 libinput 1/5] test: add litest helper functions for creating uinput devices

, -1); libevdev_uinput_write_event(uinput, EV_REL, REL_X, -1); libevdev_uinput_write_event(uinput, EV_SYN, SYN_REPORT, 0); ... libevdev_uinput_destroy(uinput); Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego

Re: [PATCH libinput 2/5] test: if no teardown func is set, use the default

. Only if no init at all is done then for non globals you may get garbage. Other then that, this patch looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans diff --git a/test/litest-generic-highres-touch.c b/test/litest-generic-highres-touch.c index bb226d6..4d21b0d

Re: [PATCH libinput 3/5] test: allow for description-based test devices

struct input_absinfo *abs, + const int *events); + Hmm, shouldn't this be either static, or in a header file ? Other then that, this patch looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans struct litest_device

Re: [PATCH libinput 5/5] test: switch the remaining devices to a description-based device

(+), 432 deletions(-) Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans p.s. I'm wondering if we should remove support for direct device instantiation, now all devices use the descriptor based approach ? diff --git a/test/litest-bcm5974.c b/test/litest-bcm5974.c index

<    3   4   5   6   7   8