[PATCH libinput 02/11] Add a gesture capability flag

Add a new LIBINPUT_DEVICE_CAP_GESTURE device capability, Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev.c | 3 +++ src/evdev.h | 3 ++- src/libinput.h | 3 ++- tools/event-debug.c | 3 +++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src

[PATCH libinput 06/11] touchpad: Add tp_get_average_touches_delta helper function

Add a tp_get_average_touches_delta helper function, and rename tp_get_active_touches_delta to tp_get_combined_touches_delta to better differentiate the two. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 25 + 1 file changed, 17 insertions

[PATCH libinput 01/11] Add an API for touchpad gesture events

events and the number of fingers involved being fixed once a gesture sequence starts. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 10 src/libinput.c | 129 +++ src/libinput.h | 146

[PATCH libinput 00/11] Add touchpad gesture support

Hi All, Here is a series actually implementing the touchpad gesture support API I've been proposing. The 1st patch is unchanged from its last posting other then fixing a single type. This series only adds swipe support. I've a bunch of backlight, uas and misc. other bugs which I need to look

[PATCH libinput 04/11] touchpad: Change how we deal with scroll methods

scrolling as 2 separate state machines. The double scroll calls this introduces will mostly be removed when the gesture handling code lands. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-edge-scroll.c | 3 ++ src/evdev-mt-touchpad.c | 73

[PATCH libinput 03/11] event-debug: Add support for gesture events

Add support for gesture events to the event-debug tool. Signed-off-by: Hans de Goede hdego...@redhat.com --- tools/event-debug.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index 055f3cc..d76c127

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 27-01-15 05:22, Peter Hutterer wrote: snip or, even easier: 2fg swipe doesn't exist, use scrolling instead. Right, that is what I'm going for, big +1 AFAIK other OS don't even have 2fg swipe, why would we invent something new here, and getting ourselves in a place of hurt while

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, + LIBINPUT_EVENT_GESTURE_SWIPE

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 28-01-15 19:18, Carlos Garnacho wrote: Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote

Re: [PATCH libinput 0/4] Lenovo X1 Carbon 3rd support

. The entire series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 29-01-15 07:11, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 04:02:20PM +0100, Hans de Goede wrote: Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: snip Ok, I'll change this to mm for v3 then (just send v2

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 29-01-15 16:23, Carlos Garnacho wrote: Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: snip Isn't this mostly a UI issue than the gesture itself? Most gestures you undo by doing the reverse. when you start pinching, expanding the fingers restores you back to the

[RFC libinput v2] Add an API for touchpad gesture events

events and the number of fingers involved being fixed once a gesture sequence starts. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 12 +++ src/libinput.c | 147 src/libinput.h | 199

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 23-01-15 14:53, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: Hi, On 23-01-15 05:21, Peter Hutterer wrote: snip +double +libinput_event_gesture_get_absolute_x(struct libinput_event_gesture *event); this is a bit inconsistent with the other API

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 23-01-15 07:18, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events

Re: [RFC libinput v2] Add an API for touchpad gesture events

Hi, On 23-01-15 16:17, Derek Foreman wrote: On 23/01/15 07:46 AM, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 23-01-15 05:21, Peter Hutterer wrote: CC-ing Carlos too, I'd like to get his input here. On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 23-01-15 09:51, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: Hi, On 23-01-15 07:18, Jonas Ådahl wrote: snip As for 2 finger swipe at least: isn't that covered by scrolling? with the caller deciding when a scroll event event is a swipe and when

Re: [RFC libinput] Add an API for touchpad gesture events

Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: snip Ok, I'll change this to mm for v3 then (just send v2 addressing the other review comments and adding a core implementation). So I've been thinking more about this and I'm

Re: [PATCH libinput 1/6] touchpad: factor out fake finger handling

and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans and the other bits for BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP, etc. BTN_TOUCH is independent of the rest, the others are mutually exclusive in the kernel. Since the mask isn't a straightforward bitmask anymore, abstract it all through

Re: [PATCH libinput 3/6] touchpad: add a TOUCH_HOVERING state

Hi, On 16-12-14 04:14, Peter Hutterer wrote: Some touchpads provide touch information while the finger hovers over the touchpad, i.e. before BTN_TOUCH. Add a touch state for those touchpads so we can ignore the touches until they actually start. The approach is now: instead of BEGIN we mark a

Re: [PATCH libinput 6/6] test: add touchpad hover finger test

Hi, On 16-12-14 04:14, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/touchpad.c | 322 +++- 1 file changed, 321

Re: [PATCH libinput 4/6] test: move semi-mt special tracking into the shared litest.c

Hi, On 16-12-14 04:14, Peter Hutterer wrote: An upcoming synaptics semi-mt device needs the same code. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest-alps-semi-mt.c | 146

Re: [PATCH libinput 5/6] test: add a semi-mt + hover synaptics touchpad

Hi, On 16-12-14 04:14, Peter Hutterer wrote: This device sends touch information before BTN_TOUCH https://bugs.freedesktop.org/show_bug.cgi?id=87197 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput 2/2] Add libinput_event_pointer_has_axis to scroll events

Hi, On 05-01-15 06:20, Peter Hutterer wrote: Right now we only have two (scroll) axes and we could easily just check both for non-zero values. If we want to allow further axes in the future, we need a check whether an axis is set in an event. We also need the mask to notify of a scroll stop

Re: [PATCH v4 libinput] touchpad: add a TOUCH_HOVERING state

in inline comments, with that fixed (no need to resend) this is: Reviewed-by: Hans de Goede hdego...@redhat.com Changes to v3: - drop the has_ended leftover from tp_end_touch - drop the active_real_touches counting from tp_post_process_state - when ending touches, hover or end them based on the t

[PATCH libinput resend] touchpad: Allow the center of pinned fingers to drift over time

Allow the center of pinned fingers to drift over time, to avoid accidentally unpinning fingers. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86807 Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src

[PATCH libinput resend 0/1] touchpad: Allow the center of pinned fingers

Hi Peter, I still have this patch sitting in my local patch-queue and I still believe it makes sense to do this, can you please review this ? A motivated NAK will do too, then I'll drop it :) Regards, Hans ___ wayland-devel mailing list

Re: [PATCH (diff only) libinput] touchpad: track touch sequences that ended

Hi, On 13-01-15 02:38, Peter Hutterer wrote: Note: this patch is just for easier review, see below for the real patch (with this one squashed in) http://lists.freedesktop.org/archives/wayland-devel/2015-January/019352.html A touch in the touchpad code refers to one on the touchpad. When we

Re: [PATCH v2 libinput] Change axis events to carry all directions

this patch is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH v2 libinput 3/6] touchpad: add a TOUCH_HOVERING state

Hi Peter, On 07-01-15 01:14, Peter Hutterer wrote: Some touchpads provide touch information while the finger hovers over the touchpad, i.e. before BTN_TOUCH. Add a touch state for those touchpads so we can ignore the touches until they actually start. The approach is now: instead of BEGIN we

Re: [PATCH libinput] test: add another hover test

pointed out with one touch ending as we switch to hover. Thanks for adding this, one small comment inline, with that fixed: Reviewed-by: Hans de Goede hdego...@redhat.com test/touchpad.c | 69 + 1 file changed, 69 insertions(+) diff

[PATCH libinput v2 0/5] Add a config interface for click methods

Hi All, Here is v2 of Peter's config interface for click methods series, only touchpad: hook up click method configuration is changed: - Keep top softbuttons working when enabling clickfinger - Simplify touchpad click method switching Regards, Hans

[PATCH libinput v2 4/5] test: run clickfinger test for all clickpad-capable devices

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c

[PATCH libinput v2 1/5] Add a config interface for click methods

, right, middle click Both methods already exist in the touchpad code, this is just the configuration interface. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 9 + src/libinput.c | 50

[PATCH libinput v2 5/5] tests: add a few clickfinger tests

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 293 1 file changed, 293 insertions(+) diff --git a/test/touchpad.c

[PATCH libinput v2 2/5] touchpad: hook up click method configuration

click method switching Signed-off-by: Hans de Goede hdego...@redhat.com --- doc/clickpad-softbuttons.dox| 6 ++ src/evdev-mt-touchpad-buttons.c | 216 +++- src/evdev-mt-touchpad.c | 4 +- src/evdev-mt-touchpad.h | 11 +- 4 files changed

[PATCH libinput v2 3/5] test: add tests for clickfinger defaults

From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 85 + 1 file changed, 85 insertions(+) diff --git a/test/touchpad.c b

Re: [PATCH v2 libinput] Add libinput_event_pointer_get_axis_value_discrete() to count wheel clicks

Hi Peter, As requested I've reviewed the API addition done in: http://lists.freedesktop.org/archives/wayland-devel/2015-January/019365.html This looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel

Re: [RFC libinput 1/2] Add a buttonset interface for button-only devices

Hi, On 16-02-15 04:50, Peter Hutterer wrote: snip ok, I've played around with the ideas in this thread and discussed it with Benjamin this morning. Short summary: I think we should go with the original patch, with an optional extension for numbered axes later. I tried the enum spacing first,

Re: [PATCH libinput] tools: don't use deprecated gdk_cursor_new()

Hi, On 18-03-15 00:44, Peter Hutterer wrote: Replaced by gdk_cursor_new_from_display() which means we need to tickle the event until it spits out a GdkDisplay. Deprecated in gdk 3.16 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

for working on this, I've done a review mostly focussing on the API and the first patch set, that looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Assuming the FIXME-s in there get fixed :) I've also glanced over the second patch and I cannot find anything wrong there either

Re: [RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

Hi, On 12-03-15 09:23, Peter Hutterer wrote: On Wed, Mar 11, 2015 at 03:20:55PM +0100, Hans de Goede wrote: Implement touchpad pinch (and rotate) gesture support. WIP: TODO: fix testsuite. Signed-off-by: Hans de Goede hdego...@redhat.com looks good, almost all comments are just related

Re: [RFC libinput 1/2] touchpad: Extend the touchpad gesture API with pinch gestures

Hi, On 12-03-15 23:57, Peter Hutterer wrote: On Wed, Mar 11, 2015 at 03:20:54PM +0100, Hans de Goede wrote: Extend the touchpad gesture API with pinch gestures. Note that this new API offers a single event stream for both pinch and rotate data, this is deliberate as some applications may

Re: [PATCH libinput 00/12] typesafe coordinate wrappers

and we could start with merging it as is. The entire series looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans *) There are 2 ways around this: 1) Store device coords as doubles to, since we some time average them (e.g. for deltas in various places) 2) Use

[PATCH libinput 1/2] touchpad: Extend the touchpad gesture API with pinch gestures

ignore the other. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 11 +++ src/libinput.c | 70 +--- src/libinput.h | 78

[PATCH libinput 2/2] touchpad: Implement pinch gesture support

Implement touchpad pinch (and rotate) gesture support. Note that two two-finger scrolling tests are slightly tweaked to assure that there is enough touch movement to allow the scroll-or-pinch detect code to do its works. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad

[PATCH libinput 0/2] touchpad: Add pinch gesture support

Hi All, The pinch gesture support I've been working on is finished, so here is the first non RFC version of the pinch gesture support series, addressing all the comments made on the RFC versions. Regards, Hans ___ wayland-devel mailing list

Re: [PATCH libinput 1/9] touchpad: simplify resolution check

Hi, On 17-03-15 06:34, Peter Hutterer wrote: The struct evdev_device's absinfo_x/y point to the right axis Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt

Re: [PATCH libinput 1/4] filter: switch to normalized_coords

Hi, On 19-03-15 04:11, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire set looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 26 +++-- src/evdev.c

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

Hi, On 20-03-15 01:38, Peter Hutterer wrote: On Fri, Mar 20, 2015 at 10:19:06AM +1000, Peter Hutterer wrote: [...] 5) If a device has multiple axes of the same type, is the order supposed to be ABI? Example: gamepads tend to have two analog-sticks. How do applications reliably find the left

Re: [RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

Hi, On 17-03-15 06:35, Peter Hutterer wrote: On Mon, Mar 16, 2015 at 02:58:02PM +0100, Hans de Goede wrote: Hi, On 12-03-15 09:23, Peter Hutterer wrote: On Wed, Mar 11, 2015 at 03:20:55PM +0100, Hans de Goede wrote: Implement touchpad pinch (and rotate) gesture support. WIP: TODO: fix

[PATCH libinput] touchpad: Remove unnecessary edge scroll threshold variable

later on in tp_edge_scroll_post_events(). Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-edge-scroll.c | 7 +-- src/evdev-mt-touchpad.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt

Re: [PATCH v2 libinput 5/3] touchpad: accumulate the initial scroll edge delta

the finger motion. This accumulated delta only applies when exceeding the motion threshold, when the timeout triggers the switch to scrolling the first delta posted is the current delta. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com Looks

Re: [PATCH libinput 4/3] touchpad: annotate all coordinates that are in device coordinates

Hi, On 06-03-15 06:43, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.h | 39 --- 1 file changed, 20 insertions(+), 19

Re: [PATCH libinput 2.5/3] Move DEFAULT_MOUSE_DPI to evdev.h, provide a conversion macro

Hi, On 06-03-15 06:41, Peter Hutterer wrote: Ideally we want to specify various thresholds in mm, but not all touchpads set the hardware resolutions. Rather than conditions to check for resolutions everywhere, use a macro to give us a normalized value that we use for motion as well.

Re: [PATCH libinput 1/3] test: fix/disable two tap test for semi-mt devices

). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/touchpad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 8077f8e..5c8f579 100644 --- a/test

Re: [PATCH libinput 2/3] touchpad: return normalized deltas from tp_get_delta

coordinates but normalized deltas instead. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 5 +++-- src/evdev-mt-touchpad.h | 7 +++ 2 files changed, 10 insertions(+), 2

Re: [PATCH libinput 2.5/3] Move DEFAULT_MOUSE_DPI to evdev.h, provide a conversion macro

Hi, On 06-03-15 11:38, Hans de Goede wrote: Hi, On 06-03-15 06:41, Peter Hutterer wrote: Ideally we want to specify various thresholds in mm, but not all touchpads set the hardware resolutions. Rather than conditions to check for resolutions everywhere, use a macro to give us a normalized

Re: [PATCH v2 libinput 3/3] touchpad: change tap motion threshold to 3 mm

the MAGIC stuff. You likely want to change the threshold to a different value then too, say 5 mm (3 / MAGIC = 7.5 but that seems a bit much). With that changes this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans src/evdev-mt-touchpad-tap.c | 11 --- src/evdev-mt

Re: [PATCH libinput 5/3] touchpad: accumulate the initial scroll edge delta

this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput 1/6] Calling has_axis on a non-axis pointer event is a bug, note this

Hi, The entire series looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 13-03-15 01:37, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src

[RFC libinput 2/3] litest: Add a litest_touch_move_two_touches helper function

. Signed-off-by: Hans de Goede hdego...@redhat.com --- test/litest.c | 22 ++ test/litest.h | 5 + test/touchpad.c | 17 ++--- 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/test/litest.c b/test/litest.c index 3646446..fc4b1fb 100644

[RFC libinput 1/3] litest: Make touchpad_2fg_scroll_slow_distance take resolution into account

, this commit fixes this. Signed-off-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index ff4edb0..36fe6e4 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -1864,13

[RFC libinput 3/3] litest: Put fingers down closer together for 2fg scroll tests

in the touchpad_2fg_scroll_slow_distance and touchpad_trackpoint_buttons_2fg_scroll tests to the default locations rather then putting them pretty far apart. Signed-off-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/test

[RFC libinput 1/2] touchpad: Extend the touchpad gesture API with pinch gestures

ignore the other. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 12 + src/libinput.c | 51 +++-- src/libinput.h | 68 ++ src/libinput.sym | 2 ++ test

[RFC libinput 0/2] touchpad: pinch gesture support

Hi All, Here is the first version of my pinch gesture support patch-set with an actual implementation of pinch gestures. Comments are welcome, for now this is a RFC patch-set as I still need to fixup the test-suite. Regards, Hans ___ wayland-devel

[RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

Implement touchpad pinch (and rotate) gesture support. WIP: TODO: fix testsuite. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-gestures.c | 242 --- src/evdev-mt-touchpad.h | 18 +++ test/touchpad.c

[PATCH libinput 3/3] Add a normalized_length helper function and use this where applicable

Add a normalized_length helper function and use this where applicable, just a minor cleanup. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 10 +++--- src/filter.c| 4 +--- src/libinput-private.h | 7 +++ 3 files changed, 11

[PATCH libinput 2/3] Add a delta_coords type and use it were applicable

tp_normalize_coords is one of the last functions taking separate x, y values rather a coordinate pair, this commit cleans this up. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-edge-scroll.c | 9 ++--- src/evdev-mt-touchpad-tap.c | 6 ++ src/evdev

[PATCH libinput 1/3] Fix scroll-threshold check for edge-scrolling to use normalized coordinates

. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-edge-scroll.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt-touchpad-edge-scroll.c index 26d6bbc..d304316 100644 --- a/src/evdev-mt

[PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

Change tp_filter_motion to use normalized_coords, rather then having it take separate x and y values. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-edge-scroll.c | 3 +-- src/evdev-mt-touchpad-gestures.c| 8 src/evdev-mt-touchpad.c | 29

[PATCH libinput 1/2] Add a normalized_is_zero helper function

Add a normalized_is_zero helper function, and use it where applicable. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-gestures.c | 5 ++--- src/evdev-mt-touchpad.c | 2 +- src/evdev.c | 6 ++ src/libinput-private.h | 6

Re: [PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

Hi, On 24-03-15 23:17, Peter Hutterer wrote: On Tue, Mar 24, 2015 at 04:51:35PM +0100, Hans de Goede wrote: Change tp_filter_motion to use normalized_coords, rather then having it take separate x and y values. Signed-off-by: Hans de Goede hdego...@redhat.com weird. I remember writing

Re: [PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

Hi, On 25-03-15 10:49, Peter Hutterer wrote: On Wed, Mar 25, 2015 at 09:44:48AM +0100, Hans de Goede wrote: Hi, On 24-03-15 23:17, Peter Hutterer wrote: On Tue, Mar 24, 2015 at 04:51:35PM +0100, Hans de Goede wrote: Change tp_filter_motion to use normalized_coords, rather then having

[PATCH libinput 2/2] Change vector_get_direction input to a normalized_coords struct

normalized coordinates may result in a wrong direction getting returned when the x and y resolution of the touchpad are not identical. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 5 +++-- src/filter.c| 2 +- src/libinput-private.h | 57

[PATCH libinput 1/2] Rename delta_coords to device_float_coords

What we really need is not a specific delta type, but a type which can hold non discrete device coordinates, this is e.g. also needed for the center coordinates of gestures. So rename delta_coords to device_float_coords to properly reflect what we really need. Signed-off-by: Hans de Goede hdego

[PATCH libinput v2 3/4] touchpad: Extend the touchpad gesture API with pinch gestures

ignore the other. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 ++ src/libinput.c | 61 +-- src/libinput.h | 78

[PATCH libinput v2 1/4] touchpad: Add an API for touchpad gesture events

events and the number of fingers involved being fixed once a gesture sequence starts. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- Changes in v2: -Merge capability flag and event-debug patches into this one -Adjust to use new

[PATCH libinput v2 4/4] touchpad: Implement pinch gesture support

Implement touchpad pinch (and rotate) gesture support. Note that two two-finger scrolling tests are slightly tweaked to assure that there is enough touch movement to allow the scroll-or-pinch detect code to do its works. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad

[PATCH libinput v2 2/4] touchpad: Add support for swipe gestures

Add support for swipe gestures. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-gestures.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/src/evdev-mt-touchpad-gestures.c

[PATCH libinput v2 0/4] touchpad gestures support

Hi All, Here is v2 of my touchpad gestures support patch series, changes since v1: - Merge the gesture capability flag and event-debug patched into the touchpad: Add an API for touchpad gesture events - Update the swipe and pinch/rotate implementations to work with the new typesafe device and

Re: [PATCH libinput] Revert touchpad: parse the TOUCHPAD_RESOLUTION property

. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Seems like the sensible thing to do: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- See the two patches here: http://lists.freedesktop.org/archives/systemd-devel/2015-March/029739.html http://lists.freedesktop.org/archives

Re: [PATCH libinput] evdev: reject devices with a min == max axis range

...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 34 + test/device.c | 82 +++ 2 files changed, 116 insertions(+) diff --git a/src/evdev.c b/src/evdev.c

Re: [PATCH libinput 1/7] test: disable tapping for pure motion tests

Hi, On 04-03-15 05:18, Peter Hutterer wrote: No effect, all devices currently have tapping disabled. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Then entire series looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/touchpad.c | 6

[PATCH libinput] Extend the touchpad gesture API with zoom/rotate gestures

simply ignore the other. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 7 +++ src/libinput.c | 53 ++ src/libinput.h | 41 ++ src/libinput.sym | 2 ++ test

Re: [PATCH libinput] Extend the touchpad gesture API with zoom/rotate gestures

Hi, On 05-03-15 04:29, Peter Hutterer wrote: On Wed, Mar 04, 2015 at 03:26:30PM +0100, Hans de Goede wrote: Extend the touchpad gesture API with zoom/rotate gestures. Note that this new API offers a single event stream for both zoom and rotate data, this is deliberate as some applications may

Re: [PATCH libinput 10/11] touchpad: Refactor tp_get_*_touches_delta

Hi, On 23-02-15 04:02, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:53PM +0100, Hans de Goede wrote: The two tp_get_*_touches_delta functions are almost identical, refactor them into one function. Signed-off-by: Hans de Goede hdego...@redhat.com --- ACK to the basics, but I'd like

Re: [PATCH libinput 11/11] touchpad: Add support for swipe gestures

Hi, On 23-02-15 04:25, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:54PM +0100, Hans de Goede wrote: Add support for swipe gestures. Signed-off-by: Hans de Goede hdego...@redhat.com unless noted otherwise, series Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Thanks

Re: [PATCH libinput 07/11] touchpad: Gesture support preparation

Hi, On 23-02-15 03:56, Peter Hutterer wrote: On Wed, Feb 18, 2015 at 01:26:50PM +0100, Hans de Goede wrote: Handle everything which is not handeld by the tap, (soft)button or edge-scroll typo: handled Fixed. code/statemachines in a unified way. Everything is treated as a X-finger

Re: [PATCH libinput 1/2] evdev: force-assign 10 slots to evdev devices

Hi, On 25-02-15 08:39, Peter Hutterer wrote: subject should be evdev: force-assign 10 slots to mtdev devices fixed locally. With that fixed both patches look good and are: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans Cheers, Peter On Wed, Feb 25, 2015 at 05:37:25PM

Re: [PATCH libinput] evdev: ignore tablet pad devices explicitly

Hi, On 26-02-15 07:02, Peter Hutterer wrote: We don't have real support for them yet but they have the ID_INPUT_TABLET tag set. Ignore them explicitly before someone thinks they're already working. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede

Re: [PATCH libinput v2 0/4] touchpad gestures support

Hi, On 01-04-15 23:42, Jason Gerecke wrote: On 3/26/2015 2:04 AM, Hans de Goede wrote: Hi All, Here is v2 of my touchpad gestures support patch series, changes since v1: - Merge the gesture capability flag and event-debug patched into the touchpad: Add an API for touchpad gesture events

[PATCH] evdev: Add support for TRACKPOINT_CONST_ACCEL udev property

laptops aprox. the same trackpoint cursor speed ootb. Recent versions of udev + hwdb set a TRACKPOINT_CONST_ACCEL udev property which can be used to adjust trackpoints which are too slow / too fast ootb, this commit implements support for that property. Signed-off-by: Hans de Goede hdego...@redhat.com

Re: [PATCH] evdev: Add support for TRACKPOINT_CONST_ACCEL udev property

Hi, Note this is a libinput patch, I forgot to set subjectprefix when sending this. Regards, Hans On 02-04-15 11:50, Hans de Goede wrote: There is quite a wide spread in the delta events generated by trackpoints, some generate deltas of 1-2 under normal use, while others generate deltas

Re: Touchpad trouble with two- and three-finger touch

Hi, On 04/10/2015 11:01 AM, Stefanos A. wrote: Hello, I am having trouble registering multi-finger touches using libinput. Roughly 50% of the time a touch will fail to register. Once a touch registers, then the next several touches also register. If it fails then there's again a roughly 50%

Re: Touchpad acceleration

Hi, On 04/10/2015 11:15 AM, Stefanos A. wrote: Hello, I recently started testing Gnome 3.16 over Wayland 1.7.0 libinput 0.13.0 and came across the following interesting behavior on my touchpad. In short, the pointer feels as if it lagging on the monitor compared to my finger movement. The

Re: Touchpad acceleration

the physical size (width and height of usable area in mm) of your touchpad. Thanks Regards, Hans 2015-04-11 10:58 GMT+02:00, Hans de Goede hdego...@redhat.com: Hi, On 04/10/2015 11:15 AM, Stefanos A. wrote: Hello, I recently started testing Gnome 3.16 over Wayland 1.7.0 libinput 0.13.0

Re: [PATCH libinput 1/5] tools: add --set-scroll-method commandline flag

Hi, Series looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 21-04-15 07:28, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/shared.c | 29 + tools/shared.h | 1 + 2 files changed, 30

Re: [PATCH libinput] touchpad: allow BTN_LEFT in clickfinger mode without touches

still think this is a good idea, then this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 6 -- test/touchpad.c | 30 ++ 2 files changed, 34 insertions(+), 2 deletions(-) diff --git

<    1   2   3   4   5   6   7   8   >