Re: [PATCH libinput 4/4] evdev: always defuzz absolute touchscreens

tialize point, as you overwrite all its member variables anyway. Other than that, and the other patches I didn't comment on, are Reviewed-by: Jonas Ådahl <jad...@gmail.com> Jonas > + > + if (!device->mt.want_hysteresis) > + retur

Re: [PATCH libinput 1/4] evdev: move the hysteresis code to a more generic location

t->hysteresis_center.y, > - tp->hysteresis_margin.y); Shouldn't you remove tp_hysteresis() now? I can't see where its use other than these too calls. Other than that this is Reviewed-by: Jonas Ådahl <jad...@gmail.com> . Jonas > +

Re: [PATCH v3] protocol: Extend wl_touch with touchpoint shape event

On Thu, Apr 14, 2016 at 07:04:25PM -0500, Yong Bakos wrote: > On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote: > > > > This CL updates the wl_touch interface with a shape and > > orientation event. > > The shape/orientation of a touch point is not relevant for most UI >

Re: [PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

with requiring that a correctly working compositor never tries to configure a size that is not within the set bounds? I think it should be cleared out anyhow, what the client can rely upon here anyhow. Another (minor) issue is the lack of error code for when the min/max are conflicting. I

Re: [PATCH wayland-protocols 0/7] xdg-shell: Tooltips revisited and xdg_positioner

On Thu, Apr 14, 2016 at 04:28:11PM +0800, Jonas Ådahl wrote: > Hi, > > This is the continuation of the previous patch series meaning to split up > xdg_surface into different per-role interfaces, while making it possible to > map > more types of surfaces. It enables using x

[PATCH wayland-protocols 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unsta

[PATCH wayland-protocols 7/7] xdg-shell: Introduce xdg_positioner

surface should be positioned in relation to the parent surface. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 206 ++- 1 file changed, 204 insertions(+), 2 deleti

[PATCH wayland-protocols 4/7] xdg-shell: Improve error enum formatting some

The long lines stood out, break them by putting the summary on its own line. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unsta

[PATCH wayland-protocols 3/7] xdg-shell: Add error codes for invalid surface state

Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml index f8875e8..2a3cf66 100644 --- a/unstable/xdg

[PATCH wayland-protocols 2/7] xdg-shell: Put xdg_shell events after requests

It makes the structure consistent with most other protocols and provides a clear separation between what is done by the server and what is done by the client. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 16 1 file chan

[PATCH wayland-protocols 1/7] xdg-shell: Turn xdg_surface into a generic base interface

xdg_surface based extensions are meant to also extend xdg_surface.configure for relevant window type dependend state synchronization. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> --- unstable/xdg-shell/xdg-shell-unstable-

[PATCH wayland-protocols 6/7] xdg-shell: Make xdg_popup non-grabbing by default

to grabbing, stacking and mapping order. This enables using xdg_popup for creating tooltips and other user interface elements that does not want to take an explicit grab. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@samsung.com> --- unstable/xdg-she

[PATCH wayland-protocols 0/7] xdg-shell: Tooltips revisited and xdg_positioner

probably questions that should be answered up front. Jonas Jonas Ådahl (7): xdg-shell: Turn xdg_surface into a generic base interface xdg-shell: Put xdg_shell events after requests xdg-shell: Add error codes for invalid surface state xdg-shell: Improve error enum formatting some

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

On Tue, Apr 12, 2016 at 08:05:03AM -0500, Yong Bakos wrote: > On Apr 12, 2016, at 2:22 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > > > On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: > >> Hi Mike, > >> > >> - Original Mess

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: > Hi Mike, > > - Original Message - > > I think this should probably use uint instead of int for params since zero > > is the "unset" number. Otherwise you have to write something about negative > > sizes. > > Reason I used

[PATCH libinput 2/3] libinput: Actually return the default accel profile

We just returned the current profile instead of the default one. Fix that. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- src/libinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.c b/src/libinput.c index 1480878..b6e660a 100644 --- a/src/libinput.c

[PATCH libinput 3/3] test-pointer: Test that the default accel profile doesn't change

Make sure that changing the accel profile doesn't affect the default accel profile. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- test/pointer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 32e3fd2..a34740a 100644 --- a/test/pointer.c

[PATCH libinput 1/3] test: Handle 32 bit msec time overflows

casting the millisecond 64 bit unsigned integer to a 32 unsigned integer, triggering the same overflow. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- test/gestures.c | 4 +++- test/keyboard.c | 4 +++- test/pointer.c | 4 +++- test/tablet.c | 4 +++- test/touch.c| 4 +++- test/touchpad

Re: [PATCH v4 xdg-shell-unstable-v6] xdg-shell: add preferred min/max size requests

On Fri, Apr 08, 2016 at 02:42:53AM -0400, Olivier Fourdan wrote: > Hi > > > I see no reason for "preferred" to be in the name. There is no intention to > > be able to ever specify a "real" min/max size so this word does not > > distinguish the values from any thing else. > > This was asked

Re: [PATCH v2] xdg-shell: add preferred min/max size requests

Hi, If we want this in an initial minimalistic xdg_shell version, this needs to be targetted at xdg_shell unstable v6, which currently lives on a branch and as set of proposed patches. We cannot add this to version 5 anyhow. If we indeed want this in the core protocol now, and not in some

Re: weston-info

On Wed, Apr 06, 2016 at 02:57:29PM +0200, Olivier Fourdan wrote: > On 6 April 2016 at 14:12, Daniel Stone wrote: > > > > Just a fly by shed color thought. If we in the future want to add more > > > generic debug tools (for example something like xev that is a bit more > > >

Re: Introduction and updates from NVIDIA

On Mon, Apr 04, 2016 at 04:27:56PM +0100, Daniel Stone wrote: > Hi, > > On 2 April 2016 at 01:28, Andy Ritger wrote: > > On Tue, Mar 29, 2016 at 05:44:41PM +0100, Daniel Stone wrote: > >> On 23 March 2016 at 00:12, Andy Ritger wrote: > >> > Also, mailbox

Re: weston-info

On Tue, Apr 05, 2016 at 11:55:42AM +0200, Olivier Fourdan wrote: > Hi Pekka, > > On 5 April 2016 at 10:30, Pekka Paalanen wrote: > > > ​[...] > > > > > > this is a good idea indeed. > > > > Originally weston-info was needed in Weston repository, because it was > > useful in

Re: history/semantics of uint32_t name

On Thu, Mar 31, 2016 at 06:48:06PM -0500, Yong Bakos wrote: > Hi, > I've been investigating the semantics of the name parameter within the > wl_registry interface, prompted by a recent dialog regarding my patch of arg > summary attributes in wayland.xml. > > I've dug around the Weston source to

Re: [PATCH] protocol: Extend wl_touch with touch point shape

On Fri, Mar 25, 2016 at 09:29:56AM -0700, Dennis Kempin wrote: > This CL updates the wl_touch interface with a shape event. > The shape of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing app. > > The shape event is used by

Re: wayland.xml style guide and whitespace fix

On Wed, Mar 30, 2016 at 08:40:46AM -0500, Yong Bakos wrote: > Hi fellow hackers, > I'm working on documentation fixes within wayland.xml and I'm noticing two > major inconsistencies that I would like to address. The first is > writing-related. > > Some enum entry summary attribute values start

Re: Collaboration on standard Wayland protocol extensions

On Tue, Mar 29, 2016 at 07:41:10AM -0400, Drew DeVault wrote: > Thus begins my long morning of writing emails: > > On 2016-03-29 12:01 PM, Jonas Ådahl wrote: > > > I prefer to think of it as "who has logical ownership over this resource > > > that they're providin

Re: Collaboration on standard Wayland protocol extensions

On Mon, Mar 28, 2016 at 11:33:15PM -0400, Drew DeVault wrote: > On 2016-03-29 10:30 AM, Jonas Ådahl wrote: > > I'm just going to put down my own personal thoughts on these. I mostly > > agree with Carsten on all of this. In general, my opinion is that it is > > completely poi

Re: Collaboration on standard Wayland protocol extensions

On Sun, Mar 27, 2016 at 04:34:37PM -0400, Drew DeVault wrote: > Greetings! I am the maintainer of the Sway Wayland compositor. > > http://swaywm.org > > It's almost the Year of Wayland on the Desktop(tm), and I have > reached out to each of the projects this message is addressed to (GNOME, >

[PATCH weston 3/3] clients: Fork clickdot as confine

The new confine client will be used to demonstrate pointer confinement. It is so far identical to clickdot except that it doesn't respond to clicks. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- This patch does what Peter suggested, i.e. fork clickdot into a separate client that demons

[PATCH weston 2/3] Implement pointer locking and confinement

conventions applied. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> --- The changes since last version include: * Updated to the new protocol: - Added oneshot vs persistent constraint lifetime - Changed the constraint creation input

[PATCH weston 1/3] input: Activate view no matter the keyboard focus

, only change the keyboard focus if the focus actually changed. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- The patch that introduced the early-out if the surface already had keyboard focus broke activated-view tracking later used by pointer constraints. I partly reverted that but added a

[PATCH weston 0/3] Pointer constraints follow up

Hi, I have just updated the relative pointer and pointer constraints implementation for weston to be compatible with the protocol published via wayland-protocols. Up to date patches can be found here: https://github.com/jadahl/weston/commits/wip/pointer-constraints The patches in this series

Re: Accessibility considerations

Hi, On Fri, Mar 11, 2016 at 06:51:35AM +0100, Timofonic wrote: > Please consider mandatory high contrast option with custom colors. I prefer > black background and green foreground, it's a lie better for Mr eyes because > clear colors really tire me. There is no way for a compositor to

[ANNOUNCE] wayland-protocols 1.3

wayland-protocols 1.3 is now available. This release include one new unstable protocol extension: . tablet support See the corresponding XML file for details. Here is the shortlog: Jonas Ådahl (2): Revert "xdg-shell: clarify xdg_surface creation semantics regarding bu

Re: [PATCH 2/2] xdg-shell: clarify xdg_surface creation semantics regarding buffers

it > > > > > > only 3) is now valid, while 1) and 2) will trigger errors as a result > > > of handling buffers prior to creating the xdg surface > > > > > > Reviewed-by: Jasper St. Pierre <jstpie...@mecheye.net> > > > Signed-off-by: M

[ANNOUNCE] wayland-protocols 1.2

: Carlos Olmedo Escobar (1): Remove 'is'. Jonas Ådahl (1): configure.ac: Bump version to 1.2 Pekka Paalanen (4): stable: add presentation-time draft presentation-time: finish stabilization Makefile: add presentation-time to stable protocols Makefile: install

Re: GSOC 2016

On Thu, Mar 03, 2016 at 04:56:23AM +0100, Armin Krezović wrote: > Hello everyone, Hi! > > My name is Armin Krezović, a 3rd year student from Bosnia and Herzegovina > studying > at Faculty of Electrical Engineering, University of Tuzla. > > I want to participate in this year's Google Summer of

Re: [GSOC2016] Contribution to project

On Wed, Mar 02, 2016 at 11:38:58PM +0530, Arushi Dogra wrote: > Hi everyone, > > I am a 3rd Computer Science Undergraduate from IIIT Hyderabad, India. I > took graphics as a course and developed great interest in it. I would > really like to contribute wayland . I found the project " *A shattered

Re: [PATCH wayland-protocols weston 0/7] Stabilize Presentation extension

or.freedesktop.org/T43 > https://bugs.freedesktop.org/show_bug.cgi?id=83092 As for the unmerged patches, they look good to me, so Reviewed-by: Jonas Ådahl <jad...@gmail.com> . Jonas > > Wayland-protocols: > > Pekka Paalanen (4): > stable: add presentation-time dr

Re: [PATCH v6 wayland-protocols] Add the tablet protocol

On Tue, Mar 01, 2016 at 10:09:59AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > Reviewed-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > Changes to v5: > - remove le

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

On Sat, Feb 20, 2016 at 01:31:59AM +0100, Carlos Garnacho wrote: > From: Lyude > > This primary selection is similar in spirit to the eponimous > in X11, allowing a quick "select text + middle click" shortcut > to copying and pasting. > > It's otherwise very similar to it

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

On Wed, Feb 24, 2016 at 10:25:19AM +0100, Michal Suchanek wrote: > On 24 February 2016 at 05:33, Jonas Ådahl <jad...@gmail.com> wrote: > > On Sat, Feb 20, 2016 at 01:31:59AM +0100, Carlos Garnacho wrote: > >> From: Lyude <cp...@redhat.com> > >> > >

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

On Sat, Feb 20, 2016 at 01:31:59AM +0100, Carlos Garnacho wrote: > From: Lyude > > This primary selection is similar in spirit to the eponimous > in X11, allowing a quick "select text + middle click" shortcut > to copying and pasting. > > It's otherwise very similar to it

Re: [PATCH wayland] tests: add test for receiving an error on destroyed object

On Mon, Feb 22, 2016 at 02:37:00PM +0100, Marek Chalupa wrote: > test if receiving an error on already destroyed object won't > do any harm > > Signed-off-by: Marek Chalupa <mchqwe...@gmail.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- &

Re: wayland-protocols versioning between releases

On Mon, Feb 22, 2016 at 02:08:10PM -0800, Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 02:04:04PM +0200, Pekka Paalanen wrote: > > On Mon, 22 Feb 2016 19:10:37 +0800 > > Jonas Ådahl <jad...@gmail.com> wrote: > > > > > On Mon, Feb 22, 2016 at 12

Re: wayland-protocols versioning between releases

On Mon, Feb 22, 2016 at 12:44:46PM +0200, Pekka Paalanen wrote: > On Mon, 22 Feb 2016 17:19:01 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Mon, Feb 22, 2016 at 11:04:16AM +0200, Pekka Paalanen wrote: > > > Hi Jonas, > > > > > > I have

Re: [RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

wp_primary_data_device.data_offer and > wp_primary_data_device.selection > - Improved wording here and there. > - Added serial argument to wp_primary_data_offer.receive that can be > used to match against recent events. Overall good. Some comments

[PATCH wayland] tests: Test creating a shm pool with 0 size

Add a test case that tests the servers behaviour when creating a pool of size 0. The test suite will do the memory and fd leak check for us, so the test case is only a triggerer. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Makefile.am | 5 ++- tests/shm-test.c

[PATCH wayland] client: Don't segfault when receiving error on destroyed object

() documentation is updated to handle the situation. For when the proxy was NULL, the object id 0 and interface NULL is written. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- This is technically an API change, but I see no less breaking change. Considering that clients would segfault before ever re

Re: [PATCH] server: Fix shm_create_pool size fail path fd leak

e fd list that is closed automatically is just the fds that are collected during reading but yet put in a wl_closure. I went a head and wrote a test case for this, just to be sure; I'll send it as a reply to this E-mail. So consider the patch Reviewed-by: Jonas Ådahl <jad...@gmail.com> . > >

Re: [PATCH] server: Fix shm_create_pool size fail path fd leak

On Thu, Feb 18, 2016 at 11:59:29PM +0100, Sergi Granell wrote: > If the client passed a size <= 0 to shm_create_pool, it would > go to err_free, which wouldn't close the fd, and thus leave it opened. > > We can also move the size check before the struct wl_shm_pool > malloc, so in case the client

[RFC wayland] scanner: Add support for dynamic symbol loading

pointers. The application must call this function before using any Wayland IPC functionality. The 'dynamic-header' command generates a C header file with the declaration of the function the application must call to initialize the wl_interface types array. Signed-off-by: Jonas Ådahl <jad...@gmail.

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

On Thu, Feb 18, 2016 at 10:03:36AM +, Daniel Stone wrote: > Hi, > > On 31 July 2015 at 14:53, Carlos Garnacho <carl...@gnome.org> wrote: > > On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl <jad...@gmail.com> wrote: > >> On Thu, Jul 23, 2015 at 07:

Re: Are these patchsets ready to land?

On Wed, Feb 17, 2016 at 04:56:34PM -0800, Bryce Harrington wrote: > There's a few patchsets in patchwork which I'm not entirely certain > where they're at review-wise. > > Since we're at the start of a new release I'd like to clear down our > queue a bit by landing stuff that's ready to go, but

Re: [PATCH wayland] client: ensure thread safety for wl_display_roundtrip_queue()

can > Software Group I (ADITG/SW1) > > Tel. +49 5121 49 6937 > > > -Original Message- > > From: wayland-devel [mailto:wayland-devel- > > boun...@lists.freedesktop.org] On Behalf Of Jonas Ådahl > > Sent: Dienstag, 16. Februar 2016 04:49 > > To: Ucan, E

[ANNOUNCE] wayland-protocols 1.1

Foreman (2): test: add make check ignore: ignore config.sub and config.guess Jonas Ådahl (3): Introduce wp_relative_pointer interface Introduce pointer locking and confinement protocol configure.ac: Bump version to 1.1 Mike Blumenkrantz (1): xdg-shell: add state

Re: [PATCH wayland] client: ensure thread safety for wl_display_roundtrip_queue()

On Mon, Feb 15, 2016 at 02:19:43PM +, Ucan, Emre (ADITG/SW1) wrote: > We have to block other threads from reading events. Otherwise other threads > may assign done event to the default queue, if they call > wl_display_read_events before setting the queue for the callback proxy. > This would

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: > The xdg_launcher interface is added for the launcher, it's used > to notify of the startup ID to be transmitted to the launchee, > plus notifications about the startup success/failure. > > On the launchee side, we now have

Re: [PATCH] connection: Don't add uninitialized memory as 4 byte alignment padding

On Thu, Feb 11, 2016 at 11:34:15AM +0200, Pekka Paalanen wrote: > On Thu, 11 Feb 2016 09:47:29 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Wed, Feb 10, 2016 at 12:37:43PM -0600, Derek Foreman wrote: > > > On 10/02/16 09:35 AM, Jonas Ådahl wrote: >

[PATCH] connection: Don't add uninitialized memory as 4 byte alignment padding

memory shared between the server and client, initialize the buffer content to 0, making the padding bytes always 0. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- src/connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connection.c b/src/connection.c index 6

Re: [PATCH] connection: Don't add uninitialized memory as 4 byte alignment padding

On Wed, Feb 10, 2016 at 12:37:43PM -0600, Derek Foreman wrote: > On 10/02/16 09:35 AM, Jonas Ådahl wrote: > > When we are adding padding bytes making our wl_buffer buffer content 4 > > byte aligned, we are just moving the pointer. Since the buffer is > > allocated using plain

Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

ar so that we can > continue submitting new cursor frames. > > Signed-off-by: Rui Matos <tiagoma...@gmail.com> > Reviewed-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > > v2: as suggested by Jonas, moved the hunk fur

Re: [PATCH wayland-protocols v2] xdg-shell: Introduce xdg_tooltip

n Wed, Feb 3, 2016 at 12:59 AM, Giulio Camuffo <giuliocamu...@gmail.com> > > wrote: > >> 2016-02-03 10:39 GMT+02:00 Jonas Ådahl <jad...@gmail.com>: > >>> An xdg_tooltip is a new window type used to implement tooltip like > >>> surfaces. See

[PATCH wayland-protocols v2] xdg-shell: Turn xdg_surface into a generic base interface

xdg_surface based extensions are meant to also extend xdg_surface.configure for relevant window type dependend state synchronization. Signed-off-by: Jonas Ådahl <jad...@gmail.com> Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> --- Changes since v1: Moved role assignment

[PATCH wayland-protocols v2] xdg-shell: Introduce xdg_tooltip

An xdg_tooltip is a new window type used to implement tooltip like surfaces. See the interface documentation for details. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Changes since v1: Various wording changes as suggested by Mike. Added missing version attribute and . unstab

Re: Recursive dispatch (Re: [PATCH v2] server: Calculate remaining data size after a closure is processed)

> > Sent: Wednesday, February 03, 2016 6:56 AM > > > To: Pekka Paalanen; Jaeyoon Jung > > > Cc: 'Jonas Ådahl'; wayland-devel@lists.freedesktop.org > > > Subject: Re: Recursive dispatch (Re: [PATCH v2] server: Calculate > > > remaining > > > data size after

Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

On Wed, Feb 03, 2016 at 05:46:35PM -0800, Bryce Harrington wrote: > On Wed, Feb 03, 2016 at 04:14:09PM +0100, Rui Matos wrote: > > The last cursor frame we commited before the pointer left one of our > > surfaces might not have been shown. In that case we'll have a cursor > > surface frame

Re: Recursive dispatch (Re: [PATCH v2] server: Calculate remaining data size after a closure is processed)

On Wed, Feb 03, 2016 at 01:44:27PM -0800, Bryce Harrington wrote: > On Wed, Feb 03, 2016 at 01:37:21PM +0200, Pekka Paalanen wrote: > > On Wed, 3 Feb 2016 10:52:07 + > > Auke Booij <a...@tulcod.com> wrote: > > > On 3 February 2016 at 09:34, Jonas Ådahl <jad...

Re: [PATCH wayland-protocols v2] xdg-shell: Introduce xdg_tooltip

On Wed, Feb 03, 2016 at 07:24:10PM -0800, Bill Spitzak wrote: > On Wed, Feb 3, 2016 at 1:05 PM, Jasper St. Pierre > wrote: > > > On Wed, Feb 3, 2016 at 1:00 PM, Bill Spitzak wrote: > > > > > > > > > On Wed, Feb 3, 2016 at 11:36 AM, Jasper St. Pierre < >

Re: [PATCH weston] input: Don't try to send pointer frames if no focus_client

On Mon, Feb 01, 2016 at 02:38:41PM +0100, Marek Chalupa wrote: > I ran into the same issue with gtk3-demo. > When the popup was being destroyed, the focus was set to 0x0 and I got > sigsegv, because popup grab tried to sent the frame. > > Reviewed-by: Marek Chalupa Pushed

Re: [PATCH] input: send frame after axis event in default grab

On Mon, Feb 01, 2016 at 04:16:17PM +0100, Marek Chalupa wrote: > Clients that implement version 5 of pointer wait for the frame > after pointer events (e. g. GTK+ clients). We send it after motion > and button, but not after the axis event in default grab. > > Send the frame after the axis event,

Re: [PATCH weston] input: Don't try to send pointer frames if no focus_client

On Fri, Jan 29, 2016 at 10:29:46AM -0600, Derek Foreman wrote: > Prevents a segfault when mousing into clients that don't get_pointer > like weston-simple-shm and weston-simple-damage. > > Signed-off-by: Derek Foreman <der...@osg.samsung.com> Reviewed-by: Jonas Ådahl

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: > There were some shortcomings in the first version of the protocol which > makes it not really useful in real world applications. It is not really > possible to fix them in a compatible way so introduce a new v2 of the > protocol.

[PATCH wayland] scanner: Print filename on DTD validation error

Don't just print prefix the errors with "protocol", but the actual file name, if wayland-scanner was passed with the filename of the protocol file. If wayland-scanner is reading from stdin, errors will be prefixed with "" instead of "protocol". Signed-off-by:

[PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

Add a note to the wl_data_device_manager global interface about the different requirements for operating the objects created from the bound global. Signed-off-by: Jonas Ådahl <jad...@gmail.com> --- Pekka suggested we should add a note about the per version requir

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

On Mon, Jan 18, 2016 at 06:28:29PM +, Daniel Stone wrote: > Hi, > > On 15 January 2016 at 19:30, Bill Spitzak wrote: > > On Fri, Jan 15, 2016 at 8:08 AM, Daniel Stone wrote: > >> The proposed one-shot-but-delayed request to me felt like a really > >>

Re: [PATCH weston] compositor-rdp: update link to wheel delta explanation

Reviewed (well checked the link) and push this one. Jonas On Mon, Jan 18, 2016 at 01:54:19PM +1000, Peter Hutterer wrote: > The previous one is a 404 now. > --- > src/compositor-rdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rdp.c

Re: [PATCH weston v9] data-device: Implement DnD actions

> - Split from DnD progress notification changes. > > Changes since v1: > - Updated to v2 of DnD actions protocol changes, implement > wl_data_offer.source_actions. > - Fixed coding style issues. > > Signed-off-by: Carlos Garnacho <carl...@gnome.org> > R

Re: [PATCH v5 weston 2/2] Support axis source, axis discrete, frame and axis stop events

This one is now also pushed, with a couple of fixes (resource version checks before sending wl_pointer.frame when changing pointer focus). Jonas On Mon, Jan 18, 2016 at 04:38:22PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes to v2: > -

Re: [PATCH v5 weston 2/2] Support axis source, axis discrete, frame and axis stop events

On Mon, Jan 18, 2016 at 04:38:22PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Re-adding my RB to this and v4 of 1/2. Eventually I think it'd be good to introduce a weston_pointer_event that doesn't make it necessary to emit the unnecessary (though

Re: [PATCH v3 weston 2/2] Support axis source, axis discrete, frame and axis stop events

On Tue, Dec 08, 2015 at 11:15:01AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Took another look at this patch. I noticed a few things. First, it doesn't build when screen-share and the RDP backend is enabled, because of the API changes in the first

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

On Tue, Jan 12, 2016 at 10:01:17AM +, Daniel Stone wrote: > On 12 January 2016 at 04:31, Jonas Ådahl <jad...@gmail.com> wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until t

Re: [PATCH wayland 2/2] protocol: Add DnD actions

issues. > > > > Changes since v7: > > - Misc changes after updating the progress notification patch. > > > > Changes since v6: > > - Further explanations on wl_data_source/offer.set_actions, including a > > description of "ask" actions. Added p

Re: [PATCH weston 2/5] data-device: Implement DnD actions

s since v1: > - Updated to v2 of DnD actions protocol changes, implement > wl_data_offer.source_actions. > - Fixed coding style issues. > > Signed-off-by: Carlos Garnacho <carl...@gnome.org> > Reviewed-by: Michael Catanzaro <mcatanz...@igalia.com> Except for c

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

On Sat, Jan 16, 2016 at 03:07:00PM -0500, Mike Blumenkrantz wrote: > On Sat, 16 Jan 2016 10:28:20 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > > > Hi, > > > > > >

Re: [PATCH wayland-protocols 1/3] xdg-shell: Turn xdg_surface into a generic base interface

r missing adding your Signed-off-by (as this patch was a result of shedcraft session a while back). Will send a new version with wording improvements. Jonas > > On Tue, 12 Jan 2016 16:16:47 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > Split out toplevel window li

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

blocking, as it is already specified to not be blocking. It'd be an API change. Jonas > > > > On Thu, Jan 14, 2016 at 6:40 PM, Jonas Ådahl <jad...@gmail.com> wrote: > > > On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > > > On 12 January 2016 a

Re: [PATCH weston v6 1/5] data-device: Implement DnD progress notification

On Fri, Jan 15, 2016 at 09:09:46PM +0100, Carlos Garnacho wrote: > Hey Jonas, > > On Fri, Jan 15, 2016 at 6:32 AM, Jonas Ådahl <jad...@gmail.com> wrote: > > On Thu, Jan 14, 2016 at 11:43:39PM +0100, Carlos Garnacho wrote: > >> Weston now sends wl_data_source.dnd_dr

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > Hi, > > I have some suggestions which I've inlined below: > > On Tue, 12 Jan 2016 16:16:49 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > An xdg_tooltip is a new window type used to im

Re: [PATCH v7 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

ave and subsequent enter into the same frame. This > > indicates to the client that the pointer has moved between surfaces and may > > allow a client to shortcut code otherwise triggerd by the leave or enter > > events. > > > > Signed-off-by: Peter Hutterer <peter.hutte.

Re: [PATCH wayland 2/2] protocol: Add DnD actions

On Thu, Jan 14, 2016 at 11:50:29AM +0100, Michal Suchanek wrote: > On 14 January 2016 at 01:54, Carlos Garnacho wrote: > > Hi Michal, > > > > On Mon, Jan 11, 2016 at 11:34 AM, Michal Suchanek > > wrote: > >> On 24 December 2015 at 01:58, Carlos Garnacho

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

On Thu, Jan 14, 2016 at 04:59:48PM -0600, Derek Foreman wrote: > On 11/01/16 10:31 PM, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > data to read, whi

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > On 12 January 2016 at 04:31, Jonas Ådahl <jad...@gmail.com> wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there >

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

On Thu, Jan 14, 2016 at 04:25:00PM +, Daniel Stone wrote: > Hi, > > On 13 January 2016 at 02:14, Jonas Ådahl <jad...@gmail.com> wrote: > > This patch introduces a new protocol for locking and confining a > > pointer. It consists of a new global object with two re

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the set_actions requests on both

Re: [PATCH weston 4/5] data-device: Implement compositor-chosen actions

ource fields. > > Signed-off-by: Carlos Garnacho <carl...@gnome.org> > Reviewed-by: Jonas Ådahl <jad...@gmail.com> > --- > src/compositor.h | 1 + > src/data-device.c | 75 > +++ > 2 files changed, 76 inserti

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

Hey, Found a couple of more issues. Comments inline. On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

On Wed, Jan 13, 2016 at 01:59:21PM +0800, Jonas Ådahl wrote: > On Wed, Jan 13, 2016 at 02:44:29PM +1000, Peter Hutterer wrote: > > On Wed, Jan 13, 2016 at 10:14:50AM +0800, Jonas Ådahl wrote: > > > This patch introduces a new protocol for locking and confining a > > > po

Re: [PATCH] server: Add an API to get the socket fd for a client

lient The display object > > + * \return fd The fd to use for the connection > > Should probably just be > * \return The fd to use for the connection Maybe "file descriptor" here as well? > > Otherwise this looks good to me, > Reviewed-by: D

<    1   2   3   4   5   6   7   8   9   10   >