Re: [PATCH libinput 5/5] test: add tests for lid switch

On Thu, Jan 05, 2017 at 05:11:29PM +1100, James Ye wrote: > --- > test/Makefile.am| 4 +- > test/lid.c | 228 > > test/litest-device-lid-switch.c | 58 ++ > test/litest.c | 28 + >

Re: [PATCH libinput 3/5] Add evdev_dispatch interface for lid switch

gt; + udev_tags & EVDEV_UDEV_TAG_SWITCH ? " Switch" : ""); > > if (udev_tags & EVDEV_UDEV_TAG_ACCELEROMETER) { > log_info(libinput, > @@ -2631,6 +2706,17 @@ evdev_configure_device(struct evdev_device *device) >

Re: [PATCH libinput 1/5] udev: mark switches as input devices

On Thu, Jan 05, 2017 at 05:11:25PM +1100, James Ye wrote: > --- fwiw, I have the required bits here https://github.com/whot/systemd/tree/wip/ID_INPUT_SWITCH I'll get the upstream as soon as we're happy with this set Cheers, Peter > udev/90-libinput-model-quirks.hwdb | 6 ++ > 1 file

Re: [RFE wayland] protocol: add axis_source.wheel_tilt

On Tue, Dec 06, 2016 at 02:31:22PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > --- > This is missing the various version bumps, it's just an RFE at this point. > We have a bit of a problem with the axis sources in the wayland protocol

[PATCH libinput] test: add test for the vertical position-dependent pinch

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/gestures.c | 55 +++ test/litest.c | 6 ++ test/litest.h | 3 +++ 3 files changed, 64 insertions(+) diff --git a/test/gestures.c b/test/gestures.c index 0

[PATCH v2 libinput] gestures: if fingers don't move, force a gesture by finger position

fixes previously unreachable code: the test for the finger position required at least 3 fingers down but was within a condition that ensured only 2 fingers were down. This was introduced in 11917061fe320c. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes to v1: - better

Re: [PATCH] gestures: if fingers don't move, force a gesture by finger position

On Tue, Dec 20, 2016 at 12:20:38PM +0100, Hans de Goede wrote: > Hi, > > On 20-12-16 04:57, Peter Hutterer wrote: > > If the fingers rest on the touchpad without moving for a timeout, switch to > > pinch or swipe based on the finger position. We already did so for > >

[PATCH] gestures: if fingers don't move, force a gesture by finger position

If the fingers rest on the touchpad without moving for a timeout, switch to pinch or swipe based on the finger position. We already did so for two-fingers switching to scrolling, now we also do so for 3 and 4 finger gestures. This gives us better reaction to small movements. Signed-off-by: Peter

[PATCH libinput 4/4] touchpad: if an external touchpad and keyboard share a VID/PID assume dwt

This requires to expand the blacklisting to be a bit more specific so we don't initialize dwt config on devices that won't need it. https://bugs.freedesktop.org/show_bug.cgi?id=99140 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad.c

[PATCH libinput 3/4] test: use the udev property to check for external/internal touchpads

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/device.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/test/device.c b/test/device.c index f44a988..af39508 100644 --- a/test/device.c +++ b/test/device.c @@ -61,6 +61,22 @@ STAR

[PATCH libinput 1/4] test: don't set LITEST_VERBOSE during make check

in handy. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 6dfc138..f43cf52 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -143,8 +143,6 @@ test_build_linker

[PATCH libinput 2/4] test: mark the magic trackpad as external in udev

This should be handled by a udev rule in systemd/hwdb but that rule doesn't apply to virtual devices. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/litest-device-magic-trackpad.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/test/litest-device

[PATCH libinput 13/13] filter: tweak the magic slowdown

Could be confirmation bias, but it feels better. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index ab503cf..d7a1515 100644 --- a/src/filter.c +++ b/src/filter.c @@

[PATCH libinput 11/13] filter: revamp the touchpad's acceleration code

remains the same regardless of the speed The caculated factor changes with the speed set so that the base speed changes with the desired speed. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 25 +++-- 1 file changed, 11 insertions(+), 14 del

[PATCH libinput 10/13] tools: switch the ptraccel-debug printf to use mm/s

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- tools/ptraccel-debug.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tools/ptraccel-debug.c b/tools/ptraccel-debug.c index 4ecb7e8..4fcb45f 100644 --- a/tools/ptraccel-debug.c

[PATCH libinput 02/13] filter: drop the dpi_factor in favor of direct calculation

s well use that. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/filter.c b/src/filter.c index eecf4ca..06f07af 100644 --- a/src/filter.c +++ b/src/filter.c @@ -153,7

[PATCH libinput 06/13] filter: change the filter functions to take raw device coordinates

the case if a low-dpi mouse had more than 1000dpi (never true) or a trackpoint had a const accel lower than 1.0 (yeah, whatever). Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad.c | 16 +++- src/evdev-tablet.c | 7 +- src/evdev.c | 2 +

[PATCH libinput 09/13] filter: work the touchpad magic slowdown into the various parameters

We have everything separate from the mouse now, so having a magic slowdown isn't needed, we can work this into our parameters. So the acceleration function now uses everything adjusted, but the factor is still multiplied by the slowdown in the end. Signed-off-by: Peter Hutterer <peter.hu

[PATCH libinput 07/13] filter: drop the now-generic trackpoint and low-dpi filter functions

The profile is what is still special about those two, the filter itself does the same as the default filter (calculate velocity, calculate accel factor, apply to delta). Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.

[PATCH 00/13] Revamp touchpad acceleration code

This patchset is a cleanup and revamp of the touchpad acceleration code. It doesn't give us perfect acceleration, but it goes from the current rather abysimal state to one that should at least be good enough most of the time. More tweaking will come, but meanwhile santa and whatnot. Right now, we

[PATCH libinput 08/13] filter: change touchpad accel code to use mm/s

of the curve but it may not even perceivable anyway. And these values will be overhauled soon anyway, so meh. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/src/fi

[PATCH libinput 04/13] touchpad: init the device's dpi correctly

This has no real effect just yet because we don't use a touchpad's dpi anywhere in the touchpad code. Only the acceleration code wants it but all touchpads use the same acceleration method, and that one doesn't care about the dpi. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --

[PATCH libinput 01/13] filter: store the raw dpi value in the filter

Currently unused, will be used in the future. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/filter.c b/src/filter.c index 4b15c30..eecf4ca 100644 --- a/src/filter.c +++ b/src/filter.c @@ -154,6

[PATCH libinput 03/13] filter: duplicate pointer accel for touchpads

This duplicates the code so we can change it for touchpads without affecting mice. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 103 --- 1 file changed, 98 insertions(+), 5 deletions(-) diff --git

[PATCH libinput 05/13] Add device_float_get_direction

With some upcoming changes we need this function for device float coordinates as well. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/libinput-private.h | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/src/li

[PATCH libinput 1/3] touchpad: convert two functions to use the device->phys helpers

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad.c | 24 +--- src/evdev.h | 27 +++ 2 files changed, 40 insertions(+), 11 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c

[PATCH libinput 3/3] filter: add a comment for how we calculate velocity

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/filter.c b/src/filter.c index a7cb545..77652a2 100644 --- a/src/filter.c +++ b/src/filter.c @@ -228,6 +228,13 @@ calculate_velocity_after_timeout(

[PATCH libinput 2/3] filter: split a condition up so we can mark it as bug

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/filter.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/filter.c b/src/filter.c index 0bb066c..a7cb545 100644 --- a/src/filter.c +++ b/src/filter.c @@ -245,9 +245,12 @@ calculate_velocity(

[PATCH libinput 2/2] touchpad: reduce the tap movement threshold to 1.3mm

almost no impact on most tapping users but improves the reaction time of the pointer for normal movements. For a more details see: http://who-t.blogspot.com/2016/12/libinput-touchpad-tap-analysis.html Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad-tap

[PATCH libinput 1/2] touchpad: reduce the initial timeout for tapping after touch

s are less than 100ms long. Reducing the threshold should have almost no impact on most tapping users but improves the reaction time of the pointer for normal movements. For a more details see: http://who-t.blogspot.com/2016/12/libinput-touchpad-tap-analysis.html Signed-off-by: Peter Hutterer &l

Re: [RFC PATCH 0/8] Meson build system [for libinput this time]

On Thu, Dec 08, 2016 at 12:39:18PM +, Daniel Stone wrote: > Hey Peter, > > On 7 December 2016 at 22:33, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > On Tue, Nov 29, 2016 at 04:59:39PM +, Daniel Stone wrote: > >> [meson is like totally super d

Re: [RFC PATCH 0/8] Meson build system [for libinput this time]

On Tue, Nov 29, 2016 at 04:59:39PM +, Daniel Stone wrote: > [meson is like totally super duper] I tried the same for libinput, work available in https://github.com/whot/libinput/tree/wip/meson I think I'm about 80% of the way there, with more testing needed and a few details being

[ANNOUNCE] libinput 1.5.3

. if your touchpad didn't respond until you put two fingers down, this is fixed now (observed on one elantech touchpad). Peter Hutterer (11): util: fix indentation for safe_atoi util: fix include order util: if errno is nonzero, exit early from safe_atoi evdev: move

[RFE weston] Support the new wheel tilt axis source

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Also just an RFE, it's missing the various version requirements (libinput doesn't have a tag for this yet). Not much we can do in weston but treat it effectively the same as the wheel rotation. clients/eventdemo.c

[RFE wayland] protocol: add axis_source.wheel_tilt

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- This is missing the various version bumps, it's just an RFE at this point. We have a bit of a problem with the axis sources in the wayland protocol in that they're sent but not really explained well in the protocol. So to match th

Re: [RFC PATCH 0/8] Meson build system

On Fri, Dec 02, 2016 at 07:39:02PM +, Emil Velikov wrote: > On 2 December 2016 at 18:28, Daniel Stone wrote: > > Hey, > > > > On 2 December 2016 at 18:25, Emil Velikov wrote: > >> On 1 December 2016 at 15:24, Daniel Stone

Re: [PATCH v3] protocol: Define further the behavior of input on the presence of grabs

vents for this purpose. This meant one had to be added > on wl_touch. > v3: Improved wording (I hope!) largely inspired on the suggestions from > Daniel Stone. Bumped wl_seat version to 6 for wl_touch.leave. minus the issues Daniel pointed out: Reviewed-by: Peter Hutterer <pete

[PATCH libinput 3/4] Drop HAVE_CONFIG_H ifdef

We have one. Yay. Lucky us. Go forth and celebrate. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad-tap.c| 2 -- test/litest-device-alps-dualpoint.c| 2 -- test/litest-device-alps-semi-mt.c | 2 -- test/litest-

[PATCH libinput 4/4] Fix the license for a bunch of tablet test devices

the license text the same as all other files. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/litest-device-huion-pentablet.c | 33 +- test/litest-device-wacom-bamboo-tablet.c | 33 +- test/litest-device-wacom-

[PATCH libinput 2/4] tools: don't define GNU_SOURCE if were including config.h anyway

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- tools/event-gui.c | 1 - tools/shared.c| 1 - 2 files changed, 2 deletions(-) diff --git a/tools/event-gui.c b/tools/event-gui.c index b5dd097..36be874 100644 --- a/tools/event-gui.c +++ b/tools/event-gui.c @@ -20,7

[PATCH libinput 1/4] Use the LIBINPUT_VERSION define, not the normal VERSION

Not that it really matters, but given we're already setting it anyway... Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/libinput-private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libinput-private.h b/src/libinput-private.h index 5

Re: [PATCH weston] tests: Skip Xwayland test if binary isn't available

luous, there are plenty of lines going over 80 chars and this doesn't really make it any more readable. either way: Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > xwayland_test_weston_LDADD = libtest-client.la $(XWAYLAND_TEST_LIBS) > endif > &

Re: [PATCH weston] libweston: Make module loading safe against long paths

On Tue, Nov 29, 2016 at 10:18:30AM +, Daniel Stone wrote: > Avoid any buffer overflows here by checking we don't go over PATH_MAX > with stupid module names. > > Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.n

Re: [PATCH libinput] touchpad: add a quirk for the HP Pavilion dm4

On Tue, Nov 29, 2016 at 10:11:06AM +0100, Hans de Goede wrote: > Hi, > > On 29-11-16 04:48, Peter Hutterer wrote: > > On Mon, Nov 28, 2016 at 03:33:25PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 27-11-16 23:55, Peter Hutterer wrote: > >

[PATCH v2 libinput] touchpad: add a quirk for the HP Pavilion dm4

-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes to v1: - move the DM4 magic to tp_init_slots and pretend it's a single-touch touchpad. src/evdev-mt-touchpad.c| 12 +++- src/evdev.c| 1 + src/evdev.h| 1 + u

Re: [PATCH libinput] touchpad: add a quirk for the HP Pavilion dm4

On Mon, Nov 28, 2016 at 03:33:25PM +0100, Hans de Goede wrote: > Hi, > > On 27-11-16 23:55, Peter Hutterer wrote: > > This touchpad has cursor jumps for 2-finger scrolling that also affects the > > single-finger emulation. So disable any multitouch bits on this device a

[PATCH libinput 4/4] test: add wheel tilt tests

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/Makefile.am | 1 + test/litest-device-mouse-wheel-tilt.c | 76 +++ test/litest.c | 2 + test/litest.h | 1 + test/poi

[PATCH libinput 2/4] Add wheel tilt as axis source

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/libinput.h | 15 +++ tools/event-debug.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index 18a96bd..aac93fc 100644 --- a/src/libinput.h +++ b/src/libinput.h @@

[PATCH libinput 0/4] Wheel tilt scroll source

Quite a few mice have tilt-capable wheels for horizontal scrolling. We can't detect those automatically so we'll have to rely on systemd/udev for the tagging. But despite that, we should be honest about the scroll source and mark them as tilt where possible rather than pretending that they're

[PATCH libinput 1/4] evdev: add helper function to parse a udev flag

) was counted as "yes". Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index afb5e34..500a0f8 100644 --- a/src/evdev.c +

[PATCH libinput] evdev: init axis range warnings for touch devices too

Move the code from the touchpad code into the more generic evdev code Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad.c | 76 + src/evdev-mt-touchpad.h | 5 src/evdev.c | 6 src/e

Re: [PATCH weston 2/2] compositor-wayland: Destroy cursor images earlier

i...@collabora.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > libweston/compositor-wayland.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libweston/compositor-wayland.c b/libweston/compositor

[PATCH libinput 6/7] util: add a helper function to split a string into substrings

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/libinput-util.c | 82 + src/libinput-util.h | 18 test/misc.c | 45 + 3 files changed, 145 insertions(+) diff --git a/src/li

[PATCH libinput 2/7] evdev: move reading the calibration prop into a helper function

No functional changes. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.c | 39 +++ src/evdev.h | 3 +++ src/udev-seat.c | 26 +- 3 files changed, 43 insertions(+), 25 deletions(-) diff --git

[PATCH libinput 4/7] test: add a device and test for udev-set calibration values

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/Makefile.am| 1 + test/litest-device-calibrated-touchscreen.c | 103 test/litest.c | 2 + test/litest.h

[PATCH libinput 7/7] evdev: use safe_atod to convert the matrix values

Avoids parsing issues when we're in different locales https://bugs.freedesktop.org/show_bug.cgi?id=98828 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/evdev.c

[PATCH libinput 5/7] util: add safe_atod for locale-independent conversion

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/libinput-util.c | 15 ++- src/libinput-util.h | 29 + test/misc.c | 50 ++ 3 files changed, 81 insertions(+), 13 deletions(-)

[PATCH libinput 1/7] test: add a test for safe_atoi

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/misc.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/test/misc.c b/test/misc.c index 4afd4d0..95776f7 100644 --- a/test/misc.c +++ b/test/misc.c @@ -861,6 +861,47 @@ STAR

[PATCH libinput 3/7] path: read the calibration prop on startup

We were reading this property in the udev backend, but not in the path backend. Reported-by: Thomas Olszak <olszak.tom...@gmail.com> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/path.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/path.c b/src/path.c i

[PATCH libinput] touchpad: add a quirk for the HP Pavilion dm4

-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev-mt-touchpad.c| 6 ++ src/evdev.c| 12 src/evdev.h| 1 + udev/90-libinput-model-quirks.hwdb | 4 4 files changed, 23 insertions(+) diff --git

Re: [PATCH wayland] doc: Remove wayland-util.c from file list

ue, and is redundant. > > Remove the doxygen page for wayland-util.c. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > doc/doxygen/Makefile.am | 1 - > 1 file changed, 1 d

[ANNOUNCE] libinput 1.5.2

Studio G3 was added, the rest is just general cleanup bits with few funcitonal changes. Peter Hutterer (16): configure.ac: move all AM_CONDITIONALs into one place configure.ac: add some comment markers to see the configure.ac sections easier configure.ac: move the udev test path

Re: [PATCH weston] build: fix wayland-backend distcheck

kka Paalanen <pekka.paala...@collabora.co.uk> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > Makefile.am | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

On Tue, Nov 22, 2016 at 09:03:52AM -0800, Ping Cheng wrote: > On Tuesday, November 22, 2016, Daniel Stone <dan...@fooishbar.org> wrote: > > > Hey, > > > > On 21 November 2016 at 23:13, Peter Hutterer <peter.hutte...@who-t.net > > <javascript:;>>

Re: [PATCH wayland] doc: Remove display of WL_PRINTF attribute

tribute at all in the generated documentation. > > [1] https://bugzilla.gnome.org/show_bug.cgi?id=774741 > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > doc/doxygen/wayland.doxygen.i

[PATCH libinput] touchpad: only use the last two coordinates for delta calculation

the motion hysteresis as a separate item to prevent jumps (and thus adds some delay to the movement), the calculation over time doesn't provide enough benefit to justify the sluggish pointer. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- I'm leaving the motion history as-is for no

[PATCH libinput 3/4] test: allow the first event to be a short one during scroll tests

the hysteresis is per-event and by the time we get past the minimum 4 events to move the pointer, we're already flying unaffected by the hysteresis. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/litest.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-)

[PATCH libinput 2/4] test: fix edge-scroll no-motion test

test to fail. This is currently covered up by the delta calculations though, but fix it anyway. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/touchpad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 9

[PATCH libinput 1/4] test: start with the first offset when moving touches

oordinates and thus not causing a motion on the first event. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- test/litest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/litest.c b/test/litest.c index 94da85a..e685d61 100644 --- a/test/litest.c +++

[PATCH libinput 4/4] evdev: simplify hysteresis code and document it

center + diff is the input coordinate. Simplify the code so it's clear what we're returning. And document the function to explain what it does. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.h | 38 +++--- 1 file changed, 35 inse

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > Hi, > > On 20 November 2016 at 05:14, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > Rather than relying on input-event-codes, define our own enum that is > > tailored > > towards the tab

Re: [PATCH wayland] util: Improve documentation of wl_iterator_result

little more readable, and refers to documented > functions that use this enum type. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > src/wayland-util.h | 6 -- > 1 file chang

[RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

Rather than relying on input-event-codes, define our own enum that is tailored towards the tablet interface. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Because it's usually easier to pick holes into a patch proposal than come up with ideas elsewhere, here's a quick-and

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Fri, Nov 18, 2016 at 11:29:53AM +0800, Jonas Ådahl wrote: > On Fri, Nov 18, 2016 at 12:25:21PM +1000, Peter Hutterer wrote: > > On Thu, Nov 17, 2016 at 10:42:41AM +0800, Jonas Ådahl wrote: > > > On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > > > &

[PATCH libinput] evdev: add a quirk for the HP Zbook Studio G3

Announces 4 slots but only sends data for the first two. This causes libinput to miss three-finger actions (we don't look at BTN_TOOL_TRIPLETAP if we have 3 or more slots). https://bugs.freedesktop.org/show_bug.cgi?id=98100 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --

[PATCH v2 wayland] protocol: indentation fixes

8 spaces changed to one tab Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Acked-by: Bryce Harrington <br...@osg.samsung.com> --- Changes to v1: - Rebased on top of aa51a83 protocol/wayland.xml | 100 +-- 1 file changed, 5

Re: [PATCH wayland] protocol: indentation fixes

On Thu, Nov 17, 2016 at 04:42:07PM -0800, Bryce Harrington wrote: > On Thu, Nov 10, 2016 at 03:02:06PM +1000, Peter Hutterer wrote: > > 8 spaces changed to one tab > > > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > The patch isn't apply

[PATCH v2 wayland] protocol: spell out that we're using linux/input-event-codes.h button codes

Because we already rely on it in the callers anyway. This is a retrofit, which is not ideal but I'm not sure any compositor out there uses anything else. Might as well define it. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- This is the button bit only which I think we agreed

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Thu, Nov 17, 2016 at 10:42:41AM +0800, Jonas Ådahl wrote: > On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > > Hi, > > > > On 15 November 2016 at 09:42, Jonas Ådahl wrote: > > > On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > > >> But this I'd

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > Hi, > > On 15 November 2016 at 09:42, Jonas Ådahl wrote: > > On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > >> But this I'd prefer to drop. We need to describe the button codes, but > >> the key

Re: [PATCH wayland 2/3] Makefile: do not put TESTS into check_PROGRAMS

lt_test_programs to hold the names > that are both programs built from source files and tests to execute. > > This change is required by the following patch adding wayland-scanner > test script. > > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Revie

[PATCH libinput] Use AM_DISTCHECK_CONFIGURE_FLAGS, not just DISTCHECK_CONFIGURE_FLAGS

The latter is for commandline overrides. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Ooops, didn't notice until Semaphore CI failed (it uses the environment itself) Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am

Re: [PATCH v6] protocol: Extend wl_touch with touchpoint shape and orientation

> touch device support this type of information. The client is > responsible for making a reasonable assumption about the > touch shape if no shape is reported. > > Signed-off-by: Dennis Kempin <denniskem...@google.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.n

[PATCH libinput 2/4] configure.ac: add some comment markers to see the configure.ac sections easier

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index 012ab0b..5b5b68a 100644 --- a/configure.ac +++ b/configure.ac @@ -83,6 +83,9 @@ fi AC_SUBST(GCC_CFLAGS) AC

[PATCH libinput 3/4] configure.ac: move the udev test path up into the test section

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- configure.ac | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 5b5b68a..206a4ed 100644 --- a/configure.ac +++ b/configure.ac @@ -211,6 +211,12 @@ if test "x$

[PATCH libinput 1/4] configure.ac: move all AM_CONDITIONALs into one place

Makes it easier to see in one go what is conditional in the build. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 43db9bb..012ab0b 100644 --- a/config

Re: [PATCH wayland v3] util: Improve documentation of wl_argument

member type comments. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > v3: Correct spelling of marhsalling. > v2: Match union member type names to actual protocol-defined type names, >

Re: [PATCH wayland] util: Document wl_fixed_t

to just wl_fixed_t. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > src/wayland-util.h | 36 > 1 file changed, 36 insertions(+) > >

[ANNOUNCE] libinput 1.5.1

sure our hwdb is correct (requires Python but is optional) - support for the new MOUSE_WHEEL_CLICK_COUNT udev property As usual, the git shortlog is below. Eric Engestrom (1): tools: change pointer to void Hermann Gausterer (1): evdev: fix typo / bugzilla url Peter Hutterer (18

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > Hi, > > On 10 November 2016 at 05:19, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > A side-note here: my first version sent to Jonas privately had a reserved > > range for any key with the hig

[PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

Because we already rely on it for xkb anyway. This is a retrofit, which is not ideal but I'm not sure any compositor out there uses anything else. Might as well define it. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- A side-note here: my first version sent to Jonas private

[PATCH wayland] protocol: indentation fixes

8 spaces changed to one tab Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- protocol/wayland.xml | 100 +-- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 6

[PATCH libinput] tablet: reject tablets without resolution

Fix the kernel driver or get a udev override in place. Tablets not having a physical size is not ok. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- As the test case shows, this will break waltop tablets so we'll have to fix those in the udev hwdb src/evdev-ta

Re: [PATCH wayland-protocols] tablet: specify the tool button numbers are simply sequentially numbered

On Fri, Nov 04, 2016 at 09:55:14AM -0700, Jason Gerecke wrote: > On 11/03/2016 06:46 PM, Peter Hutterer wrote: > > We're using sequentially numbered buttons for the pad because actual tablets > > are quite varied in how the present buttons (BTN_A, BTN_0, etc.). For this >

[PATCH wayland-protocols] tablet: specify the tool button numbers are simply sequentially numbered

is up to the compositor but at least we can get the wayland protocol right. The ony event codes a tool currently sends are BTN_STYLUS and BTN_STYLUS2 anyway, so it's already sequentially numbered with a make-pretend fancy name. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.

Re: [PATCH libinput] evdev: implement support for the MOUSE_WHEEL_CLICK_COUNT property

On Fri, Oct 28, 2016 at 12:57:38PM +0200, Hans de Goede wrote: > Hi, > > On 28-10-16 07:08, Peter Hutterer wrote: > >Not all mice have a click angle with integer degrees. The new > >MOUSE_WHEEL_CLICK_COUNT property specifies how many clicks per full rotation, > >the a

Re: [PATCH v5] protocol: Extend wl_touch with touchpoint shape and orientation

> touch device support this type of information. The client is > responsible for making a reasonable assumption about the > touch shape if no shape is reported. > > Signed-off-by: Dennis Kempin <denniskem...@google.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> tho

[PATCH libinput] evdev: add hwdb quirk for HP Compaq 6910

Same as the HP Compat 8510, it doesn't send BTN_TOOL_DOUBLETAP/TRIPLETAP. This may be a general issue with those series but they're 6 years old now, so it's questionable to spend extra effort detecting them. https://bugs.freedesktop.org/show_bug.cgi?id=98538 Signed-off-by: Peter Hutterer

[PATCH v2 libinput] evdev: actually ignore joysticks

A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check for both. https://bugs.freedesktop.org/show_bug.cgi?id=98009 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes to v1: - fix bug with previous version where a device with just ID_INPUT set

Re: [PATCH libinput] evdev: actually ignore joysticks

On Tue, Nov 01, 2016 at 08:06:09PM -0700, Dima Ryazanov wrote: > On Tue, Nov 1, 2016 at 6:19 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > > A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check > > for > > both. > > > >

<    5   6   7   8   9   10   11   12   13   14   >