[PATCH v2 libinput 1/5] test: add litest helper functions for creating uinput devices

2014-03-31 Thread Peter Hutterer
, EV_REL, REL_X, -1); libevdev_uinput_write_event(uinput, EV_SYN, SYN_REPORT, 0); ... libevdev_uinput_destroy(uinput); Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - make absinfo a -1-terminated list as well test/litest-bcm5974.c | 45 +++- test

[PATCH libinput 4/5] test: allow partial overriding the test devices

2014-03-31 Thread Peter Hutterer
}, }; litest_create_device_with_overrides(LITEST_SYNAPTICS_CLICKPAD, NULL, NULL, overrides, NULL); For general event codes, overrides can only add to the set of events, they can't remove. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c

[PATCH libinput 0/5] test: static and modifieable device descriptions

2014-03-31 Thread Peter Hutterer
With 1/5, the descriptions are already pretty much limited to just a static description of a device. This set pushes this further, truly reducing each test device to a bunch of arrays with the device-specific data, everything else that used to be boilerplate is now handled by the litest

[PATCH libinput 3/5] test: allow for description-based test devices

2014-03-31 Thread Peter Hutterer
Most of the test devices now are static descriptions anyway, make them fully static now, including for touch events. Switch the synaptics device now as example, the rest comes later for easier patch review. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-int.h | 47

Re: [PATCH libinput 5/5] test: switch the remaining devices to a description-based device

2014-04-01 Thread Peter Hutterer
On Tue, Apr 01, 2014 at 11:50:04AM +0200, Hans de Goede wrote: Hi, On 04/01/2014 05:47 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-bcm5974.c | 147 ++- test/litest-generic-highres-touch.c | 128

Re: [PATCH libinput 3/5] test: allow for description-based test devices

2014-04-03 Thread Peter Hutterer
On Thu, Apr 03, 2014 at 10:43:03PM +0200, Jonas Ådahl wrote: [...] diff --git a/test/litest.c b/test/litest.c index 6767952..23ba76b 100644 --- a/test/litest.c +++ b/test/litest.c @@ -61,6 +61,12 @@ struct suite { static struct litest_device *current_device; +struct

Re: [PATCH libinput 4/5] test: allow partial overriding the test devices

2014-04-03 Thread Peter Hutterer
On Thu, Apr 03, 2014 at 10:40:50PM +0200, Jonas Ådahl wrote: On Tue, Apr 01, 2014 at 01:47:08PM +1000, Peter Hutterer wrote: For specific tests we need something that e.g. looks like a touchpad, but has a different name, a different number of slots, etc. In this case, the following code

Re: [PATCH libinput 0/9] Improvements for clickpad touchpads

2014-04-04 Thread Peter Hutterer
Just for the archives, Hans and I talked about this off-list. On Tue, Apr 01, 2014 at 09:54:34AM +0200, Hans de Goede wrote: So as you requested I've been looking at your wip/clickpad-improvements branch. I've been mostly reading the code / patches and here is a long list of comments : 1) I

Re: [PATCH libinput] test: Use generic test device API in touch_abs_transform test

2014-04-04 Thread Peter Hutterer
-by: Jonas Ådahl jad...@gmail.com --- Went ahead and replaced the generic-highres-touch device with custom device in the only test where it matters. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net but it refuses to apply here. please rebase this when I've pushed the other branch, sorry

Re: [PATCH libinput 5/9] test: disable parallel build in test directory

2014-04-08 Thread Peter Hutterer
On Tue, Apr 08, 2014 at 09:55:30PM +0200, Jonas Ådahl wrote: On Fri, Mar 28, 2014 at 02:38:48PM +1000, Peter Hutterer wrote: We depend on device creation on the host system, having the tests run in parallel runs a risk of random failure. Ideally we'd just disable for the actual run

Re: [PATCH libinput 9/9] Add libinput_device_get_name() to advertise the kernel name

2014-04-09 Thread Peter Hutterer
On Tue, Apr 08, 2014 at 10:22:23PM +0200, Jonas Ådahl wrote: On Fri, Mar 28, 2014 at 02:38:52PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Sorry, had forgotten about these, but have some comments (in a previous e-mail and in this one). Anyhow

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

2014-04-09 Thread Peter Hutterer
On Wed, Apr 09, 2014 at 08:33:34PM +0100, Daniel Stone wrote: Hi, On 9 April 2014 20:02, Jonas Ådahl jad...@gmail.com wrote: Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what slots are assigned. There is still a hard coded max though,

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

2014-04-09 Thread Peter Hutterer
On Wed, Apr 09, 2014 at 09:02:08PM +0200, Jonas Ådahl wrote: Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what slots are assigned. There is still a hard coded max though, to protect from invalid input, but its changed to 60. Signed-off-by:

Re: [PATCH libinput 3/9] test: Add seat slot tests

2014-04-09 Thread Peter Hutterer
On Wed, Apr 09, 2014 at 09:02:10PM +0200, Jonas Ådahl wrote: Add one test that checks uniqueness of seat slots when having multiple devices with active touch points. Add one test that checks that libinput drops touch points when it could not represent them with a seat wide slot. This

Re: [PATCH libinput 4/9] test: Test handling of many touch points

2014-04-09 Thread Peter Hutterer
); + ck_assert_int_gt(slot_count, 0); maybe ck_assert_int_eq(slot_count, libevdev_num_slots(dev-evdev)) ? Reviewed-by: Peter Hutterer peter.hutte...@who-t.net either way + + libinput_dispatch(libinput); + do { + type = libinput_event_get_type(ev); + ck_assert_int_ne(type

Re: [PATCH libinput 9/9] touchpad: Always assign iterator in tp_for_each_touch macro

2014-04-09 Thread Peter Hutterer
for initiating the iterator. Signed-off-by: Jonas Ådahl jad...@gmail.com 6, 7, and this one Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- src/evdev-mt-touchpad.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.h b/src/evdev

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
); +state == LIBINPUT_POINTER_BUTTON_STATE_PRESSED ? pressed : released, +libinput_event_pointer_get_seat_button_count(p)); might as well make it easy to understand and have , seat cound %u. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net though, the test too. Cheers, Peter

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:17:37AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 03:43:25PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:08PM +0200, Jonas Ådahl wrote: Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:35:00AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM +0200, Jonas Ådahl wrote: Compositors will need to keep provide virtual devices of supported generic device types (pointer

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:53:45AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:48:52PM +1000, Peter Hutterer wrote: On Thu, Apr 10, 2014 at 08:35:00AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM

Re: [PATCH weston v2 2/5] libinput-seat: allow setting libinput log priority in weston

2014-04-22 Thread Peter Hutterer
On Thu, Apr 17, 2014 at 07:53:23AM -0700, U. Artie Eoff wrote: Look for WESTON_LIBINPUT_LOG_PRIORITY environment variable. If it exists then use it to set the libinput log priority. Otherwise, don't set the priority and get whatever libinput's default priority is. Setting

Re: [PATCH libinput] evdev-mt-touchpad: check calloc result

2014-04-22 Thread Peter Hutterer
On Tue, Apr 15, 2014 at 11:15:35PM +0200, Carlos Olmedo Escobar wrote: Check the value returned by calloc. --- src/evdev-mt-touchpad.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index bbbd8f3..9ec1682 100644 ---

Re: [PATCH libinput 5/6] tools: Add missing newline

2014-04-22 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:20:43PM +0200, Carlos Garnacho wrote: Signed-off-by: Carlos Garnacho carl...@gnome.org --- tools/event-debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index c0a08a7..fb79be4 100644 ---

[PATCH v2 libinput] test: disable parallel build in test directory

2014-04-23 Thread Peter Hutterer
We depend on device creation on the host system, having the tests run in parallel runs a risk of random failure. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- This time the simple version instead of hacking the AM_MAKEFLAGS. test/Makefile.am | 2 ++ 1 file changed, 2 insertions

Re: [PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

2014-04-23 Thread Peter Hutterer
On Tue, Apr 15, 2014 at 04:00:41PM +0200, Hans de Goede wrote: Hi, On 04/15/2014 03:44 PM, Daniel Stone wrote: Hi, On 15 April 2014 13:28, Hans de Goede hdego...@redhat.com wrote: Apple touchpads don't have visible markings for the software button areas that almost all other

Re: [PATCH libinput 09/20] touchpad: add clickpad-style software buttons

2014-04-23 Thread Peter Hutterer
On Wed, Apr 23, 2014 at 11:35:35PM +0200, Jonas Ådahl wrote: On Tue, Apr 15, 2014 at 02:28:06PM +0200, Hans de Goede wrote: From: Peter Hutterer peter.hutte...@who-t.net This is a slightly fancier implementation than the simplest model and ported over from libtouchpad. It implements

Re: [PATCH libinput 17/20] touchpad: Ignore fingers in button area for 2 finger scroll

2014-04-23 Thread Peter Hutterer
On Tue, Apr 15, 2014 at 02:28:14PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt

Re: [PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

2014-04-23 Thread Peter Hutterer
to test all independent state machines, rather then having the state-machines poke the is_pointer variabel directly. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 5 + src/evdev-mt-touchpad.h

Re: [PATCH libinput 11/20] touchpad: Rework is_pointer handling

2014-04-23 Thread Peter Hutterer
if a finger should count for 2 finger scrolling). Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git

Re: [PATCH libinput 04/20] touchpad: don't allow tapping while any button is down

2014-04-23 Thread Peter Hutterer
On Wed, Apr 23, 2014 at 11:36:05PM +0200, Jonas Ådahl wrote: On Tue, Apr 15, 2014 at 02:28:01PM +0200, Hans de Goede wrote: From: Peter Hutterer peter.hutte...@who-t.net Immediately set the state to DEAD, waiting for the tap release to go back to idle. This will make it impossible

Re: [PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

2014-04-23 Thread Peter Hutterer
On Tue, Apr 15, 2014 at 02:28:10PM +0200, Hans de Goede wrote: And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net I've gone through all patches again and they're now all

Re: [PATCH libinput 0/24] Tablet support

2014-04-27 Thread Peter Hutterer
Hey, On Mon, Apr 21, 2014 at 07:11:09PM +0200, Carlos Garnacho wrote: Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically pointer devices, with a varying range of extra buttons (either stylus or pad buttons), and extra ABS_* axes. These

Re: [PATCH libinput 01/24] Add LIBINPUT_EVENT_POINTER_AXIS_FRAME event

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:10PM +0200, Carlos Garnacho wrote: This event marks the end of 1..N simultaneous axis changes. Will be useful to have users compress vscroll/hscroll processing in a single point, and will prove even more useful on devices with a higher number of axes, like

Re: [PATCH libinput 02/24] evdev: use an axis_frame event to mark the end of axis changes

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:11PM +0200, Carlos Garnacho wrote: It will be unlikely in this case to get both REL_WHEEL and REL_HWHEEL on a single EV_SYN, but for completeness. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH libinput 05/24] tools: Handle LIBINPUT_EVENT_POINTER_AXIS_FRAME in event-debug

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:14PM +0200, Carlos Garnacho wrote: This information has no coordinates itself, so only print out the event time. please squash this in with the patch that introduces it (01/24). Same applies for the other ones that just introduce new bits to print. Cheers,

Re: [PATCH libinput 06/24] tests: drain events before testing scroll events in test-pointer

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:15PM +0200, Carlos Garnacho wrote: This is so LIBINPUT_EVENT_POINTER_AXIS_FRAME events remaining from previous tests are discarded. please instead update the tests so we pull the frame event off before we test the next series. it safeguards us against accidental

Re: [PATCH libinput 07/24] Add extra libinput_pointer_axis values for tablets

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:16PM +0200, Carlos Garnacho wrote: distance/pressure/xtilt/ytilt are handled at the moment, this leaves wheels/strips out at the moment... Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput.h | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH libinput 18/24] test: Add infrastructure for testing tablet events.

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:27PM +0200, Carlos Garnacho wrote: no vfuncs are used, only input_event arrays. Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/litest-int.h | 8 + test/litest.c | 90 +++ test/litest.h

Re: [PATCH libinput 09/24] Add LIBINPUT_EVENT_POINTER_TOOL_UPDATE event type

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:18PM +0200, Carlos Garnacho wrote: This event would be emitted whenever a device with LIBINPUT_DEVICE_CAP_STYLUS capabilities changes its tool type. When the tablet reaches proximity, the tool/serial will be updated to match the current physical stylus'.

Re: [PATCH libinput 15/24] tablet: Add infrastructure to store and notify axis states.

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:24PM +0200, Carlos Garnacho wrote: An axis_frame event is sent too to notify a set of simultaneous axis changes. Only the infrastructure is added, No axes are managed at the moment. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 107

Re: [PATCH libinput 16/24] tablet: Emit axis events on v/h stylus tilt changes.

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:25PM +0200, Carlos Garnacho wrote: Those are normalized to be in the [-1..1] range. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/evdev-tablet.c

Re: [PATCH libinput 17/24] tablet: Emit axis events on distance/pressure changes

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:26PM +0200, Carlos Garnacho wrote: Those have been made mutually exclusive, to make sure only one or the other is notified when there is some uncertainty from the device. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 29

Re: [PATCH libinput 14/24] tablet: handle button events

2014-04-27 Thread Peter Hutterer
On Mon, Apr 21, 2014 at 07:11:23PM +0200, Carlos Garnacho wrote: This works for stylus tap and primary/secondary button, and pad buttons. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 104 +

[PATCH libinput] Name-space the scroll event types

2014-04-27 Thread Peter Hutterer
To provide a generic naming system of type_direction. That will become more important once we add new axes as part of the ongoing work to support graphics tablets. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH libinput v2] evdev-mt-touchpad: check calloc result

2014-04-28 Thread Peter Hutterer
On Wed, Apr 23, 2014 at 01:03:33PM +0200, Carlos Olmedo Escobar wrote: Check the value returned by calloc. sorry for the delay, still catching up on emails. we use signed-off-by tags in libinput. If I can have yours for this patch, I'll push it out asap, thanks. Cheers, Peter ---

Re: [PATCH libinput v2] evdev-mt-touchpad: check calloc result

2014-04-29 Thread Peter Hutterer
On Tue, Apr 29, 2014 at 01:26:28AM +0200, Carlos Olmedo Escobar wrote: Check the value returned by calloc. Signed-off-by: Carlos Olmedo Escobar carlos.olmed...@gmail.com pushed, with a minor change in the commit message. thanks. Cheers, Peter --- src/evdev-mt-touchpad.c | 2 ++ 1

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-21 Thread Peter Hutterer
On Tue, May 20, 2014 at 01:12:32PM -0700, Bill Spitzak wrote: On 05/19/2014 11:55 PM, Pekka Paalanen wrote: What is the target audience of the build guide? Somebody who wants to contribute to wayland. I have been writing Linux software in C/C++ and OpenGL for about 20 years now,

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-21 Thread Peter Hutterer
On Tue, May 20, 2014 at 07:58:59AM -0400, Jasper St. Pierre wrote: Fedora has this built-in: # yum install 'pkgconfig(laalaa.pc)' And that becomes a pretty generic guide on How to build software, so if there is a site which already explains all these basics, we can link to it, but I

Re: [PATCH libinput v3 09/17] touchpad: Rework is_pointer handling

2014-05-21 Thread Peter Hutterer
the pointer, nor that the button code makes a pinned finger the pointer. All these sanity checks are combined into a new tp_button_active function, since they should be taken into account for 2 finger scrolling, etc. too. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Peter

Re: [PATCH libinput v3 07/17] touchpad: Only enable clickfingers on Apple touchpads

2014-05-21 Thread Peter Hutterer
On Tue, May 20, 2014 at 04:34:55PM +0200, Hans de Goede wrote: From: Peter Hutterer peter.hutte...@who-t.net Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click with two

Re: [PATCH libinput v3 02/17] touchpad: after a click, lock the finger to its current position

2014-05-22 Thread Peter Hutterer
On Tue, May 20, 2014 at 04:34:50PM +0200, Hans de Goede wrote: From: Peter Hutterer peter.hutte...@who-t.net On clickpads, clicking the pad usually causes some motion events. To avoid erroneous movements, lock the finger into position on the click and don't allow for motion events until we

Re: [PATCH libinput 2/2] touchpad: Make pointer movements a bit faster by default

2014-05-22 Thread Peter Hutterer
is that on the x220, which has a touchpad in ca 16:9 format the vertical motion is now noticably faster than the horizontal motion. we need to compensate for that soon. https://bugs.freedesktop.org/show_bug.cgi?id=79056, so we don't forget. Meanwhile, please apply this one. Reviewed-by: Peter Hutterer peter.hutte

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-22 Thread Peter Hutterer
On Thu, May 22, 2014 at 09:14:30AM +0200, Thierry Reding wrote: On Thu, May 22, 2014 at 09:25:40AM +0300, Pekka Paalanen wrote: On Thu, 22 May 2014 00:18:23 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Wed, May 21, 2014 at 12:30:18PM +0300, Pekka Paalanen wrote: On Tue,

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-22 Thread Peter Hutterer
On Thu, May 22, 2014 at 09:35:23AM -0700, Bill Spitzak wrote: On 05/21/2014 03:09 PM, Thierry Reding wrote: On Wed, May 21, 2014 at 02:54:36PM -0700, Bill Spitzak wrote: On 05/21/2014 02:16 PM, Thierry Reding wrote: While I agree with the other points, I think it's perfectly consistent for

Re: [PULL] libinput clickpad improvements

2014-05-22 Thread Peter Hutterer
touchpad: Remove clickpad clicked test from 2 finger scrolling handling touchpad: handle_timeouts: Remove unused return value Change internal timestamps to uint64_t to properly deal with wrapping Peter Hutterer (7): touchpad: set ntouches for single-touch pads depending

[PATCH libinput 3/4] test: disable CK_FORK for the valgrind runs

2014-05-22 Thread Peter Hutterer
I'm not sure what exactly is happening here, but while valgrind seems to run fine in normal mode, the build from make distcheck fails with rather random errors. Disabling CK_FORK seems to help, but more investigation is needed. Meanwhile, this makes distcheck succeed again. Signed-off-by: Peter

[PATCH libinput 2/4] test: restore log priority after each test

2014-05-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/log.c | 12 1 file changed, 12 insertions(+) diff --git a/test/log.c b/test/log.c index 0c5508f..b8cc767 100644 --- a/test/log.c +++ b/test/log.c @@ -74,6 +74,7 @@ END_TEST START_TEST(log_handler_invoked

[PATCH libinput 4/4] Replace log_bug with per-component bug macros

2014-05-22 Thread Peter Hutterer
When we knowingly hit a bug, we should know what the bug is caused by. Log that in a standardized fashion. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 8 src/evdev.c | 8 src/libinput-private.h | 4

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: Hi, First of all, I'm sorry I dropped the ball this long. It's great to see you've been doing some progress. On jue, 2014-05-22 at 01:17 -0400, Chandler Paul wrote: Hi! Sorry this took so long to write, I've been spending a

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Fri, May 23, 2014 at 02:30:45AM -0400, Jasper St. Pierre wrote: On Fri, May 23, 2014 at 2:19 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: Hi, First of all, I'm sorry I dropped the ball this long. It's great

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Thu, May 22, 2014 at 03:37:44PM -0400, Chandler Paul wrote: On Thu, 2014-05-22 at 11:17 -0700, Jason Gerecke wrote: On Wed, May 21, 2014 at 10:17 PM, Chandler Paul thatsly...@gmail.com wrote: Hi! Sorry this took so long to write, I've been spending a lot of my time recently trying

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Fri, May 23, 2014 at 01:43:10AM +0200, Carlos Garnacho wrote: [...] You make a good point with tilt axes below. I think this at least stands true for ABS_PRESSURE, a device with 1024 possible values doesn't register 4x as much pressure as a device with 256 values, those are rather the

Re: [PATCH libinput 2/4] test: restore log priority after each test

2014-05-24 Thread Peter Hutterer
On 23/05/2014 17:11 , Hans de Goede wrote: Hi, On 05/23/2014 06:37 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/log.c | 12 1 file changed, 12 insertions(+) diff --git a/test/log.c b/test/log.c index 0c5508f..b8cc767 100644

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Mon, May 26, 2014 at 02:27:35AM +0200, Carlos Garnacho wrote: Hey Peter, On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: Hi, First of all, I'm sorry I dropped the ball this long. It's great to see

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Fri, May 23, 2014 at 10:34:10PM -0400, Chandler Paul wrote: On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: I'm almost sold on normalization since it does reduce the likelihood of things going wrong. We need to provide the axis resolution to convert back to the real data though

Re: Add basic mouse pointer acceleration libinput patch breaks make check

2014-05-25 Thread Peter Hutterer
On Fri, May 23, 2014 at 05:27:25PM +0200, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: Hi, On 05/23/2014 02:57 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: It might be better to reply to the patch. This

[PATCH libinput] evdev: don't post a relative motion event for dx/dy 0/0

2014-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index fedc324..6aa0d46 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -134,10 +134,12 @@ evdev_flush_pending_event(struct

Re: [PATCH libinput] evdev: don't post a relative motion event for dx/dy 0/0

2014-05-26 Thread Peter Hutterer
On Mon, May 26, 2014 at 08:27:54AM +0200, Jonas Ådahl wrote: On Mon, May 26, 2014 at 03:41:33PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src

Re: Add basic mouse pointer acceleration libinput patch breaks make check

2014-05-26 Thread Peter Hutterer
On Mon, May 26, 2014 at 08:21:35AM +0200, Jonas Ådahl wrote: On Mon, May 26, 2014 at 03:34:46PM +1000, Peter Hutterer wrote: On Fri, May 23, 2014 at 05:27:25PM +0200, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: Hi, On 05/23/2014 02:57 PM

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-26 Thread Peter Hutterer
On 26/05/2014 16:33 , Hans de Goede wrote: Hi, On 05/25/2014 02:13 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: Setting tp-scroll.direction = 0 before checking tp-scroll.direction to see if we need to send stop scroll events for vert / horz scrolling

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-26 Thread Peter Hutterer
On 26/05/2014 16:32 , Hans de Goede wrote: Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical

Re: [RFC libinput] tools: add a tool for GUI-based debugging

2014-05-27 Thread Peter Hutterer
On 27/05/2014 18:09 , Jonas Ådahl wrote: On Tue, May 27, 2014 at 04:45:42PM +1000, Peter Hutterer wrote: Looking at debugging output is nice but not useful when testing for the feel of a device. Add a tool that presents a canvas and draws the various events onto it. --- Still a bit rough

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: I've been away from my computer for most of the (long) weekend up here, so apologies for being a bit quiet :) There's a subtlety on the protocol side of things that can't

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 01:11:31PM -0700, Jason Gerecke wrote: I've been away from my computer for most of the (long) weekend up here, so apologies for being a bit quiet :) On Sun, May 25, 2014 at 7:13 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, May 23, 2014 at 10:34:10PM

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: I've been away from my

Re: Fwd: Re: libxkbcommon compilation instructions

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 03:36:39PM -0700, Bill Spitzak wrote: On 05/25/2014 11:08 PM, Pekka Paalanen wrote: On Sun, 25 May 2014 13:41:08 -0700 Bill Spitzak spit...@gmail.com wrote: On 05/24/2014 12:45 AM, Pekka Paalanen wrote: - --with-xkb-config-root should not be needed, xkeyboard-config

Re: [PATCH libinput 2/2] evdev-mt-touchpad-buttons: Add support for top softbutton area

2014-05-29 Thread Peter Hutterer
; INT_MIN maybe? none of the current TOP_BUTTONPAD devices have a negative y axes but better safe than sorry. I remember one bugreport where a touchpad had a range of [-foo, +bar] though I suspect that was a local kernel issue. tested on the t440s, and Reviewed-by: Peter Hutterer peter.hutte...@who

[PATCH v2 libinput] tools: add a tool for GUI-based debugging

2014-05-29 Thread Peter Hutterer
Looking at debugging output is nice but not useful when testing for the feel of a device. Add a tool that presents a canvas and draws the various events onto it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - switched from xlib to GTK, tested under weston - add LMR

Re: Weston multitouch support?

2014-06-01 Thread Peter Hutterer
On Sun, Jun 01, 2014 at 11:38:02PM +0100, José Expósito wrote: Hi Daniel, I'm asking because I'm the author of this tool: https://code.google.com/p/touchegg/ That is exactly what you mention but for X11. So I'd like to port it to Wayland if it is possible of course. The intention was

Re: [PATCH libinput 2/2] evdev-mt-touchpad-buttons: Add support for top softbutton area

2014-06-01 Thread Peter Hutterer
On Fri, May 30, 2014 at 04:59:22PM +0200, Hans de Goede wrote: Hi, On 05/29/2014 08:53 AM, Peter Hutterer wrote: On Wed, May 28, 2014 at 03:19:56PM +0200, Hans de Goede wrote: Add support for the top softbutton area found on some laptops. For details of how this works, see the updated

Re: [PATCH libinput 0/24] Tablet support

2014-06-01 Thread Peter Hutterer
On Fri, May 30, 2014 at 11:18:08AM -0700, Jason Gerecke wrote: On Thu, May 29, 2014 at 11:45 PM, Daniel Stone dan...@fooishbar.org wrote: On 29 May 2014 18:54, Jason Gerecke killert...@gmail.com wrote: If that's the case though, I have to ask -- *why* on Earth is 'li_fixed_t' even being

[PATCH libinput] Add our own version of linux/input.h

2014-06-02 Thread Peter Hutterer
Avoids having to #define any values we're trying to use. Header file is from Linux 3.15-rc8. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/linux/input.h | 1174 +++ src/Makefile.am |6 +- src/evdev-mt

Re: Weston multitouch support?

2014-06-02 Thread Peter Hutterer
Peter Hutterer peter.hutte...@who-t.net: On Sun, Jun 01, 2014 at 11:38:02PM +0100, José Expósito wrote: Hi Daniel, I'm asking because I'm the author of this tool: https://code.google.com/p/touchegg/ That is exactly what you mention but for X11. So I'd like to port it to Wayland

Re: [RFC libinput] Use floating point numbers instead of fixed point numbers

2014-06-02 Thread Peter Hutterer
: - motion.dx = li_fixed_to_double(device-rel.dx); - motion.dy = li_fixed_to_double(device-rel.dy); + motion.dx = (double) device-rel.dx; + motion.dy = (double) device-rel.dy; the cast here is superfluous. Reviewed-by: Peter Hutterer peter.hutte...@who

[PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-02 Thread Peter Hutterer
, because a bike shed's correct color is green. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-tap.c | 56 +++-- src/evdev-mt-touchpad.h | 1 + test/touchpad.c | 32 ++ 3 files changed, 82

[PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-02 Thread Peter Hutterer
Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 13 + src/libinput.c | 33 +++ src

[PATCH libinput 04/10] Add a config interface for scroll methods

2014-06-02 Thread Peter Hutterer
--- src/libinput-private.h | 9 ++ src/libinput.c | 35 src/libinput.h | 74 ++ 3 files changed, 118 insertions(+) diff --git a/src/libinput-private.h b/src/libinput-private.h index 020167e..d3570a4

[PATCH libinput 01/10] Add an enum for configuration return codes

2014-06-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 32 1 file changed, 32 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index d771e21..c9ec71a 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -1330,6 +1330,38 @@ int

[RFC libinput 00/10] Add a configuration interface

2014-06-02 Thread Peter Hutterer
This is not finished just yet, but I figured I might as well send what I have locally for some early feedback. The tapping and scrolling is already hooked into the touchpad code (even though scrolling is hardcoded), the rest is pretty much just there to show how the config interface would look

[PATCH libinput 05/10] touchpad: hook up scroll config

2014-06-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 43 +++ src/evdev-mt-touchpad.h | 1 + 2 files changed, 44 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 26d5f7d..c1c994a 100644

[PATCH libinput 06/10] Add a config interface to change device rotation

2014-06-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 +++ src/libinput.c | 33 src/libinput.h | 69 ++ 3 files changed, 111 insertions(+) diff --git a/src/libinput

[PATCH libinput 07/10] Add a basic pointer acceleration API

2014-06-02 Thread Peter Hutterer
Only exposes two knobs - speed and precision which have historically been the only two knobs exposed anyway on most UIs. We could go for something fancier but really, I think this will be enough. The only open question is whether speed will be enough for high-dpi devices. Signed-off-by: Peter

[PATCH libinput 08/10] Add a config API for disable-while-typing

2014-06-02 Thread Peter Hutterer
--- src/libinput-private.h | 9 src/libinput.c | 33 + src/libinput.h | 56 ++ 3 files changed, 98 insertions(+) diff --git a/src/libinput-private.h b/src/libinput-private.h index

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids having to #define any values we're trying to use. Header file is from Linux 3.15-rc8. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Wouldn't

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:21 , Pekka Paalanen wrote: On Tue, 03 Jun 2014 00:06:40 -0700 Thiago Macieira thi...@kde.org wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:06 , Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids having to #define any values we're trying to use. Header

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
this afternoon Weston to have a look to the libinput implementation 2014-06-03 0:25 GMT+01:00 Peter Hutterer peter.hutte...@who-t.net mailto:peter.hutte...@who-t.net: On Mon, Jun 02, 2014 at 12:45:51PM +0100, José Expósito wrote: Hi Peter, I have checked the libinput implementation

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
On 3/06/2014 20:25 , Shawn Rutledge wrote: On 3 June 2014 01:25, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Jun 02, 2014 at 12:45:51PM +0100, José Expósito wrote: Hi Peter, I have checked the libinput implementation and, correct me if I'm wrong, I have seen that 2 fingers click

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 10:42:50PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled while

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 08:54:38AM -0400, Jasper St. Pierre wrote: I think it should be #include linux/input.h at the very least. a_header_file.h has always meant system library to me. amended locally, thanks. Cheers, Peter On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer peter.hutte...@who

<    1   2   3   4   5   6   7   8   9   10   >