Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
...@kde.org wrote: Em ter 03 jun 2014, às 19:32:06, Peter Hutterer escreveu: The current situation is vague, and this patch probably is not intended to fix that at all, but is there a plan? Or is it expected that other OSs implement their own libinput or something? No, other OS can

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 02:13:47PM +0200, Shawn Rutledge wrote: On 3 June 2014 13:16, Peter Hutterer peter.hutte...@who-t.net wrote: On 3/06/2014 20:25 , Shawn Rutledge wrote: ... the synaptics driver does support multitouch and gives you the same type of events as any MT device

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-03 Thread Peter Hutterer
libinput_button_state allows it to be reused by other devices that may potentially be added to libinput in the future. Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com this looks good to me, and saves us from introducing a separate but same enum for the tablet buttons. Reviewed-by: Peter

[PATCH libinput] touchpad: Drop the scroll direction lock, increase threshold instead

2014-06-03 Thread Peter Hutterer
a little. It doesn't totally avoid horizontal scroll events but keeps them minimal. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Ok, I give up. I thought I could find a simple way of locking the scroll directions but I ran out of time and the simplest approach didn't work that greatly

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Peter Hutterer
On 4/06/2014 18:40 , Hans de Goede wrote: Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 10:40:10PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM -0400, Stephen Chandler Paul wrote: Button states are applicable to more then just the pointer, so having a non-generic name name

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Peter Hutterer
On Thu, Jun 05, 2014 at 12:21:52AM +0200, Jonas Ådahl wrote: On Thu, Jun 05, 2014 at 07:45:00AM +1000, Peter Hutterer wrote: On Wed, Jun 04, 2014 at 10:40:10PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 10:57:36PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: On 06/03/2014 07:34 AM, Peter Hutterer wrote: [...] @@ -583,9 +580,56 @@ tp_tap_handle_timeout(struct tp_dispatch *tp, uint64_t time) return tp-tap.timeout

Re: [PATCH libinput 1/3] Add a timer subsystem

2014-06-04 Thread Peter Hutterer
and in libinput_timer_set that this is in abstime, not reltime. + void (*timer_func)(uint64_t now, void *timer_func_data); + void *timer_func_data; +}; series: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net with Jonas' comments and the above addressed. two other things

[PATCH libinput 3/8] test: fix compiler warnings for missing prototypes

2014-06-06 Thread Peter Hutterer
litest-wacom-touch.c:31:6: warning: no previous prototype for 'litest_wacom_touch_setup' [-Wmissing-prototypes] and similar Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-synaptics-st.c | 3 ++- test/litest-synaptics.c| 3 ++- test/litest-wacom-touch.c | 3 ++- 3

[PATCH libinput 5/8] test: silence compiler warning for C++ build test

2014-06-06 Thread Peter Hutterer
is built with the correct CFLAGS too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac | 4 +++- test/Makefile.am | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ec9b0de..0e4cecc 100644 --- a/configure.ac +++ b

[PATCH libinput 6/8] test: drop TEST_CFLAGS

2014-06-06 Thread Peter Hutterer
We're using the same flags for everything anyway, drop the custom flags Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 53a3300..70e83d4 100644

[PATCH libinput 7/8] test: add --verbose flag to litests

2014-06-06 Thread Peter Hutterer
Sometimes it's handy to see what libinput prints out while running a test. This breaks test-log if run with --verbose. Checking that the default log priority hasn't changed obviously doesn't work if we change it on demand. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c

[PATCH libinput 8/8] Mark the log function as attribute printf

2014-06-06 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index d771e21..b4cb5e5 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -31,6 +31,9 @@ extern C { #include

[PATCH libinput 6/6] test: add a couple of top software button test

2014-06-10 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 124 1 file changed, 124 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index 7b7cb7d..147d0e2 100644 --- a/test/touchpad.c +++ b/test/touchpad.c

[PATCH libinput 1/6] touchpad: always call into the the tap state machine

2014-06-10 Thread Peter Hutterer
that a button event has occured and process that accordingly. Depending on the state this may either continue to the DEAD state or release the current tap button and then go to the DEAD state. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 9 - 1 file

[PATCH libinput 2/6] test: add litest_assert_empty_queue helper function

2014-06-10 Thread Peter Hutterer
Checks if the queue is empty and prints informatino about any events before failing. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c | 61 + test/litest.h | 1 + test/touchpad.c | 9 ++--- 3 files changed

[PATCH libinput 3/6] test: add a bunch of test for click behavior on touchpads

2014-06-10 Thread Peter Hutterer
Mainly testing the behaviour when clicking during a tap or tap-n-drag. Adds a new feature to the litest system, Apple clickpads don't have software buttons by default. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-bcm5974.c | 3 +- test/litest.h | 1 + test

Re: [PATCH libinput 1/2] Add a log_msg_va function

2014-06-10 Thread Peter Hutterer
On Tue, Jun 10, 2014 at 03:08:03PM +0200, Hans de Goede wrote: This is useful for when we use libraries which want us to provide them with a logging callback. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 3 +++ src/libinput.c | 16 +++-

Re: [PATCH libinput 3/6] test: add a bunch of test for click behavior on touchpads

2014-06-11 Thread Peter Hutterer
On Wed, Jun 11, 2014 at 10:48:07AM +0200, Hans de Goede wrote: Hi, On 06/11/2014 02:11 AM, Peter Hutterer wrote: Mainly testing the behaviour when clicking during a tap or tap-n-drag. Adds a new feature to the litest system, Apple clickpads don't have software buttons by default

[PATCH libinput 1/3] test: move the interface declaration down

2014-06-12 Thread Peter Hutterer
No functional changes, just some prep work. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/test/litest.c b/test/litest.c index 0a9cc72..d3f8f0d 100644 --- a/test

[PATCH libinput 3/3] Change the logging system to be per-context

2014-06-12 Thread Peter Hutterer
. There is no need for a default log function anymore. Any serious caller should hook into it anyway, those that don't care can just use NULL. There is no default log priority anymore, a caller must set the desired priority in the interface. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- There's

[PATCH libinput 2/3] udev: split libinput_udev context init into two functions

2014-06-12 Thread Peter Hutterer
this enables a caller to set the log handler for a context before any devices are initialized. Otherwise, a log message generated by a new device may pass a libinput context that the caller is not yet aware of. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- doc/libinput.doxygen.in | 3

[PATCH libinput 0/3] Per-context log handlers

2014-06-12 Thread Peter Hutterer
This work was motivated by libevdev, which too started out with a global log handler, and that's biting us now. libevdev is lower-level than libinput, so there's a higher chance

Re: [PATCH libinput 02/23] evdev: Add basic support for tablet devices

2014-06-15 Thread Peter Hutterer
. + * For tablet events that are not of type LIBINPUT_EVENT_TABLET_AXIS, needs a @ref + * this function returns 0. + * + * @note It is an application bug to call this function for events other than + * LIBINPUT_EVENT_TABLET_AXIS. needs a @ref Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput 03/23] tools: handle TABLET_EVENT_AXIS in event-debug

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:24PM -0400, Stephen Chandler Paul wrote: Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 38 -- 1 file changed, 36 insertions(+), 2

Re: [PATCH libinput] Emit LIBINPUT_TABLET_EVENT_TOOL_UPDATE events on tool changes

2014-06-15 Thread Peter Hutterer
for this event. + * For tablet events that are not of type @ref + * LIBINPUT_EVENT_TABLET_TOOL_UPDATE, this function returns NULL. By default, + * the lifetime of each tool is binded to the lifetime of the event, so the tool is bound with the changes above Reviewed-by: Peter Hutterer peter.hutte

Re: [PATCH libinput 21/23] test: Add motion event test for tablets

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:42PM -0400, Stephen Chandler Paul wrote: Based off the patch originally written by Carlos Garnacho Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com --- test/tablet.c | 65 ++- 1 file changed,

Re: [PATCH libinput 20/23] test: Add proximity-in-out and proximity-out-clear-buttons tests

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:41PM -0400, Stephen Chandler Paul wrote: This tests to make sure proximity events actually work, that they don't output cooirdinate events after they occur, and that they make sure to release all of the buttons and clear the values of all the axes Based off the

Re: [PATCH libinput 12/23] Sanitize distance and pressure axes before reporting their values

2014-06-15 Thread Peter Hutterer
be on the left even though I know what it should in this context. otherwise Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter + + /* Fall through */ case ABS_DISTANCE: axis = evcode_to_axis(e-code); if (axis == LIBINPUT_TABLET_AXIS_NONE

Re: [PATCH libinput 22/23] test: Add bad-distance-events test

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:43PM -0400, Stephen Chandler Paul wrote: There's a special distance on wacom tablets where the stylus is close enough to be (sort of) recongnized by the tablet, but not close enough to send any useful data. When the pen's in this distance, it will send a

Re: [PATCH libinput] tablet: Handle button-events

2014-06-15 Thread Peter Hutterer
the mask, just move it up by those couple of lines. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter +} + +static void tablet_process_key(struct tablet_dispatch *tablet, struct evdev_device *device, struct input_event *e, @@ -127,7 +163,11

Re: [PATCH libinput 07/23] Emit LIBINPUT_EVENT_TABLET_PROXIMITY_OUT when tool leaves proximity

2014-06-15 Thread Peter Hutterer
anymore. It has no context in this patch and the next patch makes it obvious before we even get here, so just drop this line. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter + if (tablet_has_status(tablet, TABLET_TOOL_LEAVING_PROXIMITY

Re: [PATCH libinput 00/23] Revised: Tablet support in libinput

2014-06-15 Thread Peter Hutterer
I didn't comment on gets my Reviewed-by: Peter Hutterer peter.hutte...@who-t.net most of the comments are minor changes, once you fixed them up please give me a branch to pull from and I'll merge them locally. From then on we'll do the rest as follow-ups. * Tablet events are now in their own

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-16 Thread Peter Hutterer
On Mon, Jun 16, 2014 at 12:09:16PM +0200, Hans de Goede wrote: [...] Your removing a bunch of exported symbols here, so you should also bump the soname to indicate ABI breakage. Jonas - do you want the soname bump in this patch or do it as part of the release? There may be other changes

[PATCH libinput] Rename KEYBOARD_KEY_STATE to KEY_STATE

2014-06-16 Thread Peter Hutterer
e912d620d0f20f415b4d3dde967648e4b9c317b9 changed from POINTER_BUTTON_STATE to simply BUTTON_STATE, replicate that for key events too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- API break, so best to be grouped with the logging changes. src/evdev.c| 4 ++-- src

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-17 Thread Peter Hutterer
On Tue, Jun 17, 2014 at 11:20:00PM +0200, Jonas Ådahl wrote: On Fri, Jun 13, 2014 at 12:48:33PM +1000, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-18 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 09:24:03AM +0200, Jonas Ådahl wrote: The purpose of the struct was to provide an interface with the functionality that libinput would require to have to function without having to be root, and it doesn't feel logging function fits this purpose. It was already a

Re: [PATCH libinput 2/2] evdev-mt-touchpad: tp_current_touch: Fix off by one error

2014-06-18 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 02:22:24PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 0294eb2..92e0651 100644

Re: [PATCH libinput 1/2] evdev: Safe x and y resolution for later use

2014-06-18 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 02:22:23PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev.c | 2 ++ src/evdev.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 51ad5e3..b72e5e1 100644 ---

[PATCH libinput 4/4] Add a function to get the size of a device

2014-06-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 19 +++ src/evdev.h | 5 + src/libinput.c | 10 ++ src/libinput.h | 19 +++ tools/event-debug.c | 8 +++- 5 files changed, 60 insertions(+), 1

[PATCH libinput 1/4] evdev: keep the absinfo struct around instead of min/max

2014-06-18 Thread Peter Hutterer
We'll need that later for conversion to mm. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 20 +--- src/evdev-mt-touchpad.c | 6 -- src/evdev.c | 25 + src/evdev.h

[PATCH libinput v2 3/3] Change the logging system to be per-context

2014-06-18 Thread Peter Hutterer
to the libinput context now, any userdata can be attached to that context instead. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 15 +-- src/evdev-mt-touchpad-tap.c | 13 -- src/evdev.c | 23 +++ src/libinput

Re: [PATCH libinput 1/4] evdev: Continue updating axes internally when tool leaves proximity

2014-06-19 Thread Peter Hutterer
On Thu, Jun 19, 2014 at 01:18:06AM -0400, Stephen Chandler Paul wrote: Axis changes are now still processed by libinput regardless of whether or not the tool is in proximity, however we refrain from reporting them unless the tool is in proximity. This stops bad distance events from being

Re: [PATCH libinput v2 3/3] Change the logging system to be per-context

2014-06-19 Thread Peter Hutterer
On Thu, Jun 19, 2014 at 10:02:30AM +0200, Hans de Goede wrote: Hi, On 06/19/2014 06:57 AM, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly unusual

Re: [PATCH libinput v2 3/3] Change the logging system to be per-context

2014-06-19 Thread Peter Hutterer
On Thu, Jun 19, 2014 at 12:49:08PM +0200, Hans de Goede wrote: Hi, On 06/19/2014 10:34 AM, Peter Hutterer wrote: On Thu, Jun 19, 2014 at 10:02:30AM +0200, Hans de Goede wrote: Hi, On 06/19/2014 06:57 AM, Peter Hutterer wrote: Rather than a single global logging function, make

[PATCH libinput 1/3] Add msleep() helper function

2014-06-22 Thread Peter Hutterer
For those whose eyes struggle to focus on 5 zeros in a row, or those just sick of forgetting one zero and wondering why things don't work. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-util.h | 8 test/touchpad.c | 12 ++-- 2 files changed, 14

[PATCH libinput 3/3] tablet: ignore pad buttons

2014-06-22 Thread Peter Hutterer
We've got big plans for handling pad buttons, and the interface will likely be different for those. Meanwhile, discard any pad button events so no-one can get too used to them. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 14 -- src/evdev-tablet.h

[PATCH libinput 1/3] tablet: provide x/y by default in mm off the top/left corner

2014-06-22 Thread Peter Hutterer
Given that tablets may not have the same x/y resolution, raw or normalized values are mostly meaningless and likely to be handled the wrong way. Providing x/y in mm is the only constant, meaningful value. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 3 +++ src

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-22 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 10:07:12AM +0200, Jonas Ådahl wrote: On Wed, Jun 18, 2014 at 05:52:04PM +1000, Peter Hutterer wrote: On Wed, Jun 18, 2014 at 09:24:03AM +0200, Jonas Ådahl wrote: The purpose of the struct was to provide an interface with the functionality that libinput would

Re: [PATCH libinput 1/3] Add msleep() helper function

2014-06-23 Thread Peter Hutterer
two of these diamonds, one in General, one in Flowchart and only the latter seems to render correctly with text inside. Fixed. Other then that this patch-set looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com thanks. Cheers, Peter On 06/23/2014 01:36 AM, Peter Hutterer

Re: [PATCH libinput 2/3] tablet: normalize the distance to 0..1

2014-06-23 Thread Peter Hutterer
On Mon, Jun 23, 2014 at 01:08:42PM +0200, Hans de Goede wrote: Hi, On 06/23/2014 06:16 AM, Peter Hutterer wrote: The actual data provided by current tablets is not anywhere close to accurate. While it'd be nice to have this in mm, this is unlikely to happen anytime soon. Use the same

Re: [PATCH libinput 1/3] Make ref count unref/ref() functions return resulting object pointer

2014-06-24 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 12:06:57AM +0200, Jonas Ådahl wrote: In order to know if an unref() destroyed an object and to allow more convenient use of ref(), make both functions return a pointer to the object it was passed, or NULL if that object was destroyed. Signed-off-by: Jonas Ådahl

Re: [PATCH libinput 5/5] timer: Complain if a timer is set more then 5 seconds from now

2014-06-24 Thread Peter Hutterer
On Tue, Jun 24, 2014 at 04:23:13PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Did some minor changes before merging: * two typos fixed s/then/than/ in 2/5 and this one * adding timer-libinput as first arg to log_* in this patch, I merged it on top of the

Re: [PATCH libinput] touchpad: Fix typo in documentation

2014-06-24 Thread Peter Hutterer
On Tue, Jun 24, 2014 at 06:55:25PM -0400, Stephen Chandler Paul wrote: a a left and…-a left and… Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com merged, thanks. Cheers, Peter --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ANNOUNCE] libinput 0.4.0

2014-06-24 Thread Peter Hutterer
more than 5 seconds from now Jonas Ådahl (5): doc: Fix spelling event-gui: Don't drop fraction of pointer motion events Make ref count unref/ref() functions return resulting object pointer Make context reference counted test: Add context reference counting test Peter

[PATCH weston] Require libinput 0.4.0

2014-06-24 Thread Peter Hutterer
No functional changes, just adjusting for API changes in libinput: - libinput_destroy() replaced by libinput_unref() - log functions now take a libinput context, userdata is gone - udev seat creation is now libinput_udev_create_context() and libinput_udev_assign_seat() Signed-off-by: Peter

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Peter Hutterer
is here: http://lists.freedesktop.org/archives/wayland-devel/2014-June/015590.html Cheers, Peter I'm on an Intel laptop that built weston on pure wayland 'till yesterday, any idea what could cause this? Thanks On Tue, Jun 24, 2014 at 9:06 PM, Peter Hutterer peter.hutte...@who-t.net

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Peter Hutterer
Regards On Tue, Jun 24, 2014 at 11:16 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jun 24, 2014 at 11:11:41PM -0700, Andrea Giammarchi wrote: 1. congratulations! 2. I cannot build weston anymore, it complained about the RPI backend compositor first, and now it's

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 02:06:32PM +1000, Peter Hutterer wrote: A new release of libinput, 0.4, is available. [...] git tag: 0.4.0 http://wayland.freedesktop.org/releases/libinput-0.4.0.tar.xz MD5: 60969c60e11792fab4ecaa7222f43697 libinput-0.4.0.tar.xz SHA1

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 08:56:55AM -0400, Jasper St. Pierre wrote: On Wed, Jun 25, 2014 at 2:59 AM, Lyude thatsly...@gmail.com wrote: On Tue, 2014-06-24 at 23:40 -0700, Andrea Giammarchi wrote: Yeah Peter, I know how to apply a patch and no, I don't have any of them in my inbox, that's

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 12:07:07PM -0700, Bill Spitzak wrote: Reading gmail using a local client works fine, I have done several git am calls using this, after doing save-as to the email. That said, it may be a nice idea to not update the master for weston at the same time the master for

Re: Comments about adding tablet support to Wayland

2014-06-25 Thread Peter Hutterer
Replying to three emails at once here to keep the thread a bit more managable. On Wed, Jun 25, 2014 at 01:38:22PM -0700, Jason Gerecke wrote: On Wed, Jun 25, 2014 at 12:38 AM, Lyude thatsly...@gmail.com wrote: On Wed, 2014-06-25 at 11:06 +0400, Dmitry Kazakov wrote: Hi, all! I am a

Re: [PATCH libinput 1/3] tablet: Stop redundant proximity-out events from being reported

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 02:30:15AM -0400, Stephen Chandler Paul wrote: Because bad distance events still trigger calls to tablet_flush(), tablet_flush() will see that the tablet is out of proximity and assume it's an appropriate time to send a proximity-out event, even when we've already sent

Re: [PATCH libinput 2/3] tablet: Replace tool-update with proximity-in

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 02:30:16AM -0400, Stephen Chandler Paul wrote: A proximity-in event is something we want, especially since the current drafted wayland spec has a proximity-in event. Adding this also makes our events more consistent. And since we can just report the current tool in use

Re: [PATCH libinput 3/3] tablet: Fix warnings in test/tablet.c

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 02:30:17AM -0400, Stephen Chandler Paul wrote: Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com merged, thanks. Cheers, Peter --- test/tablet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/tablet.c b/test/tablet.c index

Re: wl_tablet specification draft

2014-06-25 Thread Peter Hutterer
On Wed, Jun 25, 2014 at 08:22:21PM -0700, Jason Ekstrand wrote: On 06/25/2014 06:05 PM, Peter Hutterer wrote: On Wed, Jun 25, 2014 at 03:19:02PM +0300, Pekka Paalanen wrote: On Tue, 24 Jun 2014 21:56:09 -0400 Chandler Paul thatsly...@gmail.com wrote: Hello! As you all know I've been

Re: wl_tablet specification draft

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 09:23:51AM +0300, Pekka Paalanen wrote: On Thu, 26 Jun 2014 14:14:33 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: [...] good point, thanks! - Name: time Type: uint The time of the event with millisecond granularity

Re: wl_tablet specification draft

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: Hi, it seems you forgot to reply-to-all, so I have re-added everyone and not trimmed the quotation. On Wed, 25 Jun 2014 18:37:08 -0400 Lyude thatsly...@gmail.com wrote: On Wed, 2014-06-25 at 15:19 +0300, Pekka Paalanen

Re: [PATCH libinput v2 2/5] tablet: Replace tool-update with proximity-in

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:31:19AM -0400, Stephen Chandler Paul wrote: A proximity-in event is something we want, especially since the current drafted wayland spec has a proximity-in event. Adding this also makes our events more consistent. And since we can just report the current tool in use

Re: [PATCH libinput 4/5] tablet: remove libinput_tool_(un)ref()

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:31:21AM -0400, Stephen Chandler Paul wrote: Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com sorry, this must've been a misunderstanding on IRC: I didn't mean remove those - I was referring to we don't need the ref/unref when adding the tool to the other

Re: [PATCH libinput 3/5] tablet: Include tool with all events

2014-06-26 Thread Peter Hutterer
as it is Drop the lifetime of from this sentence. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter + * being used, and is destroyed when another tool comes into proximity. However, + * the lifetime of the tool may be extended by using libinput_tool_ref() to * increment

[PATCH libinput] tablet: copy the axis state into the tablet event

2014-06-26 Thread Peter Hutterer
The tablet state updates with each event during libinput_dispatch(), but the state in the event must reflect the state at the time of the event. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 4 +-- test/tablet.c | 83

Re: [PATCH libinput v3 1/5] tablet: Stop redundant proximity-out events from being reported

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:48PM -0400, Stephen Chandler Paul wrote: Because bad distance events still trigger calls to tablet_flush(), tablet_flush() will see that the tablet is out of proximity and assume it's an appropriate time to send a proximity-out event, even when we've already sent

Re: [PATCH libinput v3 1/5] tablet: Stop redundant proximity-out events from being reported

2014-06-26 Thread Peter Hutterer
On Fri, Jun 27, 2014 at 09:00:21AM +1000, Peter Hutterer wrote: On Thu, Jun 26, 2014 at 06:02:48PM -0400, Stephen Chandler Paul wrote: Because bad distance events still trigger calls to tablet_flush(), tablet_flush() will see that the tablet is out of proximity and assume it's

Re: [PATCH libinput 2/5] tablet: Remove tablet_notify_tool() and add tablet_get_tool()

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:49PM -0400, Stephen Chandler Paul wrote: Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com Having a hard time spotting what the changes are in this patch, this looks to be almost the same patch as the previous patch [PATCH libinput 2/3] tablet: Replace

Re: [PATCH libinput 4/5] tablet: copy the axis state into the tablet event

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:51PM -0400, Stephen Chandler Paul wrote: From: Peter Hutterer peter.hutte...@who-t.net The tablet state updates with each event during libinput_dispatch(), but the state in the event must reflect the state at the time of the event. Signed-off-by: Peter

Re: [PATCH libinput v2 5/5] tablet: Include axes with all events

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:52PM -0400, Stephen Chandler Paul wrote: Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net with the foo - foo changes in the memcpy. Cheers, Peter --- src/evdev-tablet.c | 11 +-- src

[PATCH libinput] Add functions to get the device name, PID and VID

2014-06-26 Thread Peter Hutterer
Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 18 ++ src/evdev.h| 9 + src/libinput.c | 18 ++ src/libinput.h

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-06-29 Thread Peter Hutterer
On Fri, Jun 27, 2014 at 10:10:30AM -0700, Jason Gerecke wrote: On Thu, Jun 26, 2014 at 8:02 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer

Re: wl_tablet specification draft

2014-06-30 Thread Peter Hutterer
On 30/06/2014 16:33 , Pekka Paalanen wrote: On Mon, 30 Jun 2014 11:08:35 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Jun 28, 2014 at 12:41:33PM +0300, Pekka Paalanen wrote: On Fri, 27 Jun 2014 13:04:59 -0700 Bill Spitzak spit...@gmail.com wrote: [...] - The pen moves

Re: wl_tablet specification draft

2014-06-30 Thread Peter Hutterer
On 30/06/2014 20:23 , Pekka Paalanen wrote: On Mon, 30 Jun 2014 09:33:15 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 30 Jun 2014 11:08:35 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Jun 28, 2014 at 12:41:33PM +0300, Pekka Paalanen wrote: On Fri, 27 Jun 2014 13

Re: [PATCH libinput 1/2] touchpad: Simplify tp_hysteresis

2014-06-30 Thread Peter Hutterer
On Mon, Jun 30, 2014 at 02:27:18PM +0200, Hans de Goede wrote: Once we get beyond the: if (abs(diff) = margin) return center; test, then diff is either margin or -margin, otherwise the test would have triggered. So the return center + diff; at the end will never

Re: [PATCH libinput 2/2] evdev-mt-touchpad: Switch to smooth simple acceleration code from filter.c

2014-06-30 Thread Peter Hutterer
On Mon, Jun 30, 2014 at 02:27:19PM +0200, Hans de Goede wrote: The old touchpad accel code was clamping touchpad acceleration between 0.2 and 0.4, and on the test devices I have the constant_factor ended up such that in practice the accel was almost always 0.2, so rather then having typo: than

Re: wl_tablet specification draft

2014-06-30 Thread Peter Hutterer
On Mon, Jun 30, 2014 at 06:55:25PM -0700, Bill Spitzak wrote: On 06/30/2014 12:46 AM, Pekka Paalanen wrote: I was assuming the enter event contains enough information to know which device is causing it. It is the wl_pointer of a specific wl_seat:

Re: Comments about adding tablet support to Wayland

2014-06-30 Thread Peter Hutterer
, Jun 25, 2014 at 5:50 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Replying to three emails at once here to keep the thread a bit more managable. On Wed, Jun 25, 2014 at 01:38:22PM -0700, Jason Gerecke wrote: On Wed, Jun 25, 2014 at 12:38 AM, Lyude thatsly...@gmail.com wrote

[PATCH v2 libinput 0/3] Config interface - tapping

2014-06-30 Thread Peter Hutterer
Now that Hans is almost done with the touchpad accel code, let's get the configuration interface in as well so we can tweak things at runtime. This is the first configuration option that we actually need, I'll hold the others back until the backend for them is more than a FIXME or hardcoded

[PATCH v2 libinput 3/3] touchpad: hook up to the tapping configuration

2014-06-30 Thread Peter Hutterer
, for two reasons: * if you don't know that tapping is a thing (or enabled by default), you get spurious button events that make the desktop feel buggy. * if you do know what tapping is and you want it, you usually know where to enable it, or at least you can search for it. Signed-off-by: Peter

[PATCH v2 libinput 2/3] Add an interface to enable/disable tapping

2014-06-30 Thread Peter Hutterer
Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - change to a simple enabled/disabled config src/libinput-private.h | 13 + src

[PATCH v2 libinput 1/3] Add an enum for configuration return codes

2014-06-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - actually implement libinput_config_status_to_str - add a basic test for it src/libinput.c | 20 src/libinput.h | 33 + test/misc.c| 23 +++ 3

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-07-01 Thread Peter Hutterer
On Tue, Jul 01, 2014 at 08:49:56PM +0200, jad...@gmail.com wrote: On Fri, Jun 27, 2014 at 01:02:11PM +1000, Peter Hutterer wrote: Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer peter.hutte...@who

Re: [PATCH v2 libinput 2/3] Add an interface to enable/disable tapping

2014-07-01 Thread Peter Hutterer
On Tue, Jul 01, 2014 at 08:23:23PM +0200, jad...@gmail.com wrote: On Tue, Jul 01, 2014 at 03:56:20PM +1000, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter

Re: [PATCH libinput 2/2] evdev-mt-touchpad: Switch to smooth simple acceleration code from filter.c

2014-07-01 Thread Peter Hutterer
On Tue, Jul 01, 2014 at 02:32:56PM +0200, Hans de Goede wrote: Hi, On 07/01/2014 06:33 AM, Peter Hutterer wrote: snip The idea is interesting. Indeed on the T440 with a relatively large and square-ish touchpad, this is much better now. On the x220 with a small 16:10 ratio touchpad

Re: [PATCH libinput v2] evdev-mt-touchpad: Switch to smooth simple acceleration code from filter.c

2014-07-01 Thread Peter Hutterer
On Tue, Jul 01, 2014 at 02:53:18PM +0200, Hans de Goede wrote: The old touchpad accel code was clamping touchpad acceleration between 0.2 and 0.4, and on the test devices I have the constant_factor ended up such that in practice the accel was almost always 0.2, so rather than having a velocity

[PATCH libinput 2/2] touchpad: reduce button size, use physical sizes where possible

2014-07-02 Thread Peter Hutterer
size, but prefer a physical size of 6mm instead (which is 1mm below the button marker line on the T440s). If no y resolution is available, fall back to the 8% which is 5.6mm on the T440s. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- 10mm height doesn't sound like much at first, but given

[PATCH wayland 1/3] doc: reduce chunk_section_depth to 0

2014-07-02 Thread Peter Hutterer
One html page per chapter. --- doc/publican/publican.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/publican.cfg b/doc/publican/publican.cfg index 0bc8a7e..ccb9f04 100644 --- a/doc/publican/publican.cfg +++ b/doc/publican/publican.cfg @@ -6,4 +6,4 @@ type:

[PATCH wayland 2/3] doc: force publican to use fop

2014-07-02 Thread Peter Hutterer
Because wkhtmltopdf requires a $DISPLAY, and a patched Qt. https://bugzilla.redhat.com/show_bug.cgi?id=997682 --- doc/publican/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index bf143c8..a20b1d3 100644 ---

[PATCH wayland 3/3] configure: fix publican version detection

2014-07-02 Thread Peter Hutterer
Publican now adds a spurious v to the version output. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c7ccace..e16c5b5 100644 --- a/configure.ac +++ b/configure.ac @@ -112,7 +112,7 @@ if test x$enable_documentation = xyes;

[PATCH libinput 2/6] test: fix expected delta from relative motion

2014-07-07 Thread Peter Hutterer
fail this test but we can fix that when needed. Pointer acceleration is subject to timing changes. When running tests in valgrind pointer accel timeouts and tracker resets may happen so we can't guarantee a specific acceleration length. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH libinput 6/6] accel_profile_smooth_simple: Make 0.0-1.0 accel range depend on threshold

2014-07-07 Thread Peter Hutterer
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/filter.c b/src/filter.c index 8192dd0..6fbd4d9 100644 --- a/src/filter.c +++ b/src/filter.c @@ -343,8

<    1   2   3   4   5   6   7   8   9   10   >