Re: [PATCH libinput 7/7] touchpad: Make tap code follow state machine diagram part 3

2014-11-03 Thread Peter Hutterer
On Sun, Sep 28, 2014 at 01:22:23PM +0200, Hans de Goede wrote: We should only mark touches dead on a button click if we're dealing with a clickpad. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for the series, but it conflicts because

Re: [PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:00:06AM -0600, Derek Foreman wrote: On 03/11/14 09:51 PM, Peter Hutterer wrote: On Mon, Nov 03, 2014 at 11:56:59AM +0100, David Herrmann wrote: Hi On Fri, Oct 31, 2014 at 5:33 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Oct 30, 2014 at 04:34

[PATCH libinput 1/4] evdev: factor out resolution changing code

2014-11-04 Thread Peter Hutterer
No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 57 - 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 3aa87a7..ecf105d 100644 --- a/src/evdev.c

[PATCH libinput 3/4] evdev: handle fake MT devices

2014-11-04 Thread Peter Hutterer
an empty if body. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=85836 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net CC: Leonid Borisenko leo.borise...@gmail.com --- src/evdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c

[PATCH libinput 2/4] evdev: move a comment to where it belongs

2014-11-04 Thread Peter Hutterer
And s/weston/libinput/ while we're at it Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index ecf105d..bda6af4 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1096,9 +1096,6

Re: [PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:35:37AM +0100, David Herrmann wrote: This adds struct ratelimit and ratelimit_test(). It's a very simple rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. This comes in handy to limit log-messages in possible busy loops etc.. Signed-off-by:

Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:35:38AM +0100, David Herrmann wrote: Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we will still receive SYN_DROPPED log-messages after multiple days of runtime, even though there might have been a SYN_DROPPED flood at one point in time.

Re: [PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 12:30:32PM +0100, David Herrmann wrote: On Wed, Nov 5, 2014 at 6:11 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 04, 2014 at 09:35:37AM +0100, David Herrmann wrote: This adds struct ratelimit and ratelimit_test(). It's a very simple rate-limit

[PATCH libinput] Add pointer axis sources to the API

2014-11-05 Thread Peter Hutterer
map into relative motion if the device itself is not controlling absolute motion. * For diagonal scrolling, the vertical/horizontal terminator events would come in separately. The caller would have to deal with that somehow. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev

Re: [PATCH libinput v3] touchpad: Fix log_bug_libinput calls on tap enable with fingers down

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 10:48:59AM +0100, Hans de Goede wrote: Before this commit the tap code deals with enabled being set to false, by waiting for tap.state to become IDLE, and then ignoring any events from that point on. This causes a problem when enabled gets set to true again while

Re: [PATCH libinput v2 1/2] util: introduce ratelimit helpers

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 01:32:16PM +0100, David Herrmann wrote: This adds struct ratelimit and ratelimit_test(). It's a very simple rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. This comes in handy to limit log-messages in possible busy loops etc.. Signed-off-by:

[PATCH v3 libinput] util: introduce ratelimit helpers

2014-11-06 Thread Peter Hutterer
...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- The test succeeded but not in valgrind which slows everything down enough that we didn't trigger the rate limit (valgrind is part of make check). I though of adding extra flags

Re: [PATCH v3 libinput] util: introduce ratelimit helpers

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 11:46:30PM +0100, David Herrmann wrote: Hi On Thu, Nov 6, 2014 at 11:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote: From: David Herrmann dh.herrm...@gmail.com This adds struct ratelimit and ratelimit_test(). It's a very simple rate-limit helper modeled

[PATCH libinput 5/6] test: add Xen Virtual Pointer device

2014-11-06 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-xen-virtual-pointer.c | 106 ++ test/litest.c | 2 + test/litest.h | 1 + 4 files changed, 110

[PATCH libinput 6/6] test: add VMWare Virtual USB Mouse device

2014-11-06 Thread Peter Hutterer
Yes, the name has VMware twice, not a typo. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-vmware-virtual-usb-mouse.c | 115 + test/litest.c | 2 + test/litest.h

[PATCH libinput 4/6] test: add test for absolute pointer motion

2014-11-06 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/pointer.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 4387526..52d812f 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -102,6 +102,44

[PATCH libinput 3/6] test: add QEMU tablet as test device

2014-11-06 Thread Peter Hutterer
without people noticing. They're special in that they have absolute x/y axes but relative wheels. For libinput that's not as much of a problem as it is in X but let's add them anyway. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-qemu

[PATCH libinput 1/6] evdev: don't ignore REL_HWHEEL values over 1

2014-11-06 Thread Peter Hutterer
Matching patch for REL_WHEEL is 09a3770961aad0973, not sure why I didn't do both at the same time. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index

[PATCH libinput 2/6] test: rename LITEST_POINTER to LITEST_RELATIVE

2014-11-06 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/device.c | 4 ++-- test/litest-mouse.c| 2 +- test/litest-ms-surface-cover.c | 2 +- test/litest-trackpoint.c | 2 +- test/litest.h | 2 +- test/pointer.c | 8

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 11:41:20AM -0800, Bill Spitzak wrote: It sure seems like an api that returned a list of all the keycodes the device has would be better. It looks like the client has to try every possible keycode to find out what exists with this. what is the caller (which is not a wl

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 05:46:26PM -0800, Bill Spitzak wrote: On 11/06/2014 05:17 PM, Peter Hutterer wrote: On Thu, Nov 06, 2014 at 11:41:20AM -0800, Bill Spitzak wrote: It sure seems like an api that returned a list of all the keycodes the device has would be better. It looks like

Re: [PATCH 07/11] touchpad: Hookup scroll-mode configuration

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:36PM +0100, Hans de Goede wrote: Default to 2fg scrolling for now, once we have edge-scrolling we can default to edge-scrolling on touchpads which cannot detect more then 1 touch. s/then/than/ Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [PATCH 03/11] Add configuration option to select scroll mode

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:32PM +0100, Hans de Goede wrote: Add a configuration option to allow selecting between 2-finger / edge / none scrolling (for touchpads). Signed-off-by: Hans de Goede hdego...@redhat.com --- src/libinput-private.h | 13 src/libinput.c | 82

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:31PM +0100, Hans de Goede wrote: In some cases the compositor will want to know which keys (buttons) a device has. E.g. for scrolling we want the compositor to be able to set a button to change a relative device (e.g. a trackball) into scroll mode, so that it

Re: [PATCH 09/11] test: Add trackpoint middle button scrolling disable test

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:38PM +0100, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- test/trackpoint.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/test/trackpoint.c b/test/trackpoint.c index eb9ddfb..7a36370

Re: [PATCH 10/11] test: Add litest_button_scroll helper function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:39PM +0100, Hans de Goede wrote: Turn test_trackpoint_scroll into a generic helper function for testing button scrolling. Signed-off-by: Hans de Goede hdego...@redhat.com --- test/litest.c | 28 test/litest.h | 3 +++

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-07 Thread Peter Hutterer
On 8/11/2014 08:07 , Bill Spitzak wrote: Nevermind, it sounds like this is in *addition* to an api that lets you get the set of all keys on the device. So it is just a convenience for the (probably common) case where the caller is only testing for a particular key. if you're talking about

Re: [PATCH 3/8] doc: preserve links produced by Doxygen

2014-11-09 Thread Peter Hutterer
On Fri, Nov 07, 2014 at 05:33:33PM -0800, Bill Spitzak wrote: These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation because it failed on missing and duplicate target id's,

Re: [PATCH 8/8] doc: Added % to remove some self-references from doxygen output

2014-11-09 Thread Peter Hutterer
. That aside: not a big fan of this patch, I'd prefer to see it highlighted. The linking is excessive but at least cursive or bold would be nice here. Then again, if it requires extra markup in the comments I'm not sure it's worthwhile. Rest of the series: Acked-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH libinput 2/5] evdev: move scroll flag setting/check into a helper function

2014-11-09 Thread Peter Hutterer
Much more readable, especially with the upcoming patches. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 272d165..9225163 100644 --- a/src

[PATCH libinput 3/5] evdev: use fabs(x) instead of (x = -a || x = a)

2014-11-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 9225163..424a590 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1526,11 +1526,11 @@ evdev_post_scroll(struct evdev_device

[PATCH libinput 5/5] evdev: use distance triggers to start scrolling

2014-11-09 Thread Peter Hutterer
to clarify that in the public doc. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 45 - src/evdev.h | 2 ++ src/libinput.h | 6 ++ test/touchpad.c | 45 + 4 files changed, 93

[PATCH libinput 4/5] touchpad: explicitly init scroll settings

2014-11-09 Thread Peter Hutterer
No effect, we're just initializing with the same value we did before. What is important here is the comment, the touchpad scroll threshold is in mm for touchpads providing a resolution. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 3 +++ 1 file changed, 3

[PATCH libinput 1/5] test: rename a parameter to litest_assert_scroll()

2014-11-09 Thread Peter Hutterer
This doesn't test for direction only, it tests for the minimum distance we expect in the scroll event. Rename accordingly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c | 8 test/litest.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

2014-11-10 Thread Peter Hutterer
sorry for the duplicate Hans, wayland-devel got dropped of the first reply. On Fri, Nov 07, 2014 at 02:25:06PM +0100, Hans de Goede wrote: Add edge-scrolling support for non multi-touch touchpads as well as for users who prefer edge-scrolling (as long as they don't have a clickpad). Note the

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-16 Thread Peter Hutterer
On Thu, Nov 13, 2014 at 10:06:27AM +, Daniel Stone wrote: Hi, On Thursday, November 13, 2014, Giulio Camuffo giuliocamu...@gmail.com wrote: 2014-11-13 11:18 GMT+02:00 Daniel Stone dan...@fooishbar.org javascript:;: Think about the case where pressing Alt on its own will focus the

[RFC PATCH libinput] Rename scroll_mode to scroll_method

2014-11-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- would like to get some input from native english speakers here. I was writing hooks to use the new scroll method interface and for some reason scroll mode struck me as the wrong word, with method being more appropriate to describe how

[PATCH libinput] Allow for a 0 button on button scrolling

2014-11-18 Thread Peter Hutterer
This effectively disables the button scrolling, but since 0 is the default button for most devices, we should allow setting the default button. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 2 +- src/libinput.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion

[PATCH libinput 3/6] evdev: move calibration/sendevents config init into helpers

2014-11-18 Thread Peter Hutterer
no functional changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index a539792..89c6802 100644 --- a/src/evdev.c +++ b/src/evdev.c

[PATCH libinput 2/6] tools: print the device name on DEVICE_ADDED

2014-11-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 3 ++- tools/event-gui.c | 5 - 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index 00882bf..1d9c8a0 100644 --- a/tools/event-debug.c +++ b/tools/event

[PATCH libinput 1/6] tools: print config options for each device on DEVICE_ADDED

2014-11-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index fb22f3b..00882bf 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -257,6 +257,7

[PATCH libinput 0/6] natural scrolling for all pointers

2014-11-18 Thread Peter Hutterer
We had a request to enable natural scrolling from non-touchpad devices (probably trackballs are the more common use-case here). This patchset does that, it moves the feature into evdev.c and then enables it for all pointer devices (including wheels). The first two patches are just icing for

[PATCH libinput 6/6] test: add natural scrolling tests for pointers

2014-11-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/pointer.c | 56 1 file changed, 56 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 116f185..487cd16 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -280,6

[PATCH libinput 5/6] evdev: enable natural scrolling for all pointer devices

2014-11-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 51 --- src/evdev.h | 2 ++ 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d0ddc37..bd742a6 100644 --- a/src/evdev.c +++ b

[PATCH libinput 4/6] evdev: move natural scrolling configuration into evdev

2014-11-18 Thread Peter Hutterer
We're about to add natural scroll support to other devices as well, let's share the code. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 57 +++-- src/evdev-mt-touchpad.h | 5 - src/evdev.c | 49

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

2014-11-19 Thread Peter Hutterer
On Wed, Nov 19, 2014 at 11:50:13AM +0100, Hans de Goede wrote: [...] + + switch (tp-model) { + case MODEL_SYNAPTICS: + edge_width = width * .07; + edge_height = height * .07; + break; + case MODEL_ALPS: + edge_width = width * .15; +

Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

2014-11-19 Thread Peter Hutterer
On Wed, Nov 19, 2014 at 01:45:35PM +0100, Hans de Goede wrote: Add edge-scrolling support for non multi-touch touchpads as well as for users who prefer edge-scrolling (as long as they don't have a clickpad). Note the percentage to use of the width / height as scroll-edge differs from one

Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

2014-11-20 Thread Peter Hutterer
On Thu, Nov 20, 2014 at 10:34:51AM +0100, Hans de Goede wrote: [...] +int +tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device) +{ + struct tp_touch *t; + int width, height; + int edge_width, edge_height; + + width = device-abs.absinfo_x-maximum -

[PATCH libinput 2/9] path: split out creating a device into a helper function

2014-11-23 Thread Peter Hutterer
No functional changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/path.c | 57 - 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/src/path.c b/src/path.c index f986afd..5900775 100644 --- a/src/path.c +++ b

[PATCH libinput 9/9] test: add seat changing tests

2014-11-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/path.c | 71 ++- test/udev.c | 78 - 2 files changed, 147 insertions(+), 2 deletions(-) diff --git a/test/path.c b/test

[PATCH libinput 7/9] path: optionally pass the seat name into path_device_enable()

2014-11-23 Thread Peter Hutterer
Prep work for changing seat names on devices. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/path.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/path.c b/src/path.c index 9d0632a..fef1d46 100644

[PATCH libinput 0/9] Changing logical seat names

2014-11-23 Thread Peter Hutterer
libinput devices are assigned to a struct libinput_seat that is immutable. The seat consists of physical seat (e.g. seat0, i.e. ID_SEAT) and a logical seat (default, WL_SEAT if available). The physical seat is used as filter whether a device is added at all, the logical seat effectively

[PATCH libinput 4/9] evdev: use a udev_device instead of separate sysname/syspath/devnode

2014-11-23 Thread Peter Hutterer
Using a udev_device instead of the various bits separately safes us re-initializing udev contexts whenever we need to compare the device. And having the actual udev device makes it a bit easier to ensure that we're not re-initializing a different device as a current one. Signed-off-by: Peter

[PATCH libinput 3/9] path: store the udev device instead of just the devnode

2014-11-23 Thread Peter Hutterer
Long-term plan to use more of udev_device here is to better protect us against re-opening a different device that happens to have the same devnode. This now also prints an error message for invalid devices, the log tests are adjusted. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput v3 2/3] touchpad: Add code to get the touchpad model / manufacturer

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 12:16:05PM +0100, Hans de Goede wrote: This is useful to know in some cases, it is e.g. necessary to figure out which percentage of a touchpads range to use as edge for edge-scrolling. Note this is a slightly cleaned up copy of the same code in xf86-input-synaptics.

Re: [PATCH libinput 1/2] evdev: Query mouse DPI from udev

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 03:53:36PM -0600, Derek Foreman wrote: Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. for the archives: the thing we're struggling with on high-DPI mice is that our

Re: [PATCH libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 03:53:37PM -0600, Derek Foreman wrote: Signed-off-by: Derek Foreman der...@osg.samsung.com --- test/Makefile.am| 7 - test/mouse_dpi_parser.c | 69 + 2 files changed, 75 insertions(+), 1 deletion(-)

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 12:16:18PM +0200, Pekka Paalanen wrote: On Tue, 25 Nov 2014 02:33:53 +0100 sob...@gmail.com (Krzysztof A. Sobiecki) wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com ---

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com --- src/evdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/evdev.c

[PATCH weston] Drop legacy backends in favor of libinput

2014-11-25 Thread Peter Hutterer
--- Makefile.am| 15 +- configure.ac | 10 +- src/compositor-drm.c | 2 +- src/compositor-fbdev.c | 2 +- src/compositor-rpi.c | 2 +- src/evdev-touchpad.c | 800 - src/evdev.c| 755

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 10:41:50AM -0600, Derek Foreman wrote: On 25/11/14 04:32 AM, Peter Hutterer wrote: On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob

[PATCH v3 libinput] evdev: Query mouse DPI from udev

2014-11-25 Thread Peter Hutterer
From: Derek Foreman der...@osg.samsung.com Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman der...@osg.samsung.com Signed-off-by: Peter Hutterer peter.hutte...@who

Re: [PATCH] doc: Removed redundant xslt output elements.

2014-11-27 Thread Peter Hutterer
-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- doc/publican/protocol-interfaces-to-docbook.xsl | 1 - doc/publican/protocol-to-docbook.xsl| 1 - 2 files changed, 2 deletions(-) diff --git a/doc/publican/protocol-interfaces-to-docbook.xsl b/doc/publican/protocol

[PATCH libinput 1/4] evdev: Query mouse DPI from udev

2014-11-30 Thread Peter Hutterer
From: Derek Foreman der...@osg.samsung.com Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman der...@osg.samsung.com Signed-off-by: Peter Hutterer peter.hutte...@who

[PATCH libinput 2/4] filter: fix a comment, 400 isn't hard-coded anymore

2014-11-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.h b/src/filter.h index 0dc081b..9b12618 100644 --- a/src/filter.h +++ b/src/filter.h @@ -29,7 +29,7 @@ #include stdint.h struct motion_params

[PATCH libinput 0/4] pointer acceleration DPI normalization

2014-11-30 Thread Peter Hutterer
The first patch is just in this series for completeness, it's already been on this list. systemd has now merged the mouse DPI hwdb [1], so the next version will come with that enabled and we just need to start populating the actual database. The net effect for us is that we can start relying on

[PATCH libinput 4/4] Change default DPI to 1000

2014-11-30 Thread Peter Hutterer
the touchpad by a factor of 2.5. That is way too fast. Adding touchpad-specific filter code is a bigger project, so let's just add a fixme for now and scale the coefficient back to what it was before the DPI default change. Effect: touchpad behaves as before. Signed-off-by: Peter Hutterer

[PATCH libinput 3/4] Move DEFAULT_MOUSE_DPI to filter.h

2014-11-30 Thread Peter Hutterer
The filter code is what relies on some default dpi configuration to apply pointer acceleration and expects the input coordinates to be pre-scaled to that resolution. Let's move the define here so we can use it from the touchpad code too. No functional changes. Signed-off-by: Peter Hutterer

[PATCH libinput] Add a function to retrieve the udev_device handle from a libinput device

2014-11-30 Thread Peter Hutterer
but is more prone to race conditions than the udev_device. https://bugs.freedesktop.org/show_bug.cgi?id=85573 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 6 ++ src/evdev.h| 3 +++ src/libinput.c | 6 ++ src/libinput.h | 18 ++ test

[PATCH libinput] Add libinput_device_get_context/libinput_seat_get_context

2014-12-01 Thread Peter Hutterer
Allow retrieval of the libinput context from the seat and the device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 12 src/libinput.h | 22 ++ test/device.c | 12 3 files changed, 46 insertions(+) diff --git a/src

Re: [PATCH libinput] Introduce non-accelerated motion event vectors

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 09:44:16PM +0800, Jonas Ådahl wrote: For certain applications (such as FPS games) it is necessary to use non-accelerated motion events (the motion vector that is passed to the acceleration filter) to get a more natural feeling. Supply this information by passing both

[PATCH libinput] Document relative motion normalization

2014-12-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index db56da7..5608eaa 100644 --- a/src/libinput.h +++ b/src/libinput.h

Re: [PATCH] doc: Invoke doxygen via the defined make variable.

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 05:54:07PM -0800, Jon A. Cruz wrote: Invoke doxygen via the autoconf-defined make variable instead of directly. This brings it in line with standard makefile practices. Signed-off-by: Jon A. Cruz j...@osg.samsung.com Reviewed-by: Peter Hutterer peter.hutte...@who

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: This requires doxygen 1.8 or newer. I could not figure out how to make configure.ac test the doxygen version number. It appears to be really complex. So it will run with any version of doxygen and the doc output is somewhat mangled.

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:34PM -0800, Bill Spitzak wrote: These warnings are a duplicate of the first set --- doc/doxygen/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am index 83622af..fe6f300 100644 ---

Re: [PATCH 3/4] doc: removed redundant dependency

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:35PM -0800, Bill Spitzak wrote: The .tmp file dependency depends on the index.xml file so it does not need to be repeated. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- doc/publican/Makefile.am |4 ++-- 1 file changed, 2

Re: [PATCH 4/4] doc: Remove duplicated descriptions of wayland objects

2014-12-02 Thread Peter Hutterer
-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- doc/publican/protocol-interfaces-to-docbook.xsl | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/doc/publican/protocol-interfaces-to-docbook.xsl b/doc/publican/protocol-interfaces

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 12:27:54PM -0800, Bill Spitzak wrote: On 12/02/2014 07:47 PM, Peter Hutterer wrote: On Tue, Dec 02, 2014 at 06:29:34PM -0800, Bill Spitzak wrote: These warnings are a duplicate of the first set --- doc/doxygen/Makefile.am |1 + 1 file changed, 1 insertion

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 12:37:40PM -0800, Bill Spitzak wrote: On 12/02/2014 07:45 PM, Peter Hutterer wrote: On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: This requires doxygen 1.8 or newer. I could not figure out how to make configure.ac test the doxygen version number

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 02:20:50PM -0800, Bill Spitzak wrote: On 12/03/2014 01:49 PM, Peter Hutterer wrote: what is \comment? I can't find it in the doxygen tag list. That stumped me for a while, too. It's an alias defined in the wayland.doxygen file. As far as I can tell aliases

[PATCH libinput] Always check for INVALID configs first

2014-12-03 Thread Peter Hutterer
Always check for invalid input first, then check if the input is supported by the actual device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/libinput.c b/src/libinput.c

Re: [PATCH libinput v2 1/2] Introduce unaccelerated motion event vectors

2014-12-03 Thread Peter Hutterer
more than zero. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for both with a minor nitpick below. src/evdev-mt-touchpad-edge-scroll.c | 2 +- src/evdev-mt-touchpad.c | 20 ++-- src/evdev-mt-touchpad.h | 4 +- src/evdev.c | 19

[PATCH libinput] udev: only apply default calibration on absolute devices

2014-12-04 Thread Peter Hutterer
Fixes a crash if the LIBINPUT_CALIBRATION_MATRIX is set for a relative device. https://bugs.freedesktop.org/show_bug.cgi?id=86993 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/udev-seat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/udev-seat.c b

[PATCH libinput] Split libinput-util into a noinst helper library

2014-12-04 Thread Peter Hutterer
'../libinput/libinput-0.7.0/_build/test' Makefile:412: recipe for target 'distclean-recursive' failed That was the only place we used subdir objects, so we can drop it from configure now. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac | 2 +- src/Makefile.am

[ANNOUNCE] libinput 0.7.0

2014-12-04 Thread Peter Hutterer
model / manufacturer touchpad: Add edge-scrolling support Jonas Ådahl (2): Introduce unaccelerated motion event vectors test: Don't send two motion events when button scrolling Krzysztof A. Sobiecki (1): Ignore devices that have joystick buttons Peter Hutterer (107

Re: libinput without udev

2014-12-07 Thread Peter Hutterer
On Sun, Dec 07, 2014 at 06:31:32PM +, almin...@gmail.com wrote: I am currently looking into porting libinput for freebsd by making mtdev optional and abstracting epoll so it can be nicely replaced with kqueue. one question regarding mtdev: it has no dependencies outside of linux/input.h

Re: [PATCH] Remove spurious addition from range normalization calculation

2014-12-07 Thread Peter Hutterer
On Fri, Dec 05, 2014 at 03:13:34PM -0800, Jason Gerecke wrote: The presence of a +1 in the range calculation prevents the normalization functions from returning a value of 1.0 when absinfo-value has reached its maximum. Signed-off-by: Jason Gerecke killert...@gmail.com --- whoopsy. merged,

[PATCH libinput] Drop LIBINPUT_TABLET_AXIS_CNT from the public API

2014-12-07 Thread Peter Hutterer
Avoid mismatches in what the caller expects vs what libinput actually provides when building against newer/older versions of libinput. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- This patch applies to the tablet-support branch src/libinput-private.h | 2 ++ src/libinput.h

[RFC PATCH libinput 2/2] evdev: hook up keysym API

2014-12-07 Thread Peter Hutterer
for proper key releasing, etc. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Cc: Samuel Thibault samuel.thiba...@ens-lyon.org --- src/evdev.c | 48 + src/evdev.h | 5 +++ test/Makefile.am | 1 + test/keyboard.c

[RFC PATCH libinput 1/2] Add a string-based input API

2014-12-07 Thread Peter Hutterer
as well, the exact behavior of when the release event is sent is implementation dependent. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Cc: Samuel Thibault samuel.thiba...@ens-lyon.org --- Not intending to merge this yet, this is supposed to spark some discussion. We don't have real support

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-08 Thread Peter Hutterer
On Fri, Dec 05, 2014 at 12:53:28PM -0800, Bill Spitzak wrote: On 12/05/2014 06:44 AM, Pekka Paalanen wrote: do you have any suggestions on how to get rid of the asterisks in front of code examples? All I can say is that this appears to be a Doxygen bug, and it depends both on the version

Re: [PATCH] evdev: Remove double-semicolon

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 10:46:54AM +0100, Hans de Goede wrote: From: Carlos Garnacho carl...@gnome.org Signed-off-by: Carlos Garnacho carl...@gnome.org pushed, thanks. fwiw, you can push patches like this directly to the repo, I don't think they'll trigger big discussions on design :)

Re: [PATCH libinput 2/3] Implement support for pen barrel rotation

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 12:13:17PM -0800, Bill Spitzak wrote: Why not call it Z instead of TWIST? I'm pretty certain that is a common term for this movement, and that twist is a rather strange term (roll is used more). And Z has the advantage that it also implies that counter-clockwise is

Re: [PATCH libinput v2 1/2] evdev: Add a remove callback to the evdev_dispatch_interface

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 10:46:43AM +0100, Hans de Goede wrote: Some dispatchers may want to do some cleanup at remove time, rather then at destroy time. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 1 + src/evdev.c | 4 src/evdev.h

Re: [PATCH libinput v2 2/2] touchpad: Use remove callback to unlink event listener and stop timers

2014-12-08 Thread Peter Hutterer
, which means that they may expire between remove and destroy time, and cause events to be emitted from a removed device, so this commit moves the cancelling of the timers to the remove callback as well. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact an input method? please explain On 12/07/2014 10:05 PM, Peter Hutterer wrote: Some devices don't rely on keycodes + xkb layout but rather send a specific

Re: [PATCH] doc: Label Client/Server library as Appendex B.

2014-12-08 Thread Peter Hutterer
library docs both are generated documentation from source code as opposed to the prose text of chapters 1-4, thus my guess is that both were intended to be Appendices. Signed-off-by: Bryce Harrington br...@osg.samsung.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter

Re: [RFC PATCH libinput 1/2] Add a string-based input API

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 06:49:37PM -0800, Bill Spitzak wrote: On 12/08/2014 06:37 PM, Peter Hutterer wrote: On Mon, Dec 08, 2014 at 11:03:58AM -0800, Bill Spitzak wrote: Shouldn't this use the same api as the input methods, since it is in fact an input method? please explain Never

[PATCH libinput 1/6] Drop deprecated symbols

2014-12-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 7 --- src/libinput.c | 16 src/libinput.h | 27 --- 3 files changed, 50 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 0873c99..ad167b2 100644 --- a/src/evdev.c

[PATCH libinput 6/6] doc: put some extra warning in for libinput_event_destroy()

2014-12-09 Thread Peter Hutterer
Unlike all other structs, events aren't refcounted and will get destroyed immediately. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 7e5d93c..f7cb169

<    2   3   4   5   6   7   8   9   10   11   >