[PATCH libinput 2/6] Use symbol versioning

This isn't the final 0.8.0 API yet, but we might as well get started. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/Makefile.am | 5 ++- src/libinput.sym | 117 +++ 2 files changed, 120 insertions(+), 2 deletions(-) create

[PATCH libinput 5/6] doc: document the base structures so they show up in doxygen

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index d6e0446..7e5d93c 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -302,8 +302,31 @@ enum

[PATCH libinput 3/6] doc: include README as mainpage

doxygen supports markdown so we can expand the README with general interesting information in markdown format and have it be the front page of the documentation at the same time. This requires renaming README to README.txt, but that's a relatively small price to pay. Signed-off-by: Peter

[PATCH libinput 4/6] doc: add the various events to the doxygen groups

Makes them show up on the respective page and in the data structures list doxygen generates. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 29 + 1 file changed, 29 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index 682e16f

Re: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote: Otherwise, input_events will be attempted to read from the wrong place, which also leaves the right/current fd with pending data to be read, making the epoll fd wake up constantly. Signed-off-by: Carlos Garnacho

[PATCH v2 libinput 1/2] evdev: Ensure the libevdev object receives the new fd on resume

Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - sync libevdev's state after change_fd src/evdev.c | 16 1 file changed, 16 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 0873c99..3f15560 100644 --- a/src/evdev.c

Re: [PATCH 2/2] doc: Minor makefile cleanup.

On Tue, Dec 09, 2014 at 01:34:23AM -0800, Jon A. Cruz wrote: Split out directory creation to leverage order only prerequisites. bit beyond my puny make skills but to the best of my abilities both patches: Acked-by: Peter Hutterer peter.hutte...@who-t.net learned a few new tricks though

Re: [PATCH 3/3] touchpad: Use TOUCHPAD_MIN_SAMPLES in tp_get_delta

already checks itself. Right, though note that you're now passing the initial 0/0 deltas into the filter and thus feed the velocity trackers. Not that it has any effect, 0 + 0 is still 0... Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter Signed-off-by: Hans de Goede hdego

Re: [PATCH 2/3] touchpad: When a clickpad is clicked post combined motion of all touches

this. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86807 Signed-off-by: Hans de Goede hdego...@redhat.com much nicer, thanks. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- src/evdev-mt-touchpad.c | 43 +++ 1 file

[PATCH libinput 4/5] test: run clickfinger test for all clickpad-capable devices

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 01dabfd..44b403b 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -828,8 +828,13

[PATCH libinput 5/5] tests: add a few clickfinger tests

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 293 1 file changed, 293 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index 44b403b..c044fee 100644 --- a/test/touchpad.c +++ b/test/touchpad.c

[PATCH libinput 2/5] touchpad: hook up click method configuration

. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 163 ++-- src/evdev-mt-touchpad.c | 6 +- src/evdev-mt-touchpad.h | 15 +++- src/libinput.h | 6 ++ 4 files changed, 160 insertions

[PATCH libinput 3/5] test: add tests for clickfinger defaults

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 85 + 1 file changed, 85 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index 934674c..01dabfd 100644 --- a/test/touchpad.c +++ b/test/touchpad.c

[PATCH libinput 1/5] Add a config interface for click methods

in the touchpad code, this is just the configuration interface. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I fully admit, I'm not happy with the naming but I can't come up with something nicer. src/libinput-private.h | 9 + src/libinput.c | 50

Re: Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

On Wed, Dec 10, 2014 at 01:17:30PM +0100, Carlos Garnacho wrote: Doh, resending to list from the subscribed account... Hey Peter :), On Wed, Dec 10, 2014 at 1:40 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote

Re: [PATCH libinput 5/6] doc: document the base structures so they show up in doxygen

On Wed, Dec 10, 2014 at 05:54:12PM +0800, Jonas Ådahl wrote: Hi, A couple of comments inline: On Wed, Dec 10, 2014 at 10:34:03AM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 34 ++ 1 file

Re: [PATCH libinput 6/6] doc: put some extra warning in for libinput_event_destroy()

On Wed, Dec 10, 2014 at 06:01:13PM +0800, Jonas Ådahl wrote: Hi, Comment inline. On Wed, Dec 10, 2014 at 10:34:04AM +1000, Peter Hutterer wrote: Unlike all other structs, events aren't refcounted and will get destroyed immediately. Signed-off-by: Peter Hutterer peter.hutte...@who

Re: [PATCH 3/3] touchpad: Use TOUCHPAD_MIN_SAMPLES in tp_get_delta

On Fri, Dec 12, 2014 at 01:15:49PM +0100, Hans de Goede wrote: Hi, On 10-12-14 04:34, Peter Hutterer wrote: On Tue, Dec 09, 2014 at 12:47:11PM +0100, Hans de Goede wrote: Use TOUCHPAD_MIN_SAMPLES in tp_get_delta rather then hardcoding 4. s/then/than/ Also remove the superfluous

Re: [PATCH 1/3] touchpad: Add a tp_post_pointer_motion helper function

On Tue, Dec 09, 2014 at 12:47:09PM +0100, Hans de Goede wrote: Split out the pointer-motion handling into a helper function. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- src/evdev-mt-touchpad.c | 46

[PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

BTN_TOOL_FINGER, DOUBLETAP, etc. are mutually exclusive in the kernel, so we can use ffs here instead of manually counting. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/evdev

[PATCH libinput 1/6] touchpad: factor out fake finger handling

the mask isn't a straightforward bitmask anymore, abstract it all through helper functions. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 72 - 1 file changed, 53 insertions(+), 19 deletions(-) diff --git a/src/evdev

[PATCH libinput 6/6] test: add touchpad hover finger test

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 322 +++- 1 file changed, 321 insertions(+), 1 deletion(-) diff --git a/test/touchpad.c b/test/touchpad.c index 934674c..9890566 100644 --- a/test/touchpad.c +++ b

[PATCH libinput 5/6] test: add a semi-mt + hover synaptics touchpad

This device sends touch information before BTN_TOUCH https://bugs.freedesktop.org/show_bug.cgi?id=87197 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-synaptics-hover.c | 132 ++ test/litest.c

[PATCH libinput 3/6] touchpad: add a TOUCH_HOVERING state

, switch them back into HOVERING if the BTN_TOOL_FINGER is still set, otherwise end them properly. https://bugs.freedesktop.org/show_bug.cgi?id=87197 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 1 + src/evdev-mt-touchpad.c | 81

[PATCH libinput 4/6] test: move semi-mt special tracking into the shared litest.c

An upcoming synaptics semi-mt device needs the same code. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-alps-semi-mt.c | 146 +++-- test/litest.c | 141 +++ test/litest.h

[PATCH libinput] Declare libinput.sym as dependency

We want to rebuild whenever it changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Many thanks to Jon, he pointed me in the right direction src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index eeaf439..b5eba73 100644

Re: [PATCH libinput v3 2/2] Added configure option for documentation build.

On Thu, Dec 18, 2014 at 10:49:59AM -0800, Jon A. Cruz wrote: Added option with fallback of 'auto' to control building of documentation. Signed-off-by: Jon A. Cruz j...@osg.samsung.com --- configure.ac| 72 ++--- doc/Makefile.am | 2

[PATCH libinput 1/8] tools: make event-debug's option parsing more flexible

We need to be able to turn config options on/off for testing, so switch to something that's a bit more flexible than characters that represent the options. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 22 +++--- 1 file changed, 15 insertions

[PATCH libinput 5/8] tools: move applying device configuration to shared lib

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 10 ++ tools/shared.c | 8 tools/shared.h | 3 ++- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index b8be215..ffc9a13 100644

[PATCH libinput 4/8] tools: move opening the backend to the shared lib too

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 79 ++ tools/shared.c | 91 + tools/shared.h | 4 +++ 3 files changed, 98 insertions(+), 76 deletions

[PATCH libinput 2/8] tools: add --enable-tap to event-debug

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index 1be3e14..b6b7140 100644 --- a/tools/event-debug.c +++ b/tools

[PATCH libinput 6/8] tools: add support to enable/disable natural scrolling

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/shared.c | 16 tools/shared.h | 1 + 2 files changed, 17 insertions(+) diff --git a/tools/shared.c b/tools/shared.c index bd8fd11..623005e 100644 --- a/tools/shared.c +++ b/tools/shared.c @@ -39,6 +39,8 @@ enum

[PATCH libinput 8/8] tools: use the new shared lib from event-gui

This gives the event gui the ability to use the path backend, and any configuration toggles given on the commandline. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/Makefile.am | 2 +- tools/event-gui.c | 50 ++ 2 files changed

[PATCH libinput 3/8] tools: move option parsing to a helper library

event-debug and event-gui can and should share this Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/Makefile.am | 8 +++- tools/event-debug.c | 121 +-- tools/shared.c | 133

[PATCH libinput 7/8] tools: add support for enabling/disabling left-handed button mappings

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/shared.c | 15 +++ tools/shared.h | 1 + 2 files changed, 16 insertions(+) diff --git a/tools/shared.c b/tools/shared.c index 623005e..8439cb2 100644 --- a/tools/shared.c +++ b/tools/shared.c @@ -41,6 +41,8 @@ enum

[PATCH libinput 5/5] touchpad: revert to pointer movement when stopping twofinger scrolling

/show_bug.cgi?id=86807 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 40 ++-- src/evdev-mt-touchpad.h | 6 ++ test/touchpad.c | 39 +++ 3 files changed, 79 insertions(+), 6 deletions

[PATCH libinput 1/5] test: switch touch points around for semi-mt tap-n-drag testing

as expected. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 84b3080..e6f0eb6 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -211,11

[PATCH libinput 2/5] test: add helper function for checking for a specific event type

In a few tests we care about that a specific set of events are in the queue but not about the details of the events (usually checked elsewhere). Instead of manual loops, provide a helper function that also checks that there is at least one of those events in the queue. Signed-off-by: Peter

[PATCH libinput 3/5] test: switch tests to use the new helper function

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touchpad.c | 79 ++--- 1 file changed, 8 insertions(+), 71 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index e6f0eb6..1a0414c 100644 --- a/test/touchpad.c +++ b

[PATCH libinput 4/5] touchpad: rename scroll.state to scroll.edge_state

In preparation for a twofinger_state field, to avoid confusion. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-edge-scroll.c | 6 +++--- src/evdev-mt-touchpad.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt

Re: [PATCH] Fix Back, Forward, and other special mouse buttons in XWayland.

less confusing (and is what we do in e.g. evdev). but either way, Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH v2] Fix Back, Forward, and other special mouse buttons in XWayland.

On Mon, Dec 22, 2014 at 11:35:29AM -0800, Dima Ryazanov wrote: Currently, the indexes are off by 4 because of the scroll buttons. Signed-off-by: Dima Ryazanov d...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- hw/xwayland/xwayland-input.c | 7

Re: [PATCH] libinput-seat: Don't regard no input devices as failure

with no input devices attached. Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk Reviewed-by: Peter Hutterer peter.hutte...@who-t.net though I'd use available over attached which is less ambiguous in a multi-seat scenario. Cheers, Peter --- src/libinput-seat.c | 2 +- 1 file changed

Re: [PATCH weston v2] Fix Back, Forward, and other special mouse buttons in the X11 compositor.

On Wed, Feb 04, 2015 at 01:51:57AM -0800, Dima Ryazanov wrote: They're off by 4 because of the scroll buttons. Signed-off-by: Dima Ryazanov d...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- src/compositor-x11.c | 7 +-- 1 file changed, 5

Re: [PATCH libinput] Do not abort on invalid speed.

On Wed, Feb 04, 2015 at 10:34:25AM +0100, Olivier Fourdan wrote: Libinput's accelerator_set_speed() asserts the given speed value is within the [-1.0, 1.0] range. When using xf86-input-libinput, a client may try to set an invalid speed which will cause the entire Xserver to abort. Instead

Re: [PATCH libinput] Do not abort on invalid speed.

trigger. I tried triggering this through xinput set-prop and it seems to work as expected with the random values I tried. Can you attach gdb to see the callstack of how you get there? Cheers, Peter - Original Message - From: Olivier Fourdan ofour...@redhat.com To: Peter Hutterer

Re: [PATCH v2 libinput] add simple symbols leak checker

On Mon, Feb 02, 2015 at 01:16:23PM +0100, Marek Chalupa wrote: This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. v2. use noinst_SCRIPTS instead of dummy target drop .sh suffix

[PATCH libinput 3/5] test: add pointer acceleration defaults test

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/pointer.c | 40 1 file changed, 40 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 45e0d57..9a91231 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -732,6 +732,44

[PATCH libinput 4/5] Don't init pointer acceleration on absolute devices

Note: touchpads have a different backend, we never get here in that case. This only applies to true absolute pointer devices. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c| 3 ++- test/pointer.c | 26 ++ 2 files changed, 28 insertions(+), 1

[PATCH libinput 5/5] zalloc the libinput_source, don't malloc it

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.c b/src/libinput.c index 951698a..7456b90 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -510,7 +510,7 @@ libinput_add_fd(struct libinput

[PATCH libinput 2/5] evdev: set the default speed after initializing ptraccel

https://bugs.freedesktop.org/show_bug.cgi?id=88899 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 1b3bb90..b2b8cbf 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1229,6 +1229,9

[PATCH libinput 1/5] filter: zalloc the struct to make sure the speed is initialized

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index 89390d1..72ef760 100644 --- a/src/filter.c +++ b/src/filter.c @@ -286,7 +286,7 @@ create_pointer_accelerator_filter

[PATCH libinput 1/2] test: switch event conversion tests to use litest devices

it the device will be tagged with ID_INPUT_KEY but not ID_INPUT_KEYBOARD. This could be fixed by adding all normal keyboard keys to the uinput device but it's easier to just re-use litest. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Part 1 of two to make the udev tagging possible without

Re: [PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

On Mon, Feb 02, 2015 at 06:33:49PM -0800, Bill Spitzak wrote: On 02/02/2015 03:12 PM, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-02 22:29, Bill Spitzak wrote: This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu

[PATCH libinput 2/2] path: make sure udev devices are initialized before usage

into heisenbugs later. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/path.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/path.c b/src/path.c index dd70efc..832a1fd 100644 --- a/src/path.c +++ b/src/path.c @@ -291,14 +291,34

Re: [PATCH v3 libinput] add simple symbols leak checker

On Thu, Feb 05, 2015 at 09:33:19AM +0100, Marek Chalupa wrote: This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. v2. use noinst_SCRIPTS instead of dummy target drop .sh suffix

Re: libinput: disabling touchpad motion without disabling scrolling?

On Sat, Jan 31, 2015 at 03:12:09PM -0800, Josh Triplett wrote: Is it possible to disable touchpad motion events without disabling scrolling? On a laptop with both a touchstick and a touchpad, I'd like to use a touchpad as a scroll wheel, but not have it generate any motion events. (Bonus

Re: [PATCH V3] configure.ac: Fallback to older detection code if pkg-config can't find expat

On Tue, Feb 03, 2015 at 02:10:32PM -0800, Bill Spitzak wrote: On 02/03/2015 01:50 PM, Peter Hutterer wrote: On Tue, Feb 03, 2015 at 12:33:35PM -0800, Bill Spitzak wrote: This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu

Re: [PATCH libinput v2] Fix an abort if the device speed is NaN

On Thu, Feb 05, 2015 at 02:33:31PM +0100, Olivier Fourdan wrote: When using libinput with xf86-input-libinput, the device speed is represented as a float passed via X properties. If a buggy client gives a broken value, the conversions that occur can cause the value of speed to be NaN (not a

[ANNOUNCE] libinput 0.10.0

Peter Hutterer (13): Add missing doxygen ingroup tag for libinput_device_get_udev_device test: add per-device udev rule support cosmetic: remove double empty-line filter: zalloc the struct to make sure the speed is initialized evdev: set the default speed after

Re: [PATCH libinput] Introduce device groups to group logical devices together

On Thu, Feb 05, 2015 at 07:14:54PM +0800, Jonas Ådahl wrote: On Thu, Feb 05, 2015 at 02:30:58PM +1000, Peter Hutterer wrote: Devices like Wacom tablets have multiple event nodes (touch, pad and stylus). This requires some logical grouping, e.g. setting an Intuos 5 tablet left-handed

[PATCH v2 libinput 1/2] evdev: retrieve udev tags

Tissoires benjamin.tissoi...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - typo fixes in commit message - add ID_INPUT parsing - keep the udev_tags variable local src/evdev.c | 65 + 1 file changed, 65

[PATCH libinput 2/2] evdev: switch to using udev's device tagging system

) ID_INPUT_TOUCH - we can re-use that knowledge then. Ignore anything that doesn't have ID_INPUT set, this provides for an easy way of making devices invisible to libinput. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 116

Re: [PATCH weston] Fix Back, Forward, and other special mouse buttons in the X11 compositor.

= BTN_LEFT; break; case 2: button = BTN_MIDDLE; -- 2.1.0 Reviewed-by: Peter Hutterer peter.hutte...@who-t.net though I'd prefer having the default at the bottom of the switch case Cheers, Peter ___ wayland-devel mailing

Re: [PATCH libinput] evdev: retrieve udev tags

On Mon, Feb 02, 2015 at 01:43:48PM -0500, Benjamin Tissoires wrote: Udev already tags the devices by opening each of them and analyzing their features. We are basically re-doing this in libinput. The advantage of udev tags over the plain heuristic from libinput is that users (or driver

Re: [PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

, Peter On 02/02/2015 10:46 PM, Peter Hutterer wrote: On Mon, Feb 02, 2015 at 06:33:49PM -0800, Bill Spitzak wrote: On 02/02/2015 03:12 PM, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-02 22:29, Bill Spitzak wrote: This paritally reverts commit

Re: [PATCH V3] configure.ac: Fallback to older detection code if pkg-config can't find expat

On Tue, Feb 03, 2015 at 12:33:35PM -0800, Bill Spitzak wrote: This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config file, so fall back to a test for the header and library. hmm, this is the first

Re: [PATCH libinput resend] touchpad: Allow the center of pinned fingers to drift over time

On Wed, Jan 14, 2015 at 10:17:06AM +0100, Hans de Goede wrote: Allow the center of pinned fingers to drift over time, to avoid accidentally unpinning fingers. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86807 Signed-off-by: Hans de Goede hdego...@redhat.com pushed, thanks.

Re: [PATCH libinput 1/2] Change the scroll step distance to 15 and document it as degrees

wheel click by this software and would make your window scroll far too fast. All in all this change seems pretty questionable. On 01/11/2015 03:12 PM, Peter Hutterer wrote: Similar to the mouse resolution, let's make the scroll distance a sensible predictable value. Most mice use a 15

[PATCH libinput] Rename a tablet function to ...has_axis to match the pointer axis function

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- For the tablet-support branch, provides some consistency. src/libinput.c | 2 +- src/libinput.h | 4 ++-- src/libinput.sym| 2 +- test/tablet.c | 20 ++-- tools/event-debug.c | 2 +- 5 files

Re: [PATCH libinput] evdev.c: Return from evdev_configure_device() after configuring a device as a tablet

On Mon, Jan 19, 2015 at 08:54:45PM -0500, Stephen Chandler Paul wrote: As it turns out upon detecting a tablet in evdev_configure_device(), there isn't any call to return to escape the function once we've finished configuring the tablet. As a result, the code continues running and ends up

Re: [PATCH libinput] tablet: Add a left handed mode and tests

On Mon, Jan 19, 2015 at 09:44:08PM -0500, Stephen Chandler Paul wrote: On the majority of Wacom tablets, the buttons are on the left side, opposite of the side where the palm is meant to rest. Because of this, it's impossible to use the tablet with your left hand (comfortably, anyway) unless

Re: [PATCH libinput 2/2] remove libinput_event_pointer_get_axis from symbols

On Wed, Jan 21, 2015 at 12:11:22PM +0100, Marek Chalupa wrote: This function was removed in 1baf109b40 Signed-off-by: Marek Chalupa mchqwe...@gmail.com --- src/libinput.sym | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libinput.sym b/src/libinput.sym index cfbeabd..77fccb8

Re: [PATCH libinput 1/2] add simple symbols leak checker

On Wed, Jan 21, 2015 at 12:11:21PM +0100, Marek Chalupa wrote: This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. good idea, thanks Signed-off-by: Marek Chalupa mchqwe...@gmail.com ---

Re: [PATCH libinput] evdev: Be more careful about what we consider a joystick

On Wed, Jan 21, 2015 at 12:25:39PM +0100, Michael Schellenberger Costa wrote: Hi, is there an acutal reason, why joysticks and/or gamepads are ignored inside libinput. Is it just, that they are not yet implemented, or are there some real reasons? If the answer is that nobody has yet

Re: [PATCH libinput v2 0/5] Add a config interface for click methods

On Wed, Jan 14, 2015 at 02:54:41PM +0100, Hans de Goede wrote: Hi All, Here is v2 of Peter's config interface for click methods series, only touchpad: hook up click method configuration is changed: - Keep top softbuttons working when enabling clickfinger - Simplify touchpad click method

[ANNOUNCE] libinput 0.8.0

main(void) Peter Hutterer (63): doc: delete double-empty lines doc: fix wording on the dpi normalization paragraph README: link to bugzilla and API docs test: create a new device during the disable test to change fds Drop deprecated symbols Use symbol versioning

Re: [PATCH libinput] tablet: Add a left handed mode and tests

On Tue, Jan 20, 2015 at 09:58:12PM -0500, Stephen Chandler Paul wrote: On the majority of Wacom tablets, the buttons are on the left side, opposite of the side where the palm is meant to rest. Because of this, it's impossible to use the tablet with your left hand (comfortably, anyway) unless

Re: [RFC libinput] Add an API for touchpad gesture events

CC-ing Carlos too, I'd like to get his input here. On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen

Re: [RFC libinput] Add an API for touchpad gesture events

On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a

[PATCH v2 libinput 2/3] Add a udev bits to assign LIBINPUT_DEVICE_GROUP

with multiple interfaces. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Pretty big revamp. Changes to v1: - configure.ac: handle AC_ARG_WITH better (e.g. --without-...) - configure.ac: change from udev_rules_dir to udev_dir for the base dir, we have a binary now too - change to a rule

Re: [PATCH libinput 4/8] tablet: Merge PROXIMITY_IN and PROXIMITY_OUT into a single event

On Mon, Feb 16, 2015 at 10:48:42PM -0500, Stephen Chandler Paul wrote: There isn't much purpose in having proximity in and out as different events, combining them into one single event is more consistent with the rest of the API, and means less code for clients to have to work with.

Re: [PATCH libinput 8/8] tablet: Add tests for axes on proximity events

On Mon, Feb 16, 2015 at 10:48:46PM -0500, Stephen Chandler Paul wrote: --- test/tablet.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/test/tablet.c b/test/tablet.c index 8074e4e..bf78e12 100644 --- a/test/tablet.c +++

Re: [PATCH libinput 6/8] tablet: Include starting values of axes in proximity events

On Mon, Feb 16, 2015 at 10:48:44PM -0500, Stephen Chandler Paul wrote: Having a motion event that's sent right after the original proximity event just to give the values of each axis is somewhat redundant. Since we already include the values of each axis with each type of event, we may as

Re: libinput in Coverity

On Tue, Feb 17, 2015 at 11:19:58PM +0100, Carlos Olmedo Escobar wrote: I was trying to check libinput in Coverity but it seems it's not there yet. Is there anybody who is supposed to register libinput there? fwiw, I ran irregular coverity checks on Red Hat's internal Coverity instance. last

[PATCH libinput 02/15] test: fix two tablet tests

The serial test was broken, it succeeded even if we never got an event. The second test was fine, but complicated. Make it use some of the newer litest features. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/tablet.c | 42 -- 1 file

[PATCH libinput 05/15] tablet: fix two coding style issues

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 0de4bcd..9f55946 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -130,7 +130,8

[PATCH libinput 11/15] tablet: support artpen rotation

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 33 + src/evdev-tablet.h | 6 +++ src/libinput.h | 3 +- test/tablet.c | 105 + 4 files changed, 131 insertions(+), 16 deletions

[PATCH libinput 14/15] tablet: add support for libinput_tool_has_button

The mouse like devices have LMR, SIDE and EXTRA. PENCIL (which is the Wacom Inking) and the eraser have no buttons. AIRBRUSH has only one button, all other pens have two. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 41

[PATCH libinput 01/15] tablet: explicitly ignore ABS_THROTTLE, ABS_RX, ABS_RY, and ABS_RZ

. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 4a0d4b2..0de4bcd 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -62,6 +62,17

[PATCH libinput 06/15] Keep the tablet APIs in a separate symbol version block

I keep having to move them around after merging from master and often I'm late with it too. It's a lot easier to just have to update the dependency in a single line, and causes less conflicts too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.sym | 8 +--- 1 file

[PATCH libinput 10/15] tools: only print the tablet axes we have on the tool

This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 49 + 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/tools

[PATCH libinput 08/15] tablet: support z-rotation for the mouse/lens tool

Needs to be calculated from the x/y tilt values, the mouse has a fixed offset of 175 degrees counterclockwise. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 95 -- src/libinput-private.h | 2 +- src/libinput.c

[PATCH libinput 07/15] tablet: factor out checking a device for axes

This gets more complicated for axes that aren't a 1:1 relationship with event codes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c

[PATCH libinput 15/15] tools: print tool capabilities on proximity

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/event-debug.c | 32 1 file changed, 32 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index dcf1dae..37d344c 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c

[PATCH libinput 12/15] tablet: factor out setting axis bits on a tool

No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-tablet.c | 100 + 1 file changed, 48 insertions(+), 52 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 81cb99e..46eb665 100644

[PATCH libinput] udev: fix a race condition if a device disappears before we get a handle

If the device disappears too quickly, the device is NULL, the sysname is NULL and that causes a segfault in strcmp. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/udev-seat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev-seat.c b/src/udev-seat.c index 3d05733

[PATCH libinput 03/15] test: replace a while loop with a litest helper

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/tablet.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/test/tablet.c b/test/tablet.c index 1e5947a..746f643 100644 --- a/test/tablet.c +++ b/test/tablet.c @@ -799,15 +799,10 @@ START_TEST(tool_ref

[PATCH libinput 00/15] tablet: support the remaining tools

This patchset adds the remaining tools to the tablet branch (at least for Wacom tools). The notable additions are: * rotation support for mouse/lens cursor * rotation support for the artpen * 'wheel' support for the airbrush * correct per-tool capabilities (including buttons) If you have one of

[PATCH libinput 04/15] test: fix double comparison macros

args needs to be within () to ensure correct calculation Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/litest.h b/test/litest.h index 4553c87..dd1ad9a 100644 --- a/test/litest.h +++ b

<    3   4   5   6   7   8   9   10   11   12   >