Re: [PATCH weston] desktop-shell: use binding_modifier for zoom

2017-09-18 Thread Ray, Ian (GE Healthcare)
On 18/09/2017, 12.58, "Pekka Paalanen" wrote: > > On Fri, 15 Sep 2017 09:12:38 +0300 > Ian Ray wrote: > > > Support for kiosk-style use cases where binding modififer is `none': > > > > - Use binding modifier instead of hard-coded MODIFIER_SUPER for zoom.

Re: [PATCH weston 08/21] compositor-drm: set all properties in create_output_for_connector

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Move the remaining scattered setup of the fixed properties into >

Re: [PATCH weston 09/21] libweston: send more wl_surface.enter/leave events

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > A client may have bound the same wl_output multiple times, for who knows > what

Re: [PATCH weston 15/21] compositor-fbdev: simplify FB destroy/unmap/disable

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Rename fbdev_frame_buffer_destroy() to fbdev_frame_buffer_unmap() > because that

Re: [PATCH weston 06/21] compositor-wayland: move output init into common, fix error path

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Move the weston_output_init() call into wayland_output_create_common(). > This

Re: [PATCH weston 12/21] libweston: set backend pointer earlier

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Change all backends to set the core backend pointer early. > > This is

Re: [PATCH weston 11/21] libweston: ensure backend is not loaded twice

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Check and ensure that a compositor can only load one backend > successfully. If

Re: [PATCH weston 16/21] compositor-fbdev: always destroy renderer-output on disable

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > If we pass the base->enabled test, then the renderer output is > guaranteed to

Re: [PATCH weston 10/21] libweston: rename weston_output_destroy() to weston_output_release()

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > 'release' is a more appropriate name because the function does not free > the

Re: [PATCH weston 01/21] libweston: move weston_output::mode_list init to core

2017-09-26 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Initialize the list in weston_output_init() instead of doing it > separately in

Re: [PATCH weston 02/21] compositor-drm: use asprintf in make_connector_name()

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Gets rid of the constant size char array. > > While here, document the

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Add 'name' argument to weston_output_init(). This is much more obvious > than

Re: [PATCH weston 04/21] tests: ensure output dependent IVI tests run

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > There are IVI tests that require an output. Previously these tests would >

Re: [PATCH weston 20/21] compositor-fbdev: unref udev on backend destruction

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.34, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Fixes a small memory leak, spotted with Valgrind. > > Signed-off-by: Pekka

Re: [PATCH weston 19/21] compositor-fbdev: remove unused field 'depth'

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.34, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Not referenced anywhere ever, has been there since the introduction of >

Re: [PATCH weston 17/21] compositor-fbdev: rename fbdev_output_disable_handler()

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.33, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > This is a more logical name for the function, matching the pattern used > in

Re: [PATCH weston 18/21] compositor-fbdev: fix finish_frame_timer leak

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.34, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > The timer was never removed anywhere. Remove it in disable() to match > what

Re: [PATCH weston 21/21] compositor-drm: unref udev on backend destruction

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.34, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Fixes a small memory leak, spotted with Valgrind. > > Signed-off-by: Pekka

Re: [PATCH weston 03/21] compositor-wayland: use asprintf for output title

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Simplifies the code, and makes moving weston_output_init() into >

Re: [PATCH weston] weston: add wait-for-debugger option

2017-11-02 Thread Ray, Ian (GE Healthcare)
On 01/11/2017, 16.24, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > When you need to start Weston via weston-launch, systemd unit, or any > other

Re: [PATCH weston 1/1] xwayland - input size calculation correction

2017-12-21 Thread Ray, Ian (GE Healthcare)
On 20/12/2017, 13.19, "Daniel Stone" wrote: > > Hi Ian and Nandor, > > On 20 December 2017 at 10:09, Ian Ray wrote: > > The input area for an undecorated non-fullscreen window is based on the > > window size itself. > > > > Fixes a case where mouse events

Re: EXT: [PATCH] log: improve handling of use-before-init

2018-05-07 Thread Ray, Ian (GE Healthcare)
> On 4 May 2018, at 17.26, Matt Hoosier wrote: > > Rather than segfaulting by attempting to traverse an initially > null log handler pointer, explicitly print a message and abort. > > Signed-off-by: Matt Hoosier Nice improvement! Reviewed-by:

Re: EXT: [PATCH weston 1/2] desktop-shell: fix output destroy signal list corruption

2018-05-22 Thread Ray, Ian (GE Healthcare)
> On 22 May 2018, at 13.34, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This issue was introduced by "desktop-shell: detect stale shell surface > outputs" which forgot to remove the output destroy listener when > shell_surface is

Re: EXT: [PATCH weston 2/2] libweston: fix output destroy signal list corruption

2018-05-22 Thread Ray, Ian (GE Healthcare)
> On 22 May 2018, at 13.34, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This issue was likely introduced by "libweston: add > weston_view_set_output()" which forgot to ensure the output destroy > listener is removed when weston_view

Re: EXT: Re: [PATCH weston 0/4] Handle several NULL output pointer

2018-05-21 Thread Ray, Ian (GE Healthcare)
> On 21 May 2018, at 16.37, Pekka Paalanen wrote: > > Hi, > > this series was originally written by me as you can see, and Fabien > lifted the patches, reviewed, tested and submitted them. If no-one > objects, I would like to land these on Thursday. > Reviewed-by: Ian

Re: EXT: [PATCH weston 0/1] Allow forcing outputs on

2018-05-24 Thread Ray, Ian (GE Healthcare)
> On 23 May 2018, at 15.47, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Hi, > > this patch depends on the last patch of the clone mode series: > https://patchwork.freedesktop.org/patch/217906/ > > I've tested this on a dual-head

Re: EXT: Re: [PATCH weston 0/4] Optimize pixman renderer

2018-05-21 Thread Ray, Ian (GE Healthcare)
> On 21 May 2018, at 16.29, Pekka Paalanen wrote: > > Hi, > > this series was originally written by me as you can see, and Fabien > lifted the patches, reviewed, tested and submitted them. If no-one > objects, I would like to land these on Thursday. Reviewed-by: Ian Ray

Re: EXT: Re: [PATCH weston 0/2] xwm: Dump properties.

2018-05-22 Thread Ray, Ian (GE Healthcare)
> On 21 May 2018, at 16.46, Pekka Paalanen wrote: > > Hi, > > I'd like to push these two patches as well on Thursday if no-one objects. > > I'll hold off with the O-R state debugging patch until I get a chance > to look at Scott's implementation for O-R changes. I think

Re: EXT: [PATCH weston 6/9] compositor-drm: move refresh rate computation

2018-02-09 Thread Ray, Ian (GE Healthcare)
> On 9 Feb 2018, at 15.07, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Move it into to a new function. Following patches want to compute it > elsewhere as well. > > No functional changes. > > Signed-off-by: Pekka Paalanen

Re: EXT: [PATCH weston 0/9] DRM-backend preparation for clone mode patches

2018-02-09 Thread Ray, Ian (GE Healthcare)
> On 9 Feb 2018, at 15.07, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Hi, > > here are some patches I extracted from my clone mode series. These are > building on top of > https://patchwork.freedesktop.org/series/37994/ > in case

Re: EXT: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Ray, Ian (GE Healthcare)
> On 29 Aug 2018, at 9.17, Daniel Stone wrote: > > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually completely

Re: EXT: Wayland/weston opens files in suspend/resume

2018-08-22 Thread Ray, Ian (GE Healthcare)
> On 22 Aug 2018, at 12.18, Teemu K wrote: > > Hi, > > I have custom iMX6 based HW running image generated with Yocto 2.4 > (Wayland 2.0.0) and Linux kernel 4.1.x that I've been testing with > suspend/resume cycles. > > I noticed that after each suspend/resume cycle open file count >

Re: EXT: [PATCH weston 2/2] libweston: fix output reflow on removal

2018-07-04 Thread Ray, Ian (GE Healthcare)
> On 21 Jun 2018, at 15.53, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This is regression apparently introduced in > 0de859ede4bad72b5d3b78e086632f02196d997f, which accidentally swapped the > sign of 'delta_width' in the original call site. If one removes an > output, the remaining

Re: [PATCH v2] xwm: Update input region on resize

2018-03-27 Thread Ray, Ian (GE Healthcare)
On 27/03/2018, 21.50, "wayland-devel on behalf of Derek Foreman" wrote: > > Hey everyone, > > I've added Ian Ray to CC as the author of commit 332d1892bbb (xwm: do > not include shadow in input region) > > I

Re: EXT: [PATCH weston v6 23/73] weston: migrate RDP to head-based output API

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Migrate the RDP frontend to use the new head-based output configuration > API: listen for heads_changed, and process all heads. > > Signed-off-by: Pekka

Re: EXT: [PATCH weston v6 22/73] weston: migrate fbdev to head-based output API

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Migrate the fbdev frontend to use the new head-based output > configuration API: listen for heads_changed, and process all heads. > > Signed-off-by: Pekka

Re: EXT: [PATCH weston v6 25/73] libweston: change windowed_output_api output_create to create_head

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 23 Mar 2018, at 15.36, Ray, Ian (GE Healthcare) <ian@ge.com> wrote: > >> >> On 16 Feb 2018, at 16.57, Pekka Paalanen <ppaala...@gmail.com> wrote: >> >> From: Pekka Paalanen <pekka.paala...@collabora.co.uk> >> >> Renam

Re: EXT: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.56, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Hi all, > > here is the v6 of the shared-CRTC clone mode series. Since v5, quite > many patches have been extracted from this series, sent out and merged >

Re: EXT: [PATCH weston v6 25/73] libweston: change windowed_output_api output_create to create_head

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Rename the function pointer to create_head() because that is what it > does on backends that are converted to the head-based API. Update the > documentation to

Re: EXT: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

2018-03-23 Thread Ray, Ian (GE Healthcare)
> On 23 Mar 2018, at 15.12, Ray, Ian (GE Healthcare) <ian@ge.com> wrote: > > >> On 16 Feb 2018, at 16.56, Pekka Paalanen <ppaala...@gmail.com> wrote: >> >> From: Pekka Paalanen <pekka.paala...@collabora.co.uk> >> >> Hi all, >>

Re: EXT: [PATCH weston v6 37/73] compositor-wayland: migrate to head-based output API

2018-03-24 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Follow the standard pattern used in the headless and x11 backend > migration, but also cater for the two other backend modes: --sprawl or > fullscreen-shell, and

Re: EXT: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

2018-03-24 Thread Ray, Ian (GE Healthcare)
> On 23 Mar 2018, at 19.16, Ray, Ian (GE Healthcare) <ian@ge.com> wrote: > > >> On 23 Mar 2018, at 15.12, Ray, Ian (GE Healthcare) <ian@ge.com> wrote: >> >> >>> On 16 Feb 2018, at 16.56, Pekka Paalanen <ppaala...@gmail.com

Re: EXT: [PATCH weston v6 32/73] compositor-rdp: migrate to head-based output API

2018-03-24 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Follow the starndard patttern as the other backends, headless and x11 in Nit: s/starndard/standard (And, at risk of being overly pedantic, the X11 change does

Re: EXT: [PATCH weston v6 34/73] compositor-fbdev: migrate to head-based output API

2018-03-24 Thread Ray, Ian (GE Healthcare)
> On 16 Feb 2018, at 16.57, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Implement the head-based output API in this backend, and stop relying on > the implicit weston_output::head. > > The split between fbdev_head and fbdev_output

Re: EXT: Re: [PATCH weston v10 0/1] Head-based output configuration API a.k.a clone mode infrastructure

2018-06-29 Thread Ray, Ian (GE Healthcare)
> On 25 Jun 2018, at 15.00, Pekka Paalanen wrote: > > Ping? > > Would be really nice to get this final patch of a series of around 130+ > patches merged. It only needs an objective technical review, the > Acked-by's already cover the subjective review. > > > Thanks, > pq > > On Wed, 6 Jun

Re: EXT: [PATCH weston v10 1/1] weston: support clone mode on DRM-frontend

2018-06-29 Thread Ray, Ian (GE Healthcare)
> On 6 Jun 2018, at 14.30, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Add a new output section key "same-as" for configuring clone mode. An > output marked "same-as" another output will be configured identically to > the other output. > > The current implementation supports only

Re: EXT: Re: [PATCH wayland v2] contributing: use Gitlab merge request workflow

2019-03-06 Thread Ray, Ian (GE Healthcare)
> On 6 Mar 2019, at 11.28, Pekka Paalanen wrote: > > Going once, going twice... > > Any objections? More acks? > > Let's say I'll push this and enable MRs on Friday if there are no > further comments. More acks and I might do it sooner. :-) > > LGTM Acked-by: Ian Ray > Thanks, > pq >

Re: EXT: Multiple touchscreen environment with Weston

2019-06-20 Thread Ray, Ian (GE Healthcare)
> On 17 Jun 2019, at 17.45, Theo BUENO wrote: > > Hello everyone, > > I am (relatively) new Weston user working with industrial embedded Linux > systems. I am seeking for advice regarding a Weston use case. > > I have been trying to understand how would one map touchscreens to unique >

Re: EXT: How to attach multiple heads to one weston_output correctly.

2019-09-12 Thread Ray, Ian (GE Healthcare)
> On 12 Sep 2019, at 6.58, Sichem Zhou wrote: > > Hi wayland devs, > > I am trying to run multiple monitors in clone mode, which requires one output > to drive multiple heads. While I can create output for every head and attach > them with no problem (defaultly new output comes on the