Hi,
On 10/3/22 12:32, Pekka Paalanen wrote:
> On Mon, 3 Oct 2022 11:44:56 +0200
> Hans de Goede wrote:
>
>> One example mentioned here is that laptops with Intel integrated
>> graphics may have some "perceived brightness" mapping table
>> in their Video BIOS
Hi,
On 9/30/22 18:17, Sebastian Wick wrote:
> On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote:
>>
>> On Fri, 30 Sep 2022 17:44:17 +0300
>> Ville Syrjälä wrote:
>>
>>> On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote:
On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote:
Hi,
On 9/28/22 12:57, Ville Syrjälä wrote:
> On Wed, Sep 28, 2022 at 01:04:01PM +0300, Jani Nikula wrote:
>> On Fri, 09 Sep 2022, Hans de Goede wrote:
>>> Hi all,
>>>
>>> Here is v2 of my "drm/kms: control display brightness through drm_connector
Hi,
On 9/28/22 12:04, Jani Nikula wrote:
> On Fri, 09 Sep 2022, Hans de Goede wrote:
>> Hi all,
>>
>> Here is v2 of my "drm/kms: control display brightness through drm_connector
>> properties" RFC:
>>
>> Changes from version 1:
>> -
Hi,
On 9/13/22 12:28, Carlos Garnacho wrote:
> Hi!,
>
> On Tue, Sep 13, 2022 at 11:36 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 9/12/22 23:20, Peter wrote:
>>> Hi all,
>>>
>>>
>>> Op maandag 12 september 2022 om 15:14:09 +020
Hi,
On 9/12/22 23:20, Peter wrote:
> Hi all,
>
>
> Op maandag 12 september 2022 om 15:14:09 +0200 schreef Juerd Waalboer
> :
>> Hans de Goede skribis 2022-09-12 7:16 (+0200):
>>> During a big hacker event in the Netherlands this summer (MCH) the logistics
>>
Hi All,
Juerd (in the Cc) reported the following problem to me at our local hackerspace.
During a big hacker event in the Netherlands this summer (MCH) the logistics
team used custom barcodes to keep track of inventory. These custom barcodes
contain a # symbol.
They noticed that with the
Hi All,
On 9/9/22 12:23, Hans de Goede wrote:
> Hi All,
>
> I will be at Plumbers Dublin next week and I was wondering if
> anyone interested in this wants to get together for a quick
> discussion / birds of a feather session about this?
>
> I have just posted version
Hi,
On 9/9/22 15:39, Simon Ser wrote:
> On Friday, September 9th, 2022 at 12:12, Hans de Goede
> wrote:
>
>> Phase 3: Deprecate /sys/class/backlight uAPI
>>
>>
>> Once most userspace has moved over to using the new
Hi All,
I will be at Plumbers Dublin next week and I was wondering if
anyone interested in this wants to get together for a quick
discussion / birds of a feather session about this?
I have just posted version 2 of the RFC:
Hi all,
Here is v2 of my "drm/kms: control display brightness through drm_connector
properties" RFC:
Changes from version 1:
- Drop bl_brightness_0_is_min_brightness from list of new connector
properties.
- Clearly define that 0 is always min-brightness when setting the brightness
through
h just having a kernel cmdline parameter to hide/unhide
it might be good enough.
Regards,
Hans
>
> On Thu, Aug 25, 2022 at 3:27 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> Hi Yusuf,
>
> On 8/24/22 04:18, Yusuf Khan wrote:
> > Sorry
lowly. This is likely going to take multiple years and then some ...
Regards,
Hans
>
> On Thu, Apr 7, 2022 at 10:39 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> As discussed already several times in the past:
> https://www.x.org/wiki/Events/XDC201
Hi,
On 6/10/22 14:53, Simon Ser wrote:
> On Friday, June 10th, 2022 at 14:36, Gerd Hoffmann wrote:
>
>> Hi,
>>
As Pekka mentionned, I'd also like to have a conversation of how far we
want to
push virtualized driver features. I think KMS support is a good feature to
have
Hi,
On 6/3/22 17:22, Simon Ser wrote:
> On Friday, June 3rd, 2022 at 17:17, Zack Rusin wrote:
>
>>
>>> On Jun 3, 2022, at 10:56 AM, Simon Ser wrote:
>>> ⚠ External Email
>>>
>>> On Friday, June 3rd, 2022 at 16:38, Zack Rusin wrote:
>>>
> On Jun 3, 2022, at 10:32 AM, Simon Ser wrote:
Hi,
On 5/18/22 16:23, Jani Nikula wrote:
> On Wed, 18 May 2022, Hans de Goede wrote:
>> So how about: display_brightness or panel_brightness ?
>
> This is a prime opportunity to look at all the existing properties, and
> come up with a new combination of capitalization
Hi,
On 4/14/22 15:10, Jani Nikula wrote:
> On Thu, 07 Apr 2022, Hans de Goede wrote:
>> As discussed already several times in the past:
>> https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/
>>
>> https://lore.kernel.org/all/4b17ba08-39f3-57dd-5aad-d
gt;>>>> On Mon, Apr 11, 2022 at 6:18 AM Hans de Goede wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On 4/8/22 17:11, Alex Deucher wrote:
>>>>>>> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede
>>
Hi All,
As discussed in the "[RFC] drm/kms: control display brightness through
drm_connector properties" thread, step 1 of the plan is to stop
registering multiple /sys/class/backlight devs for a single display.
On x86 there can be multiple firmware + direct-hw-access methods
for controlling the
Hi,
On 4/13/22 10:32, Daniel Vetter wrote:
> On Fri, Apr 08, 2022 at 12:26:24PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 4/8/22 12:16, Simon Ser wrote:
>>> Would it be an option to only support the KMS prop for Good devices,
>>> and continue using th
Hi Pekka,
On 4/11/22 13:34, Pekka Paalanen wrote:
> On Mon, 11 Apr 2022 12:18:30 +0200
> Hans de Goede wrote:
>
>> Hi,
>>
>> On 4/8/22 17:11, Alex Deucher wrote:
>>> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote:
>>>>
>
> ...
>
Hi Simon,
On 4/8/22 10:22, Simon Ser wrote:
> Hi Hans,
>
> Thanks for your details replies!
>
> On Thursday, April 7th, 2022 at 19:43, Hans de Goede
> wrote:
>
>>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
>>> wrote:
>>&
Hi,
On 4/7/22 20:58, Carsten Haitzler wrote:
> On Thu, 7 Apr 2022 17:38:59 +0200 Hans de Goede said:
>
> Below you covered our usual /sys/class/backlight device friends... what about
> DDC monitor controls? These function similarly but just remotely control a
> screen via I2C
Hi,
On 4/8/22 17:11, Alex Deucher wrote:
> On Fri, Apr 8, 2022 at 10:56 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 4/8/22 16:08, Alex Deucher wrote:
>>> On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote:
>>>>
>>>> On Thu, Apr 07, 202
Hi Simon,
On 4/8/22 10:22, Simon Ser wrote:
> Hi Hans,
>
> Thanks for your details replies!
>
> On Thursday, April 7th, 2022 at 19:43, Hans de Goede
> wrote:
>
>>> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
>>> wrote:
>>&
Hi,
On 4/8/22 16:08, Alex Deucher wrote:
> On Fri, Apr 8, 2022 at 4:07 AM Daniel Vetter wrote:
>>
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi,
On 4/8/22 12:16, Simon Ser wrote:
> Would it be an option to only support the KMS prop for Good devices,
> and continue using the suboptimal existing sysfs API for Bad devices?
>
> (I'm just throwing ideas around to see what sticks, feel free to ignore.)
Currently suid-root or pkexec
Hi,
On 4/8/22 11:58, Hans de Goede wrote:
> Hi Daniel,
>
> On 4/8/22 10:07, Daniel Vetter wrote:
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi,
On 4/8/22 11:58, Hans de Goede wrote:
> Hi Daniel,
>
> On 4/8/22 10:07, Daniel Vetter wrote:
>> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>>
>>>> Hi Simon,
>&g
Hi Daniel,
On 4/8/22 10:07, Daniel Vetter wrote:
> On Thu, Apr 07, 2022 at 05:05:52PM -0400, Alex Deucher wrote:
>> On Thu, Apr 7, 2022 at 1:43 PM Hans de Goede wrote:
>>>
>>> Hi Simon,
>>>
>>> On 4/7/22 18:51, Simon Ser wrote:
>>>> Very n
Hi Simon,
On 4/7/22 18:51, Simon Ser wrote:
> Very nice plan! Big +1 for the overall approach.
Thanks.
> On Thursday, April 7th, 2022 at 17:38, Hans de Goede
> wrote:
>
>> The drm_connector brightness properties
>> ===
>>
&g
As discussed already several times in the past:
https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/
https://lore.kernel.org/all/4b17ba08-39f3-57dd-5aad-d37d844b0...@linux.intel.com/
The current userspace API for brightness control offered by
/sys/class/backlight devices has various
Hi,
On 6/25/20 11:40 AM, Simon Ser wrote:
On Thursday, June 25, 2020 11:01 AM, Brad Robinson
wrote:
As a toolkit developer coming from Windows/OSX this is fairly
shocking. I'm aware of the decoration protocol, but given it's not
supported (and by the sound of it never will be) on some of
Hi Sean,
On 02-10-2019 11:33, Sean Young wrote:
Hi,
On Tue, Oct 01, 2019 at 03:32:52PM +0200, Hans de Goede wrote:
On 01-10-2019 10:39, Sean Young wrote:
On Mon, Sep 30, 2019 at 01:29:59PM +0200, Hans de Goede wrote:
So can you please explain your specific use-case here?
Simply loading
Hi,
On 01-10-2019 10:39, Sean Young wrote:
Hi Hans,
On Mon, Sep 30, 2019 at 01:29:59PM +0200, Hans de Goede wrote:
On 30-09-2019 10:33, Sean Young wrote:
On Mon, Sep 30, 2019 at 11:34:04AM +1000, Peter Hutterer wrote:
On Sun, Sep 29, 2019 at 08:17:38PM +0100, Sean Young wrote:
Any thoughts
Hi,
On 30-09-2019 10:33, Sean Young wrote:
On Mon, Sep 30, 2019 at 11:34:04AM +1000, Peter Hutterer wrote:
On Sun, Sep 29, 2019 at 08:17:38PM +0100, Sean Young wrote:
When using IR receivers using libinput, key events get dropped if a new
rc keymap is loaded and the key was not in the old
Hi,
On 25-09-17 08:08, Peter Hutterer wrote:
On Sat, Sep 23, 2017 at 09:57:37AM +0200, Klaus Rudolph wrote:
With X11 ( before wayland ) I can set up my touchscreen with:
xinput --list
find my device: "Advanced Silicon S.A. CoolTouch(TM) System"
and can simply set the props I need with:
Hi,
On 21-09-17 16:00, Matt Porter wrote:
On Thu, Sep 21, 2017 at 10:59:08AM +0200, Hans de Goede wrote:
Hi,
On 19-09-17 18:41, Matt Porter wrote:
The Chalkboard Electronics HID Touchscreen is classified as
a tablet device by systemd udev because it has BTN_TOOL_PEN
support. It also reports
Hi,
On 19-09-17 18:41, Matt Porter wrote:
The Chalkboard Electronics HID Touchscreen is classified as
a tablet device by systemd udev because it has BTN_TOOL_PEN
support. It also reports a resolution of 0 for both X and Y
axes in absinfo. This causes libinput to reject it as an
invalid tablet
working reliably than both unreliably.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
I agree this is the best way to handle this:
Acked-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad-gestures.c | 7 +-
test/test-gestures.c
Hi,
On 10-07-17 07:11, Peter Hutterer wrote:
From: Hans de Goede <hdego...@redhat.com>
Some devices, specifically some bluetooth touchpads generate quite
unreliable timestamps for their events. The problem seems to be that
(some of) these touchpads sample at aprox 90 Hz, but the blu
Bluetooth wreaks havoc with the timestamp of the input events coming
from the touchpad, enable timestamp smoothing support to counter this.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
src/evdev-mt-touchpad.c | 4 +++-
src/filter.c| 6 +-
src/filter.h
vent being event_delta_smooth_value us apart.
Theoritically a very still finger may send the exact same coordinates
and pressure twice, but even if this happens that is not a problem because
a still finger generates coordinates changes below the hyst treshold so
we ignore it anyways.
Signed-off-by: Han
in the software button. We can revisit this if we see
tap detection failures in the future.
https://bugzilla.redhat.com/show_bug.cgi?id=1415796
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Sounds reasonable to me and the code changes look good:
Reviewed-by: Hans de Goede <hdego...@r
tp->pressure.high = 24;
tp->pressure.low = 10;
+ } else if (device->model_flags & EVDEV_MODEL_CYAPA) {
+ tp->pressure.high = 8;
+ tp->pressure.low = 6;
updated locally to 10/8 at the tester's request
LGTM:
R
Hi,
On 07-03-17 04:22, Peter Hutterer wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=99975
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-tou
=99976
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad-buttons.c | 2 +-
test/test-touchpad-buttons.c| 32
2 files
as an horizontal edge scroll area. Reduce the minimum size to 40mm
instead, that's closer to where it starts to get a bit iffy.
https://bugzilla.redhat.com/show_bug.cgi?id=141
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede
Hi,
On 24-02-17 07:15, Peter Hutterer wrote:
Brings some consistency to the log output, making it easier to grep for a
specific device's output, etc.
Patch series looks good to me:
Acked-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hi,
On 24-02-17 05:41, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-tablet-pad-leds.c | 4
1 file changed, 4 insertions(+)
diff
de changes look good to me, as for how the new accel feels / works,
I trust you've good reasons for these changes:
Acked-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
This is the first time I'm quite happy with the touchpad acceleration.
src/filter.c | 37 +
. With these fixes, a long click
now sends button events if there never were any scroll events generated.
Series looks good to me:
Reviewed-by: Hans de Goede <hdgo...@redhat.com>
Regards,
Hans
___
wayland-devel mailing list
wayland
Hi,
On 14-02-17 02:58, Peter Hutterer wrote:
makes it easier to filter out debugging messages
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
---
Sorry, used the wrong patch, v1 was an earlier version.
v2 looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com&
te...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-tablet-pad.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/evdev-tablet-pad.c b/src/evdev-tablet-pad.c
index bed43b6..6be53b5 100644
--- a/src/evdev-
Hi,
Series looks good, but patch 1/2 introduces
tp_is_tpkb_combo_below() and patch 2/2 then moves it around
to avoid doing a forward declaration, it would be better IMHO
if patch 1/2 simply defined it in the place where 2/2 puts it.
With that fixed:
Reviewed-by: Hans de Goede <hd
Hi,
On 09-02-17 23:55, Peter Hutterer wrote:
On Thu, Feb 09, 2017 at 05:25:36PM +0100, Hans de Goede wrote:
Hi,
First of all patches 1-9 and 11 looks good to me and are:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
thx, fwiw, I already pushed these, so fixups will come as a se
-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-lid.c | 28 +---
src/evdev-mt-touchpad-tap.c | 22 --
src/evdev-mt-touchpa
Hi,
First of all patches 1-9 and 11 looks good to me and are:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
I've some remarks inline on this one.
On 30-01-17 01:58, Peter Hutterer wrote:
Don't rely on BTN_TOUCH for "finger down", the value for that is hardcod
Hi,
On 08-02-17 01:17, Peter Hutterer wrote:
42 and 58 were within the middle button already, 40/60 are more accurate
values.
https://bugs.freedesktop.org/show_bug.cgi?id=99212
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Looks good to me:
Reviewed-by: Hans de Goede
tte...@who-t.net>
Patch-set looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index f437c2d..ca00c40 1006
Hi,
On 19-01-17 03:34, Peter Hutterer wrote:
We were just switching type here without actual normalization, the filter code
is in device units as of bdd4264d6150f4a6248eec7.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede
Hi,
On 09-01-17 23:39, Peter Hutterer wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=99200
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
udev/90-libinput-model-qui
wrong and it skipped the test/udev directories in v1.
Ah, that explains things...
New version looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
src/evdev-mt-touchpad-buttons.c | 4 +---
src/evdev.c | 2 +-
src/evdev.h
;, gestures_pinch_3fg, LITEST_TOUCHPAD,
LITEST_SINGLE_TOUCH, );
Test twice now, otherwise LGTM, so with this fixed:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
litest_add_ranged("gestures:pinch", gestures_pinch_4fg, LITEST_TOUCHPAD,
LITEST_SINGLE_TOU
tte...@who-t.net>
---
Changes to v1:
- better commit message/comments
- dropped the finger_count > 2 check that was a dead condition before anyway
LGTM now:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
src/evdev-mt-touchpad-gestures.c | 14 --
1
Hi,
On 20-12-16 04:57, Peter Hutterer wrote:
If the fingers rest on the touchpad without moving for a timeout, switch to
pinch or swipe based on the finger position. We already did so for two-fingers
switching to scrolling, now we also do so for 3 and 4 finger gestures. This
gives us better
but leave the parsing in for cases where it may come in handy.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me and is:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
test/Makefile.am | 2 --
1 file changed, 2 deletions(-)
diff
this branch.
Series looks good to me and is:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Hi,
On 14-12-16 08:36, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad.c | 24 +---
src/evdev.h
lysis.html
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad-tap.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/evdev-m
ignore any multifinger gesture as well.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad.c | 8
test/touchpad.c | 24
2 files
Hi,
On 01-12-16 02:37, Peter Hutterer wrote:
Not that it really matters, but given we're already setting it anyway...
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
://bugs.freedesktop.org/show_bug.cgi?id=91135
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
v2 LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
Changes to v1:
- move the DM4 magic to tp_init_slots and pretend it's a single-touch
touchpad.
ilted" and returning just
-1 or 1 here would likely break the world. And I like this world, I don't
have another one available.
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
___
wayland-devel mailing li
Hi,
On 29-11-16 02:22, Peter Hutterer wrote:
Move the code from the touchpad code into the more generic evdev code
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
Hi,
On 29-11-16 04:48, Peter Hutterer wrote:
On Mon, Nov 28, 2016 at 03:33:25PM +0100, Hans de Goede wrote:
Hi,
On 27-11-16 23:55, Peter Hutterer wrote:
This touchpad has cursor jumps for 2-finger scrolling that also affects the
single-finger emulation. So disable any multitouch bits
Hi,
On 28-11-16 06:20, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Entire series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
test/misc.c | 42 ++
1 file
Hi,
On 27-11-16 23:55, Peter Hutterer wrote:
This touchpad has cursor jumps for 2-finger scrolling that also affects the
single-finger emulation. So disable any multitouch bits on this device and
disallow the 2-finger scroll method. This still allows for 2-finger
tapping/clicking.
net>
---
I'm leaving the motion history as-is for now even though it's largely unused
now. This can be fixed up later once we know this patch has the desired
effect (it does here, but that could be confirmation bias)
Patch looks good to me and is:
Reviewed-by: Hans de Goede <hdego...@redhat.com&
in between rather than re-using the touch down coordinates and thus not
causing a motion on the first event.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me and is:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
test/litest.c |
Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev.c| 6 ++
src/evdev.h| 1 +
udev/90-libinput-model-quirks.hwdb | 4
3 files changed, 1
Hi,
On 14-11-16 01:50, Peter Hutterer wrote:
Makes it easier to see in one go what is conditional in the build.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
The entire series looks good to me and is:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Re
Hi,
On 03-11-16 03:16, Peter Hutterer wrote:
On Fri, Oct 28, 2016 at 12:57:38PM +0200, Hans de Goede wrote:
Hi,
On 28-10-16 07:08, Peter Hutterer wrote:
Not all mice have a click angle with integer degrees. The new
MOUSE_WHEEL_CLICK_COUNT property specifies how many clicks per full rotation
?id=98538
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev.c| 7 +--
src/evdev.h| 1 +
udev/90-libinput-model-quirks.hwdb | 6 +++
Hi,
On 02-11-16 05:51, Peter Hutterer wrote:
A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check for
both.
https://bugs.freedesktop.org/show_bug.cgi?id=98009
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de
Hi,
On 28-10-16 07:41, Peter Hutterer wrote:
No functional changes
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Entire series LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad.c | 24
1 file
s.
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
configure.ac | 4 +
udev/90-libinput-model-quirks.hwdb | 2 +-
udev/Makefile.am | 4
Hi,
On 28-10-16 07:08, Peter Hutterer wrote:
Not all mice have a click angle with integer degrees. The new
MOUSE_WHEEL_CLICK_COUNT property specifies how many clicks per full rotation,
the angle can be calculated from that.
See https://github.com/systemd/systemd/pull/4440 for more information
Hi,
All 3 patches LGTM and are:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
On 24-10-16 03:45, Peter Hutterer wrote:
Fixes the respective clang warnings
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
---
src/libinput.c| 6 ++
test/lites
missed the original posting of this patch, so
I'm replying this mail instead.
Patch LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
Cheers,
Peter
---
src/evdev-mt-touchpad.c | 9 -
src/evdev-mt-touchpad.h | 1 +
test/trackpoint.
net>
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev.c| 7 +++
src/evdev.h| 1 +
udev/90-libinput-model-quirks.hwdb | 4
3 files changed, 12 insertions(+)
diff --git a/src/evdev.c b/src/evdev.c
i
<peter.hutte...@who-t.net>
Patch LGTM:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev.c| 9 +
src/evdev.h| 1 +
udev/90-libinput-model-quirks.hwdb | 7 +++
3 files changed, 17 insertions(+)
diff
. Let's see if we have complaints first before we implement something
more complex.
https://bugs.freedesktop.org/show_bug.cgi?id=91695
Signed-off-by:Peter Hutterer <peter.hutte...@who-t.net>
A nice and KISS solution, I like:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
be set to the area
state but it was never reset on touch release.
https://bugs.freedesktop.org/show_bug.cgi?id=97425
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-t
://bugs.freedesktop.org/show_bug.cgi?id=97194
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
Hi,
On 16-08-16 07:18, Peter Hutterer wrote:
The Logitech MX master has different click angles for the two wheels.
https://github.com/systemd/systemd/issues/3947
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Patch looks good to me:
Reviewed-by: Hans de Goede
.
https://bugs.freedesktop.org/show_bug.cgi?id=96962
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
Series looks good to me:
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
---
src/evdev-mt-touchpad-tap.c | 22
src/libinput-private.h |
Hi,
On 03-08-16 23:57, Peter Hutterer wrote:
We leave the old LIBINPUT_MODEL_TRACKBALL in place until we can rely on
systems to have the new systemd tagging.
https://github.com/systemd/systemd/pull/3872
Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
LGTM:
Reviewed-by: H
Hi,
On 04-08-16 07:07, Peter Hutterer wrote:
On Wed, Aug 03, 2016 at 01:06:01PM +0200, Hans de Goede wrote:
Hi,
On 03-08-16 11:36, Peter Hutterer wrote:
This timeout is there to switch to scrolling when the fingers rest on the
touchpad unmoving and thus avoids the initial scroll threshold
Hi,
On 03-08-16 11:36, Peter Hutterer wrote:
This timeout is there to switch to scrolling when the fingers rest on the
touchpad unmoving and thus avoids the initial scroll threshold for slow
scrolls.
Since the only other gestures we support are swipe (usually a fast movement)
and
1 - 100 of 718 matches
Mail list logo
