Re: [PATCH libinput 1/8] evdev: Don't write out of bounds when mt slot is too large

2014-03-26 Thread Peter Hutterer
On Tue, Mar 25, 2014 at 09:45:52PM +0100, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl jad...@gmail.com patch looks good, but I do wonder if it'd be better to just dynamically allocate slots based on the number of touches. A quick glance shows we don't really need this a fixed length anyway,

Re: [PATCH libinput 1/8] evdev: Don't write out of bounds when mt slot is too large

2014-03-26 Thread Jonas Ådahl
On Wed, Mar 26, 2014 at 06:05:19PM +1000, Peter Hutterer wrote: On Tue, Mar 25, 2014 at 09:45:52PM +0100, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl jad...@gmail.com patch looks good, but I do wonder if it'd be better to just dynamically allocate slots based on the number of touches. A

Re: [PATCH libinput 1/8] evdev: Don't write out of bounds when mt slot is too large

2014-03-26 Thread Peter Hutterer
On Wed, Mar 26, 2014 at 09:20:27AM +0100, Jonas Ådahl wrote: On Wed, Mar 26, 2014 at 06:05:19PM +1000, Peter Hutterer wrote: On Tue, Mar 25, 2014 at 09:45:52PM +0100, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl jad...@gmail.com patch looks good, but I do wonder if it'd be better to

Re: [PATCH libinput 1/8] evdev: Don't write out of bounds when mt slot is too large

2014-03-26 Thread Jonas Ådahl
On Wed, Mar 26, 2014 at 06:29:59PM +1000, Peter Hutterer wrote: On Wed, Mar 26, 2014 at 09:20:27AM +0100, Jonas Ådahl wrote: On Wed, Mar 26, 2014 at 06:05:19PM +1000, Peter Hutterer wrote: On Tue, Mar 25, 2014 at 09:45:52PM +0100, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl

[PATCH libinput 1/8] evdev: Don't write out of bounds when mt slot is too large

2014-03-25 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl jad...@gmail.com --- src/evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 72e4086..ff8b27a 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -132,6 +132,9 @@ evdev_flush_pending_event(struct evdev_device *device,