Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-22 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 10:07:12AM +0200, Jonas Ådahl wrote: On Wed, Jun 18, 2014 at 05:52:04PM +1000, Peter Hutterer wrote: On Wed, Jun 18, 2014 at 09:24:03AM +0200, Jonas Ådahl wrote: The purpose of the struct was to provide an interface with the functionality that libinput would

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-18 Thread Jonas Ådahl
On Wed, Jun 18, 2014 at 08:39:01AM +1000, Peter Hutterer wrote: On Tue, Jun 17, 2014 at 11:20:00PM +0200, Jonas Ådahl wrote: On Fri, Jun 13, 2014 at 12:48:33PM +1000, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-18 Thread Peter Hutterer
On Wed, Jun 18, 2014 at 09:24:03AM +0200, Jonas Ådahl wrote: The purpose of the struct was to provide an interface with the functionality that libinput would require to have to function without having to be root, and it doesn't feel logging function fits this purpose. It was already a

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-17 Thread Jonas Ådahl
On Fri, Jun 13, 2014 at 12:48:33PM +1000, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly unusual) case of having multiple libinput contexts. The log

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-17 Thread Peter Hutterer
On Tue, Jun 17, 2014 at 11:20:00PM +0200, Jonas Ådahl wrote: On Fri, Jun 13, 2014 at 12:48:33PM +1000, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-16 Thread Hans de Goede
Hi, On 06/13/2014 04:48 AM, Peter Hutterer wrote: Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly unusual) case of having multiple libinput contexts. The log handler and the

Re: [PATCH libinput 3/3] Change the logging system to be per-context

2014-06-16 Thread Peter Hutterer
On Mon, Jun 16, 2014 at 12:09:16PM +0200, Hans de Goede wrote: [...] Your removing a bunch of exported symbols here, so you should also bump the soname to indicate ABI breakage. Jonas - do you want the soname bump in this patch or do it as part of the release? There may be other changes

[PATCH libinput 3/3] Change the logging system to be per-context

2014-06-12 Thread Peter Hutterer
Rather than a single global logging function, make the logging dependent on the individual context. This way we won't stomp on each other's feet in the (admittedly unusual) case of having multiple libinput contexts. The log handler and the log priority is now a part of the libinput interface. We