Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-27 Thread Jonas Ådahl
On Tue, May 27, 2014 at 04:43:01PM +1000, Peter Hutterer wrote: On Mon, May 26, 2014 at 09:06:50PM +1000, Peter Hutterer wrote: On 26/05/2014 16:32 , Hans de Goede wrote: Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-26 Thread Hans de Goede
Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-26 Thread Peter Hutterer
On 26/05/2014 16:32 , Hans de Goede wrote: Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-25 Thread Jonas Ådahl
On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for horizontal. But if the first 2 finger motion is

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-24 Thread Hans de Goede
Hi, On 05/23/2014 05:00 PM, Jasper St. Pierre wrote: Any reason you switched the order of these two if statements around? Yes to prefer vertical scrolling when both dx and dy meet the threshold on the initial 2 finger motion, as is stated in the commit message. Regards, Hans On Fri,

[PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-23 Thread Hans de Goede
We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for horizontal. But if the first 2 finger motion is diagonal, then we go into a diagonal scrolling mode where we post both

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-23 Thread Jasper St. Pierre
Any reason you switched the order of these two if statements around? On Fri, May 23, 2014 at 10:06 AM, Hans de Goede hdego...@redhat.com wrote: We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll