Re: [PATCH v8 4/6] compositor-fbdev: set fb device info upon the first run.

2018-06-29 Thread Pekka Paalanen
On Wed, 27 Jun 2018 20:44:20 -0400
nerdopolis  wrote:

> This attempts to wake up secondary framebuffer devices
> (/dev/fb1 and up) as usually these devices start powered off, and
> the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on a
> qemu system with the options:
> 
> -vga none -device VGA,id=video0 -device secondary-vga,id=video1 \
> -device secondary-vga,id=video2
> ---
>  libweston/compositor-fbdev.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/libweston/compositor-fbdev.c b/libweston/compositor-fbdev.c
> index 09a2eb39..e3777495 100644
> --- a/libweston/compositor-fbdev.c
> +++ b/libweston/compositor-fbdev.c
> @@ -384,6 +384,13 @@ fbdev_frame_buffer_open(const char *fb_dev,
>   return -1;
>   }
>  
> + /* Attempt to correct the framebuffer settings */

Hi,

this comment is still inaccurate, your intention is to wake up the
device which cannot be otherwise seen in the code.

> + if (fbdev_set_screen_info(fd, screen_info) < 0) {
> + weston_log("Failed to set mode settings. "
> +"Attempting to open output anyway.\n");
> + }
> +
> +
>   return fd;
>  }
>  

With that fixed:

Reviewed-by: Pekka Paalanen 


Thanks,
pq


pgpnvPFfGICd5.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel


[PATCH v8 4/6] compositor-fbdev: set fb device info upon the first run.

2018-06-27 Thread nerdopolis
This attempts to wake up secondary framebuffer devices
(/dev/fb1 and up) as usually these devices start powered off, and
the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on a
qemu system with the options:

-vga none -device VGA,id=video0 -device secondary-vga,id=video1 \
-device secondary-vga,id=video2
---
 libweston/compositor-fbdev.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libweston/compositor-fbdev.c b/libweston/compositor-fbdev.c
index 09a2eb39..e3777495 100644
--- a/libweston/compositor-fbdev.c
+++ b/libweston/compositor-fbdev.c
@@ -384,6 +384,13 @@ fbdev_frame_buffer_open(const char *fb_dev,
return -1;
}
 
+   /* Attempt to correct the framebuffer settings */
+   if (fbdev_set_screen_info(fd, screen_info) < 0) {
+   weston_log("Failed to set mode settings. "
+  "Attempting to open output anyway.\n");
+   }
+
+
return fd;
 }
 
-- 
2.17.1

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel