Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-26 Thread Pekka Paalanen 
On Fri, 23 Feb 2018 16:45:14 -0600
Derek Foreman  wrote:

> Pushed with Daniel's RB.

Hi Derek,

this seems to have trivially broken 'make check' by not updating the
reference output files for wayland-scanner.


Thanks,
pq

> On 2018-02-23 04:39 PM, Daniel Stone wrote:
> > Rb me (sorry for mangled phone client formatting ...)
> > 
> > On Fri, 23 Feb 2018, 10:25 pm Derek Foreman,  > > wrote:
> > 
> > Missing a closing bracket.
> > 
> > Signed-off-by: Derek Foreman  > >
> > ---
> >   src/scanner.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/scanner.c b/src/scanner.c
> > index c93070c..1737911 100644
> > --- a/src/scanner.c
> > +++ b/src/scanner.c
> > @@ -1748,7 +1748,7 @@ emit_code(struct protocol *protocol, enum
> > visibility vis)
> >                         "# define __has_attribute(x) 0  /*
> > Compatibility with non-clang compilers. */\n"
> >                         "#endif\n\n");
> > 
> > -               printf("#if (__has_attribute(visibility) ||
> > defined(__GNUC__) && __GNUC__ >= 4\n"
> > +               printf("#if (__has_attribute(visibility) ||
> > defined(__GNUC__) && __GNUC__ >= 4)\n"
> >                         "#define WL_PRIVATE __attribute__
> > ((visibility(\"hidden\")))\n"
> >                         "#else\n"
> >                         "#define WL_PRIVATE\n"
> > --
> > 2.14.3


pgpfgqyVDoHzt.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-26 Thread Pekka Paalanen 
On Fri, 23 Feb 2018 22:46:39 +
Emil Velikov  wrote:

> On 23 February 2018 at 22:24, Derek Foreman  wrote:
> > Missing a closing bracket.
> >  
> Eek, that's a embarasing.
> Reviewed-by: Emil Velikov 
> 
> We might want to tweak the existing infra to check that, bonus points
> if we also check the headers actually safe for inclusion in C and C++
> sources.
> A simple runner like weston-tests-env should do it.

There is already cpp-compile-test.cpp in wayland, one could follow that
pattern. I don't think it would actually need a runner script.


Thanks,
pq


pgptwiQsTb2Oi.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Emil Velikov 
On 23 February 2018 at 22:24, Derek Foreman  wrote:
> Missing a closing bracket.
>
Eek, that's a embarasing.
Reviewed-by: Emil Velikov 

We might want to tweak the existing infra to check that, bonus points
if we also check the headers actually safe for inclusion in C and C++
sources.
A simple runner like weston-tests-env should do it.

-Emil
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Derek Foreman 

Pushed with Daniel's RB.

Thanks,
Derek

On 2018-02-23 04:39 PM, Daniel Stone wrote:

Rb me (sorry for mangled phone client formatting ...)

On Fri, 23 Feb 2018, 10:25 pm Derek Foreman, > wrote:


Missing a closing bracket.

Signed-off-by: Derek Foreman >
---
  src/scanner.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/scanner.c b/src/scanner.c
index c93070c..1737911 100644
--- a/src/scanner.c
+++ b/src/scanner.c
@@ -1748,7 +1748,7 @@ emit_code(struct protocol *protocol, enum
visibility vis)
                        "# define __has_attribute(x) 0  /*
Compatibility with non-clang compilers. */\n"
                        "#endif\n\n");

-               printf("#if (__has_attribute(visibility) ||
defined(__GNUC__) && __GNUC__ >= 4\n"
+               printf("#if (__has_attribute(visibility) ||
defined(__GNUC__) && __GNUC__ >= 4)\n"
                        "#define WL_PRIVATE __attribute__
((visibility(\"hidden\")))\n"
                        "#else\n"
                        "#define WL_PRIVATE\n"
--
2.14.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org

https://lists.freedesktop.org/mailman/listinfo/wayland-devel



___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Derek Foreman 
Missing a closing bracket.

Signed-off-by: Derek Foreman 
---
 src/scanner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/scanner.c b/src/scanner.c
index c93070c..1737911 100644
--- a/src/scanner.c
+++ b/src/scanner.c
@@ -1748,7 +1748,7 @@ emit_code(struct protocol *protocol, enum visibility vis)
   "# define __has_attribute(x) 0  /* Compatibility with 
non-clang compilers. */\n"
   "#endif\n\n");
 
-   printf("#if (__has_attribute(visibility) || defined(__GNUC__) 
&& __GNUC__ >= 4\n"
+   printf("#if (__has_attribute(visibility) || defined(__GNUC__) 
&& __GNUC__ >= 4)\n"
   "#define WL_PRIVATE __attribute__ 
((visibility(\"hidden\")))\n"
   "#else\n"
   "#define WL_PRIVATE\n"
-- 
2.14.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel