Re: [PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

[Eric Engestrom]

On Friday, 2018-02-23 17:31:53 +, Emil Velikov wrote:
> From: Emil Velikov 
> 
> Inspired by Heiko Becker and Eric's work in libdrm and Mesa
> respectively.
> 
> Cc: Eric Engestrom 
> Signed-off-by: Emil Velikov 

Reviewed-by: Eric Engestrom 

I haven't really followed that, but I think the meson stuff is in
a branch somewhere? I guess it should get the other half of this patch
so that it doesn't need fixing when it lands :)

> ---
>  configure.ac  | 1 +
>  egl/wayland-egl-symbols-check | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 2542243..91f837d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -29,6 +29,7 @@ AC_PROG_CC
>  AC_PROG_CXX
>  AC_PROG_GREP
>  AM_PROG_AS
> +AC_PROG_NM
>  
>  # check if we have C++ compiler. This is hacky workaround,
>  # for a reason why it is this way see
> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check
> index e107362..6ad28f3 100755
> --- a/egl/wayland-egl-symbols-check
> +++ b/egl/wayland-egl-symbols-check
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -FUNCS=$(nm -D --defined-only ${WAYLAND_EGL_LIB} | grep -o "T .*" | cut -c 3- 
> | while read func; do
> +FUNCS=$($NM -D --defined-only ${WAYLAND_EGL_LIB} | grep -o "T .*" | cut -c 
> 3- | while read func; do
>  ( grep -q "^$func$" || echo $func )  <  wl_egl_window_resize
>  wl_egl_window_create
> -- 
> 2.16.0
> 
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

[Daniel Stone]

Hi,

On 23 February 2018 at 17:31, Emil Velikov  wrote:
> Inspired by Heiko Becker and Eric's work in libdrm and Mesa
> respectively.

Seems trivially correct and also worked here - pushed, thanks!

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

[Emil Velikov]

From: Emil Velikov 

Inspired by Heiko Becker and Eric's work in libdrm and Mesa
respectively.

Cc: Eric Engestrom 
Signed-off-by: Emil Velikov 
---
 configure.ac  | 1 +
 egl/wayland-egl-symbols-check | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 2542243..91f837d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -29,6 +29,7 @@ AC_PROG_CC
 AC_PROG_CXX
 AC_PROG_GREP
 AM_PROG_AS
+AC_PROG_NM
 
 # check if we have C++ compiler. This is hacky workaround,
 # for a reason why it is this way see
diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check
index e107362..6ad28f3 100755
--- a/egl/wayland-egl-symbols-check
+++ b/egl/wayland-egl-symbols-check
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-FUNCS=$(nm -D --defined-only ${WAYLAND_EGL_LIB} | grep -o "T .*" | cut -c 3- | 
while read func; do
+FUNCS=$($NM -D --defined-only ${WAYLAND_EGL_LIB} | grep -o "T .*" | cut -c 3- 
| while read func; do
 ( grep -q "^$func$" || echo $func )