Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Pekka Paalanen]

On Thu, 18 Jan 2018 15:13:53 +
Daniel Stone  wrote:

> Hi,
> 
> On 18 January 2018 at 14:37, Pekka Paalanen  wrote:
> > On Wed, 20 Dec 2017 16:21:32 +0200
> > Alexandros Frantzis  wrote:  
> >> a heads-up that I have posted the libweston input-timestamps patchset
> >> for review at:
> >>
> >> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036392.html
> >>   
> >
> > I have been going through the Weston implementation enough that I can
> > confidently land the wayland-protocols patch tomorrow, Friday.
> >
> > If anyone has doubts, please shout.  
> 
> Sounds good to me! I haven't (and won't; please don't block on me) got
> the chance to look at the Weston implementation, but the protocol is
> also:
> Reviewed-by: Daniel Stone 

Cool, pushed:
   0130366..4f78928  master -> master


Thanks,
pq


pgpPJ1GwIte2E.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Daniel Stone]

Hi,

On 18 January 2018 at 14:37, Pekka Paalanen  wrote:
> On Wed, 20 Dec 2017 16:21:32 +0200
> Alexandros Frantzis  wrote:
>> a heads-up that I have posted the libweston input-timestamps patchset
>> for review at:
>>
>> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036392.html
>
> I have been going through the Weston implementation enough that I can
> confidently land the wayland-protocols patch tomorrow, Friday.
>
> If anyone has doubts, please shout.

Sounds good to me! I haven't (and won't; please don't block on me) got
the chance to look at the Weston implementation, but the protocol is
also:
Reviewed-by: Daniel Stone 

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Pekka Paalanen]

On Wed, 20 Dec 2017 16:21:32 +0200
Alexandros Frantzis  wrote:

> On Tue, Dec 19, 2017 at 01:06:11PM +0200, Alexandros Frantzis wrote:
> > On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote:  
> > > On Mon, 18 Dec 2017 14:55:00 +0200
> > > Alexandros Frantzis  wrote:
> > >   
> > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit
> > > > timestamp with millisecond resolution. In some cases, notably latency
> > > > measurements, this resolution is too coarse to be useful.
> > > > 
> > > > This protocol provides additional high-resolution timestamps events,
> > > > which are emitted before the corresponding input event. Each timestamp
> > > > event contains a high-resolution, and ideally higher-accuracy, version
> > > > of the 'time' argument of the first subsequent supported input event.
> > > > 
> > > > Clients that care about high-resolution timestamps just need to keep
> > > > track of the last timestamp event they receive and associate it with the
> > > > next supported input event that arrives.
> > > > 
> > > > Signed-off-by: Alexandros Frantzis 
> > > > Reviewed-by: Pekka Paalanen 
> > > > Acked-by: Jonas Ådahl 
> > > > ---
> > > > 
> > > > Changes in v2:
> > > >  - Add '...carrying a timestamp...' to better describe the set of 
> > > > subsequent
> > > >input events in the timestamp event description. 
> > > >  - Clarify normalization requirements of tv_sec_hi, tv_sec_lo, tv_nsec
> > > >timestamp representation.
> > > > 
> > > >  Makefile.am|   1 +
> > > >  unstable/input-timestamps/README   |   4 +
> > > >  .../input-timestamps-unstable-v1.xml   | 145 
> > > > +
> > > >  3 files changed, 150 insertions(+)
> > > >  create mode 100644 unstable/input-timestamps/README
> > > >  create mode 100644 
> > > > unstable/input-timestamps/input-timestamps-unstable-v1.xml  
> > > 
> > > Cool! I suppose we want to see the Weston implementation patches posted
> > > to the list before landing this?  
> > 
> > The plan is to refresh and clean up the proof-of-concept Weston
> > implementation and propose it. For those interested to take an
> > early look the p-o-c code is at:
> > 
> > https://gitlab.collabora.com/alf/weston/commits/zwp-input-timestamps  
> 
> Hi all,
> 
> a heads-up that I have posted the libweston input-timestamps patchset
> for review at:
> 
> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036392.html

Hi,

I have been going through the Weston implementation enough that I can
confidently land the wayland-protocols patch tomorrow, Friday.

If anyone has doubts, please shout.


Thanks,
pq


pgpQgsLj4hbxE.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Alexandros Frantzis]

On Tue, Dec 19, 2017 at 01:06:11PM +0200, Alexandros Frantzis wrote:
> On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote:
> > On Mon, 18 Dec 2017 14:55:00 +0200
> > Alexandros Frantzis  wrote:
> > 
> > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit
> > > timestamp with millisecond resolution. In some cases, notably latency
> > > measurements, this resolution is too coarse to be useful.
> > > 
> > > This protocol provides additional high-resolution timestamps events,
> > > which are emitted before the corresponding input event. Each timestamp
> > > event contains a high-resolution, and ideally higher-accuracy, version
> > > of the 'time' argument of the first subsequent supported input event.
> > > 
> > > Clients that care about high-resolution timestamps just need to keep
> > > track of the last timestamp event they receive and associate it with the
> > > next supported input event that arrives.
> > > 
> > > Signed-off-by: Alexandros Frantzis 
> > > Reviewed-by: Pekka Paalanen 
> > > Acked-by: Jonas Ådahl 
> > > ---
> > > 
> > > Changes in v2:
> > >  - Add '...carrying a timestamp...' to better describe the set of 
> > > subsequent
> > >input events in the timestamp event description. 
> > >  - Clarify normalization requirements of tv_sec_hi, tv_sec_lo, tv_nsec
> > >timestamp representation.
> > > 
> > >  Makefile.am|   1 +
> > >  unstable/input-timestamps/README   |   4 +
> > >  .../input-timestamps-unstable-v1.xml   | 145 
> > > +
> > >  3 files changed, 150 insertions(+)
> > >  create mode 100644 unstable/input-timestamps/README
> > >  create mode 100644 
> > > unstable/input-timestamps/input-timestamps-unstable-v1.xml
> > 
> > Cool! I suppose we want to see the Weston implementation patches posted
> > to the list before landing this?
> 
> The plan is to refresh and clean up the proof-of-concept Weston
> implementation and propose it. For those interested to take an
> early look the p-o-c code is at:
> 
> https://gitlab.collabora.com/alf/weston/commits/zwp-input-timestamps

Hi all,

a heads-up that I have posted the libweston input-timestamps patchset
for review at:

https://lists.freedesktop.org/archives/wayland-devel/2017-December/036392.html

Thanks,
Alexandros
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Alexandros Frantzis]

On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote:
> On Mon, 18 Dec 2017 14:55:00 +0200
> Alexandros Frantzis  wrote:
> 
> > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit
> > timestamp with millisecond resolution. In some cases, notably latency
> > measurements, this resolution is too coarse to be useful.
> > 
> > This protocol provides additional high-resolution timestamps events,
> > which are emitted before the corresponding input event. Each timestamp
> > event contains a high-resolution, and ideally higher-accuracy, version
> > of the 'time' argument of the first subsequent supported input event.
> > 
> > Clients that care about high-resolution timestamps just need to keep
> > track of the last timestamp event they receive and associate it with the
> > next supported input event that arrives.
> > 
> > Signed-off-by: Alexandros Frantzis 
> > Reviewed-by: Pekka Paalanen 
> > Acked-by: Jonas Ådahl 
> > ---
> > 
> > Changes in v2:
> >  - Add '...carrying a timestamp...' to better describe the set of subsequent
> >input events in the timestamp event description. 
> >  - Clarify normalization requirements of tv_sec_hi, tv_sec_lo, tv_nsec
> >timestamp representation.
> > 
> >  Makefile.am|   1 +
> >  unstable/input-timestamps/README   |   4 +
> >  .../input-timestamps-unstable-v1.xml   | 145 
> > +
> >  3 files changed, 150 insertions(+)
> >  create mode 100644 unstable/input-timestamps/README
> >  create mode 100644 
> > unstable/input-timestamps/input-timestamps-unstable-v1.xml
> 
> Cool! I suppose we want to see the Weston implementation patches posted
> to the list before landing this?

The plan is to refresh and clean up the proof-of-concept Weston
implementation and propose it. For those interested to take an
early look the p-o-c code is at:

https://gitlab.collabora.com/alf/weston/commits/zwp-input-timestamps

> Alf, what would you have for the client side of the implementation?

The weston p-o-c implementation branch includes tests that I think
exhibit well the client side use of this protocol, but if that's not
sufficient I am happy to add or enhance an example client to use this
protocol.

Thanks,
Alexandros
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Pekka Paalanen]

On Mon, 18 Dec 2017 14:55:00 +0200
Alexandros Frantzis  wrote:

> wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit
> timestamp with millisecond resolution. In some cases, notably latency
> measurements, this resolution is too coarse to be useful.
> 
> This protocol provides additional high-resolution timestamps events,
> which are emitted before the corresponding input event. Each timestamp
> event contains a high-resolution, and ideally higher-accuracy, version
> of the 'time' argument of the first subsequent supported input event.
> 
> Clients that care about high-resolution timestamps just need to keep
> track of the last timestamp event they receive and associate it with the
> next supported input event that arrives.
> 
> Signed-off-by: Alexandros Frantzis 
> Reviewed-by: Pekka Paalanen 
> Acked-by: Jonas Ådahl 
> ---
> 
> Changes in v2:
>  - Add '...carrying a timestamp...' to better describe the set of subsequent
>input events in the timestamp event description. 
>  - Clarify normalization requirements of tv_sec_hi, tv_sec_lo, tv_nsec
>timestamp representation.
> 
>  Makefile.am|   1 +
>  unstable/input-timestamps/README   |   4 +
>  .../input-timestamps-unstable-v1.xml   | 145 
> +
>  3 files changed, 150 insertions(+)
>  create mode 100644 unstable/input-timestamps/README
>  create mode 100644 unstable/input-timestamps/input-timestamps-unstable-v1.xml

Cool! I suppose we want to see the Weston implementation patches posted
to the list before landing this?

Alf, what would you have for the client side of the implementation?


Thanks,
pq


pgp0KuWkRf4yO.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

[Alexandros Frantzis]

wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit
timestamp with millisecond resolution. In some cases, notably latency
measurements, this resolution is too coarse to be useful.

This protocol provides additional high-resolution timestamps events,
which are emitted before the corresponding input event. Each timestamp
event contains a high-resolution, and ideally higher-accuracy, version
of the 'time' argument of the first subsequent supported input event.

Clients that care about high-resolution timestamps just need to keep
track of the last timestamp event they receive and associate it with the
next supported input event that arrives.

Signed-off-by: Alexandros Frantzis 
Reviewed-by: Pekka Paalanen 
Acked-by: Jonas Ådahl 
---

Changes in v2:
 - Add '...carrying a timestamp...' to better describe the set of subsequent
   input events in the timestamp event description. 
 - Clarify normalization requirements of tv_sec_hi, tv_sec_lo, tv_nsec
   timestamp representation.

 Makefile.am|   1 +
 unstable/input-timestamps/README   |   4 +
 .../input-timestamps-unstable-v1.xml   | 145 +
 3 files changed, 150 insertions(+)
 create mode 100644 unstable/input-timestamps/README
 create mode 100644 unstable/input-timestamps/input-timestamps-unstable-v1.xml

diff --git a/Makefile.am b/Makefile.am
index cabc279..4b9a901 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -16,6 +16,7 @@ unstable_protocols =  
\
unstable/xwayland-keyboard-grab/xwayland-keyboard-grab-unstable-v1.xml  
\

unstable/keyboard-shortcuts-inhibit/keyboard-shortcuts-inhibit-unstable-v1.xml \
unstable/xdg-output/xdg-output-unstable-v1.xml  
\
+   unstable/input-timestamps/input-timestamps-unstable-v1.xml  \
$(NULL)
 
 stable_protocols = 
\
diff --git a/unstable/input-timestamps/README b/unstable/input-timestamps/README
new file mode 100644
index 000..3e82890
--- /dev/null
+++ b/unstable/input-timestamps/README
@@ -0,0 +1,4 @@
+High-resolution timestamps for input events.
+
+Maintainers:
+Alexandros Frantzis 
diff --git a/unstable/input-timestamps/input-timestamps-unstable-v1.xml 
b/unstable/input-timestamps/input-timestamps-unstable-v1.xml
new file mode 100644
index 000..7c5e082
--- /dev/null
+++ b/unstable/input-timestamps/input-timestamps-unstable-v1.xml
@@ -0,0 +1,145 @@
+
+
+
+  
+Copyright © 2017 Collabora, Ltd.
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice (including the next
+paragraph) shall be included in all copies or substantial portions of the
+Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
+  
+
+  
+This protocol specifies a way for a client to request and receive
+high-resolution timestamps for input events.
+
+Warning! The protocol described in this file is experimental and
+backward incompatible changes may be made. Backward compatible changes
+may be added together with the corresponding interface version bump.
+Backward incompatible changes are done by bumping the version number in
+the protocol and interface names and resetting the interface version.
+Once the protocol is to be declared stable, the 'z' prefix and the
+version number in the protocol and interface names are removed and the
+interface version number is reset.
+  
+
+  
+
+  A global interface used for requesting high-resolution timestamps
+  for input events.
+
+
+
+  
+Informs the server that the client will no longer be using this
+protocol object. Existing objects created by this object are not
+affected.
+  
+
+
+
+  
+Creates a new input timestamps object that represents a subscription
+to high-resolution