Re: [PATCH weston] build: honour libinput header location

[Emil Velikov]

On 15 March 2018 at 13:11, Jan Engelhardt  wrote:
>
> On Thursday 2018-03-15 13:20, Pekka Paalanen wrote:
>>> diff --git a/Makefile.am b/Makefile.am
>>> index b5c29c04..8de40e51 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -43,7 +43,8 @@ AM_CPPFLAGS =  \
>>>  -I$(top_builddir)/protocol  \
>>>  -DLIBWESTON_MODULEDIR='"$(libweston_moduledir)"' \
>>>  -DLIBEXECDIR='"$(libexecdir)"'  \
>>> --DBINDIR='"$(bindir)"'
>>> +-DBINDIR='"$(bindir)"' \
>>> +$(LIBINPUT_BACKEND_CFLAGS)
>>>
>>>  CLEANFILES = weston.ini \
>>>  ivi-shell/weston.ini\
>>
>>I don't think we want the libinput flags on *everything*
>
> It does not really matter, the libinput API is not bad.
> Not nearly as bad as some science software, anyhow.
>
> The "only" downside of using target_CPPFLAGS is that
> (a) the generated Makefile, Makefile.in gets bigger - somewhat larger release 
> tarball
> (b) sources part of multiple targets can get built twice to accomodate 
> invocations
> with different CPPFLAGS, even if the different CPPFLAGS still lead to the
> same gcc -E output.
>
Or in a Tl;Dr - there are no serious issues either way.
Proposed patch/result is shorter. Regardless, will send v2 in a moment.

>
>>Or do you think we should actually have CFLAGS of all deps with
>>everything we build, and just gate the LIBS we link with to the targets
>>that actually need it?
>
> That's the easy way, and the one requiring the fewest keystrokes IMO.
Agreed. Some projects opt for unconditionally add all CFLAGS, while
others prefer to keep it conditional.

In either case, I'd welcome if any notable changes/reshuffle do not
hold this* fix.
Thanks
Emil

* ... or analogous of course.
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston] build: honour libinput header location

[Jan Engelhardt]

On Thursday 2018-03-15 13:20, Pekka Paalanen wrote:
>> diff --git a/Makefile.am b/Makefile.am
>> index b5c29c04..8de40e51 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -43,7 +43,8 @@ AM_CPPFLAGS =  \
>>  -I$(top_builddir)/protocol  \
>>  -DLIBWESTON_MODULEDIR='"$(libweston_moduledir)"' \
>>  -DLIBEXECDIR='"$(libexecdir)"'  \
>> --DBINDIR='"$(bindir)"'
>> +-DBINDIR='"$(bindir)"' \
>> +$(LIBINPUT_BACKEND_CFLAGS)
>>  
>>  CLEANFILES = weston.ini \
>>  ivi-shell/weston.ini\
>
>I don't think we want the libinput flags on *everything*

It does not really matter, the libinput API is not bad.
Not nearly as bad as some science software, anyhow.

The "only" downside of using target_CPPFLAGS is that
(a) the generated Makefile, Makefile.in gets bigger - somewhat larger release 
tarball
(b) sources part of multiple targets can get built twice to accomodate 
invocations
with different CPPFLAGS, even if the different CPPFLAGS still lead to the
same gcc -E output.


>Or do you think we should actually have CFLAGS of all deps with
>everything we build, and just gate the LIBS we link with to the targets
>that actually need it?

That's the easy way, and the one requiring the fewest keystrokes IMO.
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston] build: honour libinput header location

[Pekka Paalanen]

On Tue, 27 Feb 2018 14:14:27 +
Emil Velikov  wrote:

> From: Jan Engelhardt 
> 
> Add the respective CFLAGS to the build, otherwise the build will error
> out as seen below.
> 
> src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory
> 
> [Emil Velikov: polish commit message]
> Signed-off-by: Emil Velikov 
> ---
> Jan, don't be shy to send patches upstream. Devs. won't bite... most of
> the time ;-)
> ---
>  Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index b5c29c04..8de40e51 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -43,7 +43,8 @@ AM_CPPFLAGS =   \
>   -I$(top_builddir)/protocol  \
>   -DLIBWESTON_MODULEDIR='"$(libweston_moduledir)"' \
>   -DLIBEXECDIR='"$(libexecdir)"'  \
> - -DBINDIR='"$(bindir)"'
> + -DBINDIR='"$(bindir)"' \
> + $(LIBINPUT_BACKEND_CFLAGS)
>  
>  CLEANFILES = weston.ini  \
>   ivi-shell/weston.ini\

Hi,

I don't think we want the libinput flags on *everything*, but in the
same places where LIBINPUT_BACKEND_LIBS are already used.

Or do you think we should actually have CFLAGS of all deps with
everything we build, and just gate the LIBS we link with to the targets
that actually need it?


Thanks,
pq


pgpZYJqXR2xa2.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] build: honour libinput header location

[Emil Velikov]

From: Jan Engelhardt 

Add the respective CFLAGS to the build, otherwise the build will error
out as seen below.

src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory

[Emil Velikov: polish commit message]
Signed-off-by: Emil Velikov 
---
Jan, don't be shy to send patches upstream. Devs. won't bite... most of
the time ;-)
---
 Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index b5c29c04..8de40e51 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -43,7 +43,8 @@ AM_CPPFLAGS = \
-I$(top_builddir)/protocol  \
-DLIBWESTON_MODULEDIR='"$(libweston_moduledir)"' \
-DLIBEXECDIR='"$(libexecdir)"'  \
-   -DBINDIR='"$(bindir)"'
+   -DBINDIR='"$(bindir)"' \
+   $(LIBINPUT_BACKEND_CFLAGS)
 
 CLEANFILES = weston.ini\
ivi-shell/weston.ini\
-- 
2.16.0

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel