On 16/01/2017 14:04, Daniel Stone wrote:
Hi,
On 16 January 2017 at 13:01, Emil Velikov wrote:
On 15 January 2017 at 12:26, Quentin Glidic
wrote:
- PKG_CHECK_MODULES(PANGO, [pangocairo], [have_pango=yes], [have_pango=no])
+ PKG_CHECK_MODULES(PANGO, [pangocairo pango glib >= 2.36], [have_pan
Hi,
On 16 January 2017 at 13:01, Emil Velikov wrote:
> On 15 January 2017 at 12:26, Quentin Glidic
> wrote:
>> - PKG_CHECK_MODULES(PANGO, [pangocairo], [have_pango=yes], [have_pango=no])
>> + PKG_CHECK_MODULES(PANGO, [pangocairo pango glib >= 2.36],
>> [have_pango=yes], [have_pango=no])
>
> A
On 15 January 2017 at 12:26, Quentin Glidic
wrote:
> From: Quentin Glidic
>
> HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong.
> g_type_init() was never called, which is fine since GLib 2.36 anyway.
> It is better not to have a wrong usage of HAVE_PANGO here.
> Just check for GLi
From: Quentin Glidic
HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong.
g_type_init() was never called, which is fine since GLib 2.36 anyway.
It is better not to have a wrong usage of HAVE_PANGO here.
Just check for GLib 2.36 in configure.ac instead.
Signed-off-by: Quentin Glidic