[PATCH libinput 3/8] test: fix compiler warnings for missing prototypes

litest-wacom-touch.c:31:6: warning: no previous prototype for 'litest_wacom_touch_setup' [-Wmissing-prototypes] and similar Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest-synaptics-st.c | 3 ++- test/litest-synaptics.c| 3 ++- test/litest-wacom-touch.c | 3 ++- 3

[PATCH libinput 5/8] test: silence compiler warning for C++ build test

cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ [enabled by default] Since gcc also complains about adding -Wno-strict-prototypes we have to handle the two separately. A side-effect here: now that we promote the GCC_CFLAGS to AM_CFLAGS, litest.la is

[PATCH libinput 6/8] test: drop TEST_CFLAGS

We're using the same flags for everything anyway, drop the custom flags Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 53a3300..70e83d4 100644

[PATCH libinput 7/8] test: add --verbose flag to litests

Sometimes it's handy to see what libinput prints out while running a test. This breaks test-log if run with --verbose. Checking that the default log priority hasn't changed obviously doesn't work if we change it on demand. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c

[PATCH libinput 8/8] Mark the log function as attribute printf

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index d771e21..b4cb5e5 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -31,6 +31,9 @@ extern C { #include

Maximizing window after fullscreening it in weston desktop shell

The handling about window states has been improved recently but there still seems some problem with that. When I was running weston-stacking with yesterday's snapshot of weston (weston-stacking in 1.5.0 is much more troublesome), I found if I press m (maximize) multiple times after

Re: [PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

On Tue, 3 Jun 2014 10:03:57 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 30 May 2014 12:08:16 +0200 Jonny Lamb jonny.l...@collabora.co.uk wrote: --- protocol/wayland.xml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/protocol/wayland.xml

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

Hi, On 06/04/2014 10:57 PM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may

[PATCH weston] fix SIGSEGV in Weston data_device_start_drag() during, weston-dnd

Hi, This is a trivial fix for SIGSEGV described in https://bugs.freedesktop.org/show_bug.cgi?id=79725 occurring due to null pointer dereference. Currently I do not have enough knowledge about the protocol itself to be certain if this is not a deeper bug down the line requiring an assertion

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 12:18 AM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 05:40 AM, Peter Hutterer wrote: On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a

[PATCH libinput 2/3] evdev-mt-touchpad-buttons: Switch over to new timer subsystem

Besides being a nice cleanup, this gives us proper per touch timeouts. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 95 + src/evdev-mt-touchpad.c | 3 +-

[PATCH libinput 0/3] Add a timer subsystem series v2

Hi, Here is v2 of my timer subsystem series with all the review comments fixed. Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput 1/3] Add a timer subsystem

Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout per touch, which means that if a timeout is set for 100ms from now for touch 1, and then 50 ms later touch 2 sets

[PATCH libinput 3/3] evdev-mt-touchpad-tap: Switch over to new timer subsystem

Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-tap.c | 76 ++--- src/evdev-mt-touchpad.c | 1 - src/evdev-mt-touchpad.h | 7 + 3 files changed, 10 insertions(+),

Re: [PATCH weston] Clients: Fix memleak issues in various clients of weston

On Thu, May 15, 2014 at 06:58:16PM +0530, vivek wrote: In many clients of weston, Display was not being destroyed so added it. Also destroy windows, widgets which were not being destroyed. Signed-off-by: vivek vivek.el...@samsung.com LGTM Reviewed-by: Bryce Harrington