Re: [PATCH] server: Fix crash when accessing client which is already freed

2016-09-22 Thread Giulio Camuffo
Hi, could you write how to trigger the crash, also in the commit message maybe? Besides that, i have a comment inline below. 2016-09-21 9:08 GMT+02:00 Hyunkook Khang : > While processing pending data, client could be destroyed in the middle of > the process. (e.g. by invoking wl_display_flush_cli

[PATCH wayland v5] util: Document wl_list methods

2016-09-22 Thread Yong Bakos
From: Yong Bakos Add doxygen comment blocks to all wl_list methods. Signed-off-by: Yong Bakos --- v5: Change description to linked-list (pq) Clarify uses of `wl_list_init` (pq) v4: Fix variable name in sample code. (pq) Remove implemenetation details of pointer state. (pq) Remove no

[PATCH wayland v6] util: Document wl_list methods

2016-09-22 Thread Yong Bakos
From: Yong Bakos Add doxygen comment blocks to all wl_list methods. Signed-off-by: Yong Bakos --- v6: Change description to doubly-linked list (pq) v5: Change description to linked-list [err] Clarify uses of `wl_list_init` (pq) v4: Fix variable name in sample code. (pq) Remove implemene

Re: [PATCH wayland v6] util: Document wl_list methods

2016-09-22 Thread Bryce Harrington
On Thu, Sep 22, 2016 at 09:59:37PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Add doxygen comment blocks to all wl_list methods. > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington One extremely minor wording suggestion below only if you do another rev. But this all looks extrem

[PATCH] xdg-shell: validate positioner object

2016-09-22 Thread Sjoerd Simons
According to the xdg-shell v6 protocol a positioner object is only complete if both the size and its anchor are set. Ensure the weston clients do this and let weston be more strict on checking if a client has done so. This also fixes weston-terminal popups not showing up on gnome-shell 3.22. Sign