Re: [PATCH wayland-protocols 1/2] tests: Use public-code and private-code instead of code

2018-07-30 Thread Simon Ser
On July 30, 2018 4:10 PM, Jonas Ådahl wrote: > The wayland-scanner sub-commands private-code and public-code replaced > the old code command, so lets use those in the tests instead. > > Signed-off-by: Jonas Ådahl LGTM and works. Reviewed-by: Simon Ser > --- > tests/scan.sh | 3 ++- > 1 file

Re: [ANNOUNCE] wayland-protocols 1.16

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 18:42:01 +0200 Jonas Ådahl wrote: > wayland-protocols 1.16 is now available. > > This version includes a new version of the unstable text-input protocol. The > new version is not compatible with the old version. Please check the commit > adding the new protocols for more

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 01:29:04PM +0200, Dorota Czaplejewicz wrote: > On Mon, 30 Jul 2018 13:09:06 +0200 > Jonas Ådahl wrote: > > > On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > > > On Mon, 30 Jul 2018 12:36:45 +0200 > > > Jonas Ådahl wrote: > > > > > > > On Sat,

Re: [PATCH v9 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 15:20:05 +0200 Jonas Ådahl wrote: > On Mon, Jul 30, 2018 at 02:44:47PM +0200, Dorota Czaplejewicz wrote: > > From: Carlos Garnacho > > > > This new protocol description is an evolution of v2. > > > > - All pre-edit text styling is gone. > > - Pre-edit cursor can span

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 04:24:00PM +0200, Carlos Garnacho wrote: > Hey, > > With the serial number behavior cleared out, this all reads great to > me. Can't be part and judge though :), so no R-b label. I'll put my R-b stamp on it; I think we're good to go now! Jonas > > Cheers, > Carlos >

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 04:44:51PM +0200, Jonas Ådahl wrote: > On Mon, Jul 30, 2018 at 10:35:49AM -0400, Simon Ser wrote: > > On July 30, 2018 3:14 PM, Dorota Czaplejewicz > > wrote: > > > From: Carlos Garnacho > > > > > > This new protocol description is an evolution of v2. > > > > > > - All

Re: [PATCH wayland-protocols 2/2] tests: Make wayland-scanner strict

2018-07-30 Thread Daniel Stone
Hi Jonas, On Mon, 30 Jul 2018 at 16:10, Jonas Ådahl wrote: > Pass --strict to wayland-scanner in order to make it exit with failure > if something wasn't correct. The series is: Reviewed-by: Daniel Stone It might be nice to autodetect whether or not wayland-scanner is new enough to support

[PATCH v11 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is an evolution of v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

2018-07-30 Thread Daniel Stone
Hi, On Fri, 20 Jul 2018 at 11:08, Quentin Glidic wrote: > Then, all four patches are: > Reviewed-by: Quentin Glidic > (With or without the split.) So from mail, that's myself, Quentin, Emre, Erik, and Pekka supporting the move, with qualified support (... semi-enthusiasm?) from Jonas. From

Re: [PATCH wayland-protocols 2/2] tests: Make wayland-scanner strict

2018-07-30 Thread Simon Ser
On July 30, 2018 4:10 PM, Jonas Ådahl wrote: > Pass --strict to wayland-scanner in order to make it exit with failure > if something wasn't correct. > > Signed-off-by: Jonas Ådahl LGTM and catches the inside issue. Reviewed-by: Simon Ser > --- > tests/scan.sh | 8 > 1 file

Re: [PATCH v11 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Simon Ser
> From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered rectangle. > Compositors are still free to handle situations where the

[ANNOUNCE] wayland-protocols 1.16

2018-07-30 Thread Jonas Ådahl
wayland-protocols 1.16 is now available. This version includes a new version of the unstable text-input protocol. The new version is not compatible with the old version. Please check the commit adding the new protocols for more details about the introduced changes. The stable xdg-shell protocol

Re: [PATCH v3 0/3] Change wording in xdg-shell stable

2018-07-30 Thread Jonas Ådahl
Patch 1 and 2 look fine to me. While it look a bit like a change in semantics, given the possibility of race conditions etc, clients could never make any assumptions about any state in future configure events. The third patch, however, is more problematic, as it is possible that clients may have

Re: [PATCH v11 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 05:11:01PM +0200, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered

[PATCH wayland-protocols 2/2] tests: Make wayland-scanner strict

2018-07-30 Thread Jonas Ådahl
Pass --strict to wayland-scanner in order to make it exit with failure if something wasn't correct. Signed-off-by: Jonas Ådahl --- tests/scan.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/scan.sh b/tests/scan.sh index 0b1ff00..cad6887 100755 ---

[PATCH wayland-protocols 1/2] tests: Use public-code and private-code instead of code

2018-07-30 Thread Jonas Ådahl
The wayland-scanner sub-commands private-code and public-code replaced the old code command, so lets use those in the tests instead. Signed-off-by: Jonas Ådahl --- tests/scan.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/scan.sh b/tests/scan.sh index

[PATCH] connection: Detect overflows in length field.

2018-07-30 Thread Michal Srb
The length field can be any uint32 value. Two kinds of overflows may happen on 32 bit systems: 1) If the value is in range [UINT32_MAX-3, UINT32_MAX], the DIV_ROUNDUP will turn it into 0. Then `next` equals `p` and so the big `length` is not detected. But the wl_array will contain the original

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Simon Ser
On July 30, 2018 3:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered rectangle. >

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 13:09:06 +0200 Jonas Ådahl wrote: > On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > > On Mon, 30 Jul 2018 12:36:45 +0200 > > Jonas Ådahl wrote: > > > > > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > > > From: Carlos

Re: [PATCH v9 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 02:44:47PM +0200, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Carlos Garnacho
Hey, With the serial number behavior cleared out, this all reads great to me. Can't be part and judge though :), so no R-b label. Cheers, Carlos On Mon, Jul 30, 2018 at 4:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > -

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
On Mon, 30 Jul 2018 12:36:45 +0200 Jonas Ådahl wrote: > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > From: Carlos Garnacho > > > > This new protocol description is an evolution of v2. > > > > - All pre-edit text styling is gone. > > - Pre-edit cursor can span

[PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is an evolution of v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

Re: [PATCH v9 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 03:59:48PM +0200, Dorota Czaplejewicz wrote: > On Mon, 30 Jul 2018 15:20:05 +0200 > Jonas Ådahl wrote: > > > On Mon, Jul 30, 2018 at 02:44:47PM +0200, Dorota Czaplejewicz wrote: > > > From: Carlos Garnacho > > > > > > This new protocol description is an evolution of v2.

Re: [PATCH v8 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 12:57:52PM +0200, Dorota Czaplejewicz wrote: > On Mon, 30 Jul 2018 12:36:45 +0200 > Jonas Ådahl wrote: > > > On Sat, Jul 28, 2018 at 08:17:56PM +0200, Dorota Czaplejewicz wrote: > > > From: Carlos Garnacho > > > > > > This new protocol description is an evolution of v2.

[PATCH v9 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is an evolution of v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 10:35:49AM -0400, Simon Ser wrote: > On July 30, 2018 3:14 PM, Dorota Czaplejewicz > wrote: > > From: Carlos Garnacho > > > > This new protocol description is an evolution of v2. > > > > - All pre-edit text styling is gone. > > - Pre-edit cursor can span characters. > >

RE: [PATCH weston v5 10/14] compositor: protocol logger

2018-07-30 Thread Ucan, Emre (ADITG/ESB)
Hi Daniel, We found an issue with this patch. I am adding a patch to this email to fix this issue. Please check: Subject: [PATCH] main: copy va_list for second use we are using va_list once for debug protocol and once for local logging to stdout. After first use the list is invalidated.

Re: [PATCH v4 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2018-07-30 Thread Simon Ser
On July 29, 2018 6:55 PM, Dorota Czaplejewicz wrote: > On Tue, 24 Jul 2018 15:10:29 +0200 > Dorota Czaplejewicz wrote: > > > On Thu, 12 Jul 2018 18:15:32 -0400 > > Simon Ser wrote: > > > > > Hi, > > > > > > Sorry for the delay. > > > > > > I'm not sure I like this new design. > > > > > >

[ANNOUNCE] libinput 1.11.901

2018-07-30 Thread Peter Hutterer
The first RC for libinput 1.12 is now available. First a heads-up, this is probably going to be a longer RC cycle than usual which is why I'm getting an RC out very soon after the 1.11 release. But we're accumulating a few big changes and I really need testing feedback. Expect there to be more