> + if (!devnode) { > + log_info(libinput, "%s: no device node associated\n", > sysname); > + return NULL; > + } > + > if (udev_device_should_be_ignored(udev_device)) { > log_debug(libinput, "%s: device is ignored\n", sysname); > return NULL;
As long as you are intentionally wanting this reported even if the device "should be ignored", then it LGTM. > + if (devnode == NULL) > + return -ENODEV; > + Checking (!devnode) would be better as it matches the other change, and in evdev.c implicit NULL comparison is much more common than explicit NULL comparison. AFAICT, the return value from evdev_device_resume is never checked, so it seems that this may be a good place for a log message too. Would it be noisy? If so, maybe a log_debug would be enough. -- Jeff _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel