[PATCH v3 0/2] Add tablet_v2 suport to weston-info

2018-04-30 Thread wl
From: Markus Ongyerth Changes since v2: * Incorporated style changes as requested by Peter Exception: Single line multi declaration. Cheers, ongy Markus Ongyerth (2): weston-info: Add support for tablet-unstable-v2 weston-info: destroy wl_keyboard Makefile.am |

[PATCH v3 1/2] weston-info: Add support for tablet-unstable-v2

2018-04-30 Thread wl
From: Markus Ongyerth This now prints each tablet seat with at least one tablet/pad/tool attached. For each tablet seat, each tablet, pad and tool is printed with as much detail about the device as the protocol provides. Seat info is stored to be referenced, because the protocol

[PATCH v3 2/2] weston-info: destroy wl_keyboard

2018-04-30 Thread wl
From: Markus Ongyerth Fixes a memory leak by calling wl_keyboard_destroy on a any keyboard that was used to listen for events. Signed-off-by: Markus Ongyerth Acked-by: Pekka Paalanen Reviewed-by: Peter Hutterer

[PATCH 0/1] Add remove-without-free test

2018-02-23 Thread wl
From: Markus Ongyerth In [1] it was pointed out, that the proposed patch breaks code, that does not remove their listener from a wl_signal list, but just free()s them. From libwayland's perspective, this has never been different. People just got lucky. wl_priv_signal_emit will

[PATCH 1/1] tests: Add free-without-remove test

2018-02-23 Thread wl
From: Markus Ongyerth This is related to the discussion earlier on the mailing list and demonstrates a problem with current wl_priv_signal_emit and wl_listener that free themselves, but do not remove from the list. The testcase itself passes. And I'm not sure if that can be

[PATCH 0/1] free-without-remove v2

2018-02-23 Thread wl
From: Markus Ongyerth This is a v2 for the free-without-remove test, that actually fails the test and does not require the use of valgrind to make observe the problem. This is intended to fail at the moment, as the primary purpose is to show a problem with current days

[PATCH 1/1] tests: Add free-without-remove test

2018-02-23 Thread wl
From: Markus Ongyerth This is related to the discussion earlier on the mailing list and demonstrates a problem with current wl_priv_signal_emit and wl_listener that free themselves, but do not remove from the list. This testcase asserts that the wl_list inside wl_listener is not

[PATCH v3 0/3] Change wording in xdg-shell stable

2018-07-20 Thread wl
From: Markus Ongyerth v2 was https://lists.freedesktop.org/archives/wayland-devel/2018-June/038734.html Changes from v2: Moved the word wrapping change into the first commit, as pointed out by Simon. Markus Ongyerth (3): xdg-shell: move maximized state definition together xdg-shell: Make

[PATCH v3 3/3] xdg-shell: Give compositor control over configure

2018-07-20 Thread wl
From: Markus Ongyerth The `[un]set_(fullscreen/maximized)` requests text requires compositors to respon to the request with a configure event. with the asynchronous nature of wayland protocols, this provides essentially no benefit and might entice consumers to rely on details that are not

[PATCH v3 1/3] xdg-shell: move maximized state definition together

2018-07-20 Thread wl
From: Markus Ongyerth The xdg-shell documentation had part of the maximized state render implications in the `set_maximized` request documentation, not the actual state. This moves the relevant lines into the state description. Signed-off-by: Markus Ongyerth Reviewed-By: Mike Blumenkrantz ---

[PATCH v3 2/3] xdg-shell: Make sure wording reflects expectations

2018-07-20 Thread wl
From: Markus Ongyerth The wording in xdg-shell's `set_*` requests implies the compositor *will* honour the client's request. This would give clients the control over their actual state, while the general expectation is that clients kindly ask for state changes which the compositor may follow.

[PATCH 2/2] weston-info: destroy wl_keyboard

2018-04-24 Thread wl
From: Markus Ongyerth Fixes a memory leak by calling wl_keyboard_destroy on a any keyboard that was used to listen for events. Signed-off-by: Markus Ongyerth --- clients/weston-info.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] weston-info: Add support for tablet-unstable-v2

2018-04-24 Thread wl
From: Markus Ongyerth This now prints each tablet seat with at least one tablet/pad/tool attached. For each tablet seat, each tablet, pad and tool is printed with as much detail about the device as the protocol provides. Seat info is stored to be referenced, because the protocol

[PATCH 0/2] Add tablet_v2 support to weston-info

2018-04-24 Thread wl
From: Markus Ongyerth Hi, the first commit adds support for the tablet-unstable-v2 protocol to weston-info. It will output the currently attached tablets, tablet_pads and tablet_tools with all info provided by the protocol. An example output: ``` interface:

[PATCH 1/2] xdg-shell: move maximized state difnition together

2018-02-27 Thread wl
From: Markus Ongyerth The xdg-shell documentation had part of the maximized state render implications in the `set_maximized` request documentation, not the actual state. This moves the relevant lines into the state description. Signed-off-by: Markus Ongyerth ---

[PATCH 0/2] Improve wording in xdg-shell

2018-02-27 Thread wl
From: Markus Ongyerth Hi, this is a small patch series that pulls together the definition of the maximized state and slightly improves the wording in xdg-shell `set_*` requests to reflect the amount of control clients have. Cheers, ongy Markus Ongyerth (2): xdg-shell: move

[PATCH 2/2] xdg-shell: Make sure wording reflects expectations

2018-02-27 Thread wl
From: Markus Ongyerth The wording in xdg-shell `set_*` requests implies the compositor *will* react to requests. This would give clients the control over its state, while they should just be able to kindly ask for a state change. This makes sure the language reflects that and

[PATCH v2 1/2] weston-info: Add support for tablet-unstable-v2

2018-04-26 Thread wl
From: Markus Ongyerth This now prints each tablet seat with at least one tablet/pad/tool attached. For each tablet seat, each tablet, pad and tool is printed with as much detail about the device as the protocol provides. Seat info is stored to be referenced, because the protocol

[PATCH v2 0/2] Add tablet_v2 support to weston-info

2018-04-26 Thread wl
From: Markus Ongyerth This is a v2 based on the suggestions from Simon on the v1. Changes: * Changed C90/C++ style comment to C style * Changed the *_v2_listener struct instances to be const Not changed: * struct tablet_path -> struct wl_array. I think wl_array is lacking in

[PATCH v2 2/2] weston-info: destroy wl_keyboard

2018-04-26 Thread wl
From: Markus Ongyerth Fixes a memory leak by calling wl_keyboard_destroy on a any keyboard that was used to listen for events. Signed-off-by: Markus Ongyerth --- clients/weston-info.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH] libwayland: Add WAYLAND_DEBUG_INTERFACES

2018-06-29 Thread wl
From: Markus Ongyerth Add environment variable WAYLAND_DEBUG_INTERFACES for filtering the output of WAYLAND_DEBUG logs. While WAYLAND_DEBUG is a pretty powerful and useful debug tool, printing everything has a few downsides. 1) It's a full keylogger (getting debug-logs from users) 2) It can be

[PATCH v2 3/3] xdg-shell: Give compositor control over configure

2018-06-29 Thread wl
From: Markus Ongyerth The `[un]set_(fullscreen/maximized)` requests text requires compositors to respon to the request with a configure event. with the asynchronous nature of wayland protocols, this provides essentially no benefit and might entice consumers to rely on details that are not

[PATCH v2 1/3] xdg-shell: move maximized state definition together

2018-06-29 Thread wl
From: Markus Ongyerth The xdg-shell documentation had part of the maximized state render implications in the `set_maximized` request documentation, not the actual state. This moves the relevant lines into the state description. Signed-off-by: Markus Ongyerth Reviewed-By: Mike Blumenkrantz ---

[PATCH v2 2/3] xdg-shell: Make sure wording reflects expectations

2018-06-29 Thread wl
From: Markus Ongyerth The wording in xdg-shell's `set_*` requests implies the compositor *will* honour the client's request. This would give clients the control over their actual state, while the general expectation is that clients kindly ask for state changes which the compositor may follow.

[PATCH v2 0/3] Change wording in xdg-shell stable

2018-06-29 Thread wl
From: Markus Ongyerth Hi, This is a v2 of a rather old patch series I more or less forgot about [1]. The previous version of patch 1 is [2] The patch 2 and 3 are based on are: [3] Patch 1 should still be quite straight forward. Patch 2 is the well received part of the previous Patch 2. Patch