Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-07-02 Thread Pekka Paalanen
On Mon, 2 Jul 2018 08:37:52 +0100 Emil Velikov wrote: > Agreed, DESTDIR in itself should be (and is) fine. > Some illustrations on the "disaster" mentioned earlier. > > git clean > ./configure > make // implicit all - weston.ini is generated > make bindir=foo install // weston.ini is not

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-07-02 Thread Emil Velikov
Hi All, Tl;Dr: Silly brain of mine auto-expanded $(foo). Patch might work, but as Quentin mentioned it won't majority of the time. Please consider this binned. On 29 June 2018 at 08:37, Pekka Paalanen wrote: > On Thu, 28 Jun 2018 18:59:01 +0100 > Emil Velikov wrote: > >> On 28 June 2018 at

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-29 Thread Pekka Paalanen
On Thu, 28 Jun 2018 18:59:01 +0100 Emil Velikov wrote: > On 28 June 2018 at 10:58, Quentin Glidic > wrote: > > On 6/27/18 3:04 PM, Emil Velikov wrote: > >> > >> From: Emil Velikov > >> > >> Adding those to configure.ac ensures that: > >> - the weston.ini files are {re,}generated only when

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 10:58, Quentin Glidic wrote: > On 6/27/18 3:04 PM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Adding those to configure.ac ensures that: >> - the weston.ini files are {re,}generated only when needed >> - the .in files are shipped in the tarball >> - all the

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-28 Thread Quentin Glidic
On 6/27/18 3:04 PM, Emil Velikov wrote: From: Emil Velikov Adding those to configure.ac ensures that: - the weston.ini files are {re,}generated only when needed - the .in files are shipped in the tarball - all the manual handling of the above can be removed ;-) Did you actually test

[PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-27 Thread Emil Velikov
From: Emil Velikov Adding those to configure.ac ensures that: - the weston.ini files are {re,}generated only when needed - the .in files are shipped in the tarball - all the manual handling of the above can be removed ;-) Note: the abs_top_builddir for weston-flower was swapped with the