Re: [PATCH weston] gl-renderer: Fix crash in dmabuf format query for fallback formats

[Daniel Stone]

Hi Philipp,

On 9 February 2018 at 20:59, Philipp Kerling  wrote:
> Since formats is an out parameter, we need to copy to the alloc'ed
> memory and not over the pointer address.

Oops, right you are. Reviewed and pushed, thanks!

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] gl-renderer: Fix crash in dmabuf format query for fallback formats

[Philipp Kerling]

Since formats is an out parameter, we need to copy to the alloc'ed
memory and not over the pointer address.

Signed-off-by: Philipp Kerling 
---
 libweston/gl-renderer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
index 371e06b3..d091d165 100644
--- a/libweston/gl-renderer.c
+++ b/libweston/gl-renderer.c
@@ -2122,7 +2122,7 @@ gl_renderer_query_dmabuf_formats(struct weston_compositor 
*wc,
}
 
if (fallback) {
-   memcpy(formats, fallback_formats, num * sizeof(int));
+   memcpy(*formats, fallback_formats, num * sizeof(int));
*num_formats = num;
return;
}
-- 
2.16.1

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel