Re: [PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-13 Thread Daniel Stone
Hi Emilio,

On Thu, 12 Jul 2018 at 12:47, Emilio Pozuelo Monfort  wrote:
> @@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry 
> *registry,
> d->fshell = wl_registry_bind(registry,
>  id, 
> &zwp_fullscreen_shell_v1_interface, 1);
> } else if (strcmp(interface, "zwp_linux_dmabuf_v1") == 0) {
> -   int ver;
> -   if (d->req_dmabuf_modifiers)
> -   ver = 3;
> -   else if (d->req_dmabuf_immediate)
> -   ver = 2;
> -   else
> -   ver = 1;
> d->dmabuf = wl_registry_bind(registry,
> -id, 
> &zwp_linux_dmabuf_v1_interface,
> -ver);
> +id, 
> &zwp_linux_dmabuf_v1_interface, 3);

This is missing a version check now, which I'll squash in when pushing.

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel


[PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-12 Thread Emilio Pozuelo Monfort
We effectively require it as we don't react to dmabuf_format,
only to dmabuf_modifiers, so there's a chance we may not get
the supported formats information at all.

Signed-off-by: Emilio Pozuelo Monfort 
---
v4: No changes here.

 clients/simple-dmabuf-drm.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c
index fcab30e5..1c8b6f36 100644
--- a/clients/simple-dmabuf-drm.c
+++ b/clients/simple-dmabuf-drm.c
@@ -85,7 +85,6 @@ struct display {
int nv12_format_found;
uint64_t nv12_modifier;
int req_dmabuf_immediate;
-   int req_dmabuf_modifiers;
 };
 
 struct drm_device {
@@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry 
*registry,
d->fshell = wl_registry_bind(registry,
 id, 
&zwp_fullscreen_shell_v1_interface, 1);
} else if (strcmp(interface, "zwp_linux_dmabuf_v1") == 0) {
-   int ver;
-   if (d->req_dmabuf_modifiers)
-   ver = 3;
-   else if (d->req_dmabuf_immediate)
-   ver = 2;
-   else
-   ver = 1;
d->dmabuf = wl_registry_bind(registry,
-id, &zwp_linux_dmabuf_v1_interface,
-ver);
+id, 
&zwp_linux_dmabuf_v1_interface, 3);
zwp_linux_dmabuf_v1_add_listener(d->dmabuf, &dmabuf_listener, 
d);
}
 }
@@ -861,7 +852,6 @@ create_display(int opts, int format)
assert(display->display);
 
display->req_dmabuf_immediate = opts & OPT_IMMEDIATE;
-   display->req_dmabuf_modifiers = (format == DRM_FORMAT_NV12);
 
/*
 * hard code format if the platform egl doesn't support format
-- 
2.18.0

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel