On Mon, 12 Feb 2018 13:15:45 +
Daniel Stone wrote:
> Hi Pekka,
>
> On 12 February 2018 at 13:11, Pekka Paalanen wrote:
> > On Mon, 12 Feb 2018 12:59:22 + Daniel Stone
> > wrote:
> >> On 12 February 2018 at 12:51, Pekka Paalanen wrote:
> >> > I believe nothing is depending on the
Hi Pekka,
On 12 February 2018 at 13:11, Pekka Paalanen wrote:
> On Mon, 12 Feb 2018 12:59:22 + Daniel Stone wrote:
>> On 12 February 2018 at 12:51, Pekka Paalanen wrote:
>> > I believe nothing is depending on the values of implicit padding bytes
>> > in structs anyway, if such happen to exi
On Mon, 12 Feb 2018 12:59:22 +
Daniel Stone wrote:
> Hi,
>
> On 12 February 2018 at 12:51, Pekka Paalanen wrote:
> > On Mon, 12 Feb 2018 12:28:55 + Daniel Stone
> > wrote:
> >> Second and last nitpick: this is very clever, but should probably just
> >> use memset() like everywhere e
Hi,
On 12 February 2018 at 12:51, Pekka Paalanen wrote:
> On Mon, 12 Feb 2018 12:28:55 + Daniel Stone wrote:
>> Second and last nitpick: this is very clever, but should probably just
>> use memset() like everywhere else.
>
> I hate memset. :-)
Me too!
> You have to explicitly give the size
On Mon, 12 Feb 2018 12:28:55 +
Daniel Stone wrote:
> Hi,
>
> On 9 February 2018 at 13:07, Pekka Paalanen wrote:
> > index 1897f455..a975b379 100644
> > --- a/libweston/compositor-drm.c
> > +++ b/libweston/compositor-drm.c
> > @@ -4347,6 +4347,8 @@ parse_modeline(const char *s, drmModeModeIn
Hi,
On 9 February 2018 at 13:07, Pekka Paalanen wrote:
> index 1897f455..a975b379 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -4347,6 +4347,8 @@ parse_modeline(const char *s, drmModeModeInfo *mode)
> char vsync[16];
> float fclock;
>
> +
From: Pekka Paalanen
Fixes the following Valgrind error:
==21607== Syscall param ioctl(generic) points to uninitialised byte(s)
==21607==at 0x5E8C787: ioctl (in /lib64/libc-2.25.so)
==21607==by 0x8220C17: drmIoctl (in /usr/lib64/libdrm.so.2.4.0)
==21607==by 0x82263CD: drmModeSetCrtc
