Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

[Jonas Ådahl]

On Tue, Apr 10, 2018 at 09:05:28AM -0400, Mike Blumenkrantz wrote:
> this adds implementation from a related discussion long ago in which
> it was decided that it would be useful for clients to know if/where their
> windows were tiled so that various behaviors and visuals could be modified
> to improve UX
> 
> a window which is e.g., tiled on the right side of the screen would set the
> right|top|bottom tiled states in configure
> 
> Signed-off-by: Mike Blumenkrantz 

Looks good to me. I'll have a look about adding the other thing missing
to make the gtk_shell tiling stuff obsolete. I have one comment below
inline. With that fixed, this is

Reviewed-by: Jonas Ådahl 


> 
> Changes since v1: added since=2 to enum members
> ---
>  stable/xdg-shell/xdg-shell.xml | 34 +-
>  1 file changed, 29 insertions(+), 5 deletions(-)
> 
> diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml
> index d524ea9..629b983 100644
> --- a/stable/xdg-shell/xdg-shell.xml
> +++ b/stable/xdg-shell/xdg-shell.xml
> @@ -29,7 +29,7 @@
>  DEALINGS IN THE SOFTWARE.
>
>  
> -  
> +  
>  
>The xdg_wm_base interface is exposed as a global object enabling 
> clients
>to turn their wl_surfaces into windows in a desktop environment. It
> @@ -115,7 +115,7 @@
>  
>
>  
> -  
> +  
>  
>The xdg_positioner provides a collection of rules for the placement of 
> a
>child surface relative to a parent surface. Rules can be defined to 
> ensure
> @@ -359,7 +359,7 @@
>  
>
>  
> -  
> +  
>  
>An interface that may be implemented by a wl_surface, for
>implementations that provide a desktop-style user interface.
> @@ -528,7 +528,7 @@
>  
>
>  
> -  
> +  
>  
>This interface defines an xdg_surface role which allows a surface to,
>among other things, set window-like properties such as maximize,
> @@ -750,6 +750,30 @@
> keyboard or pointer focus.
>   
>
> +  
> + 

I think the summary attribute should only go in the description element.
I also just noticed they are all the same. Might not need the "now" as
well, since the state might change, but not necessarily the tiled-ness.


Jonas

> +   The window is currently in a tiled layout and the left edge is 
> considered to be
> +   adjacent to another part of the tiling grid.
> + 
> +  
> +  
> + 
> +   The window is currently in a tiled layout and the right edge is 
> considered to be
> +   adjacent to another part of the tiling grid.
> + 
> +  
> +  
> + 
> +   The window is currently in a tiled layout and the top edge is 
> considered to be
> +   adjacent to another part of the tiling grid.
> + 
> +  
> +  
> + 
> +   The window is currently in a tiled layout and the bottom edge is 
> considered to be
> +   adjacent to another part of the tiling grid.
> + 
> +  
>  
>  
>  
> @@ -989,7 +1013,7 @@
>  
>
>  
> -  
> +  
>  
>A popup surface is a short-lived, temporary surface. It can be used to
>implement for example menus, popovers, tooltips and other similar user
> -- 
> 2.14.3
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

[Drew DeVault]

On 2018-03-20  9:52 AM, Mike Blumenkrantz wrote:
> this adds implementation from a related discussion long ago in which
> it was decided that it would be useful for clients to know if/where their
> windows were tiled so that various behaviors and visuals could be modified
> to improve UX
> 
> a window which is e.g., tiled on the right side of the screen would set the
> right|top|bottom tiled states in configure

+1
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] xdg-shell: add enums for tiled window state to toplevel configure

[Mike Blumenkrantz]

On Tue, Mar 20, 2018 at 10:15 AM Simon McVittie  wrote:

> On Tue, 20 Mar 2018 at 09:52:02 -0400, Mike Blumenkrantz wrote:
> > this adds implementation from a related discussion long ago in which
> > it was decided that it would be useful for clients to know if/where their
> > windows were tiled so that various behaviors and visuals could be
> modified
> > to improve UX
> >
> > a window which is e.g., tiled on the right side of the screen would set
> the
> > right|top|bottom tiled states in configure
>
> Are these for the same purpose as the tiled states in the (currently
> private)
> protocol between GTK+ and Mutter/GNOME Shell?
>
> This has separate per-edge flags for:
>
> - Tiling: each edge is tiled (aligned to some other object) or not, so
>   that windows and client-side decorations can make UI choices like
>   "draw shadows on each edge that is not tiled" or "draw square corners
>   at each corner involving a tiled edge, and rounded corners where
>   neither edge is tiled"
>
> - Resizability: each edge is resizable or not, so that client-side
>   decorations can show or not show resize handles as appropriate (in
>   GNOME Shell you can tile two windows and then drag their shared
>   border to adjust the split, and I suspect that the Wayland equivalents
>   of X11 tiling window managers would want this too)
>
> https://bugzilla.gnome.org/show_bug.cgi?id=751857
>
> https://gitlab.gnome.org/GNOME/mutter/blob/master/src/wayland/protocol/gtk-shell.xml
>
> Regards,
> smcv
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


They could be used for those purposes, yes.
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel