Re: [PATCH v2] touchpad: add wobbling detection

2018-02-22 Thread Konstantin Kharlamov
On 21.02.2018 03:33, Peter Hutterer wrote: It should work like it previously did; what bothers me however — shouldn't that be specific to a touch, but not touchpad? Couldn't that get triggered e.g. by 2-finger scrolling? (whatever that is, I dunno, touching with 2 finger doesn't scroll for me —

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Peter Hutterer
On Tue, Feb 20, 2018 at 08:58:33PM +0300, Konstantin Kharlamov wrote: > On 20.02.2018 17:31, Konstantin Kharlamov wrote: > > On 20.02.2018 13:44, Konstantin Kharlamov wrote: > > > On 20.02.2018 09:34, Peter Hutterer wrote: > > > > On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 17:31, Konstantin Kharlamov wrote: On 20.02.2018 13:44, Konstantin Kharlamov wrote: On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff,

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 13:44, Konstantin Kharlamov wrote: On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff, uint64_t time) +{ +    if (tp->hysteresis.enabled) + 

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-20 Thread Konstantin Kharlamov
On 20.02.2018 09:34, Peter Hutterer wrote: On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: +static inline void +tp_detect_wobbling(struct tp_dispatch *tp, int x_diff, uint64_t time) +{ + if (tp->hysteresis.enabled) + return; + + /* Idea: if we got

Re: [PATCH v2] touchpad: add wobbling detection

2018-02-19 Thread Peter Hutterer
On Sun, Feb 18, 2018 at 11:14:55PM +0300, Konstantin Kharlamov wrote: > The details are explained in comment in the code. That aside, I shall > mention the check is so light, that it shouldn't influence CPU > performance even a bit, and can blindly be kept always enabled. I like it! And it does