Re: [PATCH wayland] client: Don't inappropriatly close fds for zombie objects

2018-03-07 Thread Derek Foreman
On 2018-03-07 09:16 AM, Daniel Stone wrote: On 6 March 2018 at 23:38, Derek Foreman wrote: commit 239ba39331420f953de35c337ae57db35573f9cb which was intended to stop leaking fds in events for zombie objects didn't notice that passing 0 to wl_connection_close_fds_in() would still close fds. Tes

Re: [PATCH wayland] client: Don't inappropriatly close fds for zombie objects

2018-03-07 Thread Daniel Stone
On 6 March 2018 at 23:38, Derek Foreman wrote: > commit 239ba39331420f953de35c337ae57db35573f9cb which was intended > to stop leaking fds in events for zombie objects didn't notice that > passing 0 to wl_connection_close_fds_in() would still close fds. > > Test the fd count before calling. Ouch.