Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-30 Thread Pekka Paalanen
On Sat, 24 Mar 2018 07:08:15 -0400 Simon Ser wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows compositors that want to draw > decorations themselves to send their preference to clients, and clients that > prefer server-sid

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-30 Thread Pekka Paalanen
On Wed, 18 Apr 2018 11:32:09 -0400 Simon Ser wrote: > On April 18, 2018 1:05 PM, Jonas Ådahl wrote: > > Since the issue is more of a race condition kind of issue, it might not > > be easily reproducable with a demo client, but must be solved by coming > > up with a type of negotiation that doesn

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Jonas Ådahl
On Wed, Apr 18, 2018 at 11:32:09AM -0400, Simon Ser wrote: > On April 18, 2018 1:05 PM, Jonas Ådahl wrote: > > Since the issue is more of a race condition kind of issue, it might not > > be easily reproducable with a demo client, but must be solved by coming > > up with a type of negotiation that

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Simon Ser
On April 18, 2018 1:05 PM, Jonas Ådahl wrote: > Since the issue is more of a race condition kind of issue, it might not > be easily reproducable with a demo client, but must be solved by coming > up with a type of negotiation that doesn't result in incorrect > intermediate states for example the o

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Jonas Ådahl
On Wed, Apr 18, 2018 at 07:49:12AM -0400, Simon Ser wrote: > On April 18, 2018 10:28 AM, Jonas Ådahl wrote: > > How do you imagine avoiding state transitions that don't result in > > incorrect intermediate state? If a compositor changes the preferred > > mode, does it wait some arbitrary time to s

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Simon Ser
On April 18, 2018 10:28 AM, Jonas Ådahl wrote: > > I'm not sure it's a good idea to add decorations to non-toplevel surfaces. I > > can't think of a use-case for popups. We don't know yet what kind of > > xdg-surface will be added later, so I think we can't really design a > > protocol > > that w

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-18 Thread Jonas Ådahl
On Tue, Apr 17, 2018 at 05:37:48PM -0400, Simon Ser wrote: > (Re-sending the message because I forgot to reply to the list) > > On April 13, 2018 2:56 PM, Jonas Ådahl wrote: > > Another thing to consider is whether non-toplevels ever want a similar > > kind of protocol? It is not something we nee

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-17 Thread Simon Ser
(Re-sending the message because I forgot to reply to the list) On April 13, 2018 2:56 PM, Jonas Ådahl wrote: > Another thing to consider is whether non-toplevels ever want a similar > kind of protocol? It is not something we need to go into much further > details now, but it would be easy to add

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Drew DeVault
On 2018-04-13 4:59 PM, Jonas Ådahl wrote: > Neither these need the "set_mode" or "preferred_mode" stuff. I don't think I'm following. I wonder if you have time to write up a proposed revision to the patch? > > Clients have an arbitrary surface in which they can render whatever they > > want, inc

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Jonas Ådahl
On Fri, Apr 13, 2018 at 10:48:56AM -0400, Drew DeVault wrote: > On 2018-04-13 4:35 PM, Jonas Ådahl wrote: > > Is this the consensus as well? Because if it should be possible, there > > are those things I mentioned to consider regarding capabilities. A > > potential mode could for example be to out

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Drew DeVault
On 2018-04-13 4:35 PM, Jonas Ådahl wrote: > Is this the consensus as well? Because if it should be possible, there > are those things I mentioned to consider regarding capabilities. A > potential mode could for example be to outsource drawing shadow or > something. This use-case is valid, but see

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Jonas Ådahl
On Fri, Apr 13, 2018 at 10:03:11AM -0400, Drew DeVault wrote: > On 2018-04-13 3:56 PM, Jonas Ådahl wrote: > > What is the purpose of making the compositor changing the "preferred" > > mode? If we would make the assumption that a compositor stays the same > > during the whole session as in it'll ei

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Drew DeVault
On 2018-04-13 3:56 PM, Jonas Ådahl wrote: > What is the purpose of making the compositor changing the "preferred" > mode? If we would make the assumption that a compositor stays the same > during the whole session as in it'll either always prefer or not prefer > dealing with decorations, and we as

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-13 Thread Jonas Ådahl
On Sat, Mar 24, 2018 at 07:08:15AM -0400, Simon Ser wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows compositors that want to draw > decorations themselves to send their preference to clients, and clients that > prefer serve

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-04-11 Thread Eike Hein
On 03/24/2018 08:08 PM, Simon Ser wrote: > This adds a new protocol to negotiate server-side rendering of window > decorations for xdg-toplevels. This allows compositors that want to draw > decorations themselves to send their preference to clients, and clients that > prefer server-side decoration

Re: [PATCH wayland-protocols v4] unstable: add xdg-toplevel-decoration protocol

2018-03-24 Thread Eike Hein
+1 I quite like this one. It's the best version so far. Cheers, Eike ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel