Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 19 March 2018 at 13:39, Daniel Stone wrote: > Hi Emil, > > On 19 March 2018 at 13:27, Emil Velikov wrote: >> On 19 March 2018 at 13:20, Daniel Stone wrote: >>> Me neither really, but it seemed best for consistency with the

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On Mon, 19 Mar 2018 at 13:39:30 +, Daniel Stone wrote: > On 19 March 2018 at 13:27, Emil Velikov wrote: > >> I'd not realised AC_PROG_NM didn't set a full path. Brilliant. Maybe > >> replace test -x "$NM" with $NM -V >/dev/null 2>&1? Or just trusting it > >> works if

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Emil, On 19 March 2018 at 13:27, Emil Velikov wrote: > On 19 March 2018 at 13:20, Daniel Stone wrote: >> Me neither really, but it seemed best for consistency with the rest of >> the file which used test rather than [. > > Sounds fine either

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 19 March 2018 at 13:20, Daniel Stone wrote: > Hi Quentin, > Thanks for the quick review! > > On 19 March 2018 at 13:06, Quentin Glidic > wrote: >> On 3/19/18 1:31 PM, Daniel Stone wrote: >>> diff --git a/egl/wayland-egl-symbols-check

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Quentin, Thanks for the quick review! On 19 March 2018 at 13:06, Quentin Glidic wrote: > On 3/19/18 1:31 PM, Daniel Stone wrote: >> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check >> index c47026b2..d1a4a6be 100755 >> ---

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 3/19/18 1:31 PM, Daniel Stone wrote: The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we