Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
Hi Emil, On 10 October 2017 at 14:43, Emil Velikov wrote: > Here is a retake of the RFC as originally seen here [1]. > > In summary - we want the user facing library to live in Wayland with > vendors providing a backend/plugin. Otherwise we'll get file conflicts > as library can come from different vendors. > > Changes since v2 include: > - pushed multiple cleanups to Mesa and rebased the series on top > - cut down the fluff in the 1/9 commit message. > - use 17.4.0 version to avoid breakage of existing apps > - pass the DSO name (used in the symbol test) via the build system > - use local WL_EXPORT macro Thanks for this, I've pushed it now, as well as the follow-up to not break C++. Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
On 12 December 2017 at 20:48, Arnaud Vrac wrote: > Hi Emil, > > On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov > wrote: >> Hi all, >> >> Here is a retake of the RFC as originally seen here [1]. >> >> In summary - we want the user facing library to live in Wayland with >> vendors providing a backend/plugin. Otherwise we'll get file conflicts >> as library can come from different vendors. >> >> Changes since v2 include: >> - pushed multiple cleanups to Mesa and rebased the series on top >> - cut down the fluff in the 1/9 commit message. >> - use 17.4.0 version to avoid breakage of existing apps >> - pass the DSO name (used in the symbol test) via the build system >> - use local WL_EXPORT macro >> >> >> I've kept the import and build integration, since: >> - the former is mechanical, while the latter involves some brain cells >> - couple of changes were needed before building the imported code. >> >> >> Any formal Acked-by, Reviewed-by or other will be appreciated. Comments >> and suggestions are also welcome. >> >> Thanks >> Emil >> >> [1] >> https://lists.freedesktop.org/archives/wayland-devel/2017-September/035019.html > > Besides my concern in patch 1, the whole series is: > Reviewed-by: Arnaud Vrac > > It does make porting new drivers an easier task, thanks ! > Thanks for the help Arnaud. A patch addressing your suggestion is on the list (+ your inbox). -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
Hi Emil,
On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov wrote:
> Hi all,
>
> Here is a retake of the RFC as originally seen here [1].
>
> In summary - we want the user facing library to live in Wayland with
> vendors providing a backend/plugin. Otherwise we'll get file conflicts
> as library can come from different vendors.
>
> Changes since v2 include:
> - pushed multiple cleanups to Mesa and rebased the series on top
> - cut down the fluff in the 1/9 commit message.
> - use 17.4.0 version to avoid breakage of existing apps
> - pass the DSO name (used in the symbol test) via the build system
> - use local WL_EXPORT macro
>
>
> I've kept the import and build integration, since:
> - the former is mechanical, while the latter involves some brain cells
> - couple of changes were needed before building the imported code.
>
>
> Any formal Acked-by, Reviewed-by or other will be appreciated. Comments
> and suggestions are also welcome.
>
> Thanks
> Emil
>
> [1]
> https://lists.freedesktop.org/archives/wayland-devel/2017-September/035019.html
Besides my concern in patch 1, the whole series is:
Reviewed-by: Arnaud Vrac
It does make porting new drivers an easier task, thanks !
-Arnaud
>
> Emil Velikov (8):
> wayland-egl: import libwayland-egl.so frontend library from Mesa
> wayland-egl: reuse the existing WL_EXPORT macro
> wayland-egl: correct wayland-egl.pc description/version
> wayland-egl: introduce wayland-egl-backend.pc
> wayland-egl: add a note about keeping the backend version in sync
> build: wire-up wayland-egl
> wayland-egl-symbols-check: pass the DSO name via the build system
> wayland-egl: move the wayland-egl{,-core}.h headers to egl/
>
> Makefile.am | 28 -
> configure.ac| 2 +
> egl/wayland-egl-abi-check.c | 235
>
> egl/wayland-egl-backend.h | 67
> egl/wayland-egl-backend.pc.in | 9 ++
> {src => egl}/wayland-egl-core.h | 0
> egl/wayland-egl-symbols-check | 16 +++
> egl/wayland-egl.c | 104 ++
> {src => egl}/wayland-egl.h | 0
> egl/wayland-egl.pc.in | 11 ++
> 10 files changed, 468 insertions(+), 4 deletions(-)
> create mode 100644 egl/wayland-egl-abi-check.c
> create mode 100644 egl/wayland-egl-backend.h
> create mode 100644 egl/wayland-egl-backend.pc.in
> rename {src => egl}/wayland-egl-core.h (100%)
> create mode 100755 egl/wayland-egl-symbols-check
> create mode 100644 egl/wayland-egl.c
> rename {src => egl}/wayland-egl.h (100%)
> create mode 100644 egl/wayland-egl.pc.in
>
> --
> 2.14.1
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
Hi Daniel, On 13 November 2017 at 14:06, Daniel Stone wrote: > Hi Emil, > > On 8 November 2017 at 14:06, Emil Velikov wrote: >> On 10 October 2017 at 14:43, Emil Velikov wrote: >>> In summary - we want the user facing library to live in Wayland with >>> vendors providing a backend/plugin. Otherwise we'll get file conflicts >>> as library can come from different vendors. >>> >>> Changes since v2 include: >>> - pushed multiple cleanups to Mesa and rebased the series on top >>> - cut down the fluff in the 1/9 commit message. >>> - use 17.4.0 version to avoid breakage of existing apps >>> - pass the DSO name (used in the symbol test) via the build system >>> - use local WL_EXPORT macro >>> >>> >>> I've kept the import and build integration, since: >>> - the former is mechanical, while the latter involves some brain cells >>> - couple of changes were needed before building the imported code. >>> >>> Any formal Acked-by, Reviewed-by or other will be appreciated. Comments >>> and suggestions are also welcome. >>> >> Humble ping? >> >> Miguel already reviewed the [IMHO] important parts. >> How can I help move the series forward? > > I haven't had / don't have time to review the last spin, > unfortunately. But I'm happy for it to be merged if someone else can. > > There's definitely no danger of this missing the next release, mind! > Any suggestions who (and how) can I bribe to look at the series? I've intentionally kept things dead trivial so that anyone can take a look - yet no luck :-( I am not asking that _you_ have to look through it, but I'm running out of ideas. Thanks Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
Hi Emil, On 8 November 2017 at 14:06, Emil Velikov wrote: > On 10 October 2017 at 14:43, Emil Velikov wrote: >> In summary - we want the user facing library to live in Wayland with >> vendors providing a backend/plugin. Otherwise we'll get file conflicts >> as library can come from different vendors. >> >> Changes since v2 include: >> - pushed multiple cleanups to Mesa and rebased the series on top >> - cut down the fluff in the 1/9 commit message. >> - use 17.4.0 version to avoid breakage of existing apps >> - pass the DSO name (used in the symbol test) via the build system >> - use local WL_EXPORT macro >> >> >> I've kept the import and build integration, since: >> - the former is mechanical, while the latter involves some brain cells >> - couple of changes were needed before building the imported code. >> >> Any formal Acked-by, Reviewed-by or other will be appreciated. Comments >> and suggestions are also welcome. >> > Humble ping? > > Miguel already reviewed the [IMHO] important parts. > How can I help move the series forward? I haven't had / don't have time to review the last spin, unfortunately. But I'm happy for it to be merged if someone else can. There's definitely no danger of this missing the next release, mind! Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
On 10 October 2017 at 14:43, Emil Velikov wrote: > Hi all, > > Here is a retake of the RFC as originally seen here [1]. > > In summary - we want the user facing library to live in Wayland with > vendors providing a backend/plugin. Otherwise we'll get file conflicts > as library can come from different vendors. > > Changes since v2 include: > - pushed multiple cleanups to Mesa and rebased the series on top > - cut down the fluff in the 1/9 commit message. > - use 17.4.0 version to avoid breakage of existing apps > - pass the DSO name (used in the symbol test) via the build system > - use local WL_EXPORT macro > > > I've kept the import and build integration, since: > - the former is mechanical, while the latter involves some brain cells > - couple of changes were needed before building the imported code. > > > Any formal Acked-by, Reviewed-by or other will be appreciated. Comments > and suggestions are also welcome. > Humble ping? Miguel already reviewed the [IMHO] important parts. How can I help move the series forward? Thanks Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library
On 10 October 2017 at 14:43, Emil Velikov wrote: > Hi all, > > Here is a retake of the RFC as originally seen here [1]. > > In summary - we want the user facing library to live in Wayland with > vendors providing a backend/plugin. Otherwise we'll get file conflicts > as library can come from different vendors. > > Changes since v2 include: > - pushed multiple cleanups to Mesa and rebased the series on top > - cut down the fluff in the 1/9 commit message. > - use 17.4.0 version to avoid breakage of existing apps > - pass the DSO name (used in the symbol test) via the build system > - use local WL_EXPORT macro > > > I've kept the import and build integration, since: > - the former is mechanical, while the latter involves some brain cells > - couple of changes were needed before building the imported code. > > > Any formal Acked-by, Reviewed-by or other will be appreciated. Comments > and suggestions are also welcome. > Nearly forgot, as (if?) this work gets merged, we'll need to update the website [1]. I haven't thought about the exact wording, so any suggestions will be greatly appreciated. Thanks Emil [1] https://wayland.freedesktop.org/architecture.html#heading_toc_j_2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
