[webkit-changes] [157351] trunk/Source/WebKit/mac

2013-10-12 Thread aroben
Title: [157351] trunk/Source/WebKit/mac Revision 157351 Author aro...@webkit.org Date 2013-10-12 21:05:49 -0700 (Sat, 12 Oct 2013) Log Message WebViews inside OS X screen savers have large caches, but should not https://bugs.webkit.org/show_bug.cgi?id=122604 We use WebCacheModelDocumentV

[webkit-changes] [157310] trunk/Source

2013-10-11 Thread aroben
Title: [157310] trunk/Source Revision 157310 Author aro...@webkit.org Date 2013-10-11 11:50:50 -0700 (Fri, 11 Oct 2013) Log Message Confusing CGImageRef memory management in ImageBuffer::copyImage https://bugs.webkit.org/show_bug.cgi?id=122605 Source/WebCore: BitmapImage::create was ado

[webkit-changes] [138565] trunk/Source/WebKit/mac

2012-12-29 Thread aroben
Title: [138565] trunk/Source/WebKit/mac Revision 138565 Author aro...@webkit.org Date 2012-12-29 08:14:21 -0800 (Sat, 29 Dec 2012) Log Message Web Inspector: Mac WK1 Inspector can't save/load timeline data https://bugs.webkit.org/show_bug.cgi?id=105547 Reviewed by Pavel Feldman. * WebCo

[webkit-changes] [133225] trunk/Source/WebKit/mac

2012-11-01 Thread aroben
Title: [133225] trunk/Source/WebKit/mac Revision 133225 Author aro...@webkit.org Date 2012-11-01 13:57:46 -0700 (Thu, 01 Nov 2012) Log Message [WK1] Fixed-position elements jiggle up and down slightly during scrolling on a Retina display https://bugs.webkit.org/show_bug.cgi?id=100957 Rev

[webkit-changes] [133179] trunk/Tools

2012-11-01 Thread aroben
Title: [133179] trunk/Tools Revision 133179 Author aro...@webkit.org Date 2012-11-01 08:40:31 -0700 (Thu, 01 Nov 2012) Log Message Crash beneath WKRelease after failed load in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=100954 Reviewed by Sam Weinig. There were just some simple

[webkit-changes] [109111] trunk/Tools

2012-02-28 Thread aroben
2-02-28 16:50:41 UTC (rev 109111) @@ -374,7 +374,7 @@ reviewers_list = [ Reviewer("Ada Chan", "adac...@apple.com", "chanada"), Reviewer("Adam Barth", "aba...@webkit.org", "abarth"), -Reviewer("Adam Roben",

[webkit-changes] [109110] trunk/Tools

2012-02-28 Thread aroben
Title: [109110] trunk/Tools Revision 109110 Author aro...@webkit.org Date 2012-02-28 08:49:11 -0800 (Tue, 28 Feb 2012) Log Message Teach webkitpy about wkb.ug URLs Fixes webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs Patch by Adam Roben on 2012-02-28 R

[webkit-changes] [108813] trunk/Source/JavaScriptCore

2012-02-24 Thread aroben
Title: [108813] trunk/Source/_javascript_Core Revision 108813 Author aro...@apple.com Date 2012-02-24 09:25:44 -0800 (Fri, 24 Feb 2012) Log Message Undo the BUILDING_WTF part of r108808 This broke the build, which is obviously worse than the linker warning it was trying to solve. * _jav

[webkit-changes] [108808] trunk/Source/JavaScriptCore

2012-02-24 Thread aroben
Title: [108808] trunk/Source/_javascript_Core Revision 108808 Author aro...@apple.com Date 2012-02-24 08:49:04 -0800 (Fri, 24 Feb 2012) Log Message Fix linker warnings on Windows * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Removed symbols that are already exported vi

[webkit-changes] [108807] trunk/Source/WebCore

2012-02-24 Thread aroben
Title: [108807] trunk/Source/WebCore Revision 108807 Author aro...@apple.com Date 2012-02-24 08:48:53 -0800 (Fri, 24 Feb 2012) Log Message Mac build fix after r108698 * page/scrolling/mac/ScrollingCoordinatorMac.mm: Added missing #import. Modified Paths trunk/Source/WebCore/ChangeLog t

[webkit-changes] [108629] trunk/Source/WebCore

2012-02-23 Thread aroben
Title: [108629] trunk/Source/WebCore Revision 108629 Author aro...@apple.com Date 2012-02-23 08:08:10 -0800 (Thu, 23 Feb 2012) Log Message Mac build fix after r108615 * WebCore.exp.in: Added a missing export. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.ex

[webkit-changes] [108360] trunk/Source/WebCore

2012-02-21 Thread aroben
Title: [108360] trunk/Source/WebCore Revision 108360 Author aro...@apple.com Date 2012-02-21 08:38:02 -0800 (Tue, 21 Feb 2012) Log Message Mac build fix * WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that WebKit can include them. Modified Paths trun

[webkit-changes] [108239] trunk/Source/WebCore

2012-02-20 Thread aroben
Title: [108239] trunk/Source/WebCore Revision 108239 Author aro...@apple.com Date 2012-02-20 06:53:08 -0800 (Mon, 20 Feb 2012) Log Message 32-bit build fix * platform/FractionalLayoutUnit.h: (WebCore::FractionalLayoutUnit::setRawValue): Explicitly cast long long to int, since they are di

[webkit-changes] [108238] trunk/Source/WebCore

2012-02-20 Thread aroben
Title: [108238] trunk/Source/WebCore Revision 108238 Author aro...@apple.com Date 2012-02-20 06:51:17 -0800 (Mon, 20 Feb 2012) Log Message Clang build fix * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::willModifyDOMAttr): Removed unused parameter. Modified Paths trunk/

[webkit-changes] [108125] trunk

2012-02-17 Thread aroben
Title: [108125] trunk Revision 108125 Author aro...@apple.com Date 2012-02-17 14:31:14 -0800 (Fri, 17 Feb 2012) Log Message Clang/Mac build fix after r108119 Source/WebKit2: * WebProcess/WebProcess.cpp: (WebKit::randomCrashThread): Annotate this function with NO_RETURN_DUE_TO_CRASH. To

[webkit-changes] [106359] trunk/Tools

2012-01-31 Thread aroben
Title: [106359] trunk/Tools Revision 106359 Author aro...@apple.com Date 2012-01-31 07:09:33 -0800 (Tue, 31 Jan 2012) Log Message Only call -typingAttributes on WebViews, not WebHTMLViews Looks like this case was just missed in r105908. Fixes REGRESSION (r105908): WebKit1.InspectorBarT

[webkit-changes] [104621] trunk/Tools

2012-01-10 Thread aroben
Title: [104621] trunk/Tools Revision 104621 Author aro...@apple.com Date 2012-01-10 13:05:59 -0800 (Tue, 10 Jan 2012) Log Message Make it possible to type data: URLs into MiniBrowser on Windows Fixes Crash when trying to navigate to a data: URL in MiniBrowser on Windows Reviewed by Dar

[webkit-changes] [104615] trunk/Tools

2012-01-10 Thread aroben
Title: [104615] trunk/Tools Revision 104615 Author aro...@apple.com Date 2012-01-10 12:23:48 -0800 (Tue, 10 Jan 2012) Log Message Make MiniBrowser automatically escape invalid URL characters typed in its URL field Fixes Crash when typing a data: URL containing double-quotes in MiniBrows

[webkit-changes] [104483] trunk/Tools

2012-01-09 Thread aroben
Title: [104483] trunk/Tools Revision 104483 Author aro...@apple.com Date 2012-01-09 13:16:17 -0800 (Mon, 09 Jan 2012) Log Message Convert Cygwin paths to Windows paths before passing them to DRT Fixes WIN: DumpRenderTree hangs under NRWT I couldn't find a way to test this because I co

[webkit-changes] [104463] trunk/Tools

2012-01-09 Thread aroben
Title: [104463] trunk/Tools Revision 104463 Author aro...@apple.com Date 2012-01-09 10:38:49 -0800 (Mon, 09 Jan 2012) Log Message Print an error message when NRWT can't run Apache Fixes NRWT mysteriously exits when Apache returns an error code Reviewed by Dirk Pranke. * Scripts/webkit

[webkit-changes] [104195] trunk/Tools

2012-01-05 Thread aroben
Title: [104195] trunk/Tools Revision 104195 Author aro...@apple.com Date 2012-01-05 12:28:48 -0800 (Thu, 05 Jan 2012) Log Message Remove some unnecessary code from old-run-webkit-tests Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or WebKitTestR

[webkit-changes] [104191] trunk/Tools

2012-01-05 Thread aroben
Title: [104191] trunk/Tools Revision 104191 Author aro...@apple.com Date 2012-01-05 11:55:40 -0800 (Thu, 05 Jan 2012) Log Message Teach NRWT to use run-safari to open results.html on Apple's Windows port NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari i

[webkit-changes] [104190] trunk/Tools

2012-01-05 Thread aroben
Title: [104190] trunk/Tools Revision 104190 Author aro...@apple.com Date 2012-01-05 11:55:31 -0800 (Thu, 05 Jan 2012) Log Message Prepend Safari.exe's path to the command-line passed to CreateProcess Safari expects the first argument in the command-line to be the path to Safari.exe itsel

[webkit-changes] [104189] trunk/Tools

2012-01-05 Thread aroben
Title: [104189] trunk/Tools Revision 104189 Author aro...@apple.com Date 2012-01-05 11:55:22 -0800 (Thu, 05 Jan 2012) Log Message Stop using explicit memory management in WebKitLauncherWin We now use stack-allocated STL objects instead. Prep work for First argument passed to WebKit.exe

[webkit-changes] [104188] trunk

2012-01-05 Thread aroben
Title: [104188] trunk Revision 104188 Author aro...@apple.com Date 2012-01-05 11:54:46 -0800 (Thu, 05 Jan 2012) Log Message Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code This allows us to add the Safari and Apple Application Support directorie

[webkit-changes] [104187] trunk

2012-01-05 Thread aroben
Title: [104187] trunk Revision 104187 Author aro...@apple.com Date 2012-01-05 11:53:47 -0800 (Thu, 05 Jan 2012) Log Message Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code This allows us to add the Safari and Apple Application Support directories

[webkit-changes] [104157] trunk

2012-01-05 Thread aroben
Title: [104157] trunk Revision 104157 Author aro...@apple.com Date 2012-01-05 06:59:24 -0800 (Thu, 05 Jan 2012) Log Message Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code This allows us to add the Apple Application Support directory to PATH before try

[webkit-changes] [104155] trunk

2012-01-05 Thread aroben
Title: [104155] trunk Revision 104155 Author aro...@apple.com Date 2012-01-05 06:57:46 -0800 (Thu, 05 Jan 2012) Log Message Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code This allows us to add the Apple Application Support directory to PATH before t

[webkit-changes] [104154] trunk/Tools

2012-01-05 Thread aroben
Title: [104154] trunk/Tools Revision 104154 Author aro...@apple.com Date 2012-01-05 06:56:15 -0800 (Thu, 05 Jan 2012) Log Message Make WinLauncher's window frame respond to clicks/drags again Fixes REGRESSION (r84990): Can't drag WinLauncher by its title bar when Aero is disabled Revie

[webkit-changes] [104153] trunk

2012-01-05 Thread aroben
Title: [104153] trunk Revision 104153 Author aro...@apple.com Date 2012-01-05 06:52:23 -0800 (Thu, 05 Jan 2012) Log Message Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code This allows us to add the Apple Application Support directory to PATH before t

[webkit-changes] [104038] trunk/Source/WebCore

2012-01-04 Thread aroben
Title: [104038] trunk/Source/WebCore Revision 104038 Author aro...@apple.com Date 2012-01-04 07:33:20 -0800 (Wed, 04 Jan 2012) Log Message Use one big printf command instead of many chained echo commands to generate idl_files.tmp This works around a bug in Cygwin where sh.exe will crash

[webkit-changes] [103952] trunk/Tools

2012-01-03 Thread aroben
Title: [103952] trunk/Tools Revision 103952 Author aro...@apple.com Date 2012-01-03 11:53:50 -0800 (Tue, 03 Jan 2012) Log Message Make Port subclasses override the operating_system method rather than setting an attribute Without this patch, any use of Port.operating_system() within a por

[webkit-changes] [103554] trunk/Tools

2011-12-22 Thread aroben
Title: [103554] trunk/Tools Revision 103554 Author aro...@apple.com Date 2011-12-22 10:30:54 -0800 (Thu, 22 Dec 2011) Log Message Snow Leopard test fix * Scripts/webkitpy/test/main.py: (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to unittest.main, even

[webkit-changes] [103547] trunk/Tools

2011-12-22 Thread aroben
Title: [103547] trunk/Tools Revision 103547 Author aro...@apple.com Date 2011-12-22 08:57:08 -0800 (Thu, 22 Dec 2011) Log Message Add a --xml flag to test-webkitpy test-webkitpy --xml will, in addition to providing the standard text output on stdout, write JUnit-style XML files to a test

[webkit-changes] [102354] trunk/Tools

2011-12-08 Thread aroben
Title: [102354] trunk/Tools Revision 102354 Author aro...@apple.com Date 2011-12-08 11:16:14 -0800 (Thu, 08 Dec 2011) Log Message Make finding crash logs by PID work on Snow Leopard Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we were using to

[webkit-changes] [102163] trunk/Tools

2011-12-06 Thread aroben
Title: [102163] trunk/Tools Revision 102163 Author aro...@apple.com Date 2011-12-06 12:04:25 -0800 (Tue, 06 Dec 2011) Log Message Add a pid parameter to CrashLogs.find_newest_log When a PID is passed, only crash logs corresponding to a crashed process with that PID are considered. Fixes

[webkit-changes] [102162] trunk/Tools

2011-12-06 Thread aroben
Title: [102162] trunk/Tools Revision 102162 Author aro...@apple.com Date 2011-12-06 12:04:08 -0800 (Tue, 06 Dec 2011) Log Message Wait for Crash Reporter to finish even when it lets the crashed process die quickly NRWT was only waiting for Crash Reporter in cases where it was keeping the

[webkit-changes] [102000] trunk/Tools

2011-12-05 Thread aroben
Title: [102000] trunk/Tools Revision 102000 Author aro...@apple.com Date 2011-12-05 07:52:21 -0800 (Mon, 05 Dec 2011) Log Message Redeploy apple-macpro-7 and apple-xserve-1 These slaves have been sitting idle since we removed our Leopard builders in r97496. Fixes REGRESSION (r97496): a

[webkit-changes] [101822] trunk/Tools

2011-12-02 Thread aroben
Title: [101822] trunk/Tools Revision 101822 Author aro...@apple.com Date 2011-12-02 10:26:31 -0800 (Fri, 02 Dec 2011) Log Message Fix for Python 2.6 * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was on

[webkit-changes] [101821] trunk/Tools

2011-12-02 Thread aroben
Title: [101821] trunk/Tools Revision 101821 Author aro...@apple.com Date 2011-12-02 10:19:40 -0800 (Fri, 02 Dec 2011) Log Message Fix names of failed/timed out tests in run-api-tests output Fixes run-api-tests prints suite names twice for failed or timed out tests We were ending up wit

[webkit-changes] [101818] trunk/Tools

2011-12-02 Thread aroben
Title: [101818] trunk/Tools Revision 101818 Author aro...@apple.com Date 2011-12-02 10:01:31 -0800 (Fri, 02 Dec 2011) Log Message Teach build.webkit.org to display how many unit tests failed or timed out Fixes It's hard to tell how many unit tests are failing on build.webkit.org We now

[webkit-changes] [101817] trunk/Tools

2011-12-02 Thread aroben
Title: [101817] trunk/Tools Revision 101817 Author aro...@apple.com Date 2011-12-02 10:00:43 -0800 (Fri, 02 Dec 2011) Log Message Teach prepare-ChangeLog to treat master.cfg as a Python file Fixes prepare-ChangeLog doesn't show modified classes/functions in buildbot's master.cfg Review

[webkit-changes] [101803] trunk/Tools

2011-12-02 Thread aroben
Title: [101803] trunk/Tools Revision 101803 Author aro...@apple.com Date 2011-12-02 08:33:56 -0800 (Fri, 02 Dec 2011) Log Message Teach check-webkit-style how to check the syntax of JSON files Fixes check-webkit-style doesn't flag JSON syntax errors I previously landed this patch as r1

[webkit-changes] [101711] trunk/Tools

2011-12-01 Thread aroben
Title: [101711] trunk/Tools Revision 101711 Author aro...@apple.com Date 2011-12-01 14:37:51 -0800 (Thu, 01 Dec 2011) Log Message Teach check-webkit-style how to check the syntax of JSON files Fixes check-webkit-style doesn't flag JSON syntax errors Reviewed by Darin Adler. * Scripts/

[webkit-changes] [101695] trunk/Tools

2011-12-01 Thread aroben
Title: [101695] trunk/Tools Revision 101695 Author aro...@apple.com Date 2011-12-01 11:58:49 -0800 (Thu, 01 Dec 2011) Log Message Allow committers to use their Trac credentials to force builds on the buildbots Fixes A new class, CommitterAuth, handles authentication of WebKit committer

[webkit-changes] [101694] trunk/Tools

2011-12-01 Thread aroben
Title: [101694] trunk/Tools Revision 101694 Author aro...@apple.com Date 2011-12-01 11:58:38 -0800 (Thu, 01 Dec 2011) Log Message Add an HTDigestParser class to webkitpy Fixes webkitpy doesn't provide a way to parse htdigest files This class can be used to parse Apache's htdigest files

[webkit-changes] [101663] trunk/Tools

2011-12-01 Thread aroben
Title: [101663] trunk/Tools Revision 101663 Author aro...@apple.com Date 2011-12-01 05:45:54 -0800 (Thu, 01 Dec 2011) Log Message Buildbot fix * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of BuildmasterConfig not performed by loadBuilderConfig u

[webkit-changes] [101662] trunk/Tools

2011-12-01 Thread aroben
Title: [101662] trunk/Tools Revision 101662 Author aro...@apple.com Date 2011-12-01 05:36:39 -0800 (Thu, 01 Dec 2011) Log Message Use curl for downloading builds to test slaves Buildbot's built-in file transfer capabilities are transferring files much more slowly than curl does. This see

[webkit-changes] [101534] trunk/Tools

2011-11-30 Thread aroben
Title: [101534] trunk/Tools Revision 101534 Author aro...@apple.com Date 2011-11-30 11:12:36 -0800 (Wed, 30 Nov 2011) Log Message Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed This will make it a lot easier to investigate build failures on the bots. Fixes

[webkit-changes] [101533] trunk/Tools

2011-11-30 Thread aroben
Title: [101533] trunk/Tools Revision 101533 Author aro...@apple.com Date 2011-11-30 11:12:22 -0800 (Wed, 30 Nov 2011) Log Message Add a way to set OutputCapture's log level This will be used by some unit tests I'm planning to add. Fixes OutputCapture can't be used to capture DEBUG mess

[webkit-changes] [101521] trunk/Source/JavaScriptCore

2011-11-30 Thread aroben
Title: [101521] trunk/Source/_javascript_Core Revision 101521 Author aro...@apple.com Date 2011-11-30 08:39:02 -0800 (Wed, 30 Nov 2011) Log Message Fix RetainPtr's move assignment operators Fixes RetainPtr's move assignment operators don't modify the pointer being assigned to I didn't

[webkit-changes] [101516] trunk/Source/WebCore/ChangeLog

2011-11-30 Thread aroben
Title: [101516] trunk/Source/WebCore/ChangeLog Revision 101516 Author aro...@apple.com Date 2011-11-30 07:36:37 -0800 (Wed, 30 Nov 2011) Log Message Another Clang build fix after r101507 * platform/network/SocketStreamHandleClient.h: (WebCore::SocketStreamHandleClient::didUpdateBufferedA

[webkit-changes] [101512] trunk/Source/WebCore

2011-11-30 Thread aroben
Title: [101512] trunk/Source/WebCore Revision 101512 Author aro...@apple.com Date 2011-11-30 07:24:07 -0800 (Wed, 30 Nov 2011) Log Message Clang build fix after r101507 * websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didUpdateBufferedAmount): Removed unused param

[webkit-changes] [101256] trunk/Source/WebKit/mac

2011-11-28 Thread aroben
Title: [101256] trunk/Source/WebKit/mac Revision 101256 Author aro...@apple.com Date 2011-11-28 06:37:59 -0800 (Mon, 28 Nov 2011) Log Message Properly retain the OS X version string Fixes REGRESSION (r101215): Crash on launch beneath +[WebView _standardUserAgentWithApplicationName:] Re

[webkit-changes] [101006] trunk/Tools

2011-11-22 Thread aroben
Title: [101006] trunk/Tools Revision 101006 Author aro...@apple.com Date 2011-11-22 09:03:17 -0800 (Tue, 22 Nov 2011) Log Message Remove some debugging code I accidentally left in r101005 * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_python): Modified Paths trunk/Tools/Cha

[webkit-changes] [101005] trunk/Tools

2011-11-22 Thread aroben
Title: [101005] trunk/Tools Revision 101005 Author aro...@apple.com Date 2011-11-22 08:52:44 -0800 (Tue, 22 Nov 2011) Log Message Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files Fixes prepare-ChangeLog doesn't find names of modified classes/methods

[webkit-changes] [100912] trunk/Tools

2011-11-21 Thread aroben
Title: [100912] trunk/Tools Revision 100912 Author aro...@apple.com Date 2011-11-21 07:15:44 -0800 (Mon, 21 Nov 2011) Log Message Make NRWT consider all lines of output from parse-malloc-history, not just the first Fixes REGRESSION (NRWT): NRWT always reports "1 unique leaks found" even

[webkit-changes] [100799] trunk/Tools

2011-11-18 Thread aroben
Title: [100799] trunk/Tools Revision 100799 Author aro...@apple.com Date 2011-11-18 11:15:42 -0800 (Fri, 18 Nov 2011) Log Message Ignore an ANGLE leak that is not WebKit's fault * Scripts/old-run-webkit-tests: (countAndPrintLeaks): * Scripts/webkitpy/layout_tests/port/leakdetector.py: (L

[webkit-changes] [100790] trunk/Tools

2011-11-18 Thread aroben
Title: [100790] trunk/Tools Revision 100790 Author aro...@apple.com Date 2011-11-18 10:39:56 -0800 (Fri, 18 Nov 2011) Log Message Ignore another Lion-specific leak that is not WebKit's fault * Scripts/old-run-webkit-tests: (countAndPrintLeaks): * Scripts/webkitpy/layout_tests/port/leakde

[webkit-changes] [100657] trunk/Tools

2011-11-17 Thread aroben
Title: [100657] trunk/Tools Revision 100657 Author aro...@apple.com Date 2011-11-17 12:25:40 -0800 (Thu, 17 Nov 2011) Log Message Fix a crash-inducing typo I introduced in r100648 Fixes REGRESSION (r100648): NRWT crashes on Chromium when handling a crashing test Reviewed by Adam Barth.

[webkit-changes] [100655] trunk/Tools

2011-11-17 Thread aroben
Title: [100655] trunk/Tools Revision 100655 Author aro...@apple.com Date 2011-11-17 11:58:39 -0800 (Thu, 17 Nov 2011) Log Message Fix NRWT's parsing of the number of excluded leaks Fixes NRWT crashes when parsing leaks files from which certain leaks were excluded Reviewed by Adam Barth

[webkit-changes] [100648] trunk/Tools

2011-11-17 Thread aroben
Title: [100648] trunk/Tools Revision 100648 Author aro...@apple.com Date 2011-11-17 11:17:46 -0800 (Thu, 17 Nov 2011) Log Message Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process Fixes REGRESSION (NRWT): WebKitTestRunner crash log gets s

[webkit-changes] [100644] trunk/Tools

2011-11-17 Thread aroben
Title: [100644] trunk/Tools Revision 100644 Author aro...@apple.com Date 2011-11-17 10:55:37 -0800 (Thu, 17 Nov 2011) Log Message Remove extra quoting of call stacks and types passed to run-leaks by NRWT Fixes REGRESSION (NRWT): run-webkit-tests --leaks reports leaks that are supposed t

[webkit-changes] [100618] trunk/Tools

2011-11-17 Thread aroben
Title: [100618] trunk/Tools Revision 100618 Author aro...@apple.com Date 2011-11-17 06:53:02 -0800 (Thu, 17 Nov 2011) Log Message Ignore some leaks in frameworks we link against on Lion Fixes Lion Leaks bot complains about a bunch of leaks that aren't WebKit's fault Reviewed by Antti K

[webkit-changes] [100457] trunk/Tools

2011-11-16 Thread aroben
Title: [100457] trunk/Tools Revision 100457 Author aro...@apple.com Date 2011-11-16 08:50:18 -0800 (Wed, 16 Nov 2011) Log Message Move filenames/line numbers off to the right edge in Leaks Viewer Fixes Callstacks in Leaks Viewer are a little hard to read because filenames/line numbers a

[webkit-changes] [100456] trunk/Tools

2011-11-16 Thread aroben
Title: [100456] trunk/Tools Revision 100456 Author aro...@apple.com Date 2011-11-16 08:50:07 -0800 (Wed, 16 Nov 2011) Log Message Make Leaks Viewer load builds from the new Lion Leaks bot Fixes REGRESSION: Leaks Viewer no longer shows recent leaky builds Reviewed by Andreas Kling. * B

[webkit-changes] [99331] trunk/Tools

2011-11-04 Thread aroben
Title: [99331] trunk/Tools Revision 99331 Author aro...@apple.com Date 2011-11-04 15:52:26 -0700 (Fri, 04 Nov 2011) Log Message Remove Leopard-specific code from build.webkit.org We don't have any Leopard bots anymore. Fixes build.webkit.org configuration contains obsolete Leopard code

[webkit-changes] [99123] trunk/Tools

2011-11-02 Thread aroben
Title: [99123] trunk/Tools Revision 99123 Author aro...@apple.com Date 2011-11-02 17:02:03 -0700 (Wed, 02 Nov 2011) Log Message Add git-add-reviewer I've been using this script for a while to add reviewers to git commits in my local repository before pushing them to the Subversion reposi

[webkit-changes] [98927] trunk/Tools

2011-10-31 Thread aroben
Title: [98927] trunk/Tools Revision 98927 Author aro...@apple.com Date 2011-10-31 17:50:44 -0700 (Mon, 31 Oct 2011) Log Message Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT Fixes REGRESSION (r98639): Leaks Viewer doesn't show recent leaky builds Review

[webkit-changes] [98925] trunk/Source/WebCore

2011-10-31 Thread aroben
Title: [98925] trunk/Source/WebCore Revision 98925 Author aro...@apple.com Date 2011-10-31 17:39:50 -0700 (Mon, 31 Oct 2011) Log Message Fix linker warnings on Windows * WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and JSRequestAnimationFrameCallback.cpp from all

[webkit-changes] [98720] trunk/Source/WebCore

2011-10-28 Thread aroben
Title: [98720] trunk/Source/WebCore Revision 98720 Author aro...@apple.com Date 2011-10-28 05:37:55 -0700 (Fri, 28 Oct 2011) Log Message Mac build fix after r98711 * WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can find it. Modified Paths trunk/S

[webkit-changes] [98592] trunk/Source/WebCore

2011-10-27 Thread aroben
Title: [98592] trunk/Source/WebCore Revision 98592 Author aro...@apple.com Date 2011-10-27 09:41:50 -0700 (Thu, 27 Oct 2011) Log Message Windows build fix after r98512 * html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE guard. Modified Paths tru

[webkit-changes] [98590] trunk/Source/WebCore

2011-10-27 Thread aroben
Title: [98590] trunk/Source/WebCore Revision 98590 Author aro...@apple.com Date 2011-10-27 09:32:00 -0700 (Thu, 27 Oct 2011) Log Message Regenerate WebCore's Localizable.strings file All I did was run update-webkit-localizable-strings. A few localizer comments changed, and some strings (

[webkit-changes] [98588] trunk

2011-10-27 Thread aroben
Title: [98588] trunk Revision 98588 Author aro...@apple.com Date 2011-10-27 09:24:41 -0700 (Thu, 27 Oct 2011) Log Message Add WKBundlePageGetBackingScaleFactor Fixes REGRESSION (r97191): Clients can't reliably determine the scale factor of snapshots returned via WKBundlePageCreateSnaps

[webkit-changes] [97620] trunk/Source/JavaScriptCore

2011-10-17 Thread aroben
Title: [97620] trunk/Source/_javascript_Core Revision 97620 Author aro...@apple.com Date 2011-10-17 07:21:10 -0700 (Mon, 17 Oct 2011) Log Message Windows build fix after r97536, part 3 * runtime/JSAPIValueWrapper.h: * runtime/JSObject.h: Use JS_EXPORTDATA to export the s_info members. M

[webkit-changes] [97618] trunk/Source/JavaScriptCore

2011-10-17 Thread aroben
Title: [97618] trunk/Source/_javascript_Core Revision 97618 Author aro...@apple.com Date 2011-10-17 07:03:19 -0700 (Mon, 17 Oct 2011) Log Message Interpreter build fix after r97564 * runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::comp

[webkit-changes] [97615] trunk/Source/JavaScriptCore

2011-10-17 Thread aroben
Title: [97615] trunk/Source/_javascript_Core Revision 97615 Author aro...@apple.com Date 2011-10-17 06:41:55 -0700 (Mon, 17 Oct 2011) Log Message Windows build fix after r97536, part 2 * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Added back JSC::setUpStaticFunctionSlo

[webkit-changes] [97612] trunk/WebKitLibraries

2011-10-17 Thread aroben
Title: [97612] trunk/WebKitLibraries Revision 97612 Author aro...@apple.com Date 2011-10-17 06:25:19 -0700 (Mon, 17 Oct 2011) Log Message Windows build fix Here's the error: 5>c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\obj\webcore\derivedsources\jssvgpathsegcurv

[webkit-changes] [97610] trunk/Source/JavaScriptCore

2011-10-17 Thread aroben
Title: [97610] trunk/Source/_javascript_Core Revision 97610 Author aro...@apple.com Date 2011-10-17 05:58:42 -0700 (Mon, 17 Oct 2011) Log Message Windows build fix after r97536 * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Removed export of JSC::setUpStaticFunctionSlot

[webkit-changes] [97073] trunk/Source/JavaScriptCore

2011-10-10 Thread aroben
Title: [97073] trunk/Source/_javascript_Core Revision 97073 Author aro...@apple.com Date 2011-10-10 11:56:48 -0700 (Mon, 10 Oct 2011) Log Message Build fix * wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros. Modified Paths trunk/Source/_javascript_Core/Change

[webkit-changes] [96757] trunk

2011-10-05 Thread aroben
Title: [96757] trunk Revision 96757 Author aro...@apple.com Date 2011-10-05 15:23:03 -0700 (Wed, 05 Oct 2011) Log Message Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer RetainPtr's behavior of allowing the template parameter to be either a pointer t

[webkit-changes] [95955] trunk/Tools

2011-09-26 Thread aroben
Title: [95955] trunk/Tools Revision 95955 Author aro...@apple.com Date 2011-09-26 08:55:05 -0700 (Mon, 26 Sep 2011) Log Message Clean up code imported from WebKitAPITest Fixes WebViewDestruction tests and related code don't match TestWebKitAPI conventions Reviewed by David Levin. * Te

[webkit-changes] [95944] trunk

2011-09-26 Thread aroben
Title: [95944] trunk Revision 95944 Author aro...@apple.com Date 2011-09-26 05:16:59 -0700 (Mon, 26 Sep 2011) Log Message Merge WebKitAPITest into TestWebKitAPI This also means that our formerly-WebKitAPITest tests will be run on the bots! I made the minimal changes necessary to get the

[webkit-changes] [95943] trunk/Tools

2011-09-26 Thread aroben
Title: [95943] trunk/Tools Revision 95943 Author aro...@apple.com Date 2011-09-26 05:15:28 -0700 (Mon, 26 Sep 2011) Log Message Remove two failing WebKitAPITest tests The failures are covered by and . Reviewed by Anders Carlsson. * WebKitAPITest/tests/WebViewDestruction.cpp: Removed t

[webkit-changes] [95858] tags/Safari-535.3.1-Win/

2011-09-23 Thread aroben
Title: [95858] tags/Safari-535.3.1-Win/ Revision 95858 Author aro...@apple.com Date 2011-09-23 14:31:32 -0700 (Fri, 23 Sep 2011) Log Message New tag Added Paths tags/Safari-535.3.1-Win/ Diff Property changes: tags/Safari-535.3.1-Win Added: svn:ignore depcomp compile config.guess

[webkit-changes] [95735] trunk/Tools

2011-09-22 Thread aroben
Title: [95735] trunk/Tools Revision 95735 Author aro...@apple.com Date 2011-09-22 10:48:45 -0700 (Thu, 22 Sep 2011) Log Message Remove FindSafari It isn't used or built anymore. Fixes Reviewed by Darin Adler. * FindSafari: Removed this directory and its contents. Modified Paths tru

[webkit-changes] [95734] trunk

2011-09-22 Thread aroben
Title: [95734] trunk Revision 95734 Author aro...@apple.com Date 2011-09-22 10:48:18 -0700 (Thu, 22 Sep 2011) Log Message Remove FindSafari from all our .sln files It isn't used anymore, so there's no point in building it. Part of Remove FindSafari Reviewed by Steve Falkenburg. Sourc

[webkit-changes] [95733] trunk/Tools

2011-09-22 Thread aroben
Title: [95733] trunk/Tools Revision 95733 Author aro...@apple.com Date 2011-09-22 10:47:40 -0700 (Thu, 22 Sep 2011) Log Message Remove all uses of FindSafari It isn't really needed anymore. Fixes . Reviewed by Darin Adler. * Scripts/old-run-webkit-tests: Moved read/writeRegistryString

[webkit-changes] [95732] trunk/Tools

2011-09-22 Thread aroben
Title: [95732] trunk/Tools Revision 95732 Author aro...@apple.com Date 2011-09-22 10:47:13 -0700 (Thu, 22 Sep 2011) Log Message Use the "direct object" form of system() to run WebKit.exe This prevents the shell from parsing (and possibly splitting, if it contains spaces) the path to WebK

[webkit-changes] [95731] trunk/Tools

2011-09-22 Thread aroben
Title: [95731] trunk/Tools Revision 95731 Author aro...@apple.com Date 2011-09-22 10:46:50 -0700 (Thu, 22 Sep 2011) Log Message Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath Fixes build-webkit goes totally haywire on Windows if there are spaces in the path to

[webkit-changes] [95730] trunk/Source/WebKit/win

2011-09-22 Thread aroben
Title: [95730] trunk/Source/WebKit/win Revision 95730 Author aro...@apple.com Date 2011-09-22 10:46:24 -0700 (Thu, 22 Sep 2011) Log Message Add testRegExp.vcproj to WebKit.sln Fixes Windows bots don't build testRegExp.vcproj Reviewed by Brian Weinstein. * WebKit.vcproj/WebKit.sln: Add

[webkit-changes] [95540] trunk/Source/JavaScriptCore

2011-09-20 Thread aroben
Title: [95540] trunk/Source/_javascript_Core Revision 95540 Author aro...@apple.com Date 2011-09-20 07:08:17 -0700 (Tue, 20 Sep 2011) Log Message Windows build fix after r95523 * wtf/CheckedArithmetic.h: Added stdint.h so we can have int64_t defined. Modified Paths trunk/Source/_javasc

[webkit-changes] [95485] trunk/Source/JavaScriptCore

2011-09-19 Thread aroben
Title: [95485] trunk/Source/_javascript_Core Revision 95485 Author aro...@apple.com Date 2011-09-19 15:32:20 -0700 (Mon, 19 Sep 2011) Log Message Windows build fix after r95310 * _javascript_Core.vcproj/testRegExp/testRegExpCommon.vsprops: Added include\private\_javascript_Core to the in

[webkit-changes] [95481] trunk/Source/ThirdParty/ANGLE

2011-09-19 Thread aroben
Title: [95481] trunk/Source/ThirdParty/ANGLE Revision 95481 Author aro...@apple.com Date 2011-09-19 15:20:41 -0700 (Mon, 19 Sep 2011) Log Message Let Xcode 4 do its thang with ANGLE.xcodeproj * ANGLE.xcodeproj/project.pbxproj: Modified Paths trunk/Source/ThirdParty/ANGLE/ANGLE.xcodepro

[webkit-changes] [95480] trunk/Source/JavaScriptCore

2011-09-19 Thread aroben
Title: [95480] trunk/Source/_javascript_Core Revision 95480 Author aro...@apple.com Date 2011-09-19 15:20:32 -0700 (Mon, 19 Sep 2011) Log Message Windows build fix after r94575 * _javascript_Core.vcproj/_javascript_Core.sln: Relinearized project dependencies. testRegExp now builds just b

[webkit-changes] [95319] trunk/Source/JavaScriptCore

2011-09-16 Thread aroben
Title: [95319] trunk/Source/_javascript_Core Revision 95319 Author aro...@apple.com Date 2011-09-16 13:33:38 -0700 (Fri, 16 Sep 2011) Log Message Windows build fix after r95310 * _javascript_Core.vcproj/jsc/jscCommon.vsprops: Added include\private\_javascript_Core to the include path so

[webkit-changes] [95300] trunk/Source/WebKit2

2011-09-16 Thread aroben
Title: [95300] trunk/Source/WebKit2 Revision 95300 Author aro...@apple.com Date 2011-09-16 09:58:38 -0700 (Fri, 16 Sep 2011) Log Message Add support for attributes on message parameters Parameter attributes are specified as a space-separated list inside square brackets before the paramet

[webkit-changes] [95298] trunk/Source/WebKit2

2011-09-16 Thread aroben
Title: [95298] trunk/Source/WebKit2 Revision 95298 Author aro...@apple.com Date 2011-09-16 09:57:50 -0700 (Fri, 16 Sep 2011) Log Message Split some of the message-generation code into separate modules This is in preparation for making these modules scripts usable by other projects. Fixe

[webkit-changes] [95299] trunk/Source/WebKit2

2011-09-16 Thread aroben
Title: [95299] trunk/Source/WebKit2 Revision 95299 Author aro...@apple.com Date 2011-09-16 09:58:14 -0700 (Fri, 16 Sep 2011) Log Message Make WebKit2's message-generation model and parser scripts accessible to other projects We copy them into the build products directory so other project

[webkit-changes] [95195] trunk/Source/WebKit2

2011-09-15 Thread aroben
Title: [95195] trunk/Source/WebKit2 Revision 95195 Author aro...@apple.com Date 2011-09-15 09:43:15 -0700 (Thu, 15 Sep 2011) Log Message Remove WebKit2-specific knowledge from the Message class This is in preparation for making some of our message-generations scripts usable by other proj

  1   2   3   >