[webkit-changes] [290646] trunk

2022-03-01 Thread wenson_hsieh
Title: [290646] trunk Revision 290646 Author wenson_hs...@apple.com Date 2022-03-01 07:16:09 -0800 (Tue, 01 Mar 2022) Log Message focus({preventScroll: true}) does not prevent scrolling on iOS https://bugs.webkit.org/show_bug.cgi?id=236584 rdar://88911184 Reviewed by Simon Fraser.

[webkit-changes] [290620] trunk/Tools

2022-02-28 Thread wenson_hsieh
Title: [290620] trunk/Tools Revision 290620 Author wenson_hs...@apple.com Date 2022-02-28 16:14:24 -0800 (Mon, 28 Feb 2022) Log Message Add API testing infrastructure for "Markup Image" and "Copy Cropped Image" https://bugs.webkit.org/show_bug.cgi?id=236519 rdar://89154213 Reviewed by

[webkit-changes] [290578] trunk/Source

2022-02-27 Thread wenson_hsieh
Title: [290578] trunk/Source Revision 290578 Author wenson_hs...@apple.com Date 2022-02-27 19:24:13 -0800 (Sun, 27 Feb 2022) Log Message Invoking "Markup Image" should preserve the existing selection range https://bugs.webkit.org/show_bug.cgi?id=237242 Reviewed by Darin Adler.

[webkit-changes] [290543] trunk

2022-02-25 Thread wenson_hsieh
Title: [290543] trunk Revision 290543 Author wenson_hs...@apple.com Date 2022-02-25 21:38:48 -0800 (Fri, 25 Feb 2022) Log Message Adjust -[WKContentView _requiresKeyboardWhenFirstResponder] to account for editable web views https://bugs.webkit.org/show_bug.cgi?id=237226 rdar://89447095

[webkit-changes] [290450] trunk

2022-02-24 Thread wenson_hsieh
Title: [290450] trunk Revision 290450 Author wenson_hs...@apple.com Date 2022-02-24 12:13:49 -0800 (Thu, 24 Feb 2022) Log Message Refactor logic for showing "Markup Image" and Quick Note items in the callout bar https://bugs.webkit.org/show_bug.cgi?id=237127 rdar://89396617 Reviewed by

[webkit-changes] [290389] trunk/Tools

2022-02-23 Thread wenson_hsieh
Title: [290389] trunk/Tools Revision 290389 Author wenson_hs...@apple.com Date 2022-02-23 12:57:36 -0800 (Wed, 23 Feb 2022) Log Message REGRESSION (288925?): [iOS] TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal is failing

[webkit-changes] [290286] trunk

2022-02-21 Thread wenson_hsieh
Title: [290286] trunk Revision 290286 Author wenson_hs...@apple.com Date 2022-02-21 20:03:59 -0800 (Mon, 21 Feb 2022) Log Message [iOS] Adjust some behaviors around the "Markup Image" action in the callout bar https://bugs.webkit.org/show_bug.cgi?id=236980 Reviewed by Aditya Keerthi.

[webkit-changes] [290278] trunk/Source/WebCore

2022-02-21 Thread wenson_hsieh
Title: [290278] trunk/Source/WebCore Revision 290278 Author wenson_hs...@apple.com Date 2022-02-21 17:37:17 -0800 (Mon, 21 Feb 2022) Log Message Add test coverage for the pasteboard writing codepath added in r289839 https://bugs.webkit.org/show_bug.cgi?id=236944 Reviewed by Aditya

[webkit-changes] [290212] trunk/Source/WebKit

2022-02-19 Thread wenson_hsieh
Title: [290212] trunk/Source/WebKit Revision 290212 Author wenson_hs...@apple.com Date 2022-02-19 13:02:42 -0800 (Sat, 19 Feb 2022) Log Message Unreviewed, fix the internal iOS build after r290154 `-[ASCAgentProtocol performAutoFillAuthorizationRequestsForContext:]` only exists on macOS

[webkit-changes] [290211] trunk/Source/WebKit

2022-02-19 Thread wenson_hsieh
Title: [290211] trunk/Source/WebKit Revision 290211 Author wenson_hs...@apple.com Date 2022-02-19 11:24:02 -0800 (Sat, 19 Feb 2022) Log Message [macOS] Hovering over "Copy Cropped Image" context menu item should reveal the cropped image https://bugs.webkit.org/show_bug.cgi?id=236845

[webkit-changes] [290178] trunk

2022-02-18 Thread wenson_hsieh
Title: [290178] trunk Revision 290178 Author wenson_hs...@apple.com Date 2022-02-18 15:50:27 -0800 (Fri, 18 Feb 2022) Log Message [Live Text] Add a mechanism to inject images into image overlays https://bugs.webkit.org/show_bug.cgi?id=236842 Reviewed by Aditya Keerthi. Source/WebCore:

[webkit-changes] [289908] trunk/Source/WebKit

2022-02-16 Thread wenson_hsieh
Title: [289908] trunk/Source/WebKit Revision 289908 Author wenson_hs...@apple.com Date 2022-02-16 10:16:37 -0800 (Wed, 16 Feb 2022) Log Message [Cocoa] Clean up some unused context menu identifier SPI constants https://bugs.webkit.org/show_bug.cgi?id=236669 rdar://88924479 Reviewed by

[webkit-changes] [289882] trunk/Source

2022-02-16 Thread wenson_hsieh
Title: [289882] trunk/Source Revision 289882 Author wenson_hs...@apple.com Date 2022-02-16 01:19:57 -0800 (Wed, 16 Feb 2022) Log Message [macOS] Add an "Markup Image" item to the sharing services picker context menu https://bugs.webkit.org/show_bug.cgi?id=236628 rdar://86446810 Reviewed

[webkit-changes] [289851] trunk

2022-02-15 Thread wenson_hsieh
Title: [289851] trunk Revision 289851 Author wenson_hs...@apple.com Date 2022-02-15 13:57:03 -0800 (Tue, 15 Feb 2022) Log Message [macOS] Add a context menu item to "Copy Cropped Image" https://bugs.webkit.org/show_bug.cgi?id=236602 rdar://88924479 Reviewed by Megan Gardner.

[webkit-changes] [289839] trunk/Source/WebCore

2022-02-15 Thread wenson_hsieh
Title: [289839] trunk/Source/WebCore Revision 289839 Author wenson_hs...@apple.com Date 2022-02-15 12:47:29 -0800 (Tue, 15 Feb 2022) Log Message Refactor logic for writing selected text in image overlays to the pasteboard https://bugs.webkit.org/show_bug.cgi?id=236546 rdar://83173693

[webkit-changes] [289763] trunk/Source

2022-02-14 Thread wenson_hsieh
Title: [289763] trunk/Source Revision 289763 Author wenson_hs...@apple.com Date 2022-02-14 14:15:35 -0800 (Mon, 14 Feb 2022) Log Message [Live Text] Plumb platform image analysis objects to the web process https://bugs.webkit.org/show_bug.cgi?id=236535 rdar://88845367 Reviewed by Devin

[webkit-changes] [289720] trunk/Source/WebKit

2022-02-13 Thread wenson_hsieh
Title: [289720] trunk/Source/WebKit Revision 289720 Author wenson_hs...@apple.com Date 2022-02-13 13:07:52 -0800 (Sun, 13 Feb 2022) Log Message Unreviewed, fix the internal macOS build Add some missing `WebCore` namespaces (which are presumably now necessary due to changes in unified

[webkit-changes] [289681] trunk/Source

2022-02-11 Thread wenson_hsieh
Title: [289681] trunk/Source Revision 289681 Author wenson_hs...@apple.com Date 2022-02-11 17:12:05 -0800 (Fri, 11 Feb 2022) Log Message [iOS] Add a "Copy Cropped Image" context menu item when long pressing images https://bugs.webkit.org/show_bug.cgi?id=236511 rdar://88817219 Reviewed

[webkit-changes] [289665] trunk/Source/WebKit

2022-02-11 Thread wenson_hsieh
Title: [289665] trunk/Source/WebKit Revision 289665 Author wenson_hs...@apple.com Date 2022-02-11 13:09:02 -0800 (Fri, 11 Feb 2022) Log Message Unreviewed, fix the Apple TV build Don't try to import `AVKitSPI.h` on Apple TV. * UIProcess/ios/WKContentViewInteraction.mm: Modified Paths

[webkit-changes] [289624] trunk/Source/WebKit

2022-02-11 Thread wenson_hsieh
Title: [289624] trunk/Source/WebKit Revision 289624 Author wenson_hs...@apple.com Date 2022-02-11 09:11:00 -0800 (Fri, 11 Feb 2022) Log Message Unreviewed, non-unified build fixes in WKPaymentAuthorizationDelegate Include several missing headers. *

[webkit-changes] [289623] trunk/Source

2022-02-11 Thread wenson_hsieh
Title: [289623] trunk/Source Revision 289623 Author wenson_hs...@apple.com Date 2022-02-11 09:01:52 -0800 (Fri, 11 Feb 2022) Log Message [iOS] Add support for a "markup image" item in the callout bar when selecting a single image https://bugs.webkit.org/show_bug.cgi?id=236415

[webkit-changes] [289552] trunk/Source

2022-02-10 Thread wenson_hsieh
Title: [289552] trunk/Source Revision 289552 Author wenson_hs...@apple.com Date 2022-02-10 10:32:30 -0800 (Thu, 10 Feb 2022) Log Message Support `WebPageProxy::replaceSelectionWithPasteboardData()` on iOS https://bugs.webkit.org/show_bug.cgi?id=236406 Reviewed by Tim Horton.

[webkit-changes] [289514] trunk/Source

2022-02-09 Thread wenson_hsieh
Title: [289514] trunk/Source Revision 289514 Author wenson_hs...@apple.com Date 2022-02-09 17:27:42 -0800 (Wed, 09 Feb 2022) Log Message Add some WebKitAdditions extension points in VisionKitCore SPI and softlinking headers https://bugs.webkit.org/show_bug.cgi?id=236403 rdar://88709972

[webkit-changes] [289237] trunk/Source

2022-02-07 Thread wenson_hsieh
Title: [289237] trunk/Source Revision 289237 Author wenson_hs...@apple.com Date 2022-02-07 12:18:46 -0800 (Mon, 07 Feb 2022) Log Message Add PageClient plumbing for video frame extraction https://bugs.webkit.org/show_bug.cgi?id=236100 rdar://86237608 Reviewed by Eric Carlson.

[webkit-changes] [289221] trunk/Source/WebKit

2022-02-07 Thread wenson_hsieh
Title: [289221] trunk/Source/WebKit Revision 289221 Author wenson_hs...@apple.com Date 2022-02-07 08:01:55 -0800 (Mon, 07 Feb 2022) Log Message Add a helper method on VideoFullscreenManagerProxy to request video frame data https://bugs.webkit.org/show_bug.cgi?id=236094 Reviewed by Darin

[webkit-changes] [289169] trunk/Tools

2022-02-06 Thread wenson_hsieh
Title: [289169] trunk/Tools Revision 289169 Author wenson_hs...@apple.com Date 2022-02-06 08:14:09 -0800 (Sun, 06 Feb 2022) Log Message Adjust `platformResetStateToConsistentValues` to avoid grabbing the general pasteboard when possible https://bugs.webkit.org/show_bug.cgi?id=236196

[webkit-changes] [289100] trunk/Source

2022-02-03 Thread wenson_hsieh
Title: [289100] trunk/Source Revision 289100 Author wenson_hs...@apple.com Date 2022-02-03 18:45:45 -0800 (Thu, 03 Feb 2022) Log Message Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier https://bugs.webkit.org/show_bug.cgi?id=236090

[webkit-changes] [289090] trunk/Source/WebKit

2022-02-03 Thread wenson_hsieh
Title: [289090] trunk/Source/WebKit Revision 289090 Author wenson_hs...@apple.com Date 2022-02-03 17:06:52 -0800 (Thu, 03 Feb 2022) Log Message Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen https://bugs.webkit.org/show_bug.cgi?id=236083

[webkit-changes] [288961] trunk/Source/WebKit

2022-02-02 Thread wenson_hsieh
Title: [288961] trunk/Source/WebKit Revision 288961 Author wenson_hs...@apple.com Date 2022-02-02 10:14:25 -0800 (Wed, 02 Feb 2022) Log Message Unreviewed, fix the macOS build after r288956 https://bugs.webkit.org/show_bug.cgi?id=235991 * UIProcess/Cocoa/WebViewImpl.h: Modified Paths

[webkit-changes] [288956] trunk/Source/WebKit

2022-02-02 Thread wenson_hsieh
Title: [288956] trunk/Source/WebKit Revision 288956 Author wenson_hs...@apple.com Date 2022-02-02 09:52:22 -0800 (Wed, 02 Feb 2022) Log Message Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)

[webkit-changes] [288934] trunk/Source

2022-02-01 Thread wenson_hsieh
Title: [288934] trunk/Source Revision 288934 Author wenson_hs...@apple.com Date 2022-02-01 18:02:01 -0800 (Tue, 01 Feb 2022) Log Message The default values for a couple of Live Text-related features should respect system feature flags https://bugs.webkit.org/show_bug.cgi?id=235980

[webkit-changes] [288925] trunk

2022-02-01 Thread wenson_hsieh
Title: [288925] trunk Revision 288925 Author wenson_hs...@apple.com Date 2022-02-01 16:23:52 -0800 (Tue, 01 Feb 2022) Log Message Mitigate hangs underneath -requestAutocorrectionContextWithCompletionHandler: when focusing text fields https://bugs.webkit.org/show_bug.cgi?id=235963

[webkit-changes] [288690] trunk

2022-01-27 Thread wenson_hsieh
Title: [288690] trunk Revision 288690 Author wenson_hs...@apple.com Date 2022-01-27 11:55:22 -0800 (Thu, 27 Jan 2022) Log Message ImageAnalysisQueue should prioritize elements that intersect the visible viewport https://bugs.webkit.org/show_bug.cgi?id=235664 rdar://88131827 Reviewed by

[webkit-changes] [288654] trunk/Source/WebCore

2022-01-26 Thread wenson_hsieh
Title: [288654] trunk/Source/WebCore Revision 288654 Author wenson_hs...@apple.com Date 2022-01-26 16:15:46 -0800 (Wed, 26 Jan 2022) Log Message Make some minor adjustments after r288621 https://bugs.webkit.org/show_bug.cgi?id=235598 rdar://88032375 Reviewed by Darin Adler. Address

[webkit-changes] [288621] trunk

2022-01-26 Thread wenson_hsieh
Title: [288621] trunk Revision 288621 Author wenson_hs...@apple.com Date 2022-01-26 08:49:09 -0800 (Wed, 26 Jan 2022) Log Message Data detectors sometimes show up in the wrong place when resizing images with Live Text https://bugs.webkit.org/show_bug.cgi?id=235598 rdar://88032375

[webkit-changes] [288575] trunk

2022-01-25 Thread wenson_hsieh
Title: [288575] trunk Revision 288575 Author wenson_hs...@apple.com Date 2022-01-25 12:32:40 -0800 (Tue, 25 Jan 2022) Log Message UIWKDocumentRequestSpatialAndCurrentSelection should limit context to the editable root of the current selection

[webkit-changes] [288477] trunk

2022-01-24 Thread wenson_hsieh
Title: [288477] trunk Revision 288477 Author wenson_hs...@apple.com Date 2022-01-24 15:47:36 -0800 (Mon, 24 Jan 2022) Log Message [macOS] Update Pasteboard::read to prioritize native representations over TIFF https://bugs.webkit.org/show_bug.cgi?id=190101 rdar://44879244 Reviewed by

[webkit-changes] [288327] trunk/Source/WebCore

2022-01-20 Thread wenson_hsieh
Title: [288327] trunk/Source/WebCore Revision 288327 Author wenson_hs...@apple.com Date 2022-01-20 15:09:16 -0800 (Thu, 20 Jan 2022) Log Message [macOS] Various tests hit debug assertions under `SearchBuffer::search` after system ICU changes https://bugs.webkit.org/show_bug.cgi?id=235413

[webkit-changes] [288178] trunk

2022-01-18 Thread wenson_hsieh
Title: [288178] trunk Revision 288178 Author wenson_hs...@apple.com Date 2022-01-18 19:11:03 -0800 (Tue, 18 Jan 2022) Log Message REGRESSION (r264352): Mail compose body field does not avoid the keyboard when scrolling after focus https://bugs.webkit.org/show_bug.cgi?id=235331

[webkit-changes] [288102] trunk

2022-01-17 Thread wenson_hsieh
Title: [288102] trunk Revision 288102 Author wenson_hs...@apple.com Date 2022-01-17 12:17:20 -0800 (Mon, 17 Jan 2022) Log Message ImageAnalysisQueue should analyze image elements that are loaded after the call to enqueueAllImages() https://bugs.webkit.org/show_bug.cgi?id=233266

[webkit-changes] [288039] trunk

2022-01-14 Thread wenson_hsieh
Title: [288039] trunk Revision 288039 Author wenson_hs...@apple.com Date 2022-01-14 16:56:22 -0800 (Fri, 14 Jan 2022) Log Message [iOS] Occasional crash under -[UITargetedPreview initWithView:parameters:target:] when focusing form controls https://bugs.webkit.org/show_bug.cgi?id=235248

[webkit-changes] [288032] trunk

2022-01-14 Thread wenson_hsieh
Title: [288032] trunk Revision 288032 Author wenson_hs...@apple.com Date 2022-01-14 14:23:35 -0800 (Fri, 14 Jan 2022) Log Message Avoid redundant text analysis requests when long pressing inside an image that contains Live Text https://bugs.webkit.org/show_bug.cgi?id=235129

[webkit-changes] [287992] trunk

2022-01-13 Thread wenson_hsieh
Title: [287992] trunk Revision 287992 Author wenson_hs...@apple.com Date 2022-01-13 13:25:03 -0800 (Thu, 13 Jan 2022) Log Message Crash in Document::updateStyleIfNeeded() when removing a node containing the drag caret https://bugs.webkit.org/show_bug.cgi?id=235184 rdar://74845918

[webkit-changes] [287954] trunk

2022-01-12 Thread wenson_hsieh
Title: [287954] trunk Revision 287954 Author wenson_hs...@apple.com Date 2022-01-12 15:13:39 -0800 (Wed, 12 Jan 2022) Log Message Live Text is sometimes horizontally clipped when injecting TextRecognitionBlockData https://bugs.webkit.org/show_bug.cgi?id=235122 Reviewed by Devin Rousso.

[webkit-changes] [287953] trunk

2022-01-12 Thread wenson_hsieh
Title: [287953] trunk Revision 287953 Author wenson_hs...@apple.com Date 2022-01-12 14:59:04 -0800 (Wed, 12 Jan 2022) Log Message [macOS] [WK2] NSFontPanel UI (font color, text decorations, font shadow) doesn't update on selection change https://bugs.webkit.org/show_bug.cgi?id=190120

[webkit-changes] [287943] trunk

2022-01-12 Thread wenson_hsieh
Title: [287943] trunk Revision 287943 Author wenson_hs...@apple.com Date 2022-01-12 12:06:30 -0800 (Wed, 12 Jan 2022) Log Message [Live Text] Image overlay text is misaligned on rfi.fr https://bugs.webkit.org/show_bug.cgi?id=235118 Reviewed by Aditya Keerthi. Source/WebCore: Reset any

[webkit-changes] [287866] trunk

2022-01-10 Thread wenson_hsieh
Title: [287866] trunk Revision 287866 Author wenson_hs...@apple.com Date 2022-01-10 18:17:09 -0800 (Mon, 10 Jan 2022) Log Message Followup to r287863 - adjust line wrapping behavior in image overlays https://bugs.webkit.org/show_bug.cgi?id=235035 rdar://85139146 Reviewed by Tim Horton.

[webkit-changes] [287863] trunk

2022-01-10 Thread wenson_hsieh
Title: [287863] trunk Revision 287863 Author wenson_hs...@apple.com Date 2022-01-10 15:48:40 -0800 (Mon, 10 Jan 2022) Log Message Add support for a -shouldWrap property when injecting Live Text https://bugs.webkit.org/show_bug.cgi?id=235035 rdar://85139146 Reviewed by Tim Horton.

[webkit-changes] [287860] trunk

2022-01-10 Thread wenson_hsieh
Title: [287860] trunk Revision 287860 Author wenson_hs...@apple.com Date 2022-01-10 14:58:49 -0800 (Mon, 10 Jan 2022) Log Message Modal container observer should classify elements that are styled like clickable controls https://bugs.webkit.org/show_bug.cgi?id=235022 Reviewed by Tim

[webkit-changes] [287849] trunk

2022-01-10 Thread wenson_hsieh
Title: [287849] trunk Revision 287849 Author wenson_hs...@apple.com Date 2022-01-10 11:19:54 -0800 (Mon, 10 Jan 2022) Log Message Modal container observer fails detection when rendered text is inserted after the container https://bugs.webkit.org/show_bug.cgi?id=234752 rdar://87200177

[webkit-changes] [287814] trunk

2022-01-08 Thread wenson_hsieh
Title: [287814] trunk Revision 287814 Author wenson_hs...@apple.com Date 2022-01-08 14:12:16 -0800 (Sat, 08 Jan 2022) Log Message Null pointer crash when calling into `-[WebView close]` in `-webView:didCommitLoadForFrame:` https://bugs.webkit.org/show_bug.cgi?id=234994 rdar://86845512

[webkit-changes] [287777] trunk

2022-01-07 Thread wenson_hsieh
Title: [28] trunk Revision 28 Author wenson_hs...@apple.com Date 2022-01-07 12:28:04 -0800 (Fri, 07 Jan 2022) Log Message Teach modal container observer to make the body element scrollable if necessary https://bugs.webkit.org/show_bug.cgi?id=234708 rdar://86960677 Reviewed by

[webkit-changes] [287731] trunk/Source

2022-01-06 Thread wenson_hsieh
Title: [287731] trunk/Source Revision 287731 Author wenson_hs...@apple.com Date 2022-01-06 16:18:59 -0800 (Thu, 06 Jan 2022) Log Message Add a helper function that returns the value of a std::optional or constructs T if needed https://bugs.webkit.org/show_bug.cgi?id=234865 Reviewed by

[webkit-changes] [287671] trunk

2022-01-05 Thread wenson_hsieh
Title: [287671] trunk Revision 287671 Author wenson_hs...@apple.com Date 2022-01-05 19:08:12 -0800 (Wed, 05 Jan 2022) Log Message Modal container observer should detect and suppress elements that prevent user interaction https://bugs.webkit.org/show_bug.cgi?id=234695 Reviewed by Tim

[webkit-changes] [287600] trunk/Source/WebKit

2022-01-04 Thread wenson_hsieh
Title: [287600] trunk/Source/WebKit Revision 287600 Author wenson_hs...@apple.com Date 2022-01-04 17:26:05 -0800 (Tue, 04 Jan 2022) Log Message ASSERTION FAILED: pathnames.size() == sandboxExtensionsHandleArray.size() in WebKit::WebPlatformStrategies::getPathnamesForType()

[webkit-changes] [287592] trunk

2022-01-04 Thread wenson_hsieh
Title: [287592] trunk Revision 287592 Author wenson_hs...@apple.com Date 2022-01-04 15:31:23 -0800 (Tue, 04 Jan 2022) Log Message Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier https://bugs.webkit.org/show_bug.cgi?id=234677 Reviewed by

[webkit-changes] [287588] trunk

2022-01-04 Thread wenson_hsieh
Title: [287588] trunk Revision 287588 Author wenson_hs...@apple.com Date 2022-01-04 13:58:51 -0800 (Tue, 04 Jan 2022) Log Message ModalContainerObserver should search for text in subframes https://bugs.webkit.org/show_bug.cgi?id=234446 rdar://86897770 Reviewed by Tim Horton.

[webkit-changes] [287547] trunk

2022-01-03 Thread wenson_hsieh
Title: [287547] trunk Revision 287547 Author wenson_hs...@apple.com Date 2022-01-03 10:27:07 -0800 (Mon, 03 Jan 2022) Log Message Undownloaded iCloud Photos are inserted as broken images when attachment element is enabled https://bugs.webkit.org/show_bug.cgi?id=234803 rdar://82318259

[webkit-changes] [287522] trunk

2022-01-02 Thread wenson_hsieh
Title: [287522] trunk Revision 287522 Author wenson_hs...@apple.com Date 2022-01-02 12:19:40 -0800 (Sun, 02 Jan 2022) Log Message [WebKit2] Camera continuity is disabled in richly editable content https://bugs.webkit.org/show_bug.cgi?id=234773 rdar://46323417 Reviewed by Darin Adler.

[webkit-changes] [287521] trunk/Source/WebCore

2022-01-02 Thread wenson_hsieh
Title: [287521] trunk/Source/WebCore Revision 287521 Author wenson_hs...@apple.com Date 2022-01-02 11:05:11 -0800 (Sun, 02 Jan 2022) Log Message Followup to r287494 https://bugs.webkit.org/show_bug.cgi?id=234747 rdar://85899879 Reviewed by Darin Adler. Use `auto` instread of `RefPtr`

[webkit-changes] [287505] trunk

2022-01-01 Thread wenson_hsieh
Title: [287505] trunk Revision 287505 Author wenson_hs...@apple.com Date 2022-01-01 15:06:26 -0800 (Sat, 01 Jan 2022) Log Message Modal containers are incorrectly detected in navigation elements and fixed document elements https://bugs.webkit.org/show_bug.cgi?id=234669 rdar://87030613

[webkit-changes] [287503] trunk/Tools

2022-01-01 Thread wenson_hsieh
Title: [287503] trunk/Tools Revision 287503 Author wenson_hs...@apple.com Date 2022-01-01 13:03:23 -0800 (Sat, 01 Jan 2022) Log Message [Cocoa] Simplify some FontAttributes API tests https://bugs.webkit.org/show_bug.cgi?id=234770 Reviewed by Darin Adler. Simplify some of the logic

[webkit-changes] [287497] trunk

2021-12-31 Thread wenson_hsieh
Title: [287497] trunk Revision 287497 Author wenson_hs...@apple.com Date 2021-12-31 16:22:38 -0800 (Fri, 31 Dec 2021) Log Message Include a few more tag names to search when running modal container detection https://bugs.webkit.org/show_bug.cgi?id=234652 Reviewed by Darin Adler.

[webkit-changes] [287496] trunk/Source

2021-12-31 Thread wenson_hsieh
Title: [287496] trunk/Source Revision 287496 Author wenson_hs...@apple.com Date 2021-12-31 15:33:52 -0800 (Fri, 31 Dec 2021) Log Message Refactor some Cocoa-specific code in WebCore::FontAttributes to be platform-agnostic https://bugs.webkit.org/show_bug.cgi?id=234757 Source/WebCore:

[webkit-changes] [287494] trunk

2021-12-31 Thread wenson_hsieh
Title: [287494] trunk Revision 287494 Author wenson_hs...@apple.com Date 2021-12-31 11:46:47 -0800 (Fri, 31 Dec 2021) Log Message Updating the file name of attachment-backed images should automatically set the `alt` attribute https://bugs.webkit.org/show_bug.cgi?id=234747 rdar://85899879

[webkit-changes] [287461] trunk/Source/WebCore

2021-12-27 Thread wenson_hsieh
Title: [287461] trunk/Source/WebCore Revision 287461 Author wenson_hs...@apple.com Date 2021-12-27 16:29:08 -0800 (Mon, 27 Dec 2021) Log Message Element::boundingAbsoluteRectWithoutLayout() should be marked `const` https://bugs.webkit.org/show_bug.cgi?id=234703 Reviewed by Darin Adler.

[webkit-changes] [287404] trunk

2021-12-23 Thread wenson_hsieh
Title: [287404] trunk Revision 287404 Author wenson_hs...@apple.com Date 2021-12-23 09:57:29 -0800 (Thu, 23 Dec 2021) Log Message Add API testing support for modal container observation https://bugs.webkit.org/show_bug.cgi?id=234610 Reviewed by Megan Gardner. Source/WebCore: Add

[webkit-changes] [287366] trunk

2021-12-22 Thread wenson_hsieh
Title: [287366] trunk Revision 287366 Author wenson_hs...@apple.com Date 2021-12-22 11:12:30 -0800 (Wed, 22 Dec 2021) Log Message [iOS] Scroll view pinch zoom gesture sometimes fails to recognize in WKWebView https://bugs.webkit.org/show_bug.cgi?id=234584 rdar://84379650 Reviewed by

[webkit-changes] [287340] trunk/Tools

2021-12-21 Thread wenson_hsieh
Title: [287340] trunk/Tools Revision 287340 Author wenson_hs...@apple.com Date 2021-12-21 19:25:57 -0800 (Tue, 21 Dec 2021) Log Message REGRESSION (12/21/2021): [iOS] TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing https://bugs.webkit.org/show_bug.cgi?id=234574

[webkit-changes] [287321] trunk/Source

2021-12-21 Thread wenson_hsieh
Title: [287321] trunk/Source Revision 287321 Author wenson_hs...@apple.com Date 2021-12-21 10:17:38 -0800 (Tue, 21 Dec 2021) Log Message Add support for a UI delegate method to decide how to handle detected modal containers https://bugs.webkit.org/show_bug.cgi?id=234440 rdar://77073735

[webkit-changes] [287296] trunk/Source/WebKit

2021-12-20 Thread wenson_hsieh
Title: [287296] trunk/Source/WebKit Revision 287296 Author wenson_hs...@apple.com Date 2021-12-20 19:09:46 -0800 (Mon, 20 Dec 2021) Log Message Add ModalContainerControlClassifier and use it to implement classifyModalContainerControls() https://bugs.webkit.org/show_bug.cgi?id=234322

[webkit-changes] [287281] trunk/Source/WebCore

2021-12-20 Thread wenson_hsieh
Title: [287281] trunk/Source/WebCore Revision 287281 Author wenson_hs...@apple.com Date 2021-12-20 15:01:20 -0800 (Mon, 20 Dec 2021) Log Message Adopt ChromeClient::classifyModalContainerControls() in ModalContainerObserver https://bugs.webkit.org/show_bug.cgi?id=234323 Reviewed by

[webkit-changes] [287279] trunk/Source/WebKit

2021-12-20 Thread wenson_hsieh
Title: [287279] trunk/Source/WebKit Revision 287279 Author wenson_hs...@apple.com Date 2021-12-20 14:14:50 -0800 (Mon, 20 Dec 2021) Log Message Add some missing API availability macros around some WebXR SPI https://bugs.webkit.org/show_bug.cgi?id=234521 Reviewed by Tim Horton. Add some

[webkit-changes] [287274] trunk/Source/WebKit

2021-12-20 Thread wenson_hsieh
Title: [287274] trunk/Source/WebKit Revision 287274 Author wenson_hs...@apple.com Date 2021-12-20 13:36:06 -0800 (Mon, 20 Dec 2021) Log Message Minor cleanup in AuthenticationServicesCoreSPI.h https://bugs.webkit.org/show_bug.cgi?id=234514 Reviewed by Devin Rousso. When using the Apple

[webkit-changes] [287273] trunk/Source/WebCore/PAL

2021-12-20 Thread wenson_hsieh
Title: [287273] trunk/Source/WebCore/PAL Revision 287273 Author wenson_hs...@apple.com Date 2021-12-20 13:02:31 -0800 (Mon, 20 Dec 2021) Log Message Add PAL soft linking headers for CoreML and NaturalLanguage frameworks https://bugs.webkit.org/show_bug.cgi?id=234489 Reviewed by Devin

[webkit-changes] [287247] trunk/Source

2021-12-19 Thread wenson_hsieh
Title: [287247] trunk/Source Revision 287247 Author wenson_hs...@apple.com Date 2021-12-19 12:43:24 -0800 (Sun, 19 Dec 2021) Log Message Add client layer plumbing for classifying modal container controls https://bugs.webkit.org/show_bug.cgi?id=234320 Reviewed by Dean Jackson.

[webkit-changes] [287245] trunk/Source/WebCore

2021-12-19 Thread wenson_hsieh
Title: [287245] trunk/Source/WebCore Revision 287245 Author wenson_hs...@apple.com Date 2021-12-19 12:24:24 -0800 (Sun, 19 Dec 2021) Log Message Add a basic heuristic for collecting and extracting text from controls in ModalContainerObserver https://bugs.webkit.org/show_bug.cgi?id=234299

[webkit-changes] [287219] trunk/Source/WebCore

2021-12-17 Thread wenson_hsieh
Title: [287219] trunk/Source/WebCore Revision 287219 Author wenson_hs...@apple.com Date 2021-12-17 21:45:31 -0800 (Fri, 17 Dec 2021) Log Message Hide viewport-constrained elements that are detected by ModalContainerObserver https://bugs.webkit.org/show_bug.cgi?id=234216 Reviewed by Tim

[webkit-changes] [287217] trunk/Source

2021-12-17 Thread wenson_hsieh
Title: [287217] trunk/Source Revision 287217 Author wenson_hs...@apple.com Date 2021-12-17 19:06:39 -0800 (Fri, 17 Dec 2021) Log Message Add support for detecting modal containers that contain a given search term https://bugs.webkit.org/show_bug.cgi?id=234214 Reviewed by Tim Horton and

[webkit-changes] [286831] trunk/Source

2021-12-09 Thread wenson_hsieh
Title: [286831] trunk/Source Revision 286831 Author wenson_hs...@apple.com Date 2021-12-09 21:05:27 -0800 (Thu, 09 Dec 2021) Log Message Add a new WKWebpagePreferences SPI for modal container observation policies https://bugs.webkit.org/show_bug.cgi?id=234013 rdar://86219613 Reviewed by

[webkit-changes] [286658] trunk/Source/WebKit

2021-12-08 Thread wenson_hsieh
Title: [286658] trunk/Source/WebKit Revision 286658 Author wenson_hs...@apple.com Date 2021-12-08 09:04:27 -0800 (Wed, 08 Dec 2021) Log Message Add a missing CompletionHandlerCallChecker around a UI delegate method call after r286640 https://bugs.webkit.org/show_bug.cgi?id=233890

[webkit-changes] [286640] trunk

2021-12-07 Thread wenson_hsieh
Title: [286640] trunk Revision 286640 Author wenson_hs...@apple.com Date 2021-12-07 20:24:38 -0800 (Tue, 07 Dec 2021) Log Message Add support for `navigator.requestCookieConsent()` behind a disabled feature flag https://bugs.webkit.org/show_bug.cgi?id=233890 rdar://86117718 Reviewed by

[webkit-changes] [286556] trunk/Source/WebCore

2021-12-06 Thread wenson_hsieh
Title: [286556] trunk/Source/WebCore Revision 286556 Author wenson_hs...@apple.com Date 2021-12-06 11:45:01 -0800 (Mon, 06 Dec 2021) Log Message Unreviewed, add some missing #includes in WebCore Add several missing `#include`-s, which currently aren't causing any issues due to unified

[webkit-changes] [286547] trunk/Tools

2021-12-06 Thread wenson_hsieh
Title: [286547] trunk/Tools Revision 286547 Author wenson_hs...@apple.com Date 2021-12-06 10:27:41 -0800 (Mon, 06 Dec 2021) Log Message [iOS] AppHighlights.AppHighlightCreateAndRestoreAndScroll is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=233828 Reviewed by Tim Horton.

[webkit-changes] [286522] trunk

2021-12-03 Thread wenson_hsieh
Title: [286522] trunk Revision 286522 Author wenson_hs...@apple.com Date 2021-12-03 17:35:53 -0800 (Fri, 03 Dec 2021) Log Message [iOS] Web content process sometimes crashes under WebPage::positionInformation() https://bugs.webkit.org/show_bug.cgi?id=233841 rdar://85917212 Reviewed by

[webkit-changes] [286501] trunk/Source/WebKit

2021-12-03 Thread wenson_hsieh
Title: [286501] trunk/Source/WebKit Revision 286501 Author wenson_hs...@apple.com Date 2021-12-03 10:29:32 -0800 (Fri, 03 Dec 2021) Log Message [ Monterey wk2 ] http/tests/media/video-webm-stall.html (layout-test) is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=233717

[webkit-changes] [286450] trunk

2021-12-02 Thread wenson_hsieh
Title: [286450] trunk Revision 286450 Author wenson_hs...@apple.com Date 2021-12-02 13:33:49 -0800 (Thu, 02 Dec 2021) Log Message [ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure

[webkit-changes] [286366] trunk/Source/WebCore

2021-12-01 Thread wenson_hsieh
Title: [286366] trunk/Source/WebCore Revision 286366 Author wenson_hs...@apple.com Date 2021-12-01 09:09:44 -0800 (Wed, 01 Dec 2021) Log Message Adjust a Live Text quirk so that it applies to YouTube image thumbnails https://bugs.webkit.org/show_bug.cgi?id=233670 Reviewed by Devin

[webkit-changes] [286282] trunk

2021-11-29 Thread wenson_hsieh
Title: [286282] trunk Revision 286282 Author wenson_hs...@apple.com Date 2021-11-29 20:23:14 -0800 (Mon, 29 Nov 2021) Log Message [Webpage translation] Avoid translating text inside image overlays https://bugs.webkit.org/show_bug.cgi?id=233225 rdar://85713734 Reviewed by Aditya Keerthi.

[webkit-changes] [286265] trunk

2021-11-29 Thread wenson_hsieh
Title: [286265] trunk Revision 286265 Author wenson_hs...@apple.com Date 2021-11-29 14:47:33 -0800 (Mon, 29 Nov 2021) Log Message Add a basic heuristic for sizing text in image overlay blocks https://bugs.webkit.org/show_bug.cgi?id=233343 rdar://85755755 Reviewed by Tim Horton.

[webkit-changes] [286260] trunk

2021-11-29 Thread wenson_hsieh
Title: [286260] trunk Revision 286260 Author wenson_hs...@apple.com Date 2021-11-29 13:24:56 -0800 (Mon, 29 Nov 2021) Log Message WKContentView should allow -captureTextFromCamera: with a caret selection unless the sender is the callout bar https://bugs.webkit.org/show_bug.cgi?id=233378

[webkit-changes] [286125] trunk

2021-11-22 Thread wenson_hsieh
Title: [286125] trunk Revision 286125 Author wenson_hs...@apple.com Date 2021-11-22 18:24:59 -0800 (Mon, 22 Nov 2021) Log Message Remove old concurrent display list logic that's no longer necessary https://bugs.webkit.org/show_bug.cgi?id=233433 Reviewed by Sam Weinig. Source/WebCore:

[webkit-changes] [286106] trunk/Tools

2021-11-21 Thread wenson_hsieh
Title: [286106] trunk/Tools Revision 286106 Author wenson_hs...@apple.com Date 2021-11-21 15:41:28 -0800 (Sun, 21 Nov 2021) Log Message Add an API test for batch image analysis (-[WKWebView _startImageAnalysis:]) https://bugs.webkit.org/show_bug.cgi?id=21 Reviewed by Sam Weinig.

[webkit-changes] [286021] trunk

2021-11-18 Thread wenson_hsieh
Title: [286021] trunk Revision 286021 Author wenson_hs...@apple.com Date 2021-11-18 12:48:15 -0800 (Thu, 18 Nov 2021) Log Message [macOS] [Live Text] Avoid analyzing images in editable content https://bugs.webkit.org/show_bug.cgi?id=233317 Reviewed by Megan Gardner. Source/WebCore:

[webkit-changes] [285973] trunk/Source

2021-11-17 Thread wenson_hsieh
Title: [285973] trunk/Source Revision 285973 Author wenson_hs...@apple.com Date 2021-11-17 19:13:16 -0800 (Wed, 17 Nov 2021) Log Message [Live Text] Plumb an identifier string through `ChromeClient::requestTextRecognition()` https://bugs.webkit.org/show_bug.cgi?id=233210 Reviewed by

[webkit-changes] [285966] trunk/Source/WebKit

2021-11-17 Thread wenson_hsieh
Title: [285966] trunk/Source/WebKit Revision 285966 Author wenson_hs...@apple.com Date 2021-11-17 16:38:36 -0800 (Wed, 17 Nov 2021) Log Message Add a Translation WebKit2 logging category https://bugs.webkit.org/show_bug.cgi?id=233286 Reviewed by Tim Horton. Add the new category. *

[webkit-changes] [285949] trunk/Source

2021-11-17 Thread wenson_hsieh
Title: [285949] trunk/Source Revision 285949 Author wenson_hs...@apple.com Date 2021-11-17 12:22:11 -0800 (Wed, 17 Nov 2021) Log Message Add a helper class to coordinate batch analysis of images https://bugs.webkit.org/show_bug.cgi?id=233075 Reviewed by Dean Jackson. Source/WebCore:

[webkit-changes] [285862] trunk/Source/WebCore

2021-11-16 Thread wenson_hsieh
Title: [285862] trunk/Source/WebCore Revision 285862 Author wenson_hs...@apple.com Date 2021-11-16 08:37:05 -0800 (Tue, 16 Nov 2021) Log Message Add support for injecting and rendering text recognition blocks https://bugs.webkit.org/show_bug.cgi?id=233044 Reviewed by Aditya Keerthi.

[webkit-changes] [285828] trunk/Source

2021-11-15 Thread wenson_hsieh
Title: [285828] trunk/Source Revision 285828 Author wenson_hs...@apple.com Date 2021-11-15 13:40:08 -0800 (Mon, 15 Nov 2021) Log Message Unreviewed, fix the internal iOS 15 build Source/WebCore/PAL: In the internal iOS 15 SDK, does not define NSTextListMarkerFormat. Add a separate SDK

[webkit-changes] [285811] trunk/Source/WebCore/PAL

2021-11-15 Thread wenson_hsieh
Title: [285811] trunk/Source/WebCore/PAL Revision 285811 Author wenson_hs...@apple.com Date 2021-11-15 10:36:47 -0800 (Mon, 15 Nov 2021) Log Message Declare NSTextListMarker* as type NSTextListMarkerFormat when soft-linking https://bugs.webkit.org/show_bug.cgi?id=233064 rdar://85341122

<    1   2   3   4   5   6   7   8   9   10   >