Diff
Modified: trunk/Source/WebCore/ChangeLog (100994 => 100995)
--- trunk/Source/WebCore/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,21 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Inspector::bringToFront protocol method is currently used on the backend
+ in order to reveal the front-end window. We should do that by means of
+ the inspector client interface instead.
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/Inspector.json:
+ * inspector/InspectorClient.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::show):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyInspectorClient::bringFrontendToFront):
+
2011-11-21 Andrey Kosyakov <ca...@chromium.org>
Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
Modified: trunk/Source/WebCore/inspector/Inspector.json (100994 => 100995)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-11-22 14:11:46 UTC (rev 100995)
@@ -11,9 +11,6 @@
"name": "frontendReused"
},
{
- "name": "bringToFront"
- },
- {
"name": "disconnectFromBackend"
},
{
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (100994 => 100995)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -44,6 +44,7 @@
virtual void inspectorDestroyed() = 0;
virtual void openInspectorFrontend(InspectorController*) = 0;
+ virtual void bringFrontendToFront() = 0;
virtual void highlight() = 0;
virtual void hideHighlight() = 0;
Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (100994 => 100995)
--- trunk/Source/WebCore/inspector/InspectorController.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -285,7 +285,7 @@
return;
if (m_inspectorFrontend)
- m_inspectorFrontend->inspector()->bringToFront();
+ m_inspectorClient->bringFrontendToFront();
else {
m_openingFrontend = true;
m_inspectorClient->openInspectorFrontend(this);
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (100994 => 100995)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-22 14:11:46 UTC (rev 100995)
@@ -842,7 +842,6 @@
WebInspector.frontendReused = function()
{
this.resourceTreeModel.frontendReused();
- this.reset();
}
WebInspector._toolbarItemClicked = function(event)
Modified: trunk/Source/WebCore/loader/EmptyClients.h (100994 => 100995)
--- trunk/Source/WebCore/loader/EmptyClients.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -590,6 +590,7 @@
virtual void inspectorDestroyed() { }
virtual void openInspectorFrontend(InspectorController*) { }
+ virtual void bringFrontendToFront() { }
virtual void highlight() { }
virtual void hideHighlight() { }
Modified: trunk/Source/WebKit/chromium/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,17 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * src/InspectorClientImpl.cpp:
+ (WebKit::InspectorClientImpl::bringFrontendToFront):
+ * src/InspectorClientImpl.h:
+ * src/WebDevToolsAgentImpl.cpp:
+ (WebKit::WebDevToolsAgentImpl::bringFrontendToFront):
+ * src/WebDevToolsAgentImpl.h:
+
2011-11-17 Nat Duca <nd...@chromium.org>
[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
Modified: trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp (100994 => 100995)
--- trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -69,6 +69,12 @@
agent->openInspectorFrontend(controller);
}
+void InspectorClientImpl::bringFrontendToFront()
+{
+ if (WebDevToolsAgentImpl* agent = devToolsAgent())
+ agent->bringFrontendToFront();
+}
+
void InspectorClientImpl::highlight()
{
if (WebDevToolsAgentImpl* agent = devToolsAgent())
Modified: trunk/Source/WebKit/chromium/src/InspectorClientImpl.h (100994 => 100995)
--- trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -49,6 +49,7 @@
// InspectorClient methods:
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (100994 => 100995)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -271,6 +271,10 @@
{
}
+void WebDevToolsAgentImpl::bringFrontendToFront()
+{
+}
+
// PageOverlayClient
void WebDevToolsAgentImpl::paintPageOverlay(GraphicsContext& gc)
{
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h (100994 => 100995)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -86,6 +86,7 @@
// InspectorClient implementation.
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
virtual void updateInspectorStateCookie(const WTF::String&);
Modified: trunk/Source/WebKit/efl/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,14 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientEfl.cpp:
+ (WebCore::InspectorClientEfl::bringFrontendToFront):
+ * WebCoreSupport/InspectorClientEfl.h:
+
2011-11-21 Raphael Kubo da Costa <k...@profusion.mobi>
[EFL] Add more appcache functions to ewk_settings.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp (100994 => 100995)
--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -38,6 +38,11 @@
notImplemented();
}
+void InspectorClientEfl::bringFrontendToFront()
+{
+ notImplemented();
+}
+
void InspectorClientEfl::highlight()
{
notImplemented();
Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h (100994 => 100995)
--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -43,6 +43,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/gtk/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,5 +1,16 @@
2011-11-22 Pavel Feldman <pfeld...@google.com>
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientGtk.cpp:
+ (WebKit::InspectorClient::bringFrontendToFront):
+ * WebCoreSupport/InspectorClientGtk.h:
+
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
Web Inspector: strip unused InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=72886
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp (100994 => 100995)
--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -156,6 +156,11 @@
m_frontendPage->setGroupName("");
}
+void InspectorClient::bringFrontendToFront()
+{
+ m_frontendClient->bringToFront();
+}
+
void InspectorClient::releaseFrontendPage()
{
m_frontendPage = 0;
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h (100994 => 100995)
--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -54,6 +54,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/mac/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/mac/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,15 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm:
+ (WebInspectorClient::openInspectorFrontend):
+ (WebInspectorClient::bringFrontendToFront):
+
2011-11-21 Mark Rowe <mr...@apple.com>
Fix the SnowLeopard build.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (100994 => 100995)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -58,6 +58,7 @@
virtual void inspectorDestroyed() OVERRIDE;
virtual void openInspectorFrontend(WebCore::InspectorController*) OVERRIDE;
+ virtual void bringFrontendToFront() OVERRIDE;
virtual void highlight() OVERRIDE;
virtual void hideHighlight() OVERRIDE;
@@ -75,6 +76,7 @@
WebView *m_webView;
RetainPtr<WebNodeHighlighter> m_highlighter;
WebCore::Page* m_frontendPage;
+ WebCore::InspectorFrontendClient* m_frontendClient;
};
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (100994 => 100995)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-11-22 14:11:46 UTC (rev 100995)
@@ -77,6 +77,7 @@
: m_webView(webView)
, m_highlighter(AdoptNS, [[WebNodeHighlighter alloc] initWithInspectedWebView:webView])
, m_frontendPage(0)
+ , m_frontendClient(0)
{
}
@@ -92,11 +93,17 @@
m_frontendPage = core([windowController.get() webView]);
OwnPtr<WebInspectorFrontendClient> frontendClient = adoptPtr(new WebInspectorFrontendClient(m_webView, windowController.get(), inspectorController, m_frontendPage, createFrontendSettings()));
+ m_frontendClient = frontendClient.get();
RetainPtr<WebInspectorFrontend> webInspectorFrontend(AdoptNS, [[WebInspectorFrontend alloc] initWithFrontendClient:frontendClient.get()]);
[[m_webView inspector] setFrontend:webInspectorFrontend.get()];
m_frontendPage->inspectorController()->setInspectorFrontendClient(frontendClient.release());
}
+void WebInspectorClient::bringFrontendToFront()
+{
+ m_frontendClient->bringToFront();
+}
+
void WebInspectorClient::highlight()
{
[m_highlighter.get() highlight];
Modified: trunk/Source/WebKit/qt/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,14 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientQt.cpp:
+ (WebCore::InspectorClientQt::bringFrontendToFront):
+ * WebCoreSupport/InspectorClientQt.h:
+
2011-10-17 Antonio Gomes <ago...@rim.com>
Pass a Frame* parameter in EditorClient::respondToChangedSelection
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp (100994 => 100995)
--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -243,6 +243,11 @@
#endif
}
+void InspectorClientQt::bringFrontendToFront()
+{
+ m_frontendClient->bringToFront();
+}
+
void InspectorClientQt::releaseFrontendPage()
{
m_frontendWebPage = 0;
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h (100994 => 100995)
--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -52,6 +52,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/win/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/win/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/win/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,14 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ (WebInspectorClient::bringFrontendToFront):
+ * WebCoreSupport/WebInspectorClient.h:
+
2011-11-21 Pavel Feldman <pfeld...@google.com>
Not reviewed: an attempt to fix windows build.
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (100994 => 100995)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -178,6 +178,11 @@
m_frontendHwnd = frontendHwnd;
}
+void WebInspectorClient::bringFrontendToFront()
+{
+ m_frontendClient->bringToFront();
+}
+
void WebInspectorClient::highlight()
{
bool creatingHighlight = !m_highlight;
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (100994 => 100995)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -58,6 +58,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/wince/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/wince/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wince/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,14 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientWinCE.cpp:
+ (WebKit::InspectorClientWinCE::bringFrontendToFront):
+ * WebCoreSupport/InspectorClientWinCE.h:
+
2011-11-21 Andreas Kling <kl...@webkit.org>
Unreviewed WinCE build fix after r100874.
Modified: trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp (100994 => 100995)
--- trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -50,6 +50,11 @@
notImplemented();
}
+void InspectorClientWinCE::bringFrontendToFront()
+{
+ notImplemented();
+}
+
void InspectorClientWinCE::releaseFrontendPage()
{
notImplemented();
Modified: trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h (100994 => 100995)
--- trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -39,6 +39,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit/wx/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit/wx/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,14 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebKitSupport/InspectorClientWx.cpp:
+ (WebCore::InspectorClientWx::bringFrontendToFront):
+ * WebKitSupport/InspectorClientWx.h:
+
2011-11-21 Robin Dunn <ro...@alldunn.com>
Add wxWebKit APIs for controlling WebKit caching behavior.
Modified: trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp (100994 => 100995)
--- trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -52,6 +52,11 @@
notImplemented();
}
+void InspectorClientWx::bringFrontendToFront()
+{
+ notImplemented();
+}
+
void InspectorClientWx::highlight()
{
notImplemented();
Modified: trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h (100994 => 100995)
--- trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -41,6 +41,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
+ virtual void bringFrontendToFront();
virtual void highlight();
virtual void hideHighlight();
Modified: trunk/Source/WebKit2/ChangeLog (100994 => 100995)
--- trunk/Source/WebKit2/ChangeLog 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-22 14:11:46 UTC (rev 100995)
@@ -1,3 +1,15 @@
+2011-11-22 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: remove Inspector::bringToFront from the protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=72937
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+ (WebKit::WebInspectorClient::openInspectorFrontend):
+ (WebKit::WebInspectorClient::bringFrontendToFront):
+ * WebProcess/WebCoreSupport/WebInspectorClient.h:
+
2011-11-22 Caio Marcelo de Oliveira Filho <caio.olive...@openbossa.org>
[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (100994 => 100995)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-11-22 14:11:46 UTC (rev 100995)
@@ -44,12 +44,14 @@
void WebInspectorClient::openInspectorFrontend(InspectorController*)
{
- WebPage* inspectorPage = m_page->inspector()->createInspectorPage();
- ASSERT(inspectorPage);
- if (!inspectorPage)
- return;
+ ASSERT(m_page->inspector()->createInspectorPage());
}
+void WebInspectorClient::bringFrontendToFront()
+{
+ m_page->inspector()->bringToFront();
+}
+
void WebInspectorClient::highlight()
{
if (!m_highlightOverlay) {
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h (100994 => 100995)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h 2011-11-22 13:40:41 UTC (rev 100994)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h 2011-11-22 14:11:46 UTC (rev 100995)
@@ -53,6 +53,7 @@
virtual void inspectorDestroyed() OVERRIDE;
virtual void openInspectorFrontend(WebCore::InspectorController*) OVERRIDE;
+ virtual void bringFrontendToFront() OVERRIDE;
virtual void highlight() OVERRIDE;
virtual void hideHighlight() OVERRIDE;
