Title: [101278] trunk/Source/_javascript_Core
Revision
101278
Author
msab...@apple.com
Date
2011-11-28 13:42:31 -0800 (Mon, 28 Nov 2011)

Log Message

Change set 101187 from bug 73154 removed already lower case optimization
https://bugs.webkit.org/show_bug.cgi?id=73174

Added back the "string is already lower case" optimization.

Reviewed by Geoffrey Garen.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101277 => 101278)


--- trunk/Source/_javascript_Core/ChangeLog	2011-11-28 21:41:20 UTC (rev 101277)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-28 21:42:31 UTC (rev 101278)
@@ -1,3 +1,15 @@
+2011-11-28  Michael Saboff  <msab...@apple.com>
+
+        Change set 101187 from bug 73154 removed already lower case optimization
+        https://bugs.webkit.org/show_bug.cgi?id=73174
+
+        Added back the "string is already lower case" optimization.
+
+        Reviewed by Geoffrey Garen.
+
+        * runtime/StringPrototype.cpp:
+        (JSC::stringProtoFuncToLowerCase):
+
 2011-11-28  Simon Hausmann  <simon.hausm...@nokia.com>
 
         Unreviewed prospective build fix. Touch the file to trigger correct

Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (101277 => 101278)


--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2011-11-28 21:41:20 UTC (rev 101277)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2011-11-28 21:42:31 UTC (rev 101278)
@@ -1189,7 +1189,11 @@
     if (!sSize)
         return JSValue::encode(sVal);
 
-    return JSValue::encode(jsString(exec, UString(s.impl()->lower())));
+    StringImpl* ourImpl = s.impl();   
+    RefPtr<StringImpl> lower = ourImpl->lower();
+    if (ourImpl == lower.get())
+        return JSValue::encode(sVal);
+    return JSValue::encode(jsString(exec, UString(lower.release())));
 }
 
 EncodedJSValue JSC_HOST_CALL stringProtoFuncToUpperCase(ExecState* exec)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to