Title: [103386] trunk/Source/WebCore
Revision
103386
Author
eric.carl...@apple.com
Date
2011-12-20 18:37:02 -0800 (Tue, 20 Dec 2011)

Log Message

WebVTT cues sometimes render when they should not
https://bugs.webkit.org/show_bug.cgi?id=74873

Not reviewed: update Chromium to pass new test added in r103371.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (103385 => 103386)


--- trunk/Source/WebCore/ChangeLog	2011-12-21 02:33:57 UTC (rev 103385)
+++ trunk/Source/WebCore/ChangeLog	2011-12-21 02:37:02 UTC (rev 103386)
@@ -1,3 +1,13 @@
+2011-12-20  Eric Carlson  <eric.carl...@apple.com>
+
+        WebVTT cues sometimes render when they should not
+        https://bugs.webkit.org/show_bug.cgi?id=74873
+
+        Not reviewed: update Chromium to pass new test added in r103371.
+
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):
+
 2011-12-20  Andreas Kling  <kl...@webkit.org>
 
         HTMLOptionsCollection: Remove incorrect FIXME about having a base class.

Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (103385 => 103386)


--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2011-12-21 02:33:57 UTC (rev 103385)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2011-12-21 02:37:02 UTC (rev 103386)
@@ -368,9 +368,6 @@
         createTextTrackDisplay();
 
     CueList activeCues = toParentMediaElement(m_textDisplayContainer)->currentlyActiveCues();
-    if (activeCues.isEmpty())
-        return;
-
     m_textTrackDisplay->removeChildren();
     bool nothingToDisplay = true;
     for (size_t i = 0; i < activeCues.size(); ++i) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to