Title: [103498] trunk/Source/WebCore
Revision
103498
Author
da...@apple.com
Date
2011-12-21 23:41:12 -0800 (Wed, 21 Dec 2011)

Log Message

Make ~CSSParserSelector use Vector<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73782

Reviewed by Alexey Proskuryakov.

* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::~CSSParserSelector): Use Vector<OwnPtr>
so we don't have to call leakPtr or deleteAllValues.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (103497 => 103498)


--- trunk/Source/WebCore/ChangeLog	2011-12-22 07:17:51 UTC (rev 103497)
+++ trunk/Source/WebCore/ChangeLog	2011-12-22 07:41:12 UTC (rev 103498)
@@ -1,3 +1,14 @@
+2011-12-21  Darin Adler  <da...@apple.com>
+
+        Make ~CSSParserSelector use Vector<OwnPtr>
+        https://bugs.webkit.org/show_bug.cgi?id=73782
+
+        Reviewed by Alexey Proskuryakov.
+
+        * css/CSSParserValues.cpp:
+        (WebCore::CSSParserSelector::~CSSParserSelector): Use Vector<OwnPtr>
+        so we don't have to call leakPtr or deleteAllValues.
+
 2011-12-21  Yosifumi Inoue  <yo...@chromium.org>
 
         [Forms] Selection change by type-ahead doesn't fire 'change' event

Modified: trunk/Source/WebCore/css/CSSParserValues.cpp (103497 => 103498)


--- trunk/Source/WebCore/css/CSSParserValues.cpp	2011-12-22 07:17:51 UTC (rev 103497)
+++ trunk/Source/WebCore/css/CSSParserValues.cpp	2011-12-22 07:41:12 UTC (rev 103498)
@@ -95,16 +95,15 @@
 {
     if (!m_tagHistory)
         return;
-    Vector<CSSParserSelector*, 16> toDelete;
-    CSSParserSelector* selector = m_tagHistory.leakPtr();
+    Vector<OwnPtr<CSSParserSelector>, 16> toDelete;
+    OwnPtr<CSSParserSelector> selector = m_tagHistory.release();
     while (true) {
-        toDelete.append(selector);
-        CSSParserSelector* next = selector->m_tagHistory.leakPtr();
+        OwnPtr<CSSParserSelector> next = selector->m_tagHistory.release();
+        toDelete.append(selector.release());
         if (!next)
             break;
-        selector = next;
+        selector = next.release();
     }
-    deleteAllValues(toDelete);
 }
 
 void CSSParserSelector::adoptSelectorVector(Vector<OwnPtr<CSSParserSelector> >& selectorVector)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to