Title: [104812] trunk/Tools
- Revision
- 104812
- Author
- vse...@chromium.org
- Date
- 2012-01-12 04:25:27 -0800 (Thu, 12 Jan 2012)
Log Message
WebKitTestRunner should not print console message line number when it is equal to zero.
https://bugs.webkit.org/show_bug.cgi?id=76167
Reviewed by Csaba Osztrogonác.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willAddMessageToConsole):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (104811 => 104812)
--- trunk/Tools/ChangeLog 2012-01-12 12:24:10 UTC (rev 104811)
+++ trunk/Tools/ChangeLog 2012-01-12 12:25:27 UTC (rev 104812)
@@ -1,3 +1,13 @@
+2012-01-12 Vsevolod Vlasov <vse...@chromium.org>
+
+ WebKitTestRunner should not print console message line number when it is equal to zero.
+ https://bugs.webkit.org/show_bug.cgi?id=76167
+
+ Reviewed by Csaba Osztrogonác.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::willAddMessageToConsole):
+
2012-01-11 Vsevolod Vlasov <vse...@chromium.org>
Make default console messages line numbers consistent.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (104811 => 104812)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2012-01-12 12:24:10 UTC (rev 104811)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2012-01-12 12:25:27 UTC (rev 104812)
@@ -863,7 +863,11 @@
// FIXME: The code below does not handle additional text after url nor multiple urls. This matches DumpRenderTree implementation.
messageString = messageString.substr(0, fileProtocolStart) + lastFileURLPathComponent(messageString.substr(fileProtocolStart));
- InjectedBundle::shared().os() << "CONSOLE MESSAGE: line " << lineNumber << ": " << messageString << "\n";
+ InjectedBundle::shared().os() << "CONSOLE MESSAGE: ";
+ if (lineNumber)
+ InjectedBundle::shared().os() << "line " << lineNumber << ": ";
+ InjectedBundle::shared().os() << messageString << "\n";
+
}
void InjectedBundlePage::willSetStatusbarText(WKStringRef statusbarText)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
