Title: [110052] trunk
Revision
110052
Author
commit-qu...@webkit.org
Date
2012-03-07 06:07:47 -0800 (Wed, 07 Mar 2012)

Log Message

Source/WebCore: HTMLTrackElement.idl doesn't have default attribute.
https://bugs.webkit.org/show_bug.cgi?id=80116

Patch by Arun Patole <bmf...@motorola.com> on 2012-03-07
Reviewed by Kentaro Hara.

Renamed isDefault to 'default' so that in JS, it will be track.default instead of track.isDefault.
* html/HTMLTrackElement.idl:

LayoutTests: HTMLTrackElement.idl doesn't have default attribute.
https://bugs.webkit.org/show_bug.cgi?id=80116

Patch by Arun Patole <bmf...@motorola.com> on 2012-03-07
Reviewed by Kentaro Hara.

Make sure 'default' IDL attribute reflects the content attribute of the same name.
* media/track/track-default-attribute-expected.txt:
* media/track/track-default-attribute.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (110051 => 110052)


--- trunk/LayoutTests/ChangeLog	2012-03-07 14:05:27 UTC (rev 110051)
+++ trunk/LayoutTests/ChangeLog	2012-03-07 14:07:47 UTC (rev 110052)
@@ -1,3 +1,14 @@
+2012-03-07  Arun Patole  <bmf...@motorola.com>
+
+        HTMLTrackElement.idl doesn't have default attribute. 
+        https://bugs.webkit.org/show_bug.cgi?id=80116
+
+        Reviewed by Kentaro Hara.
+
+        Make sure 'default' IDL attribute reflects the content attribute of the same name.
+        * media/track/track-default-attribute-expected.txt:
+        * media/track/track-default-attribute.html:
+
 2012-03-07  Stephen White  <senorbla...@chromium.org>
 
         [chromium] Mark rtl-scrollbar.html as flaky.

Modified: trunk/LayoutTests/media/track/track-default-attribute-expected.txt (110051 => 110052)


--- trunk/LayoutTests/media/track/track-default-attribute-expected.txt	2012-03-07 14:05:27 UTC (rev 110051)
+++ trunk/LayoutTests/media/track/track-default-attribute-expected.txt	2012-03-07 14:07:47 UTC (rev 110052)
@@ -3,6 +3,7 @@
 EVENT(load)
 EXPECTED (event.target.readyState == '2') OK
 EXPECTED (event.target.id == 'default') OK
+EXPECTED (event.target.default == 'true') OK
 
 END OF TEST
 

Modified: trunk/LayoutTests/media/track/track-default-attribute.html (110051 => 110052)


--- trunk/LayoutTests/media/track/track-default-attribute.html	2012-03-07 14:05:27 UTC (rev 110051)
+++ trunk/LayoutTests/media/track/track-default-attribute.html	2012-03-07 14:07:47 UTC (rev 110052)
@@ -12,6 +12,7 @@
                 consoleWrite("EVENT(load)");
                 testExpected("event.target.readyState", HTMLTrackElement.LOADED);
                 testExpected("event.target.id", "default");
+                testExpected("event.target.default", true);
                 consoleWrite("");
 
                 // End the test after a brief pause so we allow other tracks to load if they will.

Modified: trunk/Source/WebCore/ChangeLog (110051 => 110052)


--- trunk/Source/WebCore/ChangeLog	2012-03-07 14:05:27 UTC (rev 110051)
+++ trunk/Source/WebCore/ChangeLog	2012-03-07 14:07:47 UTC (rev 110052)
@@ -1,3 +1,13 @@
+2012-03-07  Arun Patole  <bmf...@motorola.com>
+
+        HTMLTrackElement.idl doesn't have default attribute.
+        https://bugs.webkit.org/show_bug.cgi?id=80116
+
+        Reviewed by Kentaro Hara.
+
+        Renamed isDefault to 'default' so that in JS, it will be track.default instead of track.isDefault.
+        * html/HTMLTrackElement.idl:
+
 2012-03-07  Zoltan Horvath  <zol...@webkit.org>
 
         [Qt] Add qmake config tests for JPEG and PNG library

Modified: trunk/Source/WebCore/html/HTMLTrackElement.idl (110051 => 110052)


--- trunk/Source/WebCore/html/HTMLTrackElement.idl	2012-03-07 14:05:27 UTC (rev 110051)
+++ trunk/Source/WebCore/html/HTMLTrackElement.idl	2012-03-07 14:07:47 UTC (rev 110052)
@@ -32,7 +32,7 @@
         attribute DOMString kind;
         attribute DOMString srclang;
         attribute DOMString label;
-        attribute [Reflect=default] boolean isDefault;
+        attribute [Reflect] boolean default;
 
         const unsigned short NONE = 0;
         const unsigned short LOADING = 1;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to