Title: [114358] trunk/Source/WebCore
- Revision
- 114358
- Author
- hausm...@webkit.org
- Date
- 2012-04-17 00:47:28 -0700 (Tue, 17 Apr 2012)
Log Message
[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004
Patch by Bang Kwang min <justine.b...@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.
m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.
* plugins/PluginView.cpp:
(WebCore::PluginView::stop):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114357 => 114358)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 07:40:30 UTC (rev 114357)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 07:47:28 UTC (rev 114358)
@@ -1,3 +1,17 @@
+2012-04-17 Bang Kwang min <justine.b...@samsung.com>
+
+ [Plugins] delete ws_info regardless of window mode.
+ https://bugs.webkit.org/show_bug.cgi?id=83004
+
+ Reviewed by Simon Hausmann.
+
+ m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
+ Every plugin works well after this patch without any crash.
+ Additionally, change casting syntax to C++ style.
+
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::stop):
+
2012-04-17 Kent Tamura <tk...@chromium.org>
Calendar Picker: Support RTL layout
Modified: trunk/Source/WebCore/plugins/PluginView.cpp (114357 => 114358)
--- trunk/Source/WebCore/plugins/PluginView.cpp 2012-04-17 07:40:30 UTC (rev 114357)
+++ trunk/Source/WebCore/plugins/PluginView.cpp 2012-04-17 07:47:28 UTC (rev 114358)
@@ -366,8 +366,7 @@
}
#ifdef XP_UNIX
- if (m_isWindowed && m_npWindow.ws_info)
- delete (NPSetWindowCallbackStruct *)m_npWindow.ws_info;
+ delete static_cast<NPSetWindowCallbackStruct*>(m_npWindow.ws_info);
m_npWindow.ws_info = 0;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
