Title: [114402] trunk/Source
Revision
114402
Author
jer.no...@apple.com
Date
2012-04-17 11:35:48 -0700 (Tue, 17 Apr 2012)

Log Message

Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936

Reviewed by Adele Peterson.

Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedExitFullScreenAnimation:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (114401 => 114402)


--- trunk/Source/WebKit/mac/ChangeLog	2012-04-17 18:21:28 UTC (rev 114401)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-04-17 18:35:48 UTC (rev 114402)
@@ -1,3 +1,16 @@
+2012-04-17  Jer Noble  <jer.no...@apple.com>
+
+        Exiting full screen video brings the wrong Safari window to the foreground
+        https://bugs.webkit.org/show_bug.cgi?id=83936
+
+        Reviewed by Adele Peterson.
+
+        Tell the original webView's window to makeKeyAndOrderFront once the exit
+        animation completes.
+
+        * WebView/WebFullScreenController.mm:
+        (-[WebFullScreenController finishedExitFullScreenAnimation:]):
+
 2012-04-16  Anders Carlsson  <ander...@apple.com>
 
         Use a MIG call when creating a plug-in property list file

Modified: trunk/Source/WebKit/mac/WebView/WebFullScreenController.mm (114401 => 114402)


--- trunk/Source/WebKit/mac/WebView/WebFullScreenController.mm	2012-04-17 18:21:28 UTC (rev 114401)
+++ trunk/Source/WebKit/mac/WebView/WebFullScreenController.mm	2012-04-17 18:35:48 UTC (rev 114402)
@@ -377,7 +377,9 @@
     
     [_backgroundWindow.get() orderOut:self];
     [_backgroundWindow.get() setFrame:NSZeroRect display:YES];
-    
+
+    [[_webView window] makeKeyAndOrderFront:self];
+
     NSEnableScreenUpdates();
 }
 

Modified: trunk/Source/WebKit2/ChangeLog (114401 => 114402)


--- trunk/Source/WebKit2/ChangeLog	2012-04-17 18:21:28 UTC (rev 114401)
+++ trunk/Source/WebKit2/ChangeLog	2012-04-17 18:35:48 UTC (rev 114402)
@@ -1,3 +1,16 @@
+2012-04-17  Jer Noble  <jer.no...@apple.com>
+
+        Exiting full screen video brings the wrong Safari window to the foreground
+        https://bugs.webkit.org/show_bug.cgi?id=83936
+
+        Reviewed by Adele Peterson.
+
+        Tell the original webView's window to makeKeyAndOrderFront once the exit
+        animation completes.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
+
 2012-04-17  Michał Pakuła vel Rutka  <m.pak...@samsung.com>
 
         [EFL][WK2] Fix build break when FULLSCREEN_API is enabled.

Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (114401 => 114402)


--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2012-04-17 18:21:28 UTC (rev 114401)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2012-04-17 18:35:48 UTC (rev 114402)
@@ -370,6 +370,8 @@
     [_backgroundWindow.get() orderOut:self];
     [_backgroundWindow.get() setFrame:NSZeroRect display:YES];
 
+    [[_webView window] makeKeyAndOrderFront:self];
+
     NSEnableScreenUpdates();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to