Title: [116171] trunk/Source/WebCore
Revision
116171
Author
rafa...@chromium.org
Date
2012-05-04 14:21:52 -0700 (Fri, 04 May 2012)

Log Message

V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::newInstance):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (116170 => 116171)


--- trunk/Source/WebCore/ChangeLog	2012-05-04 21:20:23 UTC (rev 116170)
+++ trunk/Source/WebCore/ChangeLog	2012-05-04 21:21:52 UTC (rev 116171)
@@ -1,3 +1,17 @@
+2012-05-04  Rafael Weinstein  <rafa...@chromium.org>
+
+        V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
+        https://bugs.webkit.org/show_bug.cgi?id=85659
+
+        Reviewed by Ojan Vafai.
+
+        Added a stack-allocted V8RecursionScope to the newInstance call.
+
+        No new tests. No change in observable behavior.
+
+        * bindings/v8/V8Proxy.cpp:
+        (WebCore::V8Proxy::newInstance):
+
 2012-05-04  Joshua Bell  <jsb...@chromium.org>
 
         IndexedDB: Remove all index metadata records when deleting an index

Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (116170 => 116171)


--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp	2012-05-04 21:20:23 UTC (rev 116170)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp	2012-05-04 21:21:52 UTC (rev 116171)
@@ -435,6 +435,7 @@
     // V8Proxy::callFunction.
     v8::Local<v8::Value> result;
     {
+        V8RecursionScope recursionScope(frame() ? frame()->document() : 0);
         result = constructor->NewInstance(argc, args);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to