Title: [122461] trunk/Source/WebKit/chromium
- Revision
- 122461
- Author
- leandrogra...@chromium.org
- Date
- 2012-07-12 08:30:55 -0700 (Thu, 12 Jul 2012)
Log Message
[Chromium] Remove unrequired API in WebSurroundingText.
https://bugs.webkit.org/show_bug.cgi?id=91067
Reviewed by Adam Barth.
Remove the unused first initialize method from WebSurroundingText.
Now both Chromium and LayoutTestController use the second method.
* public/WebSurroundingText.h:
(WebSurroundingText):
* src/WebSurroundingText.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (122460 => 122461)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-12 15:30:55 UTC (rev 122461)
@@ -1,3 +1,17 @@
+2012-07-12 Leandro Gracia Gil <leandrogra...@chromium.org>
+
+ [Chromium] Remove unrequired API in WebSurroundingText.
+ https://bugs.webkit.org/show_bug.cgi?id=91067
+
+ Reviewed by Adam Barth.
+
+ Remove the unused first initialize method from WebSurroundingText.
+ Now both Chromium and LayoutTestController use the second method.
+
+ * public/WebSurroundingText.h:
+ (WebSurroundingText):
+ * src/WebSurroundingText.cpp:
+
2012-07-11 Mark Rowe <mr...@apple.com>
<http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
Modified: trunk/Source/WebKit/chromium/public/WebSurroundingText.h (122460 => 122461)
--- trunk/Source/WebKit/chromium/public/WebSurroundingText.h 2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/public/WebSurroundingText.h 2012-07-12 15:30:55 UTC (rev 122461)
@@ -48,10 +48,6 @@
WEBKIT_EXPORT bool isNull() const;
WEBKIT_EXPORT void reset();
- // Initializes the object go get the surrounding text centered in the position described by the hit test.
- // The maximum length of the contents retrieved is defined by maxLength.
- WEBKIT_EXPORT void initialize(const WebHitTestResult&, size_t maxLength);
-
// Initializes the object to get the surrounding text centered in the position relative to a provided node.
// The maximum length of the contents retrieved is defined by maxLength.
WEBKIT_EXPORT void initialize(const WebNode&, const WebPoint&, size_t maxLength);
Modified: trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp (122460 => 122461)
--- trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp 2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp 2012-07-12 15:30:55 UTC (rev 122461)
@@ -40,15 +40,6 @@
namespace WebKit {
-void WebSurroundingText::initialize(const WebHitTestResult& hitTestResult, size_t maxLength)
-{
- Node* node = hitTestResult.node().unwrap<Node>();
- if (!node || !node->renderer())
- return;
-
- m_private.reset(new SurroundingText(VisiblePosition(node->renderer()->positionForPoint(static_cast<IntPoint>(hitTestResult.localPoint()))), maxLength));
-}
-
void WebSurroundingText::initialize(const WebNode& webNode, const WebPoint& nodePoint, size_t maxLength)
{
const Node* node = webNode.constUnwrap<Node>();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
