Title: [123755] trunk/Source/WebCore
- Revision
- 123755
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-26 09:17:21 -0700 (Thu, 26 Jul 2012)
Log Message
Web Inspector: add GC button to the profiles panel toolbar.
https://bugs.webkit.org/show_bug.cgi?id=92369
Patch by Alexei Filippov <alex...@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
* inspector/front-end/profilesPanel.css:
(.garbage-collect-status-bar-item .glyph):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123754 => 123755)
--- trunk/Source/WebCore/ChangeLog 2012-07-26 16:15:27 UTC (rev 123754)
+++ trunk/Source/WebCore/ChangeLog 2012-07-26 16:17:21 UTC (rev 123755)
@@ -1,3 +1,16 @@
+2012-07-26 Alexei Filippov <alex...@chromium.org>
+
+ Web Inspector: add GC button to the profiles panel toolbar.
+ https://bugs.webkit.org/show_bug.cgi?id=92369
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.get statusBarItems):
+ (WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
+ * inspector/front-end/profilesPanel.css:
+ (.garbage-collect-status-bar-item .glyph):
+
2012-07-26 Allan Sandfeld Jensen <allan.jen...@nokia.com>
Move region from HitTestResult to HitTestPoint.
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (123754 => 123755)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-07-26 16:15:27 UTC (rev 123754)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-07-26 16:17:21 UTC (rev 123755)
@@ -225,6 +225,11 @@
this.clearResultsButton = new WebInspector.StatusBarButton(WebInspector.UIString("Clear all profiles."), "clear-status-bar-item");
this.clearResultsButton.addEventListener("click", this._clearProfiles, this);
+ if (WebInspector.experimentsSettings.liveNativeMemoryChart.isEnabled()) {
+ this.garbageCollectButton = new WebInspector.StatusBarButton(WebInspector.UIString("Collect Garbage"), "garbage-collect-status-bar-item");
+ this.garbageCollectButton.addEventListener("click", this._garbageCollectButtonClicked, this);
+ }
+
this.profileViewStatusBarItemsContainer = document.createElement("div");
this.profileViewStatusBarItemsContainer.className = "status-bar-items";
@@ -300,7 +305,10 @@
get statusBarItems()
{
- return [this.enableToggleButton.element, this.recordButton.element, this.clearResultsButton.element, this.profileViewStatusBarItemsContainer];
+ var statusBarItems = [this.enableToggleButton.element, this.recordButton.element, this.clearResultsButton.element, this.profileViewStatusBarItemsContainer];
+ if (WebInspector.experimentsSettings.liveNativeMemoryChart.isEnabled())
+ statusBarItems.splice(3, 0, this.garbageCollectButton.element);
+ return statusBarItems;
},
toggleRecordButton: function()
@@ -408,6 +416,11 @@
this._reset();
},
+ _garbageCollectButtonClicked: function()
+ {
+ ProfilerAgent.collectGarbage();
+ },
+
/**
* @param {WebInspector.ProfileType} profileType
*/
Modified: trunk/Source/WebCore/inspector/front-end/profilesPanel.css (123754 => 123755)
--- trunk/Source/WebCore/inspector/front-end/profilesPanel.css 2012-07-26 16:15:27 UTC (rev 123754)
+++ trunk/Source/WebCore/inspector/front-end/profilesPanel.css 2012-07-26 16:17:21 UTC (rev 123755)
@@ -142,6 +142,10 @@
-webkit-mask-position: 0 0;
}
+.garbage-collect-status-bar-item .glyph {
+ -webkit-mask-position: -128px -24px;
+}
+
.profile-launcher-view-content {
position: absolute;
top: 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
